Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 35372,
    "url": "http://patches.dpdk.org/api/patches/35372/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/cef0a87d69a78f57c938a099a85041d3b612d7b3.1519390269.git.pascal.mazon@6wind.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<cef0a87d69a78f57c938a099a85041d3b612d7b3.1519390269.git.pascal.mazon@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/cef0a87d69a78f57c938a099a85041d3b612d7b3.1519390269.git.pascal.mazon@6wind.com",
    "date": "2018-02-23T12:53:05",
    "name": "[dpdk-dev] net/qede: fix alloc from socket 0",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "52e139f62ea8db75c5da47988d00180140dd9770",
    "submitter": {
        "id": 657,
        "url": "http://patches.dpdk.org/api/people/657/?format=api",
        "name": "Pascal Mazon",
        "email": "pascal.mazon@6wind.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/cef0a87d69a78f57c938a099a85041d3b612d7b3.1519390269.git.pascal.mazon@6wind.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/35372/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/35372/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E363D4CA7;\n\tFri, 23 Feb 2018 13:54:10 +0100 (CET)",
            "from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com\n\t[62.23.145.76]) by dpdk.org (Postfix) with ESMTP id D2D3D4CA6;\n\tFri, 23 Feb 2018 13:54:08 +0100 (CET)",
            "from 6wind.com (unknown [10.16.0.184])\n\tby proxy.6wind.com (Postfix) with SMTP id BD9CE137C06;\n\tFri, 23 Feb 2018 13:50:50 +0100 (CET)",
            "by 6wind.com (sSMTP sendmail emulation);\n\tFri, 23 Feb 2018 13:53:56 +0100"
        ],
        "From": "Pascal Mazon <pascal.mazon@6wind.com>",
        "To": "dev@dpdk.org, Rasesh Mody <rasesh.mody@cavium.com>,\n\tHarish Patil <harish.patil@cavium.com>,\n\tShahed Shaikh <shahed.shaikh@cavium.com>",
        "Cc": "pascal.mazon@6wind.com,\n\tstable@dpdk.org",
        "Date": "Fri, 23 Feb 2018 13:53:05 +0100",
        "Message-Id": "<cef0a87d69a78f57c938a099a85041d3b612d7b3.1519390269.git.pascal.mazon@6wind.com>",
        "X-Mailer": "git-send-email 2.16.1.72.g5be1f00a9",
        "Subject": "[dpdk-dev] [PATCH] net/qede: fix alloc from socket 0",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "In case osal_dma_alloc_coherent() is called from a management thread,\ncore_id turn out to be LCORE_ID_ANY, and the resulting socket for alloc\nwill be socket 0.\n\nThis is not desirable when using a NIC from socket 1 which might very\nlikely be configured to use memory from that socket only.\nIn that case, allocation will fail.\n\nTo address this, use master lcore instead when called from mgmt thread.\nThe associated socket should have memory available.\n\nFixes: ec94dbc57362 (\"qede: add base driver\")\nCc: stable@dpdk.org\n\nSigned-off-by: Pascal Mazon <pascal.mazon@6wind.com>\n---\n drivers/net/qede/base/bcm_osal.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/qede/base/bcm_osal.c b/drivers/net/qede/base/bcm_osal.c\nindex fe42f3256400..0760cdcb9523 100644\n--- a/drivers/net/qede/base/bcm_osal.c\n+++ b/drivers/net/qede/base/bcm_osal.c\n@@ -133,7 +133,7 @@ void *osal_dma_alloc_coherent(struct ecore_dev *p_dev,\n \tsnprintf(mz_name, sizeof(mz_name) - 1, \"%lx\",\n \t\t\t\t\t(unsigned long)rte_get_timer_cycles());\n \tif (core_id == (unsigned int)LCORE_ID_ANY)\n-\t\tcore_id = 0;\n+\t\tcore_id = rte_get_master_lcore();\n \tsocket_id = rte_lcore_to_socket_id(core_id);\n \tmz = rte_memzone_reserve_aligned(mz_name, size,\n \t\t\t\t\t socket_id, 0, RTE_CACHE_LINE_SIZE);\n",
    "prefixes": [
        "dpdk-dev"
    ]
}