Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 35347,
    "url": "http://patches.dpdk.org/api/patches/35347/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1519299039-2475-1-git-send-email-alejandro.lucero@netronome.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1519299039-2475-1-git-send-email-alejandro.lucero@netronome.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1519299039-2475-1-git-send-email-alejandro.lucero@netronome.com",
    "date": "2018-02-22T11:30:39",
    "name": "[dpdk-dev] net/nfp: fix barrier location",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "5357acb9ab74f49837a2655c948a55fe4e775414",
    "submitter": {
        "id": 270,
        "url": "http://patches.dpdk.org/api/people/270/?format=api",
        "name": "Alejandro Lucero",
        "email": "alejandro.lucero@netronome.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1519299039-2475-1-git-send-email-alejandro.lucero@netronome.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/35347/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/35347/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EA8812B9E;\n\tThu, 22 Feb 2018 12:30:47 +0100 (CET)",
            "from netronome.com (host-79-78-33-110.static.as9105.net\n\t[79.78.33.110]) by dpdk.org (Postfix) with ESMTP id 294932B89;\n\tThu, 22 Feb 2018 12:30:47 +0100 (CET)",
            "from netronome.com (localhost [127.0.0.1])\n\tby netronome.com (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id\n\tw1MBUdWs002515; Thu, 22 Feb 2018 11:30:39 GMT",
            "(from alucero@localhost)\n\tby netronome.com (8.14.4/8.14.4/Submit) id w1MBUdLM002514;\n\tThu, 22 Feb 2018 11:30:39 GMT"
        ],
        "From": "Alejandro Lucero <alejandro.lucero@netronome.com>",
        "To": "dev@dpdk.org",
        "Cc": "stable@dpdk.org",
        "Date": "Thu, 22 Feb 2018 11:30:39 +0000",
        "Message-Id": "<1519299039-2475-1-git-send-email-alejandro.lucero@netronome.com>",
        "X-Mailer": "git-send-email 1.9.1",
        "Subject": "[dpdk-dev] [PATCH] net/nfp: fix barrier location",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The barrier needs to be after reading the DD bit. It has not been\na problem because the potential reads which can not happen before\nreading the DD bit seem to be far enough, so the compiler is not\nrescheduling them. However, a refactoring could make this problem\nto arise.\n\nFixes: b812daadad0d (\"nfp: add Rx and Tx\")\n\nSigned-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>\n---\n drivers/net/nfp/nfp_net.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c\nindex 5180a31..fc501d6 100644\n--- a/drivers/net/nfp/nfp_net.c\n+++ b/drivers/net/nfp/nfp_net.c\n@@ -2019,16 +2019,16 @@ enum nfp_qcp_ptr {\n \t\t\tbreak;\n \t\t}\n \n+\t\trxds = &rxq->rxds[rxq->rd_p];\n+\t\tif ((rxds->rxd.meta_len_dd & PCIE_DESC_RX_DD) == 0)\n+\t\t\tbreak;\n+\n \t\t/*\n \t\t * Memory barrier to ensure that we won't do other\n \t\t * reads before the DD bit.\n \t\t */\n \t\trte_rmb();\n \n-\t\trxds = &rxq->rxds[rxq->rd_p];\n-\t\tif ((rxds->rxd.meta_len_dd & PCIE_DESC_RX_DD) == 0)\n-\t\t\tbreak;\n-\n \t\t/*\n \t\t * We got a packet. Let's alloc a new mbuff for refilling the\n \t\t * free descriptor ring as soon as possible\n",
    "prefixes": [
        "dpdk-dev"
    ]
}