Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 35323,
    "url": "http://patches.dpdk.org/api/patches/35323/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1519220318-19328-1-git-send-email-ophirmu@mellanox.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1519220318-19328-1-git-send-email-ophirmu@mellanox.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1519220318-19328-1-git-send-email-ophirmu@mellanox.com",
    "date": "2018-02-21T13:38:38",
    "name": "[dpdk-dev,v1] net/mlx4: fix RSS actions with no parameters",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "54772aec1472f153ece592181eea7fa16f79008e",
    "submitter": {
        "id": 793,
        "url": "http://patches.dpdk.org/api/people/793/?format=api",
        "name": "Ophir Munk",
        "email": "ophirmu@mellanox.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1519220318-19328-1-git-send-email-ophirmu@mellanox.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/35323/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/35323/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EE4CC2C18;\n\tWed, 21 Feb 2018 14:39:16 +0100 (CET)",
            "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id 4A9042C18\n\tfor <dev@dpdk.org>; Wed, 21 Feb 2018 14:39:15 +0100 (CET)",
            "from Internal Mail-Server by MTLPINE1 (envelope-from\n\tophirmu@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 21 Feb 2018 15:39:21 +0200",
            "from localhost.localdomain (pegasus05.mtr.labs.mlnx\n\t[10.210.16.100])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id w1LDd9QZ003003;\n\tWed, 21 Feb 2018 15:39:09 +0200",
            "from pegasus05.mtr.labs.mlnx (localhost [127.0.0.1])\n\tby localhost.localdomain (8.14.7/8.14.7) with ESMTP id w1LDd9fb019377;\n\tWed, 21 Feb 2018 13:39:09 GMT",
            "(from root@localhost)\n\tby pegasus05.mtr.labs.mlnx (8.14.7/8.14.7/Submit) id w1LDd8g2019376; \n\tWed, 21 Feb 2018 13:39:08 GMT"
        ],
        "From": "Ophir Munk <ophirmu@mellanox.com>",
        "To": "Adrien Mazarguil <adrien.mazarguil@6wind.com>",
        "Cc": "dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,\n\tOlga Shern <olgas@mellanox.com>, Ophir Munk <ophirmu@mellanox.com>,\n\tstable@dpdk.org",
        "Date": "Wed, 21 Feb 2018 13:38:38 +0000",
        "Message-Id": "<1519220318-19328-1-git-send-email-ophirmu@mellanox.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "Subject": "[dpdk-dev] [PATCH v1] net/mlx4: fix RSS actions with no parameters",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "When creating an RSS flow with missing actions parameters, for example:\nflow create 0 ingress pattern <list of patterns>  / end actions rss / end\n\ntestpmd aborts with segmentation fault.\nIn the corrupted code mlx4_flow_prepare() accesses RSS action->conf pointer\nwithout verifying its validity.\nIn case of missing RSS actions parameters this pointer is NULL and must not\n be accessed.\nThe fix is to return an error in such cases \"missing rss actions\".\n\nFixes: 078b8b452e6b (\"net/mlx4: add RSS flow rule action support\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ophir Munk <ophirmu@mellanox.com>\n---\n drivers/net/mlx4/mlx4_flow.c | 4 ++++\n 1 file changed, 4 insertions(+)",
    "diff": "diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c\nindex 2d55bfe..7a127a8 100644\n--- a/drivers/net/mlx4/mlx4_flow.c\n+++ b/drivers/net/mlx4/mlx4_flow.c\n@@ -735,6 +735,10 @@ mlx4_flow_prepare(struct priv *priv,\n \t\t\tif (flow->rss)\n \t\t\t\tbreak;\n \t\t\trss = action->conf;\n+\t\t\tif (!rss) {\n+\t\t\t\tmsg = \"missing rss actions\";\n+\t\t\t\tgoto exit_action_not_supported;\n+\t\t\t}\n \t\t\t/* Default RSS configuration if none is provided. */\n \t\t\trss_conf =\n \t\t\t\trss->rss_conf ?\n",
    "prefixes": [
        "dpdk-dev",
        "v1"
    ]
}