Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/35222/?format=api
{ "id": 35222, "url": "http://patches.dpdk.org/api/patches/35222/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1519112078-20113-7-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1519112078-20113-7-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1519112078-20113-7-git-send-email-arybchenko@solarflare.com", "date": "2018-02-20T07:33:24", "name": "[dpdk-dev,06/80] net/sfc/base: add efsys option for Medford2", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "590d111a2940bb4f3da9cc241001e384ecd3cdcc", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1519112078-20113-7-git-send-email-arybchenko@solarflare.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/35222/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/35222/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3A78F1B1B8;\n\tTue, 20 Feb 2018 08:35:22 +0100 (CET)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 8BD721B022\n\tfor <dev@dpdk.org>; Tue, 20 Feb 2018 08:35:17 +0100 (CET)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id\n\t8F14B400056 for <dev@dpdk.org>; Tue, 20 Feb 2018 07:35:16 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1044.25; Mon, 19 Feb 2018 23:35:13 -0800", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1044.25 via Frontend Transport; Mon, 19 Feb 2018 23:35:13 -0800", "from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com\n\t[10.17.10.10])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw1K7ZCP4024856; Tue, 20 Feb 2018 07:35:12 GMT", "from uklogin.uk.solarflarecom.com (localhost.localdomain\n\t[127.0.0.1])\n\tby uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw1K7ZBtI020529; Tue, 20 Feb 2018 07:35:12 GMT" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Andy Moreton <amoreton@solarflare.com>", "Date": "Tue, 20 Feb 2018 07:33:24 +0000", "Message-ID": "<1519112078-20113-7-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.2.3", "In-Reply-To": "<1519112078-20113-1-git-send-email-arybchenko@solarflare.com>", "References": "<1519112078-20113-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-MDID": "1519112117-2Qx3Dz5C2Z5x", "Subject": "[dpdk-dev] [PATCH 06/80] net/sfc/base: add efsys option for Medford2", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Andy Moreton <amoreton@solarflare.com>\n\nSigned-off-by: Andy Moreton <amoreton@solarflare.com>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/base/efx_check.h | 97 +++++++++++++++++++++++-----------------\n drivers/net/sfc/efsys.h | 2 +\n 2 files changed, 59 insertions(+), 40 deletions(-)", "diff": "diff --git a/drivers/net/sfc/base/efx_check.h b/drivers/net/sfc/base/efx_check.h\nindex 5837775..0c85702 100644\n--- a/drivers/net/sfc/base/efx_check.h\n+++ b/drivers/net/sfc/base/efx_check.h\n@@ -30,8 +30,9 @@\n \n #if EFSYS_OPT_CHECK_REG\n /* Verify chip implements accessed registers */\n-# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || EFSYS_OPT_MEDFORD)\n-# error \"CHECK_REG requires SIENA or HUNTINGTON or MEDFORD\"\n+# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || \\\n+\tEFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2)\n+# error \"CHECK_REG requires SIENA or HUNTINGTON or MEDFORD or MEDFORD2\"\n # endif\n #endif /* EFSYS_OPT_CHECK_REG */\n \n@@ -44,15 +45,17 @@\n \n #if EFSYS_OPT_DIAG\n /* Support diagnostic hardware tests */\n-# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || EFSYS_OPT_MEDFORD)\n-# error \"DIAG requires SIENA or HUNTINGTON or MEDFORD\"\n+# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || \\\n+\tEFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2)\n+# error \"DIAG requires SIENA or HUNTINGTON or MEDFORD or MEDFORD2\"\n # endif\n #endif /* EFSYS_OPT_DIAG */\n \n #if EFSYS_OPT_EV_PREFETCH\n /* Support optimized EVQ data access */\n-# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || EFSYS_OPT_MEDFORD)\n-# error \"EV_PREFETCH requires SIENA or HUNTINGTON or MEDFORD\"\n+# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || \\\n+\tEFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2)\n+# error \"EV_PREFETCH requires SIENA or HUNTINGTON or MEDFORD or MEDFORD2\"\n # endif\n #endif /* EFSYS_OPT_EV_PREFETCH */\n \n@@ -62,21 +65,23 @@\n \n #if EFSYS_OPT_FILTER\n /* Support hardware packet filters */\n-# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || EFSYS_OPT_MEDFORD)\n-# error \"FILTER requires SIENA or HUNTINGTON or MEDFORD\"\n+# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || \\\n+\tEFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2)\n+# error \"FILTER requires SIENA or HUNTINGTON or MEDFORD or MEDFORD2\"\n # endif\n #endif /* EFSYS_OPT_FILTER */\n \n-#if (EFSYS_OPT_HUNTINGTON || EFSYS_OPT_MEDFORD)\n+#if (EFSYS_OPT_HUNTINGTON || EFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2)\n # if !EFSYS_OPT_FILTER\n-# error \"HUNTINGTON or MEDFORD requires FILTER\"\n+# error \"HUNTINGTON or MEDFORD or MEDFORD2 requires FILTER\"\n # endif\n #endif /* EFSYS_OPT_HUNTINGTON */\n \n #if EFSYS_OPT_LOOPBACK\n /* Support hardware loopback modes */\n-# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || EFSYS_OPT_MEDFORD)\n-# error \"LOOPBACK requires SIENA or HUNTINGTON or MEDFORD\"\n+# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || \\\n+\tEFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2)\n+# error \"LOOPBACK requires SIENA or HUNTINGTON or MEDFORD or MEDFORD2\"\n # endif\n #endif /* EFSYS_OPT_LOOPBACK */\n \n@@ -90,21 +95,24 @@\n \n #if EFSYS_OPT_MAC_STATS\n /* Support MAC statistics */\n-# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || EFSYS_OPT_MEDFORD)\n-# error \"MAC_STATS requires SIENA or HUNTINGTON or MEDFORD\"\n+# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || \\\n+\tEFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2)\n+# error \"MAC_STATS requires SIENA or HUNTINGTON or MEDFORD or MEDFORD2\"\n # endif\n #endif /* EFSYS_OPT_MAC_STATS */\n \n #if EFSYS_OPT_MCDI\n /* Support management controller messages */\n-# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || EFSYS_OPT_MEDFORD)\n-# error \"MCDI requires SIENA or HUNTINGTON or MEDFORD\"\n+# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || \\\n+\tEFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2)\n+# error \"MCDI requires SIENA or HUNTINGTON or MEDFORD or MEDFORD2\"\n # endif\n #endif /* EFSYS_OPT_MCDI */\n \n-#if (EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || EFSYS_OPT_MEDFORD)\n+#if (EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || \\\n+\tEFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2)\n # if !EFSYS_OPT_MCDI\n-# error \"SIENA or HUNTINGTON or MEDFORD requires MCDI\"\n+# error \"SIENA or HUNTINGTON or MEDFORD or MEDFORD2 requires MCDI\"\n # endif\n #endif\n \n@@ -144,15 +152,17 @@\n \n #if EFSYS_OPT_MON_STATS\n /* Support monitor statistics (voltage/temperature) */\n-# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || EFSYS_OPT_MEDFORD)\n-# error \"MON_STATS requires SIENA or HUNTINGTON or MEDFORD\"\n+# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || \\\n+\tEFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2)\n+# error \"MON_STATS requires SIENA or HUNTINGTON or MEDFORD or MEDFORD2\"\n # endif\n #endif /* EFSYS_OPT_MON_STATS */\n \n #if EFSYS_OPT_MON_MCDI\n /* Support Monitor via mcdi */\n-# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || EFSYS_OPT_MEDFORD)\n-# error \"MON_MCDI requires SIENA or HUNTINGTON or MEDFORD\"\n+# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || \\\n+\tEFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2)\n+# error \"MON_MCDI requires SIENA or HUNTINGTON or MEDFORD or MEDFORD2\"\n # endif\n #endif /* EFSYS_OPT_MON_MCDI*/\n \n@@ -166,8 +176,9 @@\n \n #if EFSYS_OPT_NVRAM\n /* Support non volatile configuration */\n-# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || EFSYS_OPT_MEDFORD)\n-# error \"NVRAM requires SIENA or HUNTINGTON or MEDFORD\"\n+# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || \\\n+\tEFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2)\n+# error \"NVRAM requires SIENA or HUNTINGTON or MEDFORD or MEDFORD2\"\n # endif\n #endif /* EFSYS_OPT_NVRAM */\n \n@@ -200,8 +211,9 @@\n \n #if EFSYS_OPT_PHY_LED_CONTROL\n /* Support for PHY LED control */\n-# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || EFSYS_OPT_MEDFORD)\n-# error \"PHY_LED_CONTROL requires SIENA or HUNTINGTON or MEDFORD\"\n+# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || \\\n+\tEFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2)\n+# error \"PHY_LED_CONTROL requires SIENA or HUNTINGTON or MEDFORD or MEDFORD2\"\n # endif\n #endif /* EFSYS_OPT_PHY_LED_CONTROL */\n \n@@ -246,8 +258,9 @@\n \n #if EFSYS_OPT_QSTATS\n /* Support EVQ/RXQ/TXQ statistics */\n-# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || EFSYS_OPT_MEDFORD)\n-# error \"QSTATS requires SIENA or HUNTINGTON or MEDFORD\"\n+# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || \\\n+\tEFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2)\n+# error \"QSTATS requires SIENA or HUNTINGTON or MEDFORD or MEDFORD2\"\n # endif\n #endif /* EFSYS_OPT_QSTATS */\n \n@@ -257,15 +270,17 @@\n \n #if EFSYS_OPT_RX_SCALE\n /* Support receive scaling (RSS) */\n-# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || EFSYS_OPT_MEDFORD)\n-# error \"RX_SCALE requires SIENA or HUNTINGTON or MEDFORD\"\n+# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || \\\n+\tEFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2)\n+# error \"RX_SCALE requires SIENA or HUNTINGTON or MEDFORD or MEDFORD2\"\n # endif\n #endif /* EFSYS_OPT_RX_SCALE */\n \n #if EFSYS_OPT_RX_SCATTER\n /* Support receive scatter DMA */\n-# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || EFSYS_OPT_MEDFORD)\n-# error \"RX_SCATTER requires SIENA or HUNTINGTON or MEDFORD\"\n+# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || \\\n+\tEFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2)\n+# error \"RX_SCATTER requires SIENA or HUNTINGTON or MEDFORD or MEDFORD2\"\n # endif\n #endif /* EFSYS_OPT_RX_SCATTER */\n \n@@ -275,8 +290,9 @@\n \n #if EFSYS_OPT_VPD\n /* Support PCI Vital Product Data (VPD) */\n-# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || EFSYS_OPT_MEDFORD)\n-# error \"VPD requires SIENA or HUNTINGTON or MEDFORD\"\n+# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || \\\n+\tEFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2)\n+# error \"VPD requires SIENA or HUNTINGTON or MEDFORD or MEDFORD2\"\n # endif\n #endif /* EFSYS_OPT_VPD */\n \n@@ -290,8 +306,9 @@\n \n #if EFSYS_OPT_BIST\n /* Support BIST */\n-# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || EFSYS_OPT_MEDFORD)\n-# error \"BIST requires SIENA or HUNTINGTON or MEDFORD\"\n+# if !(EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || \\\n+\tEFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2)\n+# error \"BIST requires SIENA or HUNTINGTON or MEDFORD or MEDFORD2\"\n # endif\n #endif /* EFSYS_OPT_BIST */\n \n@@ -307,15 +324,15 @@\n \n #if EFSYS_OPT_ALLOW_UNCONFIGURED_NIC\n /* Support adapters with missing static config (for factory use only) */\n-# if !EFSYS_OPT_MEDFORD\n-# error \"ALLOW_UNCONFIGURED_NIC requires MEDFORD\"\n+# if !(EFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2)\n+# error \"ALLOW_UNCONFIGURED_NIC requires MEDFORD or MEDFORD2\"\n # endif\n #endif /* EFSYS_OPT_ALLOW_UNCONFIGURED_NIC */\n \n #if EFSYS_OPT_RX_PACKED_STREAM\n /* Support packed stream mode */\n-# if !(EFSYS_OPT_HUNTINGTON || EFSYS_OPT_MEDFORD)\n-# error \"PACKED_STREAM requires HUNTINGTON or MEDFORD\"\n+# if !(EFSYS_OPT_HUNTINGTON || EFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2)\n+# error \"PACKED_STREAM requires HUNTINGTON or MEDFORD or MEDFORD2\"\n # endif\n #endif\n \ndiff --git a/drivers/net/sfc/efsys.h b/drivers/net/sfc/efsys.h\nindex ecbd14f..fcc4f5f 100644\n--- a/drivers/net/sfc/efsys.h\n+++ b/drivers/net/sfc/efsys.h\n@@ -150,6 +150,8 @@ prefetch_read_once(const volatile void *addr)\n #define EFSYS_OPT_HUNTINGTON 1\n /* Enable SFN8xxx support */\n #define EFSYS_OPT_MEDFORD 1\n+/* Disable SFN2xxx support (not supported yet) */\n+#define EFSYS_OPT_MEDFORD2 0\n #ifdef RTE_LIBRTE_SFC_EFX_DEBUG\n #define EFSYS_OPT_CHECK_REG 1\n #else\n", "prefixes": [ "dpdk-dev", "06/80" ] }