Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 35165,
    "url": "http://patches.dpdk.org/api/patches/35165/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/d3535e69b45a4139bb322a0ba8383479@sandvine.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<d3535e69b45a4139bb322a0ba8383479@sandvine.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/d3535e69b45a4139bb322a0ba8383479@sandvine.com",
    "date": "2018-02-14T12:00:21",
    "name": "[dpdk-dev,v2] net/i40e: fix link_state update for i40e_ethdev_vf drv",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "2e7d1f4ef38383c6d68b76c84f89575dfb23c09c",
    "submitter": {
        "id": 954,
        "url": "http://patches.dpdk.org/api/people/954/?format=api",
        "name": "Tushar Mulkar",
        "email": "tmulkar@sandvine.com"
    },
    "delegate": {
        "id": 24,
        "url": "http://patches.dpdk.org/api/users/24/?format=api",
        "username": "helin_zhang",
        "first_name": "Helin",
        "last_name": "Zhang",
        "email": "helin.zhang@intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/d3535e69b45a4139bb322a0ba8383479@sandvine.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/35165/comments/",
    "check": "warning",
    "checks": "http://patches.dpdk.org/api/patches/35165/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 611C41B29A;\n\tWed, 14 Feb 2018 13:00:31 +0100 (CET)",
            "from mail1.sandvine.com (Mail1.sandvine.com [64.7.137.134])\n\tby dpdk.org (Postfix) with ESMTP id 3E5931B295\n\tfor <dev@dpdk.org>; Wed, 14 Feb 2018 13:00:29 +0100 (CET)",
            "from WTL-EXCHSV1-1.sandvine.com (192.168.196.60) by\n\tWTL-EXCHSV2-1.sandvine.com (192.168.194.58) with Microsoft SMTP\n\tServer\n\t(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n\t15.1.1034.26; Wed, 14 Feb 2018 07:00:26 -0500",
            "from WTL-EXCHSV2-1.sandvine.com (192.168.194.58) by\n\tWTL-EXCHSV1-1.sandvine.com (192.168.196.60) with Microsoft SMTP\n\tServer\n\t(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n\t15.1.1034.26; Wed, 14 Feb 2018 07:00:26 -0500",
            "from BLR-EXCHSV1-2.sandvine.com (10.30.4.75) by\n\tWTL-EXCHSV2-1.sandvine.com (192.168.194.58) with Microsoft SMTP\n\tServer\n\t(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n\t15.1.1034.26 via Frontend Transport; Wed, 14 Feb 2018 07:00:26 -0500",
            "from blr-exchsv1-1.sandvine.com (10.30.4.73) by\n\tBLR-EXCHSV1-2.sandvine.com (10.30.4.75) with Microsoft SMTP Server\n\t(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n\t15.1.1034.26; Wed, 14 Feb 2018 17:30:21 +0530",
            "from blr-exchsv1-1.sandvine.com ([fe80::8cb6:e09c:f011:98f6]) by\n\tblr-exchsv1-1.sandvine.com ([fe80::8cb6:e09c:f011:98f6%24]) with mapi\n\tid 15.01.1034.026; Wed, 14 Feb 2018 17:30:21 +0530"
        ],
        "From": "Tushar Mulkar <tmulkar@sandvine.com>",
        "To": "\"Zhang, Helin\" <helin.zhang@intel.com>, \"dev@dpdk.org\" <dev@dpdk.org>",
        "CC": "\"Xing, Beilei\" <beilei.xing@intel.com>, \"Zhang, Qi Z\"\n\t<qi.z.zhang@intel.com>",
        "Thread-Topic": "[PATCH v2] net/i40e: fix link_state update for i40e_ethdev_vf\n\tdrv",
        "Thread-Index": "AQHTpYrgIRh/5+Xo3E2D0Xa0Z1IJnKOjyr+Q",
        "Date": "Wed, 14 Feb 2018 12:00:21 +0000",
        "Message-ID": "<d3535e69b45a4139bb322a0ba8383479@sandvine.com>",
        "References": "<B100BEBE3931D74C91B0DFE67C1055F9035BC999>\n\t<20180214115630.136681-1-tmulkar@sandvine.com>",
        "In-Reply-To": "<20180214115630.136681-1-tmulkar@sandvine.com>",
        "Accept-Language": "en-US",
        "Content-Language": "en-US",
        "X-MS-Has-Attach": "",
        "X-MS-TNEF-Correlator": "",
        "x-originating-ip": "[10.30.10.127]",
        "Content-Type": "text/plain; charset=\"us-ascii\"",
        "Content-Transfer-Encoding": "quoted-printable",
        "MIME-Version": "1.0",
        "X-C2ProcessedOrg": "b2f06e69-072f-40ee-90c5-80a34e700794",
        "Subject": "[dpdk-dev] [PATCH v2] net/i40e: fix link_state update for\n\ti40e_ethdev_vf drv",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The check for bool was accounting unwanted bits in the calulation of truth value. In dpdk unsingned int is typedefed to bool but all it cares about is Least Significant Bit. But in calculation of condition expression the bits other than LSB was used which doesn't make sense. Some time these bits has values which results in to incorrect expression results. To fix this we just need to account LSB form the bool value . This can be easily done by anding the value with true.\n\nSigned-off-by: Tushar Mulkar <tmulkar@sandvine.com>\n---\n drivers/net/i40e/i40e_ethdev_vf.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\n--\n2.11.0",
    "diff": "diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c\nindex b96d77a0c..d23dff044 100644\n--- a/drivers/net/i40e/i40e_ethdev_vf.c\n+++ b/drivers/net/i40e/i40e_ethdev_vf.c\n@@ -2095,8 +2095,8 @@ i40evf_dev_link_update(struct rte_eth_dev *dev,\n \t}\n \t/* full duplex only */\n \tnew_link.link_duplex = ETH_LINK_FULL_DUPLEX;\n-\tnew_link.link_status = vf->link_up ? ETH_LINK_UP :\n-\t\t\t\t\t     ETH_LINK_DOWN;\n+\tnew_link.link_status = (vf->link_up & true) ? \n+                            ETH_LINK_UP : ETH_LINK_DOWN;\n \tnew_link.link_autoneg =\n \t\tdev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED;\n \n",
    "prefixes": [
        "dpdk-dev",
        "v2"
    ]
}