Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/35136/?format=api
{ "id": 35136, "url": "http://patches.dpdk.org/api/patches/35136/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180212154612.5297-4-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180212154612.5297-4-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180212154612.5297-4-maxime.coquelin@redhat.com", "date": "2018-02-12T15:46:12", "name": "[dpdk-dev,v2,3/3] vhost: don't take access_lock on VHOST_USER_RESET_OWNER", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "14748b9814997637faf1b59a25a5510869912cc1", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180212154612.5297-4-maxime.coquelin@redhat.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/35136/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/35136/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C873C1B3D1;\n\tMon, 12 Feb 2018 16:46:46 +0100 (CET)", "from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])\n\tby dpdk.org (Postfix) with ESMTP id 30BAB1B3D2;\n\tMon, 12 Feb 2018 16:46:46 +0100 (CET)", "from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C31D040A0971;\n\tMon, 12 Feb 2018 15:46:45 +0000 (UTC)", "from localhost.localdomain (ovpn-112-42.ams2.redhat.com\n\t[10.36.112.42])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 33E402024CA2;\n\tMon, 12 Feb 2018 15:46:43 +0000 (UTC)" ], "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "tiwei.bie@intel.com, yliu@fridaylinux.org, ferruh.yigit@intel.com,\n\tvictork@redhat.com, thomas@monjalon.net, olivier.matz@6wind.com,\n\tjianfeng.tan@intel.com", "Cc": "dev@dpdk.org, stable@dpdk.org, zhihong.wang@intel.com,\n\tqian.q.xu@intel.com, \n\tlei.a.yao@intel.com, Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Mon, 12 Feb 2018 16:46:12 +0100", "Message-Id": "<20180212154612.5297-4-maxime.coquelin@redhat.com>", "In-Reply-To": "<20180212154612.5297-1-maxime.coquelin@redhat.com>", "References": "<20180212154612.5297-1-maxime.coquelin@redhat.com>", "X-Scanned-By": "MIMEDefang 2.78 on 10.11.54.4", "X-Greylist": [ "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.11.55.7]); Mon, 12 Feb 2018 15:46:45 +0000 (UTC)", "inspected by milter-greylist-4.5.16 (mx1.redhat.com\n\t[10.11.55.7]); \n\tMon, 12 Feb 2018 15:46:45 +0000 (UTC) for IP:'10.11.54.4'\n\tDOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com'\n\tHELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:''" ], "Subject": "[dpdk-dev] [PATCH v2 3/3] vhost: don't take access_lock on\n\tVHOST_USER_RESET_OWNER", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "A deadlock happens when handling VHOST_USER_RESET_OWNER request\nfor the same reason the lock is not taken for\nVHOST_USER_GET_VRING_BASE.\n\nIt is safe not to take the lock, as the queues are no more used\nby the application when the virtqueues and the device are reset.\n\nFixes: a3688046995f (\"vhost: protect active rings from async ring changes\")\nCc: stable@dpdk.org\n\nCc: Victor Kaplansky <victork@redhat.com>\nReviewed-by: Tiwei Bie <tiwei.bie@intel.com>\nReviewed-by: Jianfeng Tan <jianfeng.tan@intel.com>\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/librte_vhost/vhost_user.c | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex 65ee33919..90ed2112e 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -1348,16 +1348,16 @@ vhost_user_msg_handler(int vid, int fd)\n \t}\n \n \t/*\n-\t * Note: we don't lock all queues on VHOST_USER_GET_VRING_BASE,\n-\t * since it is sent when virtio stops and device is destroyed.\n-\t * destroy_device waits for queues to be inactive, so it is safe.\n-\t * Otherwise taking the access_lock would cause a dead lock.\n+\t * Note: we don't lock all queues on VHOST_USER_GET_VRING_BASE\n+\t * and VHOST_USER_RESET_OWNER, since it is sent when virtio stops\n+\t * and device is destroyed. destroy_device waits for queues to be\n+\t * inactive, so it is safe. Otherwise taking the access_lock\n+\t * would cause a dead lock.\n \t */\n \tswitch (msg.request.master) {\n \tcase VHOST_USER_SET_FEATURES:\n \tcase VHOST_USER_SET_PROTOCOL_FEATURES:\n \tcase VHOST_USER_SET_OWNER:\n-\tcase VHOST_USER_RESET_OWNER:\n \tcase VHOST_USER_SET_MEM_TABLE:\n \tcase VHOST_USER_SET_LOG_BASE:\n \tcase VHOST_USER_SET_LOG_FD:\n", "prefixes": [ "dpdk-dev", "v2", "3/3" ] }