Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/35115/?format=api
{ "id": 35115, "url": "http://patches.dpdk.org/api/patches/35115/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1518370054-12578-1-git-send-email-matan@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1518370054-12578-1-git-send-email-matan@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1518370054-12578-1-git-send-email-matan@mellanox.com", "date": "2018-02-11T17:27:34", "name": "[dpdk-dev] net/failsafe: fix reconfiguration", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e2d93e1045cb0772851911d99af8cc94c1309b68", "submitter": { "id": 796, "url": "http://patches.dpdk.org/api/people/796/?format=api", "name": "Matan Azrad", "email": "matan@mellanox.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1518370054-12578-1-git-send-email-matan@mellanox.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/35115/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/35115/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 058FE1B316;\n\tSun, 11 Feb 2018 18:27:52 +0100 (CET)", "from EUR01-DB5-obe.outbound.protection.outlook.com\n\t(mail-db5eur01on0054.outbound.protection.outlook.com [104.47.2.54])\n\tby dpdk.org (Postfix) with ESMTP id 7CE931B2F6;\n\tSun, 11 Feb 2018 18:27:50 +0100 (CET)", "from mellanox.com (37.142.13.130) by\n\tHE1PR0501MB2666.eurprd05.prod.outlook.com (2603:10a6:3:cb::20) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.485.10;\n\tSun, 11 Feb 2018 17:27:48 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=Tz9AKkaCWR0nkzDHOOrBPkM9+8/BRSesdD92q3DWX2g=;\n\tb=UxQfcfBdywmyQ0XfJx7GjHFpIIafoZ7absEI04AxkWvj7y4yEKj971wAbLtpRs3NMV9XCK6uXYd3Ho2vmHdYleepfU/acFS0DRAvVBtBqCl1bPIJKjX5gFyJtqQwtAnSo5yEi7u7KvV2vMqnScWX/Rei1G/UPXl3oRGYMr/2iXM=", "Authentication-Results": "spf=none (sender IP is )\n\tsmtp.mailfrom=matan@mellanox.com; ", "From": "Matan Azrad <matan@mellanox.com>", "To": "Gaetan Rivet <gaetan.rivet@6wind.com>", "Cc": "dev@dpdk.org,\n\tstable@dpdk.org", "Date": "Sun, 11 Feb 2018 17:27:34 +0000", "Message-Id": "<1518370054-12578-1-git-send-email-matan@mellanox.com>", "X-Mailer": "git-send-email 1.8.3.1", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[37.142.13.130]", "X-ClientProxiedBy": "VI1PR0102CA0005.eurprd01.prod.exchangelabs.com\n\t(2603:10a6:802::18) To HE1PR0501MB2666.eurprd05.prod.outlook.com\n\t(2603:10a6:3:cb::20)", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-HT": "Tenant", "X-MS-Office365-Filtering-Correlation-Id": "cdc19ad4-eece-4f83-bed5-08d57174c5cd", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020);\n\tSRVR:HE1PR0501MB2666; ", "X-Microsoft-Exchange-Diagnostics": [ "1; HE1PR0501MB2666;\n\t3:UUW0Q1B7S5JebFm7JTMOoS0v8aPvbWMK6KH4iEOT1FCANglDxeihPn/pPB22LeYVBA+dBwom0Gp2LJicjcdaqrlbAoW9owadQtSNV5VFg3AxUHU9NTjJrW9UGLVrR32KarnV0leAPp+coanm7G3McE98MLJRlCEXjdfQXh8pp54WlmtDB01V5R6zv5A0MwJChD/z9t56UahsoGGw9r74swn49TzuR/fkTl1m/i6fxM2roVstlHZTxb/7OJea97cz;\n\t25:6G+tEFoN8OXqUSpKLf6Dxk9wY1FHnoUAbLC7YcKkqAU6q2OyGCQaHp+LAhuFlHxM856sO9GqRx759yE4DOvS4hfNJpdzYPFSRUgq0VWzzBlaagtgFkunX+pEy0k4eB/mMAiJMOjwxfb7Oodk5Ph36sWv8UUzcLyUQJsoVA2YwAqZuW3wtNjT4oe8v48DOp2Nm3RzkgVqm7o5tChwh4kse2mROQEhWK3uDiql4887rpruauEa5jNDNUid4HHiAIuhomkBtKnkYmspRH7+o/emoLGSKPZV2fvvX22+p+7Uv/LiRmCovg34thQKda6+1asOIDICQ7DS1cs/OyMd0k5z7g==;\n\t31:dYhVq4f449v0dJ5EZu4ansVhZoCFvaxevtU5mgNuLHRcWcWlH6uj/xaU6R9kmFX3SPnRHpecUOSaH7lW7wGldQw7U/8NrBqreb3Oe17ZR4c5o8gPoRnLLOvt7mr57lQyK5JNzFjqmmvlVwAydjM/rzD86xnCZ2XGs0UKyGAz41TnNF9V534laaDwiCmEivB10r0RtsKS5ZhU/fPZVc+WJIAAzJZMfkVqtfZXzbFwS/Q=", "1; HE1PR0501MB2666;\n\t20:HRS1yiaeh0jRM4idaVJFIV5NKa9W7bqnX76eWNj7/bDAhb5BDXrdcV5daLtuE1ES3P0y7El4JcqxDTESNgjv60IuTl94hYo3GNl7Xn6nM/qklr3Wo8h2cUzebZvbNa+5L11MwFVJkUkG7/Vu9AYW82BXDqJvDKDQDLB5y5i6ul64SqjS31cDcwI7w5GYMLAaykBWAKiCLOHO16sJg7fD8qoAScTdPZks1Bk5XgwtfTSOtrRIapZXWp6z9keB4IT6E+ynhEyad/Ru8P9fXicKsYQsoGLCKHCH49u0xT8rwi5jjAhqJU1OhLjrol66Ge0RScU6TAliy1aW7LWJI2vYm1gLvnS9lGBb3qYgbwpLWoqMipqk84R/DghUm4OBhFWTcgjWsM2xVjYDXj2xNZ2CsXiGlsGPbFMWHjf00ozGR4456tC7FtwCCXbYZA9XJc+chuE7FHEsx5bh4t4sl6nxhcJMoAISMR6LV6kJRKrB/ruemRGG2y884FLN5DJpkJQW;\n\t4:yLszQ7dIiqKHX1WEleuSy3M450M5EXWMDwPQnAZobiAmC0M0dcjtVmTbged4fvfqXb7vN2ccxi0XdVM/LxrAIUbSFXbVtimBQi0KObpSFZ8fHiD6rasDzjCA5wb1EEcKbEgSIdyd0KN1pdGEgerogOYs/QpPtNKFKTrG9fl7w7vudjSkl4Xo+Lgr81uQ+sYjhnJRBfONNVPLIeE1lNpDP+AXWjlZbbdRzXuWOo9efXynECaiyOgsyMfcV4CC9p0phxqWbl6ShL9ZiBoAa02QRg==", "=?us-ascii?Q?1; HE1PR0501MB2666;\n\t23:Rb5NL1ykmsPHPynOJeUHccdkurqu2/B9zkK0Y5w?=\n\tMwD5YTX4rTvNBFMbrM7Sfc9e11TG46dgvUBjA3M1S2esX7Ecvg1qXYxiRoHsKK+dyRqgm9fy8/57JL8Lh7nfyFf07Pyc3BC/bw7S0qkYLYSFtOVU9RjH2h1cvHII4rfxjZUkA0Vr7fpScu9mqzNV3ETqmGAPnWb38V71PJyYawew9tWOHJHepJOpUfYkDbzpreAJg21/g9kp3Cez9YBd7KbgtWccsfIaP5YLf2QvihH29GR/yo6z45ojpaHOBRT49OONyqYb5zfP1CBgPC2dMxWdLTX6AgoYD5Df+Q91aO9geNlNEf89kPq728RpIN4/oEI+KKA3k69tl1a+OLefCW/yk5jK6fLY17M4BXyGXU4FhbjKat5rSGlfgPOSa22RDu55wHXxzbbfunGdb8wPkgXeNhRhaDZiakErLh8R/4FTxpIT+sXD0xGYyifMwEd3izO52K0aBvBS9wffzXMOKm+bReT7lOjsZSgil1h7JDqSCeuqyxqtiskfRsp3Munzddw55UCEpiXn8+AkZ3ve6EOaJTjkvGJQYaprLE74mon8ybq5IhK73TCuArJGB7w9WPVBP0nfS2Lct6lMNI8GsbdE0GhtHTZkjoGZWeju/4h1TsWXgM3ZTeyrZEwRJ4fw2SlhZCC251mQ9qqTmHagPUQtYuTbk65SThVIBHfOJTiQqpxmT3mkqfDh9tEGNUIxR1hXAFMX6YaW3QMMDuuWuMC0YJ+Tb0nzZ++0hHNmmQRGwz1BcOYaig1gyCPIsHDsqjdi9GXRKg7eycXHoG5VyAoGCbIVieJkDCh885sgFLAS5kNeDot+gw3O72485jj4mqr4owLMCoxXDDih11TjGOEGrKGa34JJ/nBPxp5T3XuCKWAGzhk4qLYPFlH1wv9EKBxEdGDf68XtIgIDhHexpiouZGCOSvO8FP/k4yAIWu7JIykJRp0US3ZQwEYIfwbEH6/N8LBzMqxbhzuqOFVwEkRFR5hnb6Hve0i2fMTVh8Y7UdnomHid8nS7/aMx80pslXStvUPN3g+hyQln/HmzgJVAJSS4M7m/M550t+9ED/hx9eOd+X/CBKxjiek+iNrG6c5Gxw2V+MS8yCweCr44fPfyTvb8l3qs69522ec7dsDvn7GxA7XY5EQh7nLxFxfC0U94=", "1; HE1PR0501MB2666;\n\t6:j6QqESP5CfnUH9NtQmC1exPf0j/DGzQhRmelweFMc4JfEwrVfyaYWq5yn17dsCAc9GaMRpi7UBcDxEcLF0V46L+TwLjgvRsuBm8rkkMakdWCuZhHkZC2vYFPLXDnDaCC1sHCS1R9RQlGM3Gli+psNfJp1t//gKa2tIKA+NAN3IXYLUP2JBcCHBOQPZAWp8pVyOcigA77qAQZyE1Px5BCEvU4ML152/l8z65PWESVrRuW92GhZ/0S7CsLydlJ0/K3364370Pu01Owp9G0HxqPZ95N6YweL7mxfsi7ZUffglvQULW3WPD8mLYH7Z/FBlXPgewMB4Kqgns3nCFyGFTqUzCSfIKRN8en30saM0ZbaNs=;\n\t5:2wxvY6aNRfW0f4orUyUrGyG6Cizfnh7rqydsJtUduhGi8Wu/AycIfPKZ+hu6xJqbgmZN7aPxocrnXnBwJylbYDzYe2Qvut7VUQcB6STmYq3PKrUE38Q9IcWinKeFSbxftl8f/NIi9A/kxAGODL3y41kTwtJguJn77K2opF1IfDs=;\n\t24:b99iU9HVg78x2tTFSqlKJDf76+AAjRCdeeGGkykvMrIObbDqNIvO3I9zhFZ3ZExackSleSqVgBmQUSkn+R+oi4MJPZ6Su9EyR6NlM91nz3U=;\n\t7:sDdRWVy7PJC73sSckHBMZ6g2O3VAaoGsbrJSMWq1QugTkvNWYt4v1JG+p4f42k7CT7lAHCQgrr5VSSozjZgzs/IsOeUMH+4XDnHBsAhHFJll3B32viCu3I4u0edM1GGDaFl99kdBEHIChf23psTymQYM7wDLsAfuijn+/Pjbt1gkbGkN44qBMvdvH0qNfm4zg1/BOBRhLHSykdSrdYnmW6vIB287c2oGUOtOLKGU+0mxDmeKG3wMGmlihPsXFj2o" ], "X-MS-TrafficTypeDiagnostic": "HE1PR0501MB2666:", "X-Microsoft-Antispam-PRVS": "<HE1PR0501MB266604C3A4ED4D97DAB5B102D2F00@HE1PR0501MB2666.eurprd05.prod.outlook.com>", "X-Exchange-Antispam-Report-Test": "UriScan:;", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(6040501)(2401047)(8121501046)(5005006)(3231101)(2400082)(944501161)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041288)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123564045)(6072148)(201708071742011);\n\tSRVR:HE1PR0501MB2666; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2666; ", "X-Forefront-PRVS": "058043A388", "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(39380400002)(39860400002)(366004)(346002)(396003)(376002)(189003)(199004)(26005)(68736007)(25786009)(69596002)(97736004)(53936002)(16586007)(5660300001)(48376002)(50226002)(105586002)(47776003)(59450400001)(66066001)(81166006)(106356001)(386003)(316002)(8676002)(21086003)(7736002)(55016002)(52116002)(7696005)(51416003)(2906002)(81156014)(6666003)(3846002)(6916009)(4720700003)(1857600001)(36756003)(6116002)(86362001)(186003)(16526019)(305945005)(33026002)(478600001)(4326008)(50466002)(8936002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2666; H:mellanox.com; FPR:;\n\tSPF:None; \n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ", "Received-SPF": "None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "11 Feb 2018 17:27:48.4346\n\t(UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "cdc19ad4-eece-4f83-bed5-08d57174c5cd", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "HE1PR0501MB2666", "Subject": "[dpdk-dev] [PATCH] net/failsafe: fix reconfiguration", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fail-safe PMD manages the states of its sub-devices gradually:\nDEV_UNDEFINED, DEV_PARSED, DEV_PROBED, DEV_ACTIVE, DEV_STARTED.\n\nWhen the sub-device arguments successfully was parsed, the state is\nraised from DEV_UNDEFINED to DEV_PARSED.\nWhen the sub-device successfully was probed, the state is raised from\nDEV_PARSED to DEV_PROBED.\nWhen the sub-device successfully was configured by\nrte_eth_dev_configure(), the state is raised from DEV_PROBED to\nDEV_ACTIVE.\nWhen the sub-device successfully was started by rte_eth_dev_start(), the\nstate is raised from DEV_ACTIVE to DEV_STARTED.\n\nWhen the sub-device successfully was stopped by rte_eth_dev_stop(), the\nstate is degraded from DEV_STARTED to DEV_ACTIVE.\nWhen the sub-device successfully was closed by rte_eth_dev_close(), the\nstate is degraded from DEV_ACTIVE to DEV_PROBED.\nWhen the sub-device successfully was removed by\nrte_eal_hotplug_remove(), the state is degraded from DEV_PROBED to\nDEV_UNDEFINED.\n\nFail-safe dev_configure() operation calls to its sub-devices\ndev_configure() operation, but only for sub-devices which are in\nDEV_PROBED state, means that sub-devices which are in DEV_ACTIVE state\nbecause the application triggered dev_stop() operation cannot be\nreconfigured again by dev_configure() operation which is really\nproblematic when application wants to reconfigure its ports.\nActually, the application may get success report when some of the\nsub-devices are not in the wanted configuration.\n\nThe current behavior of fail-safe dev_configure() is correct only for\nthe first time dev_configure() is triggered by the application or for\nsub-device synchronization in plug-in event, but it ignores the option\nfor reconfiguration from application side.\n\nAllow calling to sub-devices dev_configure() operations also in\nDEV_ACTIVE state when the call was triggered by the application.\n\nFixes: a46f8d584eb8 (\"net/failsafe: add fail-safe PMD\")\nCc: stable@dpdk.org\n\nSigned-off-by: Matan Azrad <matan@mellanox.com>\n---\nBased on previous series, \"fix hotplug races\".\n\n drivers/net/failsafe/failsafe_ops.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c\nindex fe64c68..057e435 100644\n--- a/drivers/net/failsafe/failsafe_ops.c\n+++ b/drivers/net/failsafe/failsafe_ops.c\n@@ -110,7 +110,8 @@\n \t\tint lsc_interrupt = 0;\n \t\tint lsc_enabled;\n \n-\t\tif (sdev->state != DEV_PROBED)\n+\t\tif (sdev->state != DEV_PROBED &&\n+\t\t !(PRIV(dev)->alarm_lock == 0 && sdev->state == DEV_ACTIVE))\n \t\t\tcontinue;\n \n \t\trmv_interrupt = ETH(sdev)->data->dev_flags &\n", "prefixes": [ "dpdk-dev" ] }