Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/34970/?format=api
{ "id": 34970, "url": "http://patches.dpdk.org/api/patches/34970/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180205123027.GA15752@bricha3-MOBL3.ger.corp.intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180205123027.GA15752@bricha3-MOBL3.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180205123027.GA15752@bricha3-MOBL3.ger.corp.intel.com", "date": "2018-02-05T12:30:27", "name": "[dpdk-dev,v2,2/2] net/sfc: add support for meson build", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "647c743e61434e9cf273589d7085354f630e5dc7", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180205123027.GA15752@bricha3-MOBL3.ger.corp.intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/34970/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/34970/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9D4B51B344;\n\tMon, 5 Feb 2018 13:30:33 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id C4F301B339\n\tfor <dev@dpdk.org>; Mon, 5 Feb 2018 13:30:31 +0100 (CET)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Feb 2018 04:30:30 -0800", "from bricha3-mobl3.ger.corp.intel.com ([10.237.221.77])\n\tby orsmga005.jf.intel.com with SMTP; 05 Feb 2018 04:30:28 -0800", "by (sSMTP sendmail emulation); Mon, 05 Feb 2018 12:30:27 +0000" ], "X-Amp-Result": "UNSCANNABLE", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.46,464,1511856000\"; d=\"scan'208\";a=\"198700603\"", "Date": "Mon, 5 Feb 2018 12:30:27 +0000", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "Andrew Rybchenko <arybchenko@solarflare.com>", "Cc": "dev@dpdk.org, Ivan Malov <ivan.malov@oktetlabs.ru>", "Message-ID": "<20180205123027.GA15752@bricha3-MOBL3.ger.corp.intel.com>", "References": "<1517575438-8609-1-git-send-email-arybchenko@solarflare.com>\n\t<1517665594-3303-1-git-send-email-arybchenko@solarflare.com>\n\t<1517665594-3303-2-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<1517665594-3303-2-git-send-email-arybchenko@solarflare.com>", "Organization": "Intel Research and Development Ireland Ltd.", "User-Agent": "Mutt/1.9.1 (2017-09-22)", "Subject": "Re: [dpdk-dev] [PATCH v2 2/2] net/sfc: add support for meson build", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "On Sat, Feb 03, 2018 at 01:46:34PM +0000, Andrew Rybchenko wrote:\n> From: Ivan Malov <ivan.malov@oktetlabs.ru>\n> \n> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>\n> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n> ---\n> v2:\n> - use includes to extend include directories set\n> - limit to x86 architecture\n> - specify include directories in base driver build\n> - remove unnecessary optimization level set and driver dir from includes\n> \n> drivers/net/meson.build | 2 +-\n> drivers/net/sfc/base/meson.build | 70 ++++++++++++++++++++++++++++++++++++++++\n> drivers/net/sfc/meson.build | 64 ++++++++++++++++++++++++++++++++++++\n> 3 files changed, 135 insertions(+), 1 deletion(-)\n> create mode 100644 drivers/net/sfc/base/meson.build\n> create mode 100644 drivers/net/sfc/meson.build\n> \nThanks, this looks a lot better.\n\nUnfortunately, it still doesn't compile on ARM, though that is more an\nissue with the drivers/meson.build file, than a bug with your driver\nspecifically. :-( Right now, the base code libraries are still compiled\neven when build = \"false\" because those targets are provided in the\nper-driver meson.build files, rather than managed at the top level one.\nTo properly fix this, in 18.05 I think we should add support at the\ntop-level driver file for base directories, since so many drivers use\nthem. That will move the building of base code to the protection of\n\"build\" flag.\n\nHowever, since this set doesn't affect any other components, I'd like to\nget this into 18.02. To fix it, the following changes need to be made to\nyour patch. If you are ok with these, I can add these changes on apply.\n\nRegards,\n/Bruce", "diff": "diff --git a/drivers/net/sfc/base/meson.build b/drivers/net/sfc/base/meson.build\nindex f8314a9bc..f1e497356 100644\n--- a/drivers/net/sfc/base/meson.build\n+++ b/drivers/net/sfc/base/meson.build\n@@ -62,9 +62,13 @@ foreach flag: extra_flags\n endif\n endforeach\n\n-base_lib = static_library('sfc_base', sources,\n- include_directories: includes,\n- dependencies: static_rte_eal,\n- c_args: c_args)\n+if build\n+ base_lib = static_library('sfc_base', sources,\n+ include_directories: includes,\n+ dependencies: static_rte_eal,\n+ c_args: c_args)\n\n-base_objs = base_lib.extract_all_objects()\n+ base_objs = base_lib.extract_all_objects()\n+else\n+ base_objs = []\n+endif\n", "prefixes": [ "dpdk-dev", "v2", "2/2" ] }