Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/34928/?format=api
{ "id": 34928, "url": "http://patches.dpdk.org/api/patches/34928/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1517768311-827-1-git-send-email-nikhil.rao@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1517768311-827-1-git-send-email-nikhil.rao@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1517768311-827-1-git-send-email-nikhil.rao@intel.com", "date": "2018-02-04T18:18:31", "name": "[dpdk-dev,v2] eventdev: fix unchecked return in default Rx adapter conf cb", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "24a4327dfbc81847f242471194ae159b5dc7deb1", "submitter": { "id": 528, "url": "http://patches.dpdk.org/api/people/528/?format=api", "name": "Rao, Nikhil", "email": "nikhil.rao@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1517768311-827-1-git-send-email-nikhil.rao@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/34928/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/34928/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D60461B1D5;\n\tSun, 4 Feb 2018 19:18:06 +0100 (CET)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id C5E041B1A4\n\tfor <dev@dpdk.org>; Sun, 4 Feb 2018 19:17:55 +0100 (CET)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t04 Feb 2018 10:17:49 -0800", "from unknown (HELO localhost.iind.intel.com) ([10.224.122.216])\n\tby fmsmga008.fm.intel.com with ESMTP; 04 Feb 2018 10:17:47 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.46,460,1511856000\"; d=\"scan'208\";a=\"15359022\"", "From": "Nikhil Rao <nikhil.rao@intel.com>", "To": "dev@dpdk.org", "Cc": "nikhil.rao@intel.com, vipin.varghese@intel.com, deepak.k.jain@intel.com, \n\tjerin.jacob@caviumnetworks.com", "Date": "Sun, 4 Feb 2018 23:48:31 +0530", "Message-Id": "<1517768311-827-1-git-send-email-nikhil.rao@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1517352989-11720-1-git-send-email-vipin.varghese@intel.com>", "References": "<1517352989-11720-1-git-send-email-vipin.varghese@intel.com>", "Subject": "[dpdk-dev] [PATCH v2] eventdev: fix unchecked return in default Rx\n\tadapter conf cb", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The default adapter configuration callback is invoked when a Rx\nqueue is added to the adapter and the adapter detects that a SW\nservice is needed. The adapter needs to re-configure the device\nwith an additional port and to do do, it needs to stop the\ndevice and restart it after it is done reconfiguring it. This\npatch adds code to check the return code of\nrte_event_dev_start() for both when the reconfiguration fails\nand when it succeeds and introduces a new error code (-EIO)\nfor the first case.\n\nFixes: 9c38b704d280 (\"eventdev: add eth Rx adapter implementation\")\nCoverity issue: 257000\n\nSigned-off-by: Nikhil Rao <nikhil.rao@intel.com>\n---\n lib/librte_eventdev/rte_event_eth_rx_adapter.h | 6 ++++++\n lib/librte_eventdev/rte_event_eth_rx_adapter.c | 8 +++++---\n 2 files changed, 11 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.h b/lib/librte_eventdev/rte_event_eth_rx_adapter.h\nindex 6a9e7ed..c20507b 100644\n--- a/lib/librte_eventdev/rte_event_eth_rx_adapter.h\n+++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.h\n@@ -321,6 +321,12 @@ int rte_event_eth_rx_adapter_free(uint8_t id);\n * @return\n * - 0: Success, Receive queue added correctly.\n * - <0: Error code on failure.\n+ * - (-EIO) device reconfiguration and restart error. The adapter reconfigures\n+ * the event device with an additional port if it is required to use a service\n+ * function for packet transfer from the ethernet device to the event device.\n+ * If the device had been started before this call, this error code indicates\n+ * an error in restart following an error in reconfiguration, i.e., a\n+ * combination of the two error codes.\n */\n int rte_event_eth_rx_adapter_queue_add(uint8_t id,\n \t\t\tuint8_t eth_dev_id,\ndiff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c\nindex 90106e6..9aece9f 100644\n--- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c\n+++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c\n@@ -602,8 +602,10 @@ default_conf_cb(uint8_t id, uint8_t dev_id,\n \tif (ret) {\n \t\tRTE_EDEV_LOG_ERR(\"failed to configure event dev %u\\n\",\n \t\t\t\t\t\tdev_id);\n-\t\tif (started)\n-\t\t\trte_event_dev_start(dev_id);\n+\t\tif (started) {\n+\t\t\tif (rte_event_dev_start(dev_id))\n+\t\t\t\treturn -EIO;\n+\t\t}\n \t\treturn ret;\n \t}\n \n@@ -617,7 +619,7 @@ default_conf_cb(uint8_t id, uint8_t dev_id,\n \tconf->event_port_id = port_id;\n \tconf->max_nb_rx = 128;\n \tif (started)\n-\t\trte_event_dev_start(dev_id);\n+\t\tret = rte_event_dev_start(dev_id);\n \trx_adapter->default_cb_arg = 1;\n \treturn ret;\n }\n", "prefixes": [ "dpdk-dev", "v2" ] }