Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/34519/?format=api
{ "id": 34519, "url": "http://patches.dpdk.org/api/patches/34519/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20180126020151.979-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180126020151.979-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20180126020151.979-3-stephen@networkplumber.org", "date": "2018-01-26T02:01:38", "name": "[dpdk-dev,v8,02/15] ethdev: add linkstatus get/set helper functions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "62780dc5fba3f75b497598b25017537d728a84f6", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20180126020151.979-3-stephen@networkplumber.org/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/34519/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/34519/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C5A861B291;\n\tFri, 26 Jan 2018 03:02:00 +0100 (CET)", "from mail-pf0-f196.google.com (mail-pf0-f196.google.com\n\t[209.85.192.196]) by dpdk.org (Postfix) with ESMTP id 5A15E1B1BE\n\tfor <dev@dpdk.org>; Fri, 26 Jan 2018 03:01:57 +0100 (CET)", "by mail-pf0-f196.google.com with SMTP id y26so7198456pfi.10\n\tfor <dev@dpdk.org>; Thu, 25 Jan 2018 18:01:57 -0800 (PST)", "from xeon-e3.lan (204-195-18-133.wavecable.com. [204.195.18.133])\n\tby smtp.gmail.com with ESMTPSA id\n\td5sm22141492pfk.2.2018.01.25.18.01.55\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 25 Jan 2018 18:01:55 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=WoPS4OdWDA8FtVLt/8SVRJfDQ7pFP89bcmolSz1ed00=;\n\tb=kyMA4hIpfzDgbkFd+PeG/OrpCnEENMYs/wATsUNdLFMXOGduyZhqKWnqujMZb7EXIZ\n\tI41hxbim4JFajh5yT++HjbP821lCZQNIgzV2WNIha1nnStYxnHpgz2wyuimth61TmjFu\n\tmwVaW+b1iAJxm5oyXdqETVTbG1s0lXWsCOB5Qa1uRnmoTyGK4rWk9oMeFsxObaX180Nf\n\tXNTr2MjY68xztqJByjX9a2qN2sHWdsXv8MkxnAKAftpHIl+lUsNJ9M1VsN1ENJQwjiox\n\tUH8xxfewxqUOj3VwCKIJTdyR6G61ravbMLUoZtc6GfHICISJMj7f6H9pO2R+I3bG9lin\n\tGDcA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=WoPS4OdWDA8FtVLt/8SVRJfDQ7pFP89bcmolSz1ed00=;\n\tb=cN8Rt0aCTueGwHnzaULE7+hYlPC9go/SKpylwXpc0vAo6rl2OxxMr9rptEloOZEH6Z\n\tPTv3uCEyc1/doCGgk2QFthsHLiikkwzGvfuSVJfVw2G1V08hrlmNKCvbTSXI5FgOjjaZ\n\tKDn1fiSmoz7BFNTLi9IdTDox44qfA4Z0GRW2I5r6CiP9OnmlxxISpD21e7rYAtcLitHs\n\tPAZNiXn3JFQ8ZP8haTGVyShtJe/V9fP5PEJTB9v40BxvI50k8f2U6zNby7w6B/3PWA6p\n\tegxeNl5dB+5na308tS1MaQEOy4KO6XuQnqD7g8i4k9L7QQh4EvxOL5zy3U4TcD/MnP/S\n\t+4Mw==", "X-Gm-Message-State": "AKwxyteFN9wypXwfaqnNkzoyw41ffsNaU6gF596u3URwVxcKYSdSx6Pr\n\tYRqUQ6ZXCn/wt9kjbJ3pb89QQkb2eAs=", "X-Google-Smtp-Source": "AH8x226I+hKHxI8UjT5yiOLjnWTF4RXnwRm4jjrVHKj/ksDYk79aOVfbQhPi2C2OyuWkxqR/K+tJnw==", "X-Received": "by 10.98.63.214 with SMTP id z83mr17461189pfj.95.1516932115983; \n\tThu, 25 Jan 2018 18:01:55 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Thu, 25 Jan 2018 18:01:38 -0800", "Message-Id": "<20180126020151.979-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.15.1", "In-Reply-To": "<20180126020151.979-1-stephen@networkplumber.org>", "References": "<20180126020151.979-1-stephen@networkplumber.org>", "Subject": "[dpdk-dev] [PATCH v8 02/15] ethdev: add linkstatus get/set helper\n\tfunctions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Many drivers are all doing copy/paste of the same code to atomically\nupdate the link status. Reduce duplication, and allow for future\nchanges by having common function for this.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_ether/rte_ethdev.c | 22 +++----------\n lib/librte_ether/rte_ethdev_driver.h | 63 ++++++++++++++++++++++++++++++++++++\n 2 files changed, 67 insertions(+), 18 deletions(-)", "diff": "diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c\nindex f285ba278967..344397101abd 100644\n--- a/lib/librte_ether/rte_ethdev.c\n+++ b/lib/librte_ether/rte_ethdev.c\n@@ -1578,20 +1578,6 @@ rte_eth_allmulticast_get(uint16_t port_id)\n \treturn dev->data->all_multicast;\n }\n \n-static inline int\n-rte_eth_dev_atomic_read_link_status(struct rte_eth_dev *dev,\n-\t\t\t\tstruct rte_eth_link *link)\n-{\n-\tstruct rte_eth_link *dst = link;\n-\tstruct rte_eth_link *src = &(dev->data->dev_link);\n-\n-\tif (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst,\n-\t\t\t\t\t*(uint64_t *)src) == 0)\n-\t\treturn -1;\n-\n-\treturn 0;\n-}\n-\n void\n rte_eth_link_get(uint16_t port_id, struct rte_eth_link *eth_link)\n {\n@@ -1600,8 +1586,8 @@ rte_eth_link_get(uint16_t port_id, struct rte_eth_link *eth_link)\n \tRTE_ETH_VALID_PORTID_OR_RET(port_id);\n \tdev = &rte_eth_devices[port_id];\n \n-\tif (dev->data->dev_conf.intr_conf.lsc != 0)\n-\t\trte_eth_dev_atomic_read_link_status(dev, eth_link);\n+\tif (dev->data->dev_conf.intr_conf.lsc)\n+\t\trte_eth_linkstatus_get(dev, eth_link);\n \telse {\n \t\tRTE_FUNC_PTR_OR_RET(*dev->dev_ops->link_update);\n \t\t(*dev->dev_ops->link_update)(dev, 1);\n@@ -1617,8 +1603,8 @@ rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *eth_link)\n \tRTE_ETH_VALID_PORTID_OR_RET(port_id);\n \tdev = &rte_eth_devices[port_id];\n \n-\tif (dev->data->dev_conf.intr_conf.lsc != 0)\n-\t\trte_eth_dev_atomic_read_link_status(dev, eth_link);\n+\tif (dev->data->dev_conf.intr_conf.lsc)\n+\t\trte_eth_linkstatus_get(dev, eth_link);\n \telse {\n \t\tRTE_FUNC_PTR_OR_RET(*dev->dev_ops->link_update);\n \t\t(*dev->dev_ops->link_update)(dev, 0);\ndiff --git a/lib/librte_ether/rte_ethdev_driver.h b/lib/librte_ether/rte_ethdev_driver.h\nindex 45f08c65ec1e..fd3e1c0bd21f 100644\n--- a/lib/librte_ether/rte_ethdev_driver.h\n+++ b/lib/librte_ether/rte_ethdev_driver.h\n@@ -68,6 +68,69 @@ struct rte_eth_dev *rte_eth_dev_attach_secondary(const char *name);\n */\n int rte_eth_dev_release_port(struct rte_eth_dev *eth_dev);\n \n+/**\n+ * @internal\n+ * Atomically set the link status for the specific device.\n+ * It is for use by DPDK device driver use only.\n+ * User applications should not call it\n+ *\n+ * @param dev\n+ * Pointer to struct rte_eth_dev.\n+ * @param link\n+ * New link status value.\n+ * @return\n+ * Same convention as eth_link_update operation.\n+ * 0 if link up status has changed\n+ * -1 if link up status was unchanged\n+ */\n+static inline int\n+rte_eth_linkstatus_set(struct rte_eth_dev *dev,\n+\t\t const struct rte_eth_link *new_link)\n+{\n+\tvolatile uint64_t *dev_link\n+\t\t = (volatile uint64_t *)&(dev->data->dev_link);\n+\tunion {\n+\t\tuint64_t val64;\n+\t\tstruct rte_eth_link link;\n+\t} orig;\n+\n+\tRTE_BUILD_BUG_ON(sizeof(*new_link) != sizeof(uint64_t));\n+\n+\torig.val64 = rte_atomic64_exchange(dev_link,\n+\t\t\t\t\t *(const uint64_t *)new_link);\n+\n+\treturn (orig.link.link_status == new_link->link_status) ? -1 : 0;\n+}\n+\n+/**\n+ * @internal\n+ * Atomically get the link speed and status.\n+ *\n+ * @param dev\n+ * Pointer to struct rte_eth_dev.\n+ * @param link\n+ * link status value.\n+ */\n+static inline void\n+rte_eth_linkstatus_get(const struct rte_eth_dev *dev,\n+\t\t struct rte_eth_link *link)\n+{\n+\tvolatile uint64_t *src = (uint64_t *)&(dev->data->dev_link);\n+\tuint64_t *dst = (uint64_t *)link;\n+\n+\tRTE_BUILD_BUG_ON(sizeof(*link) != sizeof(uint64_t));\n+\n+#ifdef __LP64__\n+\t/* if cpu arch has 64 bit unsigned lon then implicitly atomic */\n+\t*dst = *src;\n+#else\n+\t/* can't use rte_atomic64_read because it returns signed int */\n+\tdo {\n+\t\t*dst = *src;\n+\t} while (!rte_atomic64_cmpset(src, *dst, *dst));\n+#endif\n+}\n+\n /**\n * @internal\n * Release device queues and clear its configuration to force the user\n", "prefixes": [ "dpdk-dev", "v8", "02/15" ] }