Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/33630/?format=api
{ "id": 33630, "url": "http://patches.dpdk.org/api/patches/33630/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1515693035-35419-2-git-send-email-harry.van.haaren@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1515693035-35419-2-git-send-email-harry.van.haaren@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1515693035-35419-2-git-send-email-harry.van.haaren@intel.com", "date": "2018-01-11T17:50:34", "name": "[dpdk-dev,v2,2/3] test: add skipped return result", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "26c18e08336a78122fc6228b4196ef95f057cfe1", "submitter": { "id": 317, "url": "http://patches.dpdk.org/api/people/317/?format=api", "name": "Van Haaren, Harry", "email": "harry.van.haaren@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1515693035-35419-2-git-send-email-harry.van.haaren@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/33630/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/33630/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0522C1B2D2;\n\tThu, 11 Jan 2018 18:50:57 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id DE11B1B2D2\n\tfor <dev@dpdk.org>; Thu, 11 Jan 2018 18:50:55 +0100 (CET)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t11 Jan 2018 09:50:54 -0800", "from silpixa00398672.ir.intel.com ([10.237.223.128])\n\tby FMSMGA003.fm.intel.com with ESMTP; 11 Jan 2018 09:50:53 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.46,345,1511856000\"; d=\"scan'208\";a=\"18487119\"", "From": "Harry van Haaren <harry.van.haaren@intel.com>", "To": "dev@dpdk.org", "Cc": "pablo.de.lara.guarch@intel.com, bruce.richardson@intel.com,\n\tHarry van Haaren <harry.van.haaren@intel.com>", "Date": "Thu, 11 Jan 2018 17:50:34 +0000", "Message-Id": "<1515693035-35419-2-git-send-email-harry.van.haaren@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1515693035-35419-1-git-send-email-harry.van.haaren@intel.com>", "References": "<1513858050-77961-1-git-send-email-harry.van.haaren@intel.com>\n\t<1515693035-35419-1-git-send-email-harry.van.haaren@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 2/3] test: add skipped return result", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This commit allows a test to return \"skipped\", indicating\nthat it cannot be run. This is useful for PMDs which have\nnot been compiled due to the unavailability of dependencies,\nor their explicit disabling in the build configuration.\n\nThe result printing is updated to correctly indicate if a\ntest has been skipped.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n\n---\n\nv2:\n- Re-split patch into two, rewording titles check-git-log (Pablo)\n- Add check for \"Skipped\" tests to not print \"Failed\" (Pablo)\n---\n test/test/commands.c | 2 ++\n test/test/test.h | 5 +++--\n 2 files changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/test/test/commands.c b/test/test/commands.c\nindex 6649cfc..0473dac 100644\n--- a/test/test/commands.c\n+++ b/test/test/commands.c\n@@ -106,6 +106,8 @@ static void cmd_autotest_parsed(void *parsed_result,\n \tlast_test_result = ret;\n \tif (ret == 0)\n \t\tprintf(\"Test OK\\n\");\n+\telse if (ret == TEST_SKIPPED)\n+\t\tprintf(\"Test Skipped\\n\");\n \telse\n \t\tprintf(\"Test Failed\\n\");\n \tfflush(stdout);\ndiff --git a/test/test/test.h b/test/test/test.h\nindex ae88a70..a8f765a 100644\n--- a/test/test/test.h\n+++ b/test/test/test.h\n@@ -11,8 +11,9 @@\n #include <rte_common.h>\n #include <rte_log.h>\n \n-#define TEST_SUCCESS (0)\n-#define TEST_FAILED (-1)\n+#define TEST_SUCCESS EXIT_SUCCESS\n+#define TEST_FAILED -1\n+#define TEST_SKIPPED 77\n \n /* Before including test.h file you can define\n * TEST_TRACE_FAILURE(_file, _line, _func) macro to better trace/debug test\n", "prefixes": [ "dpdk-dev", "v2", "2/3" ] }