Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/33216/?format=api
{ "id": 33216, "url": "http://patches.dpdk.org/api/patches/33216/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1515505061-12112-1-git-send-email-harry.van.haaren@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1515505061-12112-1-git-send-email-harry.van.haaren@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1515505061-12112-1-git-send-email-harry.van.haaren@intel.com", "date": "2018-01-09T13:37:40", "name": "[dpdk-dev,v4,1/2] service: fix lcore role after delete", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "23967d1373c6099af99b6e4fa636522cb653b257", "submitter": { "id": 317, "url": "http://patches.dpdk.org/api/people/317/?format=api", "name": "Van Haaren, Harry", "email": "harry.van.haaren@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1515505061-12112-1-git-send-email-harry.van.haaren@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/33216/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/33216/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3AFF31B1D6;\n\tTue, 9 Jan 2018 14:37:49 +0100 (CET)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 7C9C71B1D4\n\tfor <dev@dpdk.org>; Tue, 9 Jan 2018 14:37:48 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t09 Jan 2018 05:37:47 -0800", "from silpixa00398672.ir.intel.com ([10.237.223.128])\n\tby fmsmga001.fm.intel.com with ESMTP; 09 Jan 2018 05:37:46 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.46,335,1511856000\"; d=\"scan'208\";a=\"20165237\"", "From": "Harry van Haaren <harry.van.haaren@intel.com>", "To": "dev@dpdk.org", "Cc": "pbhagavatula@caviumnetworks.com, bruce.richardson@intel.com,\n\tHarry van Haaren <harry.van.haaren@intel.com>", "Date": "Tue, 9 Jan 2018 13:37:40 +0000", "Message-Id": "<1515505061-12112-1-git-send-email-harry.van.haaren@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1515497885-191922-1-git-send-email-harry.van.haaren@intel.com>", "References": "<1515497885-191922-1-git-send-email-harry.van.haaren@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 1/2] service: fix lcore role after delete", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch fixes the reset of the service core,\nthat when rte_service_lcore_del() is called, the\nlcore_role is restored to RTE.\n\nThis issue was reported as when running the unit tests, an\nerror was thrown that \"failed to allocate lcore\". Investigating\nrevealed that the state of the service-cores after del() was\nnot allowing a core to be re-used at a later point in time.\n\nFixes: 21698354c832 (\"service: introduce service cores concept\")\n+CC stable@dpdk.org\n\nReported-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n\n---\n\nv4:\n- Improve commit title (Bruce)\n\nv3:\n- Fix whitespace issue introduced in v2 (Doh :)\n\nv2:\n- Only update state on service core ids (Pavan)\n\n@Stable maintainers; this is an EXPERIMENTAL tagged API, so I'm\nnot sure what the expectation is in terms of backporting.\n---\n lib/librte_eal/common/rte_service.c | 36 +++++++++++++++++++-----------------\n 1 file changed, 19 insertions(+), 17 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c\nindex 372d0bb..44a988a 100644\n--- a/lib/librte_eal/common/rte_service.c\n+++ b/lib/librte_eal/common/rte_service.c\n@@ -554,23 +554,6 @@ rte_service_map_lcore_get(uint32_t id, uint32_t lcore)\n \treturn ret;\n }\n \n-int32_t rte_service_lcore_reset_all(void)\n-{\n-\t/* loop over cores, reset all to mask 0 */\n-\tuint32_t i;\n-\tfor (i = 0; i < RTE_MAX_LCORE; i++) {\n-\t\tlcore_states[i].service_mask = 0;\n-\t\tlcore_states[i].is_service_core = 0;\n-\t\tlcore_states[i].runstate = RUNSTATE_STOPPED;\n-\t}\n-\tfor (i = 0; i < RTE_SERVICE_NUM_MAX; i++)\n-\t\trte_atomic32_set(&rte_services[i].num_mapped_cores, 0);\n-\n-\trte_smp_wmb();\n-\n-\treturn 0;\n-}\n-\n static void\n set_lcore_state(uint32_t lcore, int32_t state)\n {\n@@ -585,6 +568,25 @@ set_lcore_state(uint32_t lcore, int32_t state)\n \tlcore_states[lcore].is_service_core = (state == ROLE_SERVICE);\n }\n \n+int32_t rte_service_lcore_reset_all(void)\n+{\n+\t/* loop over cores, reset all to mask 0 */\n+\tuint32_t i;\n+\tfor (i = 0; i < RTE_MAX_LCORE; i++) {\n+\t\tif (lcore_states[i].is_service_core) {\n+\t\t\tlcore_states[i].service_mask = 0;\n+\t\t\tset_lcore_state(i, ROLE_RTE);\n+\t\t\tlcore_states[i].runstate = RUNSTATE_STOPPED;\n+\t\t}\n+\t}\n+\tfor (i = 0; i < RTE_SERVICE_NUM_MAX; i++)\n+\t\trte_atomic32_set(&rte_services[i].num_mapped_cores, 0);\n+\n+\trte_smp_wmb();\n+\n+\treturn 0;\n+}\n+\n int32_t\n rte_service_lcore_add(uint32_t lcore)\n {\n", "prefixes": [ "dpdk-dev", "v4", "1/2" ] }