Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/32806/?format=api
{ "id": 32806, "url": "http://patches.dpdk.org/api/patches/32806/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20171230040209.b73z42ymlh4emjxe@debian-xvivbkq.sh.intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20171230040209.b73z42ymlh4emjxe@debian-xvivbkq.sh.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20171230040209.b73z42ymlh4emjxe@debian-xvivbkq.sh.intel.com", "date": "2017-12-30T04:02:09", "name": "[dpdk-dev] net/virtio: fix vector Rx break caused by rxq flushing", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "3c3e52cdd4105827c78954a43caf65d632275cca", "submitter": { "id": 617, "url": "http://patches.dpdk.org/api/people/617/?format=api", "name": "Tiwei Bie", "email": "tiwei.bie@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20171230040209.b73z42ymlh4emjxe@debian-xvivbkq.sh.intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/32806/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/32806/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8F1DA2BD8;\n\tSat, 30 Dec 2017 05:02:40 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id D6AF3200\n\tfor <dev@dpdk.org>; Sat, 30 Dec 2017 05:02:38 +0100 (CET)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 Dec 2017 20:02:37 -0800", "from debian-xvivbkq.sh.intel.com ([10.67.104.226])\n\tby fmsmga004.fm.intel.com with ESMTP; 29 Dec 2017 20:02:36 -0800" ], "X-Amp-Result": "UNKNOWN", "X-Amp-Original-Verdict": "FILE UNKNOWN", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.45,478,1508828400\"; d=\"scan'208\";a=\"16563435\"", "Date": "Sat, 30 Dec 2017 12:02:09 +0800", "From": "Tiwei Bie <tiwei.bie@intel.com>", "To": "=?utf-8?b?546L5b+X5YWL?= <wangzhike@jd.com>", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>, bluca@debian.org, yliu@fridaylinux.org", "Message-ID": "<20171230040209.b73z42ymlh4emjxe@debian-xvivbkq.sh.intel.com>", "References": "<6DAF063A35010343823807B082E5681F41D839EF@mbx05.360buyAD.local>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Disposition": "inline", "Content-Transfer-Encoding": "8bit", "In-Reply-To": "<6DAF063A35010343823807B082E5681F41D839EF@mbx05.360buyAD.local>", "User-Agent": "NeoMutt/20170609 (1.8.3)", "Subject": "Re: [dpdk-dev] net/virtio: fix vector Rx break caused by rxq\n\tflushing", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Hi Zhike,\n\nOn Fri, Dec 29, 2017 at 01:02:04PM +0000, 王志克 wrote:\n> Hi tiwei,\n> \n> Can you please provide a patch for 16.11.4? Thanks.\n> \n\nNormally, most commits in the stable tree are backported\nfrom the commits in the mainline tree which contains below\nCc line:\n\nCc: stable@dpdk.org\n\nThis patch also contains such line. So after this patch\nis applied to the mainline tree, it will be backported.\n\nIf you need the fix right now, you can download the latest\npatch (which has been applied to dpdk-next-virtio tree)\nfrom here:\n\nhttps://dpdk.org/dev/patchwork/patch/32061/\n\nIt can be applied to DPDK 16.11.4 with the patch command.\nAfter the patching, one small change is needed to get it\nwork:\n\n\nBesides, I'm not sure whether you are aware of this or not.\nBut just FYI, when you want to use the vector Rx of virtio\nPMD, you need to be aware of the fact that the current\nimplementation of vector Rx doesn't really follow the virtio\nspec. You can find more details in below link:\n\nhttp://dpdk.org/ml/archives/dev/2017-December/084101.html\n\nBest regards,\nTiwei Bie", "diff": "diff --git a/drivers/net/virtio/virtqueue.c b/drivers/net/virtio/virtqueue.c\nindex 7fd8604..0e24194 100644\n--- a/drivers/net/virtio/virtqueue.c\n+++ b/drivers/net/virtio/virtqueue.c\n@@ -88,7 +88,7 @@ virtqueue_rxvq_flush(struct virtqueue *vq)\n \tfor (i = 0; i < nb_used; i++) {\n \t\tused_idx = vq->vq_used_cons_idx & (vq->vq_nentries - 1);\n \t\tuep = &vq->vq_ring.used->ring[used_idx];\n-\t\tif (hw->use_simple_rx) {\n+\t\tif (hw->use_simple_rxtx) {\n \t\t\tdesc_idx = used_idx;\n \t\t\trte_pktmbuf_free(vq->sw_ring[desc_idx]);\n \t\t\tvq->vq_free_cnt++;\n@@ -104,7 +104,7 @@ virtqueue_rxvq_flush(struct virtqueue *vq)\n \t\tvq->vq_used_cons_idx++;\n \t}\n \n-\tif (hw->use_simple_rx) {\n+\tif (hw->use_simple_rxtx) {\n \t\twhile (vq->vq_free_cnt >= RTE_VIRTIO_VPMD_RX_REARM_THRESH) {\n \t\t\tvirtio_rxq_rearm_vec(rxq);\n \t\t\tif (virtqueue_kick_prepare(vq))\n", "prefixes": [ "dpdk-dev" ] }