Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 31401,
    "url": "http://patches.dpdk.org/api/patches/31401/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1510819481-6809-7-git-send-email-arybchenko@solarflare.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1510819481-6809-7-git-send-email-arybchenko@solarflare.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1510819481-6809-7-git-send-email-arybchenko@solarflare.com",
    "date": "2017-11-16T08:03:54",
    "name": "[dpdk-dev,06/53] net/sfc/base: extend NVRAM RW finish to return verify result",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "8d381c3dc75ab5225746e9920d29abe4dd986189",
    "submitter": {
        "id": 607,
        "url": "http://patches.dpdk.org/api/people/607/?format=api",
        "name": "Andrew Rybchenko",
        "email": "arybchenko@solarflare.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1510819481-6809-7-git-send-email-arybchenko@solarflare.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/31401/comments/",
    "check": "warning",
    "checks": "http://patches.dpdk.org/api/patches/31401/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1FACD1B2CA;\n\tThu, 16 Nov 2017 09:05:20 +0100 (CET)",
            "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id B63571B277\n\tfor <dev@dpdk.org>; Thu, 16 Nov 2017 09:04:59 +0100 (CET)",
            "from pure.maildistiller.com (unknown [10.110.50.29])\n\tby dispatch1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server)\n\twith ESMTP id 0EA982005F\n\tfor <dev@dpdk.org>; Thu, 16 Nov 2017 08:04:59 +0000 (UTC)",
            "from mx1-us4.ppe-hosted.com (unknown [10.110.49.251])\n\tby pure.maildistiller.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id\n\t72BB010004F for <dev@dpdk.org>; Thu, 16 Nov 2017 08:04:57 +0000 (UTC)",
            "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id\n\t769F9140059 for <dev@dpdk.org>; Thu, 16 Nov 2017 08:04:57 +0000 (UTC)",
            "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1044.25; Thu, 16 Nov 2017 00:04:54 -0800",
            "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1044.25 via Frontend Transport; Thu, 16 Nov 2017 00:04:54 -0800",
            "from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com\n\t[10.17.10.10])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tvAG84qv6016623; Thu, 16 Nov 2017 08:04:52 GMT",
            "from uklogin.uk.solarflarecom.com (localhost.localdomain\n\t[127.0.0.1])\n\tby uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tvAG84qtd006905; Thu, 16 Nov 2017 08:04:52 GMT"
        ],
        "X-Virus-Scanned": "Proofpoint Essentials engine",
        "From": "Andrew Rybchenko <arybchenko@solarflare.com>",
        "To": "<dev@dpdk.org>",
        "CC": "Andy Moreton <amoreton@solarflare.com>",
        "Date": "Thu, 16 Nov 2017 08:03:54 +0000",
        "Message-ID": "<1510819481-6809-7-git-send-email-arybchenko@solarflare.com>",
        "X-Mailer": "git-send-email 1.8.2.3",
        "In-Reply-To": "<1510819481-6809-1-git-send-email-arybchenko@solarflare.com>",
        "References": "<1510819481-6809-1-git-send-email-arybchenko@solarflare.com>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain",
        "X-MDID": "1510819497-SVbMMzW1O1LJ",
        "Subject": "[dpdk-dev] [PATCH 06/53] net/sfc/base: extend NVRAM RW finish to\n\treturn verify result",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Andy Moreton <amoreton@solarflare.com>\n\nExtend efx_nvram_rw_finish() to return firmware verify result code.\n\nSigned-off-by: Andy Moreton <amoreton@solarflare.com>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/base/efx.h         |  3 ++-\n drivers/net/sfc/base/efx_bootcfg.c |  8 ++++----\n drivers/net/sfc/base/efx_nvram.c   | 12 ++++++++++--\n 3 files changed, 16 insertions(+), 7 deletions(-)",
    "diff": "diff --git a/drivers/net/sfc/base/efx.h b/drivers/net/sfc/base/efx.h\nindex 57fba05..3bde46f 100644\n--- a/drivers/net/sfc/base/efx.h\n+++ b/drivers/net/sfc/base/efx.h\n@@ -1411,7 +1411,8 @@ efx_nvram_rw_start(\n extern\t__checkReturn\t\tefx_rc_t\n efx_nvram_rw_finish(\n \t__in\t\t\tefx_nic_t *enp,\n-\t__in\t\t\tefx_nvram_type_t type);\n+\t__in\t\t\tefx_nvram_type_t type,\n+\t__out_opt\t\tuint32_t *verify_resultp);\n \n extern\t__checkReturn\t\tefx_rc_t\n efx_nvram_get_version(\ndiff --git a/drivers/net/sfc/base/efx_bootcfg.c b/drivers/net/sfc/base/efx_bootcfg.c\nindex d589c86..c47d16b 100644\n--- a/drivers/net/sfc/base/efx_bootcfg.c\n+++ b/drivers/net/sfc/base/efx_bootcfg.c\n@@ -345,11 +345,11 @@ efx_bootcfg_read(\n \n \tif ((rc = efx_nvram_read_chunk(enp, EFX_NVRAM_BOOTROM_CFG,\n \t    sector_offset, (caddr_t)payload, sector_length)) != 0) {\n-\t\t(void) efx_nvram_rw_finish(enp, EFX_NVRAM_BOOTROM_CFG);\n+\t\t(void) efx_nvram_rw_finish(enp, EFX_NVRAM_BOOTROM_CFG, NULL);\n \t\tgoto fail6;\n \t}\n \n-\tif ((rc = efx_nvram_rw_finish(enp, EFX_NVRAM_BOOTROM_CFG)) != 0)\n+\tif ((rc = efx_nvram_rw_finish(enp, EFX_NVRAM_BOOTROM_CFG, NULL)) != 0)\n \t\tgoto fail7;\n \n \t/* Verify that the area is correctly formatted and checksummed */\n@@ -521,7 +521,7 @@ efx_bootcfg_write(\n \t\t    0, (caddr_t)partn_data, partn_length)) != 0)\n \t\tgoto fail11;\n \n-\tif ((rc = efx_nvram_rw_finish(enp, EFX_NVRAM_BOOTROM_CFG)) != 0)\n+\tif ((rc = efx_nvram_rw_finish(enp, EFX_NVRAM_BOOTROM_CFG, NULL)) != 0)\n \t\tgoto fail12;\n \n \tEFSYS_KMEM_FREE(enp->en_esip, partn_length, partn_data);\n@@ -537,7 +537,7 @@ efx_bootcfg_write(\n fail9:\n \tEFSYS_PROBE(fail9);\n \n-\t(void) efx_nvram_rw_finish(enp, EFX_NVRAM_BOOTROM_CFG);\n+\t(void) efx_nvram_rw_finish(enp, EFX_NVRAM_BOOTROM_CFG, NULL);\n fail8:\n \tEFSYS_PROBE(fail8);\n \ndiff --git a/drivers/net/sfc/base/efx_nvram.c b/drivers/net/sfc/base/efx_nvram.c\nindex 773bc10..6e18e44 100644\n--- a/drivers/net/sfc/base/efx_nvram.c\n+++ b/drivers/net/sfc/base/efx_nvram.c\n@@ -362,11 +362,12 @@ efx_nvram_write_chunk(\n \t__checkReturn\t\tefx_rc_t\n efx_nvram_rw_finish(\n \t__in\t\t\tefx_nic_t *enp,\n-\t__in\t\t\tefx_nvram_type_t type)\n+\t__in\t\t\tefx_nvram_type_t type,\n+\t__out_opt\t\tuint32_t *verify_resultp)\n {\n \tconst efx_nvram_ops_t *envop = enp->en_envop;\n \tuint32_t partn;\n-\tuint32_t verify_result;\n+\tuint32_t verify_result = 0;\n \tefx_rc_t rc;\n \n \tEFSYS_ASSERT3U(enp->en_magic, ==, EFX_NIC_MAGIC);\n@@ -385,6 +386,9 @@ efx_nvram_rw_finish(\n \n \tenp->en_nvram_locked = EFX_NVRAM_INVALID;\n \n+\tif (verify_resultp != NULL)\n+\t\t*verify_resultp = verify_result;\n+\n \treturn (0);\n \n fail2:\n@@ -394,6 +398,10 @@ efx_nvram_rw_finish(\n fail1:\n \tEFSYS_PROBE1(fail1, efx_rc_t, rc);\n \n+\t/* Always report verification result */\n+\tif (verify_resultp != NULL)\n+\t\t*verify_resultp = verify_result;\n+\n \treturn (rc);\n }\n \n",
    "prefixes": [
        "dpdk-dev",
        "06/53"
    ]
}