Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/30796/?format=api
{ "id": 30796, "url": "http://patches.dpdk.org/api/patches/30796/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20171024131630.16595-4-luca.boccassi@gmail.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20171024131630.16595-4-luca.boccassi@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20171024131630.16595-4-luca.boccassi@gmail.com", "date": "2017-10-24T13:16:30", "name": "[dpdk-dev,3/3] net/ixgbe: implement VF reset", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": true, "hash": "f36e3f7d19bee19af2aa9a0a098d0c61bad52d23", "submitter": { "id": 566, "url": "http://patches.dpdk.org/api/people/566/?format=api", "name": "Luca Boccassi", "email": "luca.boccassi@gmail.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20171024131630.16595-4-luca.boccassi@gmail.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/30796/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/30796/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A15401B808;\n\tTue, 24 Oct 2017 15:16:52 +0200 (CEST)", "from mail-wm0-f65.google.com (mail-wm0-f65.google.com\n\t[74.125.82.65]) by dpdk.org (Postfix) with ESMTP id E4B691B7EB\n\tfor <dev@dpdk.org>; Tue, 24 Oct 2017 15:16:49 +0200 (CEST)", "by mail-wm0-f65.google.com with SMTP id m72so12261597wmc.0\n\tfor <dev@dpdk.org>; Tue, 24 Oct 2017 06:16:49 -0700 (PDT)", "from localhost ([213.251.34.151]) by smtp.gmail.com with ESMTPSA id\n\tq6sm172372edk.55.2017.10.24.06.16.48\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 24 Oct 2017 06:16:48 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=xWPIQDdogdkOB2KKAOKAzoZqR2U620m/JlhkDB1tJHs=;\n\tb=PuI7kDyeU3Oa80TW9DlMZKAeKNG+iAHu7jrXmIOiLH/ObtpLAyFD7hMhUU61qtY5My\n\trKWkR+SR2rh+QQAxbs8ihDiTwHeivJKCVJNa5BD/27Sl4qCEECpQwVlLn0CO9+X2cJig\n\tt5/2/8tI4Ohscd9ee1vN5cZyreQ/MwoGggrd1L/lrFTRxQYqC243zyMeSws1vuD1rlZ0\n\t7EvLiUTBLcJIz2lUrxbOkLgmgP4OdA/kB+g1YLFxJaHkxAblcpJUM0yiDTOFrdwsMUt6\n\tRHIS4MtHoWURwpiLTkh+mTJaR0OCo+znQd8TEbKp/MYbB7ACZfSpH7zlnPJUt9r+qVi5\n\t+cNA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=xWPIQDdogdkOB2KKAOKAzoZqR2U620m/JlhkDB1tJHs=;\n\tb=jm4ERL8Ge1VzERGG+yj+DpGMxOse5paFF4WWbFUmG5URlwUeWP7PmmrDKvHR8857wt\n\tCbQO2HXTA5uMSnqHxyVClkypPsuIWyB19x01RimayP5fDxt5Ae+cagS8zlVfgHp0bs9V\n\tw1wETSfheMGZ2ca8Med1QYh10OJWNpFXEvnQrKNTBo0H5tG65QOj7IIs1HgRcJFsbi+0\n\t+v1k3Cmtrn08svIxki1NZyKE3u3RXK/3DGDwJakDoiLa7zxP6L4uXhDBQsbTTfa/OMrH\n\tK1WYCN5IA9qI5IVon5IXmj0S3Y2ODMiI6Vb/B7SNTsX8VQMNKZP6528u7X4COI9Pk32J\n\tIhMA==", "X-Gm-Message-State": "AMCzsaWcBJu+c+zLlZGAmpRfC3Mbm+ILNYQEur6RyBVl2zHRPOK3b/Rj\n\tLmEMfwAFjSg/eejCOPQEZvMWc5c+", "X-Google-Smtp-Source": "ABhQp+ScqZKHj7hwxUbYG3w25tjufHh8MydzVpvpaZ6VuGyxkJMfAwoVGQYaJGYp4ys/DEmIt0iNNg==", "X-Received": "by 10.80.194.65 with SMTP id t1mr20213310edf.304.1508851009029; \n\tTue, 24 Oct 2017 06:16:49 -0700 (PDT)", "From": "luca.boccassi@gmail.com", "To": "dev@dpdk.org", "Cc": "wenzhuo.lu@intel.com, wei.dai@intel.com, remy.horton@intel.com,\n\tLuca Boccassi <bluca@debian.org>", "Date": "Tue, 24 Oct 2017 14:16:30 +0100", "Message-Id": "<20171024131630.16595-4-luca.boccassi@gmail.com>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20171024131630.16595-1-luca.boccassi@gmail.com>", "References": "<20171024131630.16595-1-luca.boccassi@gmail.com>", "Subject": "[dpdk-dev] [PATCH 3/3] net/ixgbe: implement VF reset", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Luca Boccassi <bluca@debian.org>\n\nThis reset function will stop and restart the device, and then reset\nthe stats and check that the registers have been updated.\n\nSigned-off-by: Luca Boccassi <bluca@debian.org>\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 60 +++++++++++++++++++++++++++++++++++-----\n drivers/net/ixgbe/ixgbe_ethdev.h | 2 +-\n drivers/net/ixgbe/ixgbe_rxtx.c | 12 ++++++--\n 3 files changed, 63 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 14b9c5303..13307466b 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -5026,7 +5026,9 @@ ixgbevf_dev_start(struct rte_eth_dev *dev)\n \t\tETH_VLAN_EXTEND_MASK;\n \tixgbevf_vlan_offload_set(dev, mask);\n \n-\tixgbevf_dev_rxtx_start(dev);\n+\terr = ixgbevf_dev_rxtx_start(dev);\n+\tif (err)\n+\t\treturn err;\n \n \t/* check and configure queue intr-vector mapping */\n \tif (dev->data->dev_conf.intr_conf.rxq != 0) {\n@@ -5127,15 +5129,59 @@ ixgbevf_dev_close(struct rte_eth_dev *dev)\n static int\n ixgbevf_dev_reset(struct rte_eth_dev *dev)\n {\n-\tint ret;\n+\tstruct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n+\tint diag = 0;\n+\tuint32_t vteiam;\n \n-\tret = eth_ixgbevf_dev_uninit(dev);\n-\tif (ret)\n-\t\treturn ret;\n+\t/* Nothing needs to be done if the device is not started. */\n+\tif (!dev->data->dev_started)\n+\t\treturn -EAGAIN;\n \n-\tret = eth_ixgbevf_dev_init(dev);\n+\tPMD_DRV_LOG(DEBUG, \"Link up/down event detected.\");\n \n-\treturn ret;\n+\t/* Performance VF reset. */\n+\tdo {\n+\t\tdev->data->dev_started = 0;\n+\t\tixgbevf_dev_stop(dev);\n+\t\tif (dev->data->dev_conf.intr_conf.lsc == 0)\n+\t\t\tdiag = ixgbe_dev_link_update(dev, 0);\n+\t\tif (diag) {\n+\t\t\tPMD_INIT_LOG(INFO, \"Ixgbe VF reset: \"\n+\t\t\t\t\t\"Failed to update link.\");\n+\t\t}\n+\t\trte_delay_ms(1000);\n+\n+\t\tdiag = ixgbevf_dev_start(dev);\n+\t\t/* If fail to start the device, need to stop/start it again. */\n+\t\tif (diag) {\n+\t\t\tPMD_INIT_LOG(ERR, \"Ixgbe VF reset: \"\n+\t\t\t\t\t\"Failed to start device.\");\n+\t\t\tdev->data->dev_started = 1;\n+\t\t\treturn -EAGAIN;\n+\t\t}\n+\t\tdev->data->dev_started = 1;\n+\t\tixgbevf_dev_stats_reset(dev);\n+\t\tif (dev->data->dev_conf.intr_conf.lsc == 0)\n+\t\t\tdiag = ixgbe_dev_link_update(dev, 0);\n+\t\tif (diag) {\n+\t\t\tPMD_INIT_LOG(INFO, \"Ixgbe VF reset: \"\n+\t\t\t\t\t\"Failed to update link.\");\n+\t\t\tdiag = 0;\n+\t\t}\n+\n+\t\t/**\n+\t\t * When the PF link is down, there is a chance\n+\t\t * that the VF cannot operate its registers.\n+\t\t * Check if the registers are written\n+\t\t * successfully. If not, repeat stop/start until\n+\t\t * the PF link is up, or in other words, until the\n+\t\t * registers can be written.\n+\t\t */\n+\t\tvteiam = IXGBE_READ_REG(hw, IXGBE_VTEIAM);\n+\t/* Reference ixgbevf_intr_enable when checking */\n+\t} while (diag || vteiam != IXGBE_VF_IRQ_ENABLE_MASK);\n+\n+\treturn 0;\n }\n \n static void ixgbevf_set_vfta_all(struct rte_eth_dev *dev, bool on)\ndiff --git a/drivers/net/ixgbe/ixgbe_ethdev.h b/drivers/net/ixgbe/ixgbe_ethdev.h\nindex e28c8567e..87b929518 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.h\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.h\n@@ -595,7 +595,7 @@ int ixgbevf_dev_rx_init(struct rte_eth_dev *dev);\n \n void ixgbevf_dev_tx_init(struct rte_eth_dev *dev);\n \n-void ixgbevf_dev_rxtx_start(struct rte_eth_dev *dev);\n+int ixgbevf_dev_rxtx_start(struct rte_eth_dev *dev);\n \n uint16_t ixgbe_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\tuint16_t nb_pkts);\ndiff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c\nindex 0038dfbb4..5a0be2cfe 100644\n--- a/drivers/net/ixgbe/ixgbe_rxtx.c\n+++ b/drivers/net/ixgbe/ixgbe_rxtx.c\n@@ -5419,7 +5419,7 @@ ixgbevf_dev_tx_init(struct rte_eth_dev *dev)\n /*\n * [VF] Start Transmit and Receive Units.\n */\n-void __attribute__((cold))\n+int __attribute__((cold))\n ixgbevf_dev_rxtx_start(struct rte_eth_dev *dev)\n {\n \tstruct ixgbe_hw *hw;\n@@ -5455,8 +5455,10 @@ ixgbevf_dev_rxtx_start(struct rte_eth_dev *dev)\n \t\t\trte_delay_ms(1);\n \t\t\ttxdctl = IXGBE_READ_REG(hw, IXGBE_VFTXDCTL(i));\n \t\t} while (--poll_ms && !(txdctl & IXGBE_TXDCTL_ENABLE));\n-\t\tif (!poll_ms)\n+\t\tif (!poll_ms) {\n \t\t\tPMD_INIT_LOG(ERR, \"Could not enable Tx Queue %d\", i);\n+\t\t\treturn -1;\n+\t\t}\n \t}\n \tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n \n@@ -5472,12 +5474,16 @@ ixgbevf_dev_rxtx_start(struct rte_eth_dev *dev)\n \t\t\trte_delay_ms(1);\n \t\t\trxdctl = IXGBE_READ_REG(hw, IXGBE_VFRXDCTL(i));\n \t\t} while (--poll_ms && !(rxdctl & IXGBE_RXDCTL_ENABLE));\n-\t\tif (!poll_ms)\n+\t\tif (!poll_ms) {\n \t\t\tPMD_INIT_LOG(ERR, \"Could not enable Rx Queue %d\", i);\n+\t\t\treturn -1;\n+\t\t}\n \t\trte_wmb();\n \t\tIXGBE_WRITE_REG(hw, IXGBE_VFRDT(i), rxq->nb_rx_desc - 1);\n \n \t}\n+\n+\treturn 0;\n }\n \n /* Stubs needed for linkage when CONFIG_RTE_IXGBE_INC_VECTOR is set to 'n' */\n", "prefixes": [ "dpdk-dev", "3/3" ] }