Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/30795/?format=api
{ "id": 30795, "url": "http://patches.dpdk.org/api/patches/30795/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20171024131630.16595-3-luca.boccassi@gmail.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20171024131630.16595-3-luca.boccassi@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20171024131630.16595-3-luca.boccassi@gmail.com", "date": "2017-10-24T13:16:29", "name": "[dpdk-dev,2/3] net/e1000: implement VF reset", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": true, "hash": "a136bbcc07d162767a9557b38d77897a7c6df17d", "submitter": { "id": 566, "url": "http://patches.dpdk.org/api/people/566/?format=api", "name": "Luca Boccassi", "email": "luca.boccassi@gmail.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20171024131630.16595-3-luca.boccassi@gmail.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/30795/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/30795/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2EB8F1B801;\n\tTue, 24 Oct 2017 15:16:51 +0200 (CEST)", "from mail-wm0-f68.google.com (mail-wm0-f68.google.com\n\t[74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 852681B801\n\tfor <dev@dpdk.org>; Tue, 24 Oct 2017 15:16:46 +0200 (CEST)", "by mail-wm0-f68.google.com with SMTP id r196so3325857wmf.2\n\tfor <dev@dpdk.org>; Tue, 24 Oct 2017 06:16:46 -0700 (PDT)", "from localhost ([213.251.34.151]) by smtp.gmail.com with ESMTPSA id\n\th16sm179232edj.33.2017.10.24.06.16.45\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 24 Oct 2017 06:16:45 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=IykcmzxOMOBHOnefxyb4yQfoOfHzOmu60cn87IgriRc=;\n\tb=NshKj/xzu7Cg3b2oM4H9r4o0mAFzGQKSXOGiPl6DL82CJQrhW+8yTgyXr1pB/ruKgS\n\tEx1pWfeXfDdhHDpX3FZyO7wOVYngZ/FGSW052P79DO9IjNaC4/d1qxQAB24d/JLBCfMu\n\tKTxbYJ319qh8vUW5J8H7KBPq3qbKRAAZg+UrUBMEHB5fjQ6dIEna0neS5hHc7DQ3Ev8Y\n\t+8Qg7aSmLVoQTgBY9DII/05CzQt3ikxyJI1/nmIL7Lao4HYqONJTeVMV7fdZtfAcG5VY\n\t4tQTQZuPSNXWwz5gYq0GbxBpQKBELDJ5K+/SdZaX8MEKOgo3M8Zi8u2SsYF0M89R3GJ+\n\tq1iw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=IykcmzxOMOBHOnefxyb4yQfoOfHzOmu60cn87IgriRc=;\n\tb=AzHJ/Yh42zZXlSZERLfsI71qbZ6B09qtnhMqIdPad6O1xGGqa9kgtkAQjV+LOykB3K\n\t/qV8K3fTS1JDoGvnnZjo/LPkuiQ86mJEFZf0f7BT/CNYJIR+fVsH/iM3HEvHMjYMyImN\n\t/+Sl9k0eFquNzO5UbW1gDPWrB1pS1Q3AAYAFVr6JpPWhmDDBRlJYnKvadtFyQBkYFX+a\n\tn3X0xeqIMVsR3cwBFMm4l6eDpAlarJy1dV7ZfQk+VJN95Ue7E1XTYPx3kK7gPf91sHZ/\n\tnNzwrxJl0NJzo5lgF7v03Y3lsEOtmtzyVbHtfhxn7XlEhOCfwWvR518/5vOW+FVDZo+7\n\t7tQg==", "X-Gm-Message-State": "AMCzsaUdZkz99N5zNllrezAiuTsjZ6iGkz68flvYhHpbl5YVOX3HF2rk\n\tZTcLsB426nk6ZuakCjA0Prm5kK9D", "X-Google-Smtp-Source": "ABhQp+RK8RhE1GSW7UCxlw2xijtosrrpg+tdUrwH2hZk+Enw/ktQensdxAVNgP4Dof/8Yu7CUg51FA==", "X-Received": "by 10.80.173.227 with SMTP id b32mr21286336edd.65.1508851005997; \n\tTue, 24 Oct 2017 06:16:45 -0700 (PDT)", "From": "luca.boccassi@gmail.com", "To": "dev@dpdk.org", "Cc": "wenzhuo.lu@intel.com, wei.dai@intel.com, remy.horton@intel.com,\n\tLuca Boccassi <bluca@debian.org>", "Date": "Tue, 24 Oct 2017 14:16:29 +0100", "Message-Id": "<20171024131630.16595-3-luca.boccassi@gmail.com>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20171024131630.16595-1-luca.boccassi@gmail.com>", "References": "<20171024131630.16595-1-luca.boccassi@gmail.com>", "Subject": "[dpdk-dev] [PATCH 2/3] net/e1000: implement VF reset", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Luca Boccassi <bluca@debian.org>\n\nThis reset function will stop and restart the device, and then reset\nthe stats and check that the registers have been updated.\n\nSigned-off-by: Luca Boccassi <bluca@debian.org>\n---\n drivers/net/e1000/igb_ethdev.c | 59 ++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 59 insertions(+)", "diff": "diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c\nindex 003bdf0f6..1211d5371 100644\n--- a/drivers/net/e1000/igb_ethdev.c\n+++ b/drivers/net/e1000/igb_ethdev.c\n@@ -280,6 +280,7 @@ static void eth_igb_configure_msix_intr(struct rte_eth_dev *dev);\n static void eth_igbvf_interrupt_handler(void *param);\n static void igbvf_mbx_process(struct rte_eth_dev *dev);\n static int igb_filter_restore(struct rte_eth_dev *dev);\n+static int igbvf_dev_reset(struct rte_eth_dev *dev);\n \n /*\n * Define VF Stats MACRO for Non \"cleared on read\" register\n@@ -468,6 +469,7 @@ static const struct eth_dev_ops igbvf_eth_dev_ops = {\n \t.txq_info_get = igb_txq_info_get,\n \t.mac_addr_set = igbvf_default_mac_addr_set,\n \t.get_reg = igbvf_get_regs,\n+\t.dev_reset = igbvf_dev_reset,\n };\n \n /* store statistics names and its offset in stats structure */\n@@ -2975,6 +2977,63 @@ void igbvf_mbx_process(struct rte_eth_dev *dev)\n }\n \n static int\n+igbvf_dev_reset(struct rte_eth_dev *dev)\n+{\n+\tstruct e1000_hw *hw =\n+\t\t E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n+\tint diag = 0;\n+\tuint32_t eiam;\n+\t/* Reference igbvf_intr_enable */\n+\tuint32_t eiam_mbx = 1 << E1000_VTIVAR_MISC_MAILBOX;\n+\n+\t/* Nothing needs to be done if the device is not started. */\n+\tif (!dev->data->dev_started)\n+\t\t return -EAGAIN;\n+\n+\tPMD_DRV_LOG(DEBUG, \"Link up/down event detected.\");\n+\n+\t/* Performance VF reset. */\n+\tdo {\n+\t\t dev->data->dev_started = 0;\n+\t\t igbvf_dev_stop(dev);\n+\t\t if (dev->data->dev_conf.intr_conf.lsc == 0)\n+\t\t\t diag = eth_igb_link_update(dev, 0);\n+\t\t if (diag) {\n+\t\t\t PMD_INIT_LOG(INFO, \"Igb VF reset: \"\n+\t\t\t\t\t \"Failed to update link.\");\n+\t\t }\n+\t\t rte_delay_ms(1000);\n+\n+\t\t diag = igbvf_dev_start(dev);\n+\t\t dev->data->dev_started = 1;\n+\t\t if (diag) {\n+\t\t\t PMD_INIT_LOG(ERR, \"Igb VF reset: \"\n+\t\t\t\t\t \"Failed to start device.\");\n+\t\t\t return -EAGAIN;\n+\t\t }\n+\t\t eth_igbvf_stats_reset(dev);\n+\t\t if (dev->data->dev_conf.intr_conf.lsc == 0)\n+\t\t\t diag = eth_igb_link_update(dev, 0);\n+\t\t if (diag) {\n+\t\t\t PMD_INIT_LOG(INFO, \"Igb VF reset: \"\n+\t\t\t\t\t \"Failed to update link.\");\n+\t\t }\n+\n+\t\t /**\n+\t\t * When the PF link is down, there is a chance\n+\t\t * that the VF cannot operate its registers.\n+\t\t * Check if the registers are written\n+\t\t * successfully. If not, repeat stop/start until\n+\t\t * the PF link is up, in other words, until the\n+\t\t * registers can be written.\n+\t\t */\n+\t\t eiam = E1000_READ_REG(hw, E1000_EIAM);\n+\t} while (!(eiam & eiam_mbx));\n+\n+\treturn 0;\n+}\n+\n+static int\n eth_igbvf_interrupt_action(struct rte_eth_dev *dev, struct rte_intr_handle *intr_handle)\n {\n \tstruct e1000_interrupt *intr =\n", "prefixes": [ "dpdk-dev", "2/3" ] }