Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/29107/?format=api
{ "id": 29107, "url": "http://patches.dpdk.org/api/patches/29107/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20170922123906.13308-1-michalx.k.jastrzebski@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20170922123906.13308-1-michalx.k.jastrzebski@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20170922123906.13308-1-michalx.k.jastrzebski@intel.com", "date": "2017-09-22T12:39:06", "name": "[dpdk-dev] net/vmxnet3: fix dereference before null check", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8650d0fdb744d2c64fb2d91731a507d260e4aae5", "submitter": { "id": 74, "url": "http://patches.dpdk.org/api/people/74/?format=api", "name": "Michal Jastrzebski", "email": "michalx.k.jastrzebski@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20170922123906.13308-1-michalx.k.jastrzebski@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/29107/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/29107/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 42385199AF;\n\tFri, 22 Sep 2017 14:39:15 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 944097CDE;\n\tFri, 22 Sep 2017 14:39:13 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga105.fm.intel.com with ESMTP; 22 Sep 2017 05:39:12 -0700", "from unknown ([10.103.102.61])\n\tby fmsmga001.fm.intel.com with SMTP; 22 Sep 2017 05:39:09 -0700", "by (sSMTP sendmail emulation); Fri, 22 Sep 2017 14:39:09 +0200" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.42,427,1500966000\"; d=\"scan'208\";\n\ta=\"1197955663\"", "From": "Michal Jastrzebski <michalx.k.jastrzebski@intel.com>", "To": "skhare@vmware.com", "Cc": "dev@dpdk.org, deepak.k.jain@intel.com,\n\tTomasz Kulasek <tomaszx.kulasek@intel.com>, yongwang@vmware.com,\n\tstable@dpdk.org", "Date": "Fri, 22 Sep 2017 14:39:06 +0200", "Message-Id": "<20170922123906.13308-1-michalx.k.jastrzebski@intel.com>", "X-Mailer": "git-send-email 2.12.2", "Subject": "[dpdk-dev] [PATCH] net/vmxnet3: fix dereference before null check", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Tomasz Kulasek <tomaszx.kulasek@intel.com>\n\nCoverity error:\n\ncheck_after_deref: Null-checking rq suggests that it may be null, but it\n has already been dereferenced on all paths leading to\n the check.\n\nThis patch moves NULL checking of \"rq\" at the very beginning of the path\nbefore any dereference.\n\nCoverity issue: 143468\nFixes: 5aecdc17a97d (\"vmxnet3: fix stop/restart\")\nCc: yongwang@vmware.com\nCc: stable@dpdk.org\n\nSigned-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>\n---\n drivers/net/vmxnet3/vmxnet3_rxtx.c | 17 ++++++++---------\n 1 file changed, 8 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c\nindex d9cf437..4fcceb4 100644\n--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c\n+++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c\n@@ -259,17 +259,16 @@\n {\n \tint i;\n \tvmxnet3_rx_queue_t *rq = rxq;\n-\tstruct vmxnet3_hw *hw = rq->hw;\n \tstruct vmxnet3_cmd_ring *ring0, *ring1;\n \tstruct vmxnet3_comp_ring *comp_ring;\n-\tstruct vmxnet3_rx_data_ring *data_ring = &rq->data_ring;\n \tint size;\n \n-\tif (rq != NULL) {\n-\t\t/* Release both the cmd_rings mbufs */\n-\t\tfor (i = 0; i < VMXNET3_RX_CMDRING_SIZE; i++)\n-\t\t\tvmxnet3_rx_cmd_ring_release_mbufs(&rq->cmd_ring[i]);\n-\t}\n+\tif (rq == NULL)\n+\t\treturn;\n+\n+\t/* Release both the cmd_rings mbufs */\n+\tfor (i = 0; i < VMXNET3_RX_CMDRING_SIZE; i++)\n+\t\tvmxnet3_rx_cmd_ring_release_mbufs(&rq->cmd_ring[i]);\n \n \tring0 = &rq->cmd_ring[0];\n \tring1 = &rq->cmd_ring[1];\n@@ -287,8 +286,8 @@\n \n \tsize = sizeof(struct Vmxnet3_RxDesc) * (ring0->size + ring1->size);\n \tsize += sizeof(struct Vmxnet3_RxCompDesc) * comp_ring->size;\n-\tif (VMXNET3_VERSION_GE_3(hw) && rq->data_desc_size)\n-\t\tsize += rq->data_desc_size * data_ring->size;\n+\tif (VMXNET3_VERSION_GE_3(rq->hw) && rq->data_desc_size)\n+\t\tsize += rq->data_desc_size * rq->data_ring.size;\n \n \tmemset(ring0->base, 0, size);\n }\n", "prefixes": [ "dpdk-dev" ] }