Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/28367/?format=api
{ "id": 28367, "url": "http://patches.dpdk.org/api/patches/28367/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1504611516-27404-2-git-send-email-pbhagavatula@caviumnetworks.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1504611516-27404-2-git-send-email-pbhagavatula@caviumnetworks.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1504611516-27404-2-git-send-email-pbhagavatula@caviumnetworks.com", "date": "2017-09-05T11:38:35", "name": "[dpdk-dev,v5,2/3] eal: add u64 bit variant for reciprocal", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6b64917d30d863f54f22eec529ef554c8ccd1c73", "submitter": { "id": 768, "url": "http://patches.dpdk.org/api/people/768/?format=api", "name": "Pavan Nikhilesh", "email": "pbhagavatula@caviumnetworks.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1504611516-27404-2-git-send-email-pbhagavatula@caviumnetworks.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/28367/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/28367/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 8BC1D5323;\n\tTue, 5 Sep 2017 13:39:11 +0200 (CEST)", "from NAM02-SN1-obe.outbound.protection.outlook.com\n\t(mail-sn1nam02on0040.outbound.protection.outlook.com [104.47.36.40])\n\tby dpdk.org (Postfix) with ESMTP id 9B5D53989\n\tfor <dev@dpdk.org>; Tue, 5 Sep 2017 13:39:09 +0200 (CEST)", "from PBHAGAVATULA-LT.caveonetworks.com (111.93.218.67) by\n\tCY4PR07MB3464.namprd07.prod.outlook.com (10.171.252.145) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n\t15.20.13.10; Tue, 5 Sep 2017 11:39:05 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=imILeUbgOSu2/RVqMqLpZP/pstpxlVWQ+4RIQtkpIfs=;\n\tb=VwJ6nN04zg0Knvz1OQ/gwQZ0+fvxTDziAjLToIGTNmtXhJMD2lMfZ5tSZxIpAToZJ405tJv5EQOlhRivYw2x4yhPxVY+Z6eMIy3/TY1IGgh6jxhXjrpm3lmM3cNrNwI0UA7VZm0w/Ixd0J5g/tFu6ioFphu4K28DjBntNllPBuc=", "Authentication-Results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Pavan.Bhagavatula@cavium.com; ", "From": "Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>", "To": "cristian.dumitrescu@intel.com,\n\tstephen@networkplumber.org", "Cc": "dev@dpdk.org,\n\tPavan Bhagavatula <pbhagavatula@caviumnetworks.com>", "Date": "Tue, 5 Sep 2017 17:08:35 +0530", "Message-Id": "<1504611516-27404-2-git-send-email-pbhagavatula@caviumnetworks.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1504611516-27404-1-git-send-email-pbhagavatula@caviumnetworks.com>", "References": "<1504611516-27404-1-git-send-email-pbhagavatula@caviumnetworks.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[111.93.218.67]", "X-ClientProxiedBy": "BM1PR01CA0090.INDPRD01.PROD.OUTLOOK.COM (10.174.208.158)\n\tTo\n\tCY4PR07MB3464.namprd07.prod.outlook.com (10.171.252.145)", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "20df616f-e65b-4a6c-c0d1-08d4f452b791", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:CY4PR07MB3464; ", "X-Microsoft-Exchange-Diagnostics": [ "1; CY4PR07MB3464;\n\t3:hg8fnAQEWsZSm0nbagfe4LtCWl3lH6sSmSQslI3Zviiajrw7BV4+fTo4fWVnWcMoDy3qMY9inanZhfhKhjowr4A3PP8IdOcGTAOP31RQJDMIHWKbjDfnXS4T87ujHEgkZ8GzTp6VfaTytG4v+rQMwNtXZ6CTVgHuzmm2CUtZ+yMj+3Whf/Br3EoxwBde/3vLyrqMvcUtq/WaUMQfN+6orvhAzmakUGZtkIJtdKcRlPObX32ZLdGis6S58vrzSPlp;\n\t25:n0G8vH2kCeEG9JyjDneNT04K/gngJ3B9riRBsjdwHzOr4ahrEbErpI771ZVNQprbUJPwaPUbVdxoH05oPHkdq+M3Xohr7oX8uDXrwIQ0dxYk/9XdxAj5lvH1GIHbd3JoPU30j29nKQSO+VMi5UzmtyeVAVf8zYcbBiVI5bbaJvf8tKt+HsE3QQXHPMp86SnR92vMtwH0Ls4ybjMx5G19ekiKiFav0LIIQ7Zxij9RaDaqXDvPUivzhn6CBtnPPRXSQZo7FPadNQnsePIrv/gaVdgEEyWSQrhQo9sC5qZ8uppzFyn7OW0Lhm+GwKObNxf3QJjt1gW+spUBN8+yOmXesA==;\n\t31:wOSy5FHMCZ7O6npHKLlyoHESUpKMaAORycujZaT7GAMbmgQ0WxfIGvhE4wD+zKB7dx4AjeQE2fPgPrA2mTFCxLkhfYN+hyCjYaZhNCw42Txp4u432tZNwNCjTm7F15B48Dla7CDC9yXgZjXsJ2EbTrLV/e+jZ4FSIHOLGG7apZrwlG6vYo/2j8mZNmiXC66lQ4Aei8BW6sUo1+PEtmdbRXS0ueZJf/kmiScSJC2uJs0=", "1; CY4PR07MB3464;\n\t20:Trj1uD+fUQ3yAUh6CacWz+1WUmCtSRrO0yVy2mh2YdAOZAVmi+B+ziChEmgHBmCLWoqNUjUW2q6n+h4rkr3KRkIVL7QmAZcvL1FIvjcsgiqlqkuNz+pQ5Wb363CfQYEG1gON+pAx9I/Tpzj/fxHGQBCaX1jimmpn3qeQh6raGxg5jn1sQo9h8ZQ7UJUrlwxELiQdsgYG/ZJOy37+IS5tiLseu9NqbyH7/wZMw6AZY+dPIprevmrup5w+3DYnSnC5zrqWsK/WTBwyotw2qqHqCKEIpwaIMwIAAWLYztNaLbXvLBsIwAmO19nNg/XcFyULn3DAgy3N84zhaxd49oq2PsjPxoyz1ycQKRcqkDE55pqPKFsNBh/e+lAqHQNos4YfpnSl88Q/wab8mlvCBKJ7tU5ye3fFM+gXtleBmCMt1od/oX51wqRR69Q0dIX4PyhXqWbpxB9G+MHOaMgPVKFfkPISfTAYFxpN3uIPrX7K0SsAOrzTuxbVmwEVYgqH/b5B2gCav7yYlb+RQ/cOy/OhSGNVo6FeP/zn/Xd4i8xYE6WKob2idCRbNnasU21pnneYSUOnnOiDeFMTJs4xKjm0I6Zo2VbdZK3OIuhxO8O9HvI=;\n\t4:MuyzYTa01DYmorcOArJB7ZWj/611x1ix9Xr2qB149IKrV+7C7WByivR8Sd8breGAhSWCSOAlKlKvlkg1aG9MmTRl/jZlon953l6AgBSnxfhY7OJjcRzQ5u7pXQwpqc8QWLPA8/ZfImanICCdE6eq6e0OA/Lr9Z77k4wJMmJzmhf1PUXY0IOobRaoyhForR8hmb75aPo2IlMAbyT3H51VK8wnWYh71maBLmnGBu4sZQv+lOYibxp2eFfHsMy57m4H", "=?us-ascii?Q?1; CY4PR07MB3464;\n\t23:idRkRMZB2sc27233WiYqdk5kyGZaYtrr6tT5n74gF?=\n\t/YsDCOrMZuA25D7HgCcch6jnRSYDQ2WX3w8UBDNDRg8tJOJTAlcS1edR3YeSNo0GHJI4bL0dXsqecKlBo8qEaFPzOCjea2ZzyC64i0DeKR+zw0rkT/ITif05G4ojUa/m0pT/63eDwa9i9Psp3+mTsKVxFVMKXPwhDk4Rh5Ta2Li5GyFfdeo6xZBtUbKbqqp27bobsMa48k+TGOdLW5pGZXhOGLf06ZtI/YUgnGevIXQtj2qx8iLw668MdUIxnfsuIwCY2tfM2BUZrnLv/MgyNtYXyepMZb/WcZBe+KSb5aNMHIj4K8lxQz+dwC8k23UMoEVGGoOe28dWEngcwa974/bUOguaAqFe1TiXrhSEkUvZ0U5/3ARIuZ/M+dHNFrnuSiX3iD4y2YbslSkpsFM0K+J8gAAyDaCAFd0NHyCVJFaEf0x8s2bdyJPsXCfmudXVUyzQnuZKBelQJIMRISmXPt48BcNtajBfDHUYuMwtXqa/8nXA5JWYvt7mKtSPjtimFK5zaO2aMIt0ygyx4HFK+9E16JJtFtU3OG7dE42dqrMs2j9G0zuoMKMtFv+m/RCNyGtnYpaON1/ERZXGRKJkFuwOMSIjhIy6Lfo+dcpFyRM2bOpI9pE3QrF/AIw+415hIf4jJ5HipUhX7uRV5iNceQbg8QsZlQ7vFaQKEq+2ZTo8Pz2ktH2nLN4qx8NGiGXuJZvUZ2cDbaD+bluwMWoyfxzPw998+Kp9UWcghhtc7B0Fs9/+4Tggt5DBIa9wxbv1pA3rMna8js6qZ7AP/2Y+EuQRjPdCR7bTZZ4k6eWbZ2qcl/dwbd4z9Tlv49x+Va/ByBCvZv1WXGPDK2Mx8dJpeVzBcPZXMYZvt8MfPowePjolWDb1UaY4a//GKOeDmdrIeM/i+MYUzLIzzmMrNK/kPVwcplnPBq1BX/Ym4JO1DLoYAF5HpfDICTKg4iozUbft7bppjxbOppocgke6XjpyfE1J1Kwjn+BKIi/PS2wE3qUoqZHVUdLuLnELDAufO8x3oI9dnYgAj/VNX2CpJUXsJQKCmrWvNaiToH3kWsgvbVMf5z9WTLBMLnZAN0IM3v8xIbM1Xs16tScmDdbMC4H5zybMEtI4SlHQW3gKRWqQ/Wim0AvEoV0/9LJtl7RV+sfVResuseNG4c9N2J5Lc5LjgOJ", "1; CY4PR07MB3464;\n\t6:AhLGQaoy9x2CEV6EL+AeryTKOxlsN0zNdBukkPkzoR9UVIDqGP70teCcKFIw8M3je7D9C3JglMg/uTatcZiCWqVLC+IbIBRlTsOXZzjtvSS07rXeFxACewrvYnx0AqCS/dPF+gxFEJn93u/q412s/d6Qe4w2Vh2lLy0fFIYEFTbde8th+Meqho2NbMxAU59ijqHkhRmt9CFeHzchagDCzS8PSmcTnEfqUhJrkcoTLsbVK3e/XXSjCkunS9X2sFfbL7KoKulnkmgP/2yiPjSJDjDx9aZzX41cgajMBuWIgMtZhmXRf40mRWcT90LYgpeaj9aOdVXsCpiz+I/QB9IPDg==;\n\t5:x/LJ+YFjOqCTF09meHE9VGwVQsrJkngdSvrtC3f8QD/wrFkpGV0Ix77WhB9OigzVfsPyzYMEcJaAcsh6LbBxAMnGMxr5dLPu/RffqPOaFpj7qFHYeGOvST2gs/CfR3fnQAztFjLq2P1gyQO0IRAJJw==;\n\t24:jto8VTi2pSIQNb/JETrRSSxkQ9iQ4WRNEdmFTfi4uqUAcji59gID7ZLxKeekMhMVlCEBsg9RohesVp2CuKnnSIejs60b+J7uUeQlR0Xbe2c=;\n\t7:1qkaPEUWkQY+d5fmrN3IqUVcsrCQo5YaLsTRj659OQmhCncasHie0INKgED7AU4cRPS0GBHe5pEaQhNIpCtui3x0h1wLoRHnOrQpExIMcVLsOIidEe0miqr9O072o1iT96FmvG1370oNZnchKvTpIccR7Zw4Lc8wkJmrbD4zzvBc40WqtIBsll1i1QZgT+c+ADdTtxj7hbZPKBFe3fLYz0J0vD0qYR9/us+T1cqwS9Q=" ], "X-MS-TrafficTypeDiagnostic": "CY4PR07MB3464:", "X-Exchange-Antispam-Report-Test": "UriScan:;", "X-Microsoft-Antispam-PRVS": "<CY4PR07MB3464748DFB25FDF961A1F4CC80960@CY4PR07MB3464.namprd07.prod.outlook.com>", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(100000703101)(100105400095)(10201501046)(3002001)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(20161123558100)(20161123560025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:CY4PR07MB3464; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:CY4PR07MB3464; ", "X-Forefront-PRVS": "0421BF7135", "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(6009001)(189002)(199003)(36756003)(68736007)(42186005)(189998001)(50466002)(305945005)(5003940100001)(7736002)(33646002)(66066001)(6512007)(69596002)(8676002)(6306002)(53936002)(81156014)(81166006)(106356001)(105586002)(48376002)(47776003)(110136004)(53416004)(107886003)(5009440100003)(50986999)(50226002)(76176999)(8936002)(101416001)(97736004)(6116002)(6506006)(6486002)(3846002)(2950100002)(6666003)(478600001)(966005)(42882006)(575784001)(72206003)(5660300001)(25786009)(4326008)(2906002)(42262002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3464;\n\tH:PBHAGAVATULA-LT.caveonetworks.com; FPR:; SPF:None; PTR:InfoNoRecords;\n\tMX:1; A:1; LANG:en; ", "Received-SPF": "None (protection.outlook.com: cavium.com does not designate\n\tpermitted sender hosts)", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "caviumnetworks.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "05 Sep 2017 11:39:05.2860\n\t(UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "711e4ccf-2e9b-4bcf-a551-4094005b6194", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CY4PR07MB3464", "Subject": "[dpdk-dev] [PATCH v5 2/3] eal: add u64 bit variant for reciprocal", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Pavan Bhagavatula <pbhagavatula@caviumnetworks.com>\n\nCurrently, rte_reciprocal only supports unsigned 32bit divisors. This\ncommit adds support for unsigned 64bit divisors.\n\nRename unsigned 32bit specific functions appropriately and update\nlibrte_sched accordingly.\n\nSigned-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>\n---\n lib/librte_eal/bsdapp/eal/rte_eal_version.map | 3 +-\n lib/librte_eal/common/include/rte_reciprocal.h | 111 +++++++++++++++++++++--\n lib/librte_eal/common/rte_reciprocal.c | 116 +++++++++++++++++++++---\n lib/librte_eal/linuxapp/eal/rte_eal_version.map | 3 +-\n lib/librte_sched/Makefile | 4 +-\n lib/librte_sched/rte_sched.c | 9 +-\n 6 files changed, 220 insertions(+), 26 deletions(-)", "diff": "diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map b/lib/librte_eal/bsdapp/eal/rte_eal_version.map\nindex d0bda66..5fd6101 100644\n--- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map\n+++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map\n@@ -242,6 +242,7 @@ EXPERIMENTAL {\n DPDK_17.11 {\n \tglobal:\n \n-\trte_reciprocal_value;\n+\trte_reciprocal_value_u32;\n+\trte_reciprocal_value_u64;\n \n } DPDK_17.08;\ndiff --git a/lib/librte_eal/common/include/rte_reciprocal.h b/lib/librte_eal/common/include/rte_reciprocal.h\nindex b6d752f..801d1c8 100644\n--- a/lib/librte_eal/common/include/rte_reciprocal.h\n+++ b/lib/librte_eal/common/include/rte_reciprocal.h\n@@ -22,22 +22,117 @@\n #ifndef _RTE_RECIPROCAL_H_\n #define _RTE_RECIPROCAL_H_\n \n-#include <stdint.h>\n+#include <rte_memory.h>\n \n-struct rte_reciprocal {\n+/**\n+ * Unsigned 32-bit divisor structure.\n+ */\n+struct rte_reciprocal_u32 {\n \tuint32_t m;\n \tuint8_t sh1, sh2;\n-};\n+} __rte_cache_aligned;\n+\n+/**\n+ * Unsigned 64-bit divisor structure.\n+ */\n+struct rte_reciprocal_u64 {\n+\tuint64_t m;\n+\tuint8_t sh1;\n+} __rte_cache_aligned;\n \n+/**\n+ * Divide given unsigned 32-bit integer with pre calculated divisor.\n+ *\n+ * @param a\n+ * The 32-bit dividend.\n+ * @param R\n+ * The pointer to pre calculated divisor reciprocal structure.\n+ *\n+ * @return\n+ * The result of the division\n+ */\n static inline uint32_t\n-rte_reciprocal_divide(uint32_t a, struct rte_reciprocal R)\n+rte_reciprocal_divide_u32(uint32_t a, struct rte_reciprocal_u32 *R)\n+{\n+\tuint32_t t = (((uint64_t)a * R->m) >> 32);\n+\n+\treturn (t + ((a - t) >> R->sh1)) >> R->sh2;\n+}\n+\n+static inline uint64_t\n+mullhi_u64(uint64_t x, uint64_t y)\n+{\n+#ifdef __SIZEOF_INT128__\n+\t__uint128_t xl = x;\n+\t__uint128_t rl = xl * y;\n+\n+\treturn (rl >> 64);\n+#else\n+\tuint64_t u0, u1, v0, v1, k, t;\n+\tuint64_t w1, w2;\n+\tuint64_t whi;\n+\n+\tu1 = x >> 32; u0 = x & 0xFFFFFFFF;\n+\tv1 = y >> 32; v0 = y & 0xFFFFFFFF;\n+\n+\tt = u0*v0;\n+\tk = t >> 32;\n+\n+\tt = u1*v0 + k;\n+\tw1 = t & 0xFFFFFFFF;\n+\tw2 = t >> 32;\n+\n+\tt = u0*v1 + w1;\n+\tk = t >> 32;\n+\n+\twhi = u1*v1 + w2 + k;\n+\n+\treturn whi;\n+#endif\n+}\n+\n+/**\n+ * Divide given unsigned 64-bit integer with pre calculated divisor.\n+ *\n+ * @param a\n+ * The 64-bit dividend.\n+ * @param R\n+ * The pointer to pre calculated divisor reciprocal structure.\n+ *\n+ * @return\n+ * The result of the division\n+ */\n+static inline uint64_t\n+rte_reciprocal_divide_u64(uint64_t a, struct rte_reciprocal_u64 *R)\n {\n-\tuint32_t t = (uint32_t)(((uint64_t)a * R.m) >> 32);\n+\tuint64_t q = mullhi_u64(R->m, a);\n+\tuint64_t t = ((a - q) >> 1) + q;\n \n-\treturn (t + ((a - t) >> R.sh1)) >> R.sh2;\n+\treturn t >> R->sh1;\n }\n \n-struct rte_reciprocal\n-rte_reciprocal_value(uint32_t d);\n+/**\n+ * Generate pre calculated divisor structure.\n+ *\n+ * @param d\n+ * The unsigned 32-bit divisor.\n+ *\n+ * @return\n+ * Divisor structure.\n+ */\n+struct rte_reciprocal_u32\n+rte_reciprocal_value_u32(uint32_t d);\n+\n+/**\n+ * Generate pre calculated divisor structure.\n+ *\n+ * @param d\n+ * The unsigned 64-bit divisor.\n+ *\n+ * @return\n+ * Divisor structure.\n+ */\n+struct rte_reciprocal_u64\n+rte_reciprocal_value_u64(uint64_t d);\n \n #endif /* _RTE_RECIPROCAL_H_ */\ndiff --git a/lib/librte_eal/common/rte_reciprocal.c b/lib/librte_eal/common/rte_reciprocal.c\nindex 7ab99b4..2024e62 100644\n--- a/lib/librte_eal/common/rte_reciprocal.c\n+++ b/lib/librte_eal/common/rte_reciprocal.c\n@@ -31,18 +31,13 @@\n * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n */\n \n-#include <stdio.h>\n-#include <stdint.h>\n-\n-#include <rte_common.h>\n-\n-#include \"rte_reciprocal.h\"\n+#include <rte_reciprocal.h>\n \n /* find largest set bit.\n * portable and slow but does not matter for this usage.\n */\n static inline int\n-fls(uint32_t x)\n+fls_u32(uint32_t x)\n {\n \tint b;\n \n@@ -54,14 +49,14 @@ fls(uint32_t x)\n \treturn 0;\n }\n \n-struct rte_reciprocal\n-rte_reciprocal_value(uint32_t d)\n+struct rte_reciprocal_u32\n+rte_reciprocal_value_u32(uint32_t d)\n {\n-\tstruct rte_reciprocal R;\n+\tstruct rte_reciprocal_u32 R;\n \tuint64_t m;\n \tint l;\n \n-\tl = fls(d - 1);\n+\tl = fls_u32(d - 1);\n \tm = ((1ULL << 32) * ((1ULL << l) - d));\n \tm /= d;\n \n@@ -72,3 +67,102 @@ rte_reciprocal_value(uint32_t d)\n \n \treturn R;\n }\n+\n+/* Code taken from Hacker's Delight:\n+ * http://www.hackersdelight.org/HDcode/divlu.c.\n+ * License permits inclusion here per:\n+ * http://www.hackersdelight.org/permissions.htm\n+ */\n+static inline uint64_t\n+divide_128_div_64_to_64(uint64_t u1, uint64_t u0, uint64_t v, uint64_t *r)\n+{\n+\tconst uint64_t b = (1ULL << 32); /* Number base (16 bits). */\n+\tuint64_t un1, un0, /* Norm. dividend LSD's. */\n+\t\t\t vn1, vn0, /* Norm. divisor digits. */\n+\t\t\t q1, q0, /* Quotient digits. */\n+\t\t\t un64, un21, un10, /* Dividend digit pairs. */\n+\t\t\t rhat; /* A remainder. */\n+\tint s; /* Shift amount for norm. */\n+\n+ /* If overflow, set rem. to an impossible value. */\n+\tif (u1 >= v) {\n+\t\tif (r != NULL)\n+\t\t\t*r = (uint64_t) -1;\n+\t\treturn (uint64_t) -1;\n+\t}\n+\n+\t/* Count leading zeros. */\n+\ts = __builtin_clzll(v);\n+\tif (s > 0) {\n+\t\tv = v << s;\n+\t\tun64 = (u1 << s) | ((u0 >> (64 - s)) & (-s >> 31));\n+\t\tun10 = u0 << s;\n+\t} else {\n+\n+\t\tun64 = u1 | u0;\n+\t\tun10 = u0;\n+\t}\n+\n+\tvn1 = v >> 32;\n+\tvn0 = v & 0xFFFFFFFF;\n+\n+\tun1 = un10 >> 32;\n+\tun0 = un10 & 0xFFFFFFFF;\n+\n+\tq1 = un64/vn1;\n+\trhat = un64 - q1*vn1;\n+again1:\n+\tif (q1 >= b || q1*vn0 > b*rhat + un1) {\n+\t\tq1 = q1 - 1;\n+\t\trhat = rhat + vn1;\n+\t\tif (rhat < b)\n+\t\t\tgoto again1;\n+\t}\n+\n+\tun21 = un64*b + un1 - q1*v;\n+\n+\tq0 = un21/vn1;\n+\trhat = un21 - q0*vn1;\n+again2:\n+\tif (q0 >= b || q0*vn0 > b*rhat + un0) {\n+\t\tq0 = q0 - 1;\n+\t\trhat = rhat + vn1;\n+\t\tif (rhat < b)\n+\t\t\tgoto again2;\n+\t}\n+\n+\tif (r != NULL)\n+\t\t*r = (un21*b + un0 - q0*v) >> s;\n+\treturn q1*b + q0;\n+}\n+\n+struct rte_reciprocal_u64\n+rte_reciprocal_value_u64(uint64_t d)\n+{\n+\tstruct rte_reciprocal_u64 R;\n+\n+\tconst uint32_t fld = 63 - __builtin_clzll(d);\n+\n+\tif ((d & (d - 1)) == 0) {\n+\t\tR.m = 0;\n+\t\tR.sh1 = (fld - 1) | 0x40;\n+\t} else {\n+\t\tuint64_t rem;\n+\t\tuint64_t multiplier;\n+\t\tuint8_t more;\n+\n+\t\tmultiplier = divide_128_div_64_to_64(1ULL << fld, 0, d, &rem);\n+\t\tmultiplier += multiplier;\n+\n+\t\tconst uint64_t twice_rem = rem + rem;\n+\t\tif (twice_rem >= d || twice_rem < rem)\n+\t\t\tmultiplier += 1;\n+\t\tmore = fld;\n+\t\tR.m = 1 + multiplier;\n+\t\tR.sh1 = more | 0x40;\n+\t}\n+\n+\tR.sh1 &= 0x3F;\n+\n+\treturn R;\n+}\ndiff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map\nindex 65117cb..63ff2b8 100644\n--- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map\n+++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map\n@@ -247,6 +247,7 @@ EXPERIMENTAL {\n DPDK_17.11 {\n \tglobal:\n \n-\trte_reciprocal_value;\n+\trte_reciprocal_value_u32;\n+\trte_reciprocal_value_u64;\n \n } DPDK_17.08;\ndiff --git a/lib/librte_sched/Makefile b/lib/librte_sched/Makefile\nindex 569656b..a2fd6f3 100644\n--- a/lib/librte_sched/Makefile\n+++ b/lib/librte_sched/Makefile\n@@ -54,6 +54,8 @@ LIBABIVER := 1\n SRCS-$(CONFIG_RTE_LIBRTE_SCHED) += rte_sched.c rte_red.c rte_approx.c\n \n # install includes\n-SYMLINK-$(CONFIG_RTE_LIBRTE_SCHED)-include := rte_sched.h rte_bitmap.h rte_sched_common.h rte_red.h rte_approx.h\n+SYMLINK-$(CONFIG_RTE_LIBRTE_SCHED)-include := rte_sched.h rte_bitmap.h\n+SYMLINK-$(CONFIG_RTE_LIBRTE_SCHED)-include += rte_sched_common.h rte_red.h\n+SYMLINK-$(CONFIG_RTE_LIBRTE_SCHED)-include += rte_approx.h\n \n include $(RTE_SDK)/mk/rte.lib.mk\ndiff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c\nindex 3b8ccaa..7bb6d51 100644\n--- a/lib/librte_sched/rte_sched.c\n+++ b/lib/librte_sched/rte_sched.c\n@@ -228,7 +228,7 @@ struct rte_sched_port {\n \tuint64_t time_cpu_cycles; /* Current CPU time measured in CPU cyles */\n \tuint64_t time_cpu_bytes; /* Current CPU time measured in bytes */\n \tuint64_t time; /* Current NIC TX time measured in bytes */\n-\tstruct rte_reciprocal inv_cycles_per_byte; /* CPU cycles per byte */\n+\tstruct rte_reciprocal_u32 inv_cycles_per_byte; /* CPU cycles per byte */\n \n \t/* Scheduling loop detection */\n \tuint32_t pipe_loop;\n@@ -677,7 +677,7 @@ rte_sched_port_config(struct rte_sched_port_params *params)\n \n \tcycles_per_byte = (rte_get_tsc_hz() << RTE_SCHED_TIME_SHIFT)\n \t\t/ params->rate;\n-\tport->inv_cycles_per_byte = rte_reciprocal_value(cycles_per_byte);\n+\tport->inv_cycles_per_byte = rte_reciprocal_value_u32(cycles_per_byte);\n \n \t/* Scheduling loop detection */\n \tport->pipe_loop = RTE_SCHED_PIPE_INVALID;\n@@ -2147,8 +2147,9 @@ rte_sched_port_time_resync(struct rte_sched_port *port)\n \tuint64_t bytes_diff;\n \n \t/* Compute elapsed time in bytes */\n-\tbytes_diff = rte_reciprocal_divide(cycles_diff << RTE_SCHED_TIME_SHIFT,\n-\t\t\t\t\t port->inv_cycles_per_byte);\n+\tbytes_diff = rte_reciprocal_divide_u32(\n+\t\t\tcycles_diff << RTE_SCHED_TIME_SHIFT,\n+\t\t\t&port->inv_cycles_per_byte);\n \n \t/* Advance port time */\n \tport->time_cpu_cycles = cycles;\n", "prefixes": [ "dpdk-dev", "v5", "2/3" ] }