Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 27330,
    "url": "http://patches.dpdk.org/api/patches/27330/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/7c454998a918c29815332297f8fe88b6ce47260c.1501598384.git.adrien.mazarguil@6wind.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<7c454998a918c29815332297f8fe88b6ce47260c.1501598384.git.adrien.mazarguil@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/7c454998a918c29815332297f8fe88b6ce47260c.1501598384.git.adrien.mazarguil@6wind.com",
    "date": "2017-08-01T16:54:05",
    "name": "[dpdk-dev,v1,18/48] net/mlx4: drop packet type recognition support",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "828913ac32034dd4a7a34e7e36c8801f2f464402",
    "submitter": {
        "id": 165,
        "url": "http://patches.dpdk.org/api/people/165/?format=api",
        "name": "Adrien Mazarguil",
        "email": "adrien.mazarguil@6wind.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/7c454998a918c29815332297f8fe88b6ce47260c.1501598384.git.adrien.mazarguil@6wind.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/27330/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/27330/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id DDC52A16C;\n\tTue,  1 Aug 2017 18:55:38 +0200 (CEST)",
            "from mail-wr0-f172.google.com (mail-wr0-f172.google.com\n\t[209.85.128.172]) by dpdk.org (Postfix) with ESMTP id A0F1AA0C6\n\tfor <dev@dpdk.org>; Tue,  1 Aug 2017 18:55:16 +0200 (CEST)",
            "by mail-wr0-f172.google.com with SMTP id k71so9255207wrc.2\n\tfor <dev@dpdk.org>; Tue, 01 Aug 2017 09:55:16 -0700 (PDT)",
            "from 6wind.com (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\tv9sm1770319wmg.41.2017.08.01.09.55.14\n\tfor <dev@dpdk.org> (version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tTue, 01 Aug 2017 09:55:14 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:subject:date:message-id:in-reply-to:references;\n\tbh=zq8MKi6VqfeT2TtZ+/t/oRcFw8AQ63ullWnAjzluNUE=;\n\tb=amIbOdRQs+E8wbku/totKHmmO3o5xZHtsfMKClso+0EBmT4vEkOCMh1jwhIKyrBEKk\n\tepdOxvZlIhzqnHBMgiP9Px6xpoa7/XBTfoVgmQuCO8A7wiOCsWVg81z3J6o1NXODeT3i\n\tV6qhg63xIWnSJFSemmVVj0Z/FeD+zYwStkXwStvbTPGOGY0XzsnPR5E44sVTHswZnl2Z\n\t7N/5gTJ0ir9xth2uy3xobDv/aY7ktGdkTbLN0BmqICqjbuf6hn0aygTZRodvIEhNUDkX\n\t/j4K8+oalmDAr/igrkTwMq5S27fctaFpfNhtGQ5cqZl65X9eJ2jg9033VdIzAgdjvXeT\n\t7hUg==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=zq8MKi6VqfeT2TtZ+/t/oRcFw8AQ63ullWnAjzluNUE=;\n\tb=r7aA+lelxyWITfqcWZ9ETSZ/U2TKfZWcsrqKnKjAo3M0r5OBHcQGsiP+ch3t0DgHC6\n\tGtKfYBvokXaTOhK1bVqzq6O3MkPcySMU4fTsAAmrZZ9DIjj/r3ukbJnSkgJYu6Qv0eAC\n\tBSsCWYQKV9v/sLag/jyxAqcDgHa+LnK1+UGEioLSyPSmt0jz2/xz4CcffmnRKolvoZqm\n\tn/KZOH6IapJ7OKuNNtUQqCVqDsGx88P/Hp3WZ888thI9S8U9BcnVlHRMOExeldAWx2Sq\n\tkSIUAe+OnsKzzjdCGogfFX1bo+DhFkqKvBg16VDci1Iwmv2TzsDsvQrr6EGcGP4jd2g1\n\tLvhA==",
        "X-Gm-Message-State": "AIVw111LwUrjtSpGJZeDYcsbaOaF4ouexorueken2I+pQbqUwgUKuyjZ\n\tl+lnXW7tqC0wUknEKRo=",
        "X-Received": "by 10.223.179.83 with SMTP id k19mr17960424wrd.198.1501606515931;\n\tTue, 01 Aug 2017 09:55:15 -0700 (PDT)",
        "From": "Adrien Mazarguil <adrien.mazarguil@6wind.com>",
        "To": "dev@dpdk.org",
        "Date": "Tue,  1 Aug 2017 18:54:05 +0200",
        "Message-Id": "<7c454998a918c29815332297f8fe88b6ce47260c.1501598384.git.adrien.mazarguil@6wind.com>",
        "X-Mailer": "git-send-email 2.1.4",
        "In-Reply-To": "<cover.1501598383.git.adrien.mazarguil@6wind.com>",
        "References": "<cover.1501598383.git.adrien.mazarguil@6wind.com>",
        "Subject": "[dpdk-dev] [PATCH v1 18/48] net/mlx4: drop packet type recognition\n\tsupport",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The Verbs API used to implement packet type recognition is deprecated.\nSupport will be added back after refactoring the PMD.\n\nSigned-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>\n---\n doc/guides/nics/features/mlx4.ini |  1 -\n drivers/net/mlx4/mlx4.c           | 70 +---------------------------------\n 2 files changed, 2 insertions(+), 69 deletions(-)",
    "diff": "diff --git a/doc/guides/nics/features/mlx4.ini b/doc/guides/nics/features/mlx4.ini\nindex 08a2e17..27c7ae3 100644\n--- a/doc/guides/nics/features/mlx4.ini\n+++ b/doc/guides/nics/features/mlx4.ini\n@@ -14,7 +14,6 @@ MTU update           = Y\n Jumbo frame          = Y\n Scattered Rx         = Y\n SR-IOV               = Y\n-Packet type parsing  = Y\n Basic stats          = Y\n Stats per queue      = Y\n Other kdrv           = Y\ndiff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c\nindex 36a616b..e0e5d1f 100644\n--- a/drivers/net/mlx4/mlx4.c\n+++ b/drivers/net/mlx4/mlx4.c\n@@ -96,12 +96,6 @@ typedef union {\n \n #define WR_ID(o) (((wr_id_t *)&(o))->data)\n \n-/* Transpose flags. Useful to convert IBV to DPDK flags. */\n-#define TRANSPOSE(val, from, to) \\\n-\t(((from) >= (to)) ? \\\n-\t (((val) & (from)) / ((from) / (to))) : \\\n-\t (((val) & (from)) * ((to) / (from))))\n-\n /** Configuration structure for device arguments. */\n struct mlx4_conf {\n \tstruct {\n@@ -2088,47 +2082,6 @@ rxq_cleanup(struct rxq *rxq)\n \tmemset(rxq, 0, sizeof(*rxq));\n }\n \n-/**\n- * Translate RX completion flags to packet type.\n- *\n- * @param flags\n- *   RX completion flags returned by poll_length_flags().\n- *\n- * @note: fix mlx4_dev_supported_ptypes_get() if any change here.\n- *\n- * @return\n- *   Packet type for struct rte_mbuf.\n- */\n-static inline uint32_t\n-rxq_cq_to_pkt_type(uint32_t flags)\n-{\n-\tuint32_t pkt_type;\n-\n-\tif (flags & IBV_EXP_CQ_RX_TUNNEL_PACKET)\n-\t\tpkt_type =\n-\t\t\tTRANSPOSE(flags,\n-\t\t\t\t  IBV_EXP_CQ_RX_OUTER_IPV4_PACKET,\n-\t\t\t\t  RTE_PTYPE_L3_IPV4_EXT_UNKNOWN) |\n-\t\t\tTRANSPOSE(flags,\n-\t\t\t\t  IBV_EXP_CQ_RX_OUTER_IPV6_PACKET,\n-\t\t\t\t  RTE_PTYPE_L3_IPV6_EXT_UNKNOWN) |\n-\t\t\tTRANSPOSE(flags,\n-\t\t\t\t  IBV_EXP_CQ_RX_IPV4_PACKET,\n-\t\t\t\t  RTE_PTYPE_INNER_L3_IPV4_EXT_UNKNOWN) |\n-\t\t\tTRANSPOSE(flags,\n-\t\t\t\t  IBV_EXP_CQ_RX_IPV6_PACKET,\n-\t\t\t\t  RTE_PTYPE_INNER_L3_IPV6_EXT_UNKNOWN);\n-\telse\n-\t\tpkt_type =\n-\t\t\tTRANSPOSE(flags,\n-\t\t\t\t  IBV_EXP_CQ_RX_IPV4_PACKET,\n-\t\t\t\t  RTE_PTYPE_L3_IPV4_EXT_UNKNOWN) |\n-\t\t\tTRANSPOSE(flags,\n-\t\t\t\t  IBV_EXP_CQ_RX_IPV6_PACKET,\n-\t\t\t\t  RTE_PTYPE_L3_IPV6_EXT_UNKNOWN);\n-\treturn pkt_type;\n-}\n-\n static uint16_t\n mlx4_rx_burst(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n);\n \n@@ -2315,7 +2268,7 @@ mlx4_rx_burst_sp(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n)\n \t\tNB_SEGS(pkt_buf) = j;\n \t\tPORT(pkt_buf) = rxq->port_id;\n \t\tPKT_LEN(pkt_buf) = pkt_buf_len;\n-\t\tpkt_buf->packet_type = rxq_cq_to_pkt_type(flags);\n+\t\tpkt_buf->packet_type = 0;\n \t\tpkt_buf->ol_flags = 0;\n \n \t\t/* Return packet. */\n@@ -2470,7 +2423,7 @@ mlx4_rx_burst(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n)\n \t\tNEXT(seg) = NULL;\n \t\tPKT_LEN(seg) = len;\n \t\tDATA_LEN(seg) = len;\n-\t\tseg->packet_type = rxq_cq_to_pkt_type(flags);\n+\t\tseg->packet_type = 0;\n \t\tseg->ol_flags = 0;\n \n \t\t/* Return packet. */\n@@ -3369,24 +3322,6 @@ mlx4_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info)\n \tpriv_unlock(priv);\n }\n \n-static const uint32_t *\n-mlx4_dev_supported_ptypes_get(struct rte_eth_dev *dev)\n-{\n-\tstatic const uint32_t ptypes[] = {\n-\t\t/* refers to rxq_cq_to_pkt_type() */\n-\t\tRTE_PTYPE_L3_IPV4,\n-\t\tRTE_PTYPE_L3_IPV6,\n-\t\tRTE_PTYPE_INNER_L3_IPV4,\n-\t\tRTE_PTYPE_INNER_L3_IPV6,\n-\t\tRTE_PTYPE_UNKNOWN\n-\t};\n-\n-\tif (dev->rx_pkt_burst == mlx4_rx_burst ||\n-\t    dev->rx_pkt_burst == mlx4_rx_burst_sp)\n-\t\treturn ptypes;\n-\treturn NULL;\n-}\n-\n /**\n  * DPDK callback to get device statistics.\n  *\n@@ -3768,7 +3703,6 @@ static const struct eth_dev_ops mlx4_dev_ops = {\n \t.stats_get = mlx4_stats_get,\n \t.stats_reset = mlx4_stats_reset,\n \t.dev_infos_get = mlx4_dev_infos_get,\n-\t.dev_supported_ptypes_get = mlx4_dev_supported_ptypes_get,\n \t.rx_queue_setup = mlx4_rx_queue_setup,\n \t.tx_queue_setup = mlx4_tx_queue_setup,\n \t.rx_queue_release = mlx4_rx_queue_release,\n",
    "prefixes": [
        "dpdk-dev",
        "v1",
        "18/48"
    ]
}