Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/27262/?format=api
{ "id": 27262, "url": "http://patches.dpdk.org/api/patches/27262/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1501282874-127700-1-git-send-email-jianfeng.tan@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1501282874-127700-1-git-send-email-jianfeng.tan@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1501282874-127700-1-git-send-email-jianfeng.tan@intel.com", "date": "2017-07-28T23:01:14", "name": "[dpdk-dev] net/virtio: fix MAC addr not correct read", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "08eccb8045d2e067073c7d78c1c201ae2495b4f3", "submitter": { "id": 313, "url": "http://patches.dpdk.org/api/people/313/?format=api", "name": "Jianfeng Tan", "email": "jianfeng.tan@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1501282874-127700-1-git-send-email-jianfeng.tan@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/27262/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/27262/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id CA1119975;\n\tSat, 29 Jul 2017 01:00:00 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id 042599974;\n\tSat, 29 Jul 2017 00:59:58 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga104.jf.intel.com with ESMTP; 28 Jul 2017 15:59:57 -0700", "from dpdk06.sh.intel.com ([10.67.111.82])\n\tby orsmga003.jf.intel.com with ESMTP; 28 Jul 2017 15:59:56 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.40,427,1496127600\"; d=\"scan'208\";a=\"998468321\"", "From": "Jianfeng Tan <jianfeng.tan@intel.com>", "To": "dev@dpdk.org", "Cc": "Jianfeng Tan <jianfeng.tan@intel.com>, stable@dpdk.org,\n\tZhihong Wang <zhihong.wang@intel.com>,\n\tYuanhan Liu <yliu@fridaylinux.org>, \n\tMaxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Fri, 28 Jul 2017 23:01:14 +0000", "Message-Id": "<1501282874-127700-1-git-send-email-jianfeng.tan@intel.com>", "X-Mailer": "git-send-email 2.7.4", "Subject": "[dpdk-dev] [PATCH] net/virtio: fix MAC addr not correct read", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When virtio-net devices are bound to uio_pci_generic, we get\nthe wrong mac addr by virtio PMD. The wrong mac addr is a\naddr that is 4-byte left shift of the correct addr.\n\nIt's a regression bug introduced by the cleanup patch below.\nThe condition of if we set use_msix should be if msix is\nactually enabled. Only to check if there is a capability list\nis not enough. For example, binding a transitional device\nto uio_pci_device would trigger the wrong assignment of use_msix.\n\nTo correct that, we also check the flags of msix capability to\nmake sure it's enabled.\n\nFixes: ee1843bd8907 (\"net/virtio: remove redundant MSI-X detection\")\nCc: stable@dpdk.org\nCc: Zhihong Wang <zhihong.wang@intel.com>\nCc: Yuanhan Liu <yliu@fridaylinux.org>\nCc: Maxime Coquelin <maxime.coquelin@redhat.com>\n\nReported-by: Vipin Varghese <vipin.varghese@intel.com>\nSigned-off-by: Jianfeng Tan <jianfeng.tan@intel.com>\n---\n drivers/net/virtio/virtio_pci.c | 15 +++++++++++++--\n 1 file changed, 13 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c\nindex e6eda75..e6da680 100644\n--- a/drivers/net/virtio/virtio_pci.c\n+++ b/drivers/net/virtio/virtio_pci.c\n@@ -580,6 +580,8 @@ get_cfg_addr(struct rte_pci_device *dev, struct virtio_pci_cap *cap)\n \treturn base + offset;\n }\n \n+#define PCI_MSIX_ENABLE 0x8000\n+\n static int\n virtio_read_caps(struct rte_pci_device *dev, struct virtio_hw *hw)\n {\n@@ -606,8 +608,17 @@ virtio_read_caps(struct rte_pci_device *dev, struct virtio_hw *hw)\n \t\t\tbreak;\n \t\t}\n \n-\t\tif (cap.cap_vndr == PCI_CAP_ID_MSIX)\n-\t\t\thw->use_msix = 1;\n+\t\tif (cap.cap_vndr == PCI_CAP_ID_MSIX) {\n+\t\t\t/* Transitional devices would also have this capability,\n+\t\t\t * that's why we also check if msix is enabled.\n+\t\t\t * 1st byte is cap ID; 2nd byte is the position of next\n+\t\t\t * cap; next two bytes are the flags.\n+\t\t\t */\n+\t\t\tuint16_t flags = ((uint16_t *)&cap)[1];\n+\n+\t\t\tif (flags & PCI_MSIX_ENABLE)\n+\t\t\t\thw->use_msix = 1;\n+\t\t}\n \n \t\tif (cap.cap_vndr != PCI_CAP_ID_VNDR) {\n \t\t\tPMD_INIT_LOG(DEBUG,\n", "prefixes": [ "dpdk-dev" ] }