Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/27197/?format=api
{ "id": 27197, "url": "http://patches.dpdk.org/api/patches/27197/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1501057992-11000-1-git-send-email-zhangsha.zhang@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1501057992-11000-1-git-send-email-zhangsha.zhang@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1501057992-11000-1-git-send-email-zhangsha.zhang@huawei.com", "date": "2017-07-26T08:33:12", "name": "[dpdk-dev,v2] bonding: fix the segfault caused by the race condition between master thread and eal-intr-thread", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5b893b3e460e757fc42633f08df1d07b21a649ac", "submitter": { "id": 749, "url": "http://patches.dpdk.org/api/people/749/?format=api", "name": "zhangsha (A)", "email": "zhangsha.zhang@huawei.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1501057992-11000-1-git-send-email-zhangsha.zhang@huawei.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/27197/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/27197/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id DD0E447CD;\n\tWed, 26 Jul 2017 10:33:34 +0200 (CEST)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n\tby dpdk.org (Postfix) with ESMTP id C1DAE388F\n\tfor <dev@dpdk.org>; Wed, 26 Jul 2017 10:33:30 +0200 (CEST)", "from 172.30.72.53 (EHLO DGGEML402-HUB.china.huawei.com)\n\t([172.30.72.53])\n\tby dggrg01-dlp.huawei.com (MOS 4.4.6-GA FastPath queued)\n\twith ESMTP id ATB38126; Wed, 26 Jul 2017 16:33:26 +0800 (CST)", "from localhost (10.177.220.209) by DGGEML402-HUB.china.huawei.com\n\t(10.3.17.38) with Microsoft SMTP Server id 14.3.301.0;\n\tWed, 26 Jul 2017 16:33:18 +0800" ], "From": "<zhangsha.zhang@huawei.com>", "To": "<dev@dpdk.org>, <declan.doherty@intel.com>", "CC": "<jerry.lilijun@huawei.com>, <zhoujingbin@huawei.com>, <caihe@huawei.com>,\n\tSha Zhang <zhangsha.zhang@huawei.com>", "Date": "Wed, 26 Jul 2017 16:33:12 +0800", "Message-ID": "<1501057992-11000-1-git-send-email-zhangsha.zhang@huawei.com>", "X-Mailer": "git-send-email 1.9.4.msysgit.1", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.177.220.209]", "X-CFilter-Loop": "Reflected", "X-Mirapoint-Virus-RAPID-Raw": "score=unknown(0),\n\trefid=str=0001.0A0B0206.597853D6.00EA, ss=1, re=0.000, recu=0.000,\n\treip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0,\n\tso=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32", "X-Mirapoint-Loop-Id": "df16512625c85d2bc39ab309ed5f4fc1", "Subject": "[dpdk-dev] [PATCH v2] bonding: fix the segfault caused by the race\n\tcondition between master thread and eal-intr-thread", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Sha Zhang <zhangsha.zhang@huawei.com>\n\nFunction slave_configure calls functions bond_ethdev_lsc_event_callback and\nslave_eth_dev->dev_ops->link_update to fix updating slave link status.\nBut there is a low probability that process may be crashed if the master\nthread, which create bonding-device, adds the active_slave_count of the\nbond to nozero while the rx_ring or tx_ring of it haven't been created.\n\nThis patch moves the functions bond_ethdev_lsc_event_callback and\nslave_eth_dev->dev_ops->link_update to eal-intr-thread to aviod the\ncompetition.\n\nFixes: 210903803f6e (\"net/bonding: fix updating slave link status\")\n\nSigned-off-by: Sha Zhang <zhangsha.zhang@huawei.com>\n---\n drivers/net/bonding/rte_eth_bond_pmd.c | 56 +++++++++++++++++++++++++++++-----\n 1 file changed, 49 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex a8d9780..c73ba00 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -55,6 +55,7 @@\n #define DEFAULT_POLLING_INTERVAL_10_MS (10)\n \n #define HASH_L4_PORTS(h) ((h)->src_port ^ (h)->dst_port)\n+#define BOND_LSC_DELAY_TIME_US (10 * 1000)\n \n /* Table for statistics in mode 5 TLB */\n static uint64_t tlb_last_obytets[RTE_MAX_ETHPORTS];\n@@ -1434,13 +1435,6 @@ struct bwg_slave {\n \t\t}\n \t}\n \n-\t/* If lsc interrupt is set, check initial slave's link status */\n-\tif (slave_eth_dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC) {\n-\t\tslave_eth_dev->dev_ops->link_update(slave_eth_dev, 0);\n-\t\tbond_ethdev_lsc_event_callback(slave_eth_dev->data->port_id,\n-\t\t\tRTE_ETH_EVENT_INTR_LSC, &bonded_eth_dev->data->port_id);\n-\t}\n-\n \treturn 0;\n }\n \n@@ -1511,6 +1505,51 @@ struct bwg_slave {\n static void\n bond_ethdev_promiscuous_enable(struct rte_eth_dev *eth_dev);\n \n+static void\n+bond_ethdev_slave_lsc_delay(void *cb_arg)\n+{\n+\tstruct rte_eth_dev *bonded_ethdev, *slave_dev;\n+\tstruct bond_dev_private *internals;\n+\n+\t/* Default value for polling slave found is true as we don't\n+\t * want todisable the polling thread if we cannot get the lock.\n+\t */\n+\tint i = 0;\n+\n+\tif (!cb_arg)\n+\t\treturn;\n+\n+\tbonded_ethdev = (struct rte_eth_dev *)cb_arg;\n+\tif (!bonded_ethdev->data->dev_started)\n+\t\treturn;\n+\n+\tinternals = (struct bond_dev_private *)bonded_ethdev->data->dev_private;\n+\tif (!rte_spinlock_trylock(&internals->lock)) {\n+\t\trte_eal_alarm_set(BOND_LSC_DELAY_TIME_US * 10,\n+\t\t\t\t bond_ethdev_slave_lsc_delay,\n+\t\t\t\t (void *)&rte_eth_devices[internals->port_id]);\n+\t\treturn;\n+\t}\n+\n+\tfor (i = 0; i < internals->slave_count; i++) {\n+\t\tslave_dev = &(rte_eth_devices[internals->slaves[i].port_id]);\n+\t\tif (slave_dev->data->dev_conf.intr_conf.lsc != 0) {\n+\t\t\tif (slave_dev->dev_ops &&\n+\t\t\t slave_dev->dev_ops->link_update)\n+\t\t\t\tslave_dev->dev_ops->link_update(slave_dev, 0);\n+\t\t\tbond_ethdev_lsc_event_callback(\n+\t\t\t\tinternals->slaves[i].port_id,\n+\t\t\t\tRTE_ETH_EVENT_INTR_LSC,\n+\t\t\t\t&bonded_ethdev->data->port_id);\n+\t\t}\n+\t}\n+\trte_spinlock_unlock(&internals->lock);\n+\tRTE_LOG(INFO, EAL,\n+\t\t\"bond %s(%u): slave num %d, current active slave num %d\\n\",\n+\t\tbonded_ethdev->data->name, bonded_ethdev->data->port_id,\n+\t\tinternals->slave_count, internals->active_slave_count);\n+}\n+\n static int\n bond_ethdev_start(struct rte_eth_dev *eth_dev)\n {\n@@ -1582,6 +1621,9 @@ struct bwg_slave {\n \t\t\t(void *)&rte_eth_devices[internals->port_id]);\n \t}\n \n+\trte_eal_alarm_set(BOND_LSC_DELAY_TIME_US, bond_ethdev_slave_lsc_delay,\n+\t\t\t (void *)&rte_eth_devices[internals->port_id]);\n+\n \tif (internals->user_defined_primary_port)\n \t\tbond_ethdev_primary_set(internals, internals->primary_port);\n \n", "prefixes": [ "dpdk-dev", "v2" ] }