Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/26776/?format=api
{ "id": 26776, "url": "http://patches.dpdk.org/api/patches/26776/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1499782773-12277-3-git-send-email-harry.van.haaren@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1499782773-12277-3-git-send-email-harry.van.haaren@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1499782773-12277-3-git-send-email-harry.van.haaren@intel.com", "date": "2017-07-11T14:19:28", "name": "[dpdk-dev,v5,2/7] service cores: EAL init changes", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "471be3ee04da8dbf6f87a7a731a31ed4fa55f3b2", "submitter": { "id": 317, "url": "http://patches.dpdk.org/api/people/317/?format=api", "name": "Van Haaren, Harry", "email": "harry.van.haaren@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1499782773-12277-3-git-send-email-harry.van.haaren@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/26776/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/26776/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 0B4255699;\n\tTue, 11 Jul 2017 16:19:42 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id C05053257\n\tfor <dev@dpdk.org>; Tue, 11 Jul 2017 16:19:36 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby orsmga104.jf.intel.com with ESMTP; 11 Jul 2017 07:19:36 -0700", "from silpixa00398672.ir.intel.com ([10.237.223.128])\n\tby fmsmga005.fm.intel.com with ESMTP; 11 Jul 2017 07:19:34 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.40,346,1496127600\"; d=\"scan'208\";a=\"125185167\"", "From": "Harry van Haaren <harry.van.haaren@intel.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, jerin.jacob@caviumnetworks.com,\n\tkeith.wiles@intel.com, bruce.richardson@intel.com,\n\tHarry van Haaren <harry.van.haaren@intel.com>", "Date": "Tue, 11 Jul 2017 15:19:28 +0100", "Message-Id": "<1499782773-12277-3-git-send-email-harry.van.haaren@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1499782773-12277-1-git-send-email-harry.van.haaren@intel.com>", "References": "<1499445667-32588-1-git-send-email-harry.van.haaren@intel.com>\n\t<1499782773-12277-1-git-send-email-harry.van.haaren@intel.com>", "Subject": "[dpdk-dev] [PATCH v5 2/7] service cores: EAL init changes", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This commit shows the changes required in rte_eal_init()\nto transparently launch the service threads. The threads\nare launched into the service worker functions here because\nafter rte_eal_init() the application is not gauranteed to\ncall any other DPDK API.\n\nAs the registration of services happens at initialization\ntime, the services that require CPU time are already available\nwhen we reach the end of rte_eal_init().\n\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\nAcked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>\n\n---\n\nv5:\n- Simplify EAL code, calling rte_service_start_with_defaults() (Jerin)\n- Added Ack from ML\n\nv4:\n- Added #include for service cores in BSD eal.c\n\nv2 comments:\n- Include BSD implementation (Jerin)\n- Move details of core-tracking into rte_service_lcore_add(Jerin)\n- Given there are changes other to suggested, not using Ack\n---\n lib/librte_eal/bsdapp/eal/eal.c | 18 ++++++++++++++++++\n lib/librte_eal/linuxapp/eal/eal.c | 18 ++++++++++++++++++\n 2 files changed, 36 insertions(+)", "diff": "diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c\nindex 05f0c1f..3e7a3a8 100644\n--- a/lib/librte_eal/bsdapp/eal/eal.c\n+++ b/lib/librte_eal/bsdapp/eal/eal.c\n@@ -72,6 +72,7 @@\n #include <rte_common.h>\n #include <rte_version.h>\n #include <rte_atomic.h>\n+#include <rte_service_component.h>\n #include <malloc_heap.h>\n \n #include \"eal_private.h\"\n@@ -653,6 +654,14 @@ rte_eal_init(int argc, char **argv)\n \trte_eal_mp_remote_launch(sync_func, NULL, SKIP_MASTER);\n \trte_eal_mp_wait_lcore();\n \n+\t/* initialize services so vdevs register service during bus_probe. */\n+\tret = rte_service_init();\n+\tif (ret) {\n+\t\trte_eal_init_alert(\"rte_service_init() failed\\n\");\n+\t\trte_errno = ENOEXEC;\n+\t\treturn -1;\n+\t}\n+\n \t/* Probe all the buses and devices/drivers on them */\n \tif (rte_bus_probe()) {\n \t\trte_eal_init_alert(\"Cannot probe devices\\n\");\n@@ -660,6 +669,15 @@ rte_eal_init(int argc, char **argv)\n \t\treturn -1;\n \t}\n \n+\t/* initialize default service/lcore mappings and start running. Ignore\n+\t * -ENOTSUP, as it indicates no service coremask passed to EAL.\n+\t */\n+\tret = rte_service_start_with_defaults();\n+\tif (ret < 0 && ret != -ENOTSUP) {\n+\t\trte_errno = ENOEXEC;\n+\t\treturn -1;\n+\t}\n+\n \trte_eal_mcfg_complete();\n \n \treturn fctret;\ndiff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c\nindex 7c78f2d..2914646 100644\n--- a/lib/librte_eal/linuxapp/eal/eal.c\n+++ b/lib/librte_eal/linuxapp/eal/eal.c\n@@ -78,6 +78,7 @@\n #include <rte_version.h>\n #include <rte_atomic.h>\n #include <malloc_heap.h>\n+#include <rte_service_component.h>\n \n #include \"eal_private.h\"\n #include \"eal_thread.h\"\n@@ -932,6 +933,14 @@ rte_eal_init(int argc, char **argv)\n \trte_eal_mp_remote_launch(sync_func, NULL, SKIP_MASTER);\n \trte_eal_mp_wait_lcore();\n \n+\t/* initialize services so vdevs register service during bus_probe. */\n+\tret = rte_service_init();\n+\tif (ret) {\n+\t\trte_eal_init_alert(\"rte_service_init() failed\\n\");\n+\t\trte_errno = ENOEXEC;\n+\t\treturn -1;\n+\t}\n+\n \t/* Probe all the buses and devices/drivers on them */\n \tif (rte_bus_probe()) {\n \t\trte_eal_init_alert(\"Cannot probe devices\\n\");\n@@ -939,6 +948,15 @@ rte_eal_init(int argc, char **argv)\n \t\treturn -1;\n \t}\n \n+\t/* initialize default service/lcore mappings and start running. Ignore\n+\t * -ENOTSUP, as it indicates no service coremask passed to EAL.\n+\t */\n+\tret = rte_service_start_with_defaults();\n+\tif (ret < 0 && ret != -ENOTSUP) {\n+\t\trte_errno = ENOEXEC;\n+\t\treturn -1;\n+\t}\n+\n \trte_eal_mcfg_complete();\n \n \treturn fctret;\n", "prefixes": [ "dpdk-dev", "v5", "2/7" ] }