Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 23638,
    "url": "http://patches.dpdk.org/api/patches/23638/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1492150230-131946-1-git-send-email-jianfeng.tan@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1492150230-131946-1-git-send-email-jianfeng.tan@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1492150230-131946-1-git-send-email-jianfeng.tan@intel.com",
    "date": "2017-04-14T06:10:30",
    "name": "[dpdk-dev] net/virtio-user: fix LSC not working",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "a387e1797489ecdace098294d9a08f76476c74d5",
    "submitter": {
        "id": 313,
        "url": "http://patches.dpdk.org/api/people/313/?format=api",
        "name": "Jianfeng Tan",
        "email": "jianfeng.tan@intel.com"
    },
    "delegate": {
        "id": 355,
        "url": "http://patches.dpdk.org/api/users/355/?format=api",
        "username": "yliu",
        "first_name": "Yuanhan",
        "last_name": "Liu",
        "email": "yuanhan.liu@linux.intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1492150230-131946-1-git-send-email-jianfeng.tan@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/23638/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/23638/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id A72F037B2;\n\tFri, 14 Apr 2017 08:09:46 +0200 (CEST)",
            "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 0A6DE378B\n\tfor <dev@dpdk.org>; Fri, 14 Apr 2017 08:09:44 +0200 (CEST)",
            "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga105.fm.intel.com with ESMTP; 13 Apr 2017 23:09:43 -0700",
            "from dpdk06.sh.intel.com ([10.239.129.195])\n\tby orsmga002.jf.intel.com with ESMTP; 13 Apr 2017 23:09:42 -0700"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.37,197,1488873600\"; d=\"scan'208\";a=\"74005059\"",
        "From": "Jianfeng Tan <jianfeng.tan@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "yuanhan.liu@linux.intel.com,\n\tJianfeng Tan <jianfeng.tan@intel.com>",
        "Date": "Fri, 14 Apr 2017 06:10:30 +0000",
        "Message-Id": "<1492150230-131946-1-git-send-email-jianfeng.tan@intel.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "Subject": "[dpdk-dev] [PATCH] net/virtio-user: fix LSC not working",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Previously, we miss to set intr_handle->fd which will be used as\ntarget file for epoll to check LSC.\n\nAs a result, stdin (0) is used and intr thread keeps busy whenever\ndata comes from stdin.\n\nTo fix this, we use vhostfd as the target file for epoll to check\nthe link status change events. And we move intr_handle initialization\nafter vhost backend settup to make sure vhostfd is initialized.\n\nFixes: 35c4f8554833 (\"net/virtio-user: support to report net status\")\n\nSigned-off-by: Jianfeng Tan <jianfeng.tan@intel.com>\n---\n drivers/net/virtio/virtio_user/virtio_user_dev.c | 19 ++++++++++++-------\n 1 file changed, 12 insertions(+), 7 deletions(-)",
    "diff": "diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c\nindex c9e8ac5..450404b 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c\n@@ -271,6 +271,8 @@ virtio_user_fill_intr_handle(struct virtio_user_dev *dev)\n \teth_dev->intr_handle->nb_efd = dev->max_queue_pairs;\n \teth_dev->intr_handle->max_intr = dev->max_queue_pairs + 1;\n \teth_dev->intr_handle->type = RTE_INTR_HANDLE_VDEV;\n+\tif (dev->vhostfd >= 0)\n+\t\teth_dev->intr_handle->fd = dev->vhostfd;\n \n \treturn 0;\n }\n@@ -284,12 +286,6 @@ virtio_user_dev_setup(struct virtio_user_dev *dev)\n \tdev->vhostfds = NULL;\n \tdev->tapfds = NULL;\n \n-\tif (virtio_user_dev_init_notify(dev) < 0)\n-\t\treturn -1;\n-\n-\tif (virtio_user_fill_intr_handle(dev) < 0)\n-\t\treturn -1;\n-\n \tif (is_vhost_user_by_type(dev->path)) {\n \t\tdev->ops = &ops_user;\n \t} else {\n@@ -308,7 +304,16 @@ virtio_user_dev_setup(struct virtio_user_dev *dev)\n \t\t}\n \t}\n \n-\treturn dev->ops->setup(dev);\n+\tif (dev->ops->setup(dev) < 0)\n+\t\treturn -1;\n+\n+\tif (virtio_user_dev_init_notify(dev) < 0)\n+\t\treturn -1;\n+\n+\tif (virtio_user_fill_intr_handle(dev) < 0)\n+\t\treturn -1;\n+\n+\treturn 0;\n }\n \n /* Use below macro to filter features from vhost backend */\n",
    "prefixes": [
        "dpdk-dev"
    ]
}