Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 23350,
    "url": "http://patches.dpdk.org/api/patches/23350/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1491631001-145204-3-git-send-email-jia.guo@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1491631001-145204-3-git-send-email-jia.guo@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1491631001-145204-3-git-send-email-jia.guo@intel.com",
    "date": "2017-04-08T05:56:41",
    "name": "[dpdk-dev,dpdk-dev,v4,3/3] test: enable HW CRC strip by default",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "edf8a54e6ada365d66a19be7a84d1b1bffc822be",
    "submitter": {
        "id": 507,
        "url": "http://patches.dpdk.org/api/people/507/?format=api",
        "name": "Guo, Jia",
        "email": "jia.guo@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1491631001-145204-3-git-send-email-jia.guo@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/23350/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/23350/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 1B390559C;\n\tSat,  8 Apr 2017 07:59:27 +0200 (CEST)",
            "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id F062EF94;\n\tSat,  8 Apr 2017 07:59:20 +0200 (CEST)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga105.fm.intel.com with ESMTP; 07 Apr 2017 22:59:20 -0700",
            "from jeffguo-s2600wt2.sh.intel.com ([10.239.129.150])\n\tby fmsmga002.fm.intel.com with ESMTP; 07 Apr 2017 22:59:19 -0700"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos; i=\"5.37,170,1488873600\"; d=\"scan'208\";\n\ta=\"1153194068\"",
        "From": "Jeff Guo <jia.guo@intel.com>",
        "To": "helin.zhang@intel.com,\n\tjingjing.wu@intel.com",
        "Cc": "dev@dpdk.org,\n\tjia.guo@intel.com,\n\tstable@dpdk.org",
        "Date": "Sat,  8 Apr 2017 13:56:41 +0800",
        "Message-Id": "<1491631001-145204-3-git-send-email-jia.guo@intel.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1491631001-145204-1-git-send-email-jia.guo@intel.com>",
        "References": "<1490247839-110341-3-git-send-email-jia.guo@intel.com>\n\t<1491631001-145204-1-git-send-email-jia.guo@intel.com>",
        "Subject": "[dpdk-dev] [dpdk-dev v4 3/3] test: enable HW CRC strip by default",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Since VF can not disable/enable HW CRC strip for non-DPDK PF drivers,\nand kernel driver almost default enable that feature, if disable it in\ntest app's rxmode, VF driver will report the VF launch failure. So\nthis patch default to enable HW CRC strip to let VF launch successful.\n\nSigned-off-by: Jeff Guo <jia.guo@intel.com>\nAcked-by: Jingjing Wu <jingjing.wu@intel.com>\nCc: stable@dpdk.org\n---\nv4: modify commit log\n---\n test/test-pipeline/init.c             | 2 +-\n test/test/test_kni.c                  | 2 +-\n test/test/test_link_bonding.c         | 4 ++--\n test/test/test_link_bonding_mode4.c   | 2 +-\n test/test/test_link_bonding_rssconf.c | 4 ++--\n test/test/test_pmd_perf.c             | 2 +-\n 6 files changed, 8 insertions(+), 8 deletions(-)",
    "diff": "diff --git a/test/test-pipeline/init.c b/test/test-pipeline/init.c\nindex aef082f..00dbc27 100644\n--- a/test/test-pipeline/init.c\n+++ b/test/test-pipeline/init.c\n@@ -105,7 +105,7 @@ static struct rte_eth_conf port_conf = {\n \t\t.hw_ip_checksum = 1, /* IP checksum offload enabled */\n \t\t.hw_vlan_filter = 0, /* VLAN filtering disabled */\n \t\t.jumbo_frame    = 0, /* Jumbo Frame Support disabled */\n-\t\t.hw_strip_crc   = 0, /* CRC stripped by hardware */\n+\t\t.hw_strip_crc   = 1, /* CRC stripped by hardware */\n \t},\n \t.rx_adv_conf = {\n \t\t.rss_conf = {\ndiff --git a/test/test/test_kni.c b/test/test/test_kni.c\nindex 309741c..db17fdf 100644\n--- a/test/test/test_kni.c\n+++ b/test/test/test_kni.c\n@@ -92,7 +92,7 @@ static const struct rte_eth_conf port_conf = {\n \t\t.hw_ip_checksum = 0,\n \t\t.hw_vlan_filter = 0,\n \t\t.jumbo_frame = 0,\n-\t\t.hw_strip_crc = 0,\n+\t\t.hw_strip_crc = 1,\n \t},\n \t.txmode = {\n \t\t.mq_mode = ETH_DCB_NONE,\ndiff --git a/test/test/test_link_bonding.c b/test/test/test_link_bonding.c\nindex 3229660..52d2d05 100644\n--- a/test/test/test_link_bonding.c\n+++ b/test/test/test_link_bonding.c\n@@ -172,7 +172,7 @@ struct rte_eth_rxmode rx_mode = {\n \t.hw_vlan_strip  = 1, /**< VLAN strip enabled. */\n \t.hw_vlan_extend = 0, /**< Extended VLAN disabled. */\n \t.jumbo_frame    = 0, /**< Jumbo Frame Support disabled. */\n-\t.hw_strip_crc   = 0, /**< CRC stripping by hardware disabled. */\n+\t.hw_strip_crc   = 1, /**< CRC stripping by hardware enabled. */\n };\n \n struct rte_fdir_conf fdir_conf = {\n@@ -191,7 +191,7 @@ static struct rte_eth_conf default_pmd_conf = {\n \t\t.hw_ip_checksum = 0, /**< IP checksum offload enabled */\n \t\t.hw_vlan_filter = 0, /**< VLAN filtering disabled */\n \t\t.jumbo_frame    = 0, /**< Jumbo Frame Support disabled */\n-\t\t.hw_strip_crc   = 0, /**< CRC stripped by hardware */\n+\t\t.hw_strip_crc   = 1, /**< CRC stripped by hardware */\n \t},\n \t.txmode = {\n \t\t.mq_mode = ETH_MQ_TX_NONE,\ndiff --git a/test/test/test_link_bonding_mode4.c b/test/test/test_link_bonding_mode4.c\nindex 15091b1..106ec62 100644\n--- a/test/test/test_link_bonding_mode4.c\n+++ b/test/test/test_link_bonding_mode4.c\n@@ -143,7 +143,7 @@ static struct rte_eth_conf default_pmd_conf = {\n \t\t.hw_ip_checksum = 0, /**< IP checksum offload enabled */\n \t\t.hw_vlan_filter = 0, /**< VLAN filtering disabled */\n \t\t.jumbo_frame    = 0, /**< Jumbo Frame Support disabled */\n-\t\t.hw_strip_crc   = 0, /**< CRC stripped by hardware */\n+\t\t.hw_strip_crc   = 1, /**< CRC stripped by hardware */\n \t},\n \t.txmode = {\n \t\t.mq_mode = ETH_MQ_TX_NONE,\ndiff --git a/test/test/test_link_bonding_rssconf.c b/test/test/test_link_bonding_rssconf.c\nindex 9034f62..ba7163e 100644\n--- a/test/test/test_link_bonding_rssconf.c\n+++ b/test/test/test_link_bonding_rssconf.c\n@@ -116,7 +116,7 @@ static struct rte_eth_conf default_pmd_conf = {\n \t\t.hw_ip_checksum = 0, /**< IP checksum offload enabled */\n \t\t.hw_vlan_filter = 0, /**< VLAN filtering disabled */\n \t\t.jumbo_frame    = 0, /**< Jumbo Frame Support disabled */\n-\t\t.hw_strip_crc   = 0, /**< CRC stripped by hardware */\n+\t\t.hw_strip_crc   = 1, /**< CRC stripped by hardware */\n \t},\n \t.txmode = {\n \t\t.mq_mode = ETH_MQ_TX_NONE,\n@@ -133,7 +133,7 @@ static struct rte_eth_conf rss_pmd_conf = {\n \t\t.hw_ip_checksum = 0, /**< IP checksum offload enabled */\n \t\t.hw_vlan_filter = 0, /**< VLAN filtering disabled */\n \t\t.jumbo_frame    = 0, /**< Jumbo Frame Support disabled */\n-\t\t.hw_strip_crc   = 0, /**< CRC stripped by hardware */\n+\t\t.hw_strip_crc   = 1, /**< CRC stripped by hardware */\n \t},\n \t.txmode = {\n \t\t.mq_mode = ETH_MQ_TX_NONE,\ndiff --git a/test/test/test_pmd_perf.c b/test/test/test_pmd_perf.c\nindex e055aa0..1ffd65a 100644\n--- a/test/test/test_pmd_perf.c\n+++ b/test/test/test_pmd_perf.c\n@@ -100,7 +100,7 @@ static struct rte_eth_conf port_conf = {\n \t\t.hw_vlan_strip  = 0, /**< VLAN strip enabled. */\n \t\t.hw_vlan_extend = 0, /**< Extended VLAN disabled. */\n \t\t.jumbo_frame    = 0, /**< Jumbo Frame Support disabled */\n-\t\t.hw_strip_crc   = 0, /**< CRC stripped by hardware */\n+\t\t.hw_strip_crc   = 1, /**< CRC stripped by hardware */\n \t\t.enable_scatter = 0, /**< scatter rx disabled */\n \t},\n \t.txmode = {\n",
    "prefixes": [
        "dpdk-dev",
        "dpdk-dev",
        "v4",
        "3/3"
    ]
}