Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 23345,
    "url": "http://patches.dpdk.org/api/patches/23345/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20170407174457.4180-12-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20170407174457.4180-12-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20170407174457.4180-12-stephen@networkplumber.org",
    "date": "2017-04-07T17:44:57",
    "name": "[dpdk-dev,11/11] test: remove unnecessary cast of void pointer",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "a79be6ef9a2f244e1538bb8ef82ffb5dff0d60c6",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20170407174457.4180-12-stephen@networkplumber.org/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/23345/comments/",
    "check": "warning",
    "checks": "http://patches.dpdk.org/api/patches/23345/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 7E2A2D1E4;\n\tFri,  7 Apr 2017 19:45:32 +0200 (CEST)",
            "from mail-it0-f45.google.com (mail-it0-f45.google.com\n\t[209.85.214.45]) by dpdk.org (Postfix) with ESMTP id 6EF5BCFA8\n\tfor <dev@dpdk.org>; Fri,  7 Apr 2017 19:45:16 +0200 (CEST)",
            "by mail-it0-f45.google.com with SMTP id y18so46691856itc.1\n\tfor <dev@dpdk.org>; Fri, 07 Apr 2017 10:45:16 -0700 (PDT)",
            "from plumbers-lap.home.lan ([66.171.166.114])\n\tby smtp.gmail.com with ESMTPSA id\n\ts40sm4649675ite.18.2017.04.07.10.45.14\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 07 Apr 2017 10:45:14 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=70QfuJgDM+Qkqz1VOKlfbRkmsdPgTHXWrx/hThH7axs=;\n\tb=xya1ndmw2EMoAZ1QH+LhXtHN0nUKBsg2OvIfuwURXeN/jdF7n22GvTgchCYdXt81dS\n\tRDHpabJyfCw8D90fiZAMyCElF26wS1HkW2wWt3Wlgwk66qZtg3OCdZnnzBHuWe47ILcu\n\tqMD+oed6c6aOtnY2oXWXK2S4K0BmLWe+17kWGdy3lok9/wRw9AdpX8Wx3rt19QtImfgD\n\tWCoFi8qjcZ8/Bw3C3emFwVQPNS4dADH7gLVSbv8b3xDDxE6fUVyDM7mpsNTuTvNrfdqG\n\tb5Tfhhs2tP71x0hjZbhZjnCfn4pqDwdoEFhVXrKEy/vRd65keLDl04sC39ubHaEQWbsY\n\t4/og==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=70QfuJgDM+Qkqz1VOKlfbRkmsdPgTHXWrx/hThH7axs=;\n\tb=nceLuoHT1HkSeggC351TjDrJhbhyfBBIgg0LGDEqgEWRnk1kgMKLkFmECUAu+nqLHM\n\tNmw1GbIRdxGFNQBbvqpAt1dXewpFZrm/nzd7D0j7fNVHYuHR2lLT3K21UZqj0f9i9u7Y\n\tM2t50sKa8wwfLkIe/LGSKAaIkLzWtL5wygVjBEX6fRX6TD2kZmYI/Cc66EXNs9t0AIg1\n\tIeVNHn1WJUP/KcsteFtYk0mp/IUw9+cfTw142eNc8ar6gkgrmIfikaWZtkMsYYP2d59C\n\tKQVA/iLMw/H6eKP4QCu3KmY7REc0U8Fxed5qimS2s7zRWj/KlE4lZWIXJy9lT6YeA0AE\n\tXi8g==",
        "X-Gm-Message-State": "AN3rC/5jykIk5OQetaF66pIUSZ8fFvrXFZ5wO3IjxQ1kfATC3EMPihPM\n\tFdHx8Nf/MfosSEVfRSA=",
        "X-Received": "by 10.36.115.146 with SMTP id y140mr607157itb.21.1491587115345; \n\tFri, 07 Apr 2017 10:45:15 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>",
        "Date": "Fri,  7 Apr 2017 13:44:57 -0400",
        "Message-Id": "<20170407174457.4180-12-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.11.0",
        "In-Reply-To": "<20170407174457.4180-1-stephen@networkplumber.org>",
        "References": "<20170407174457.4180-1-stephen@networkplumber.org>",
        "Subject": "[dpdk-dev] [PATCH 11/11] test: remove unnecessary cast of void\n\tpointer",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Remove unnecessary casts of void * pointers to a specfic type.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n test/test-pipeline/pipeline_hash.c | 2 +-\n test/test/test_efd.c               | 2 +-\n test/test/test_interrupts.c        | 4 ++--\n test/test/test_mbuf.c              | 2 +-\n test/test/test_table.c             | 2 +-\n test/test/test_table_acl.c         | 2 +-\n test/test/test_table_pipeline.c    | 2 +-\n test/test/virtual_pmd.c            | 4 ++--\n 8 files changed, 10 insertions(+), 10 deletions(-)",
    "diff": "diff --git a/test/test-pipeline/pipeline_hash.c b/test/test-pipeline/pipeline_hash.c\nindex 0c6e04f78..991e381e2 100644\n--- a/test/test-pipeline/pipeline_hash.c\n+++ b/test/test-pipeline/pipeline_hash.c\n@@ -480,7 +480,7 @@ uint64_t test_hash(\n \t__attribute__((unused)) uint32_t key_size,\n \t__attribute__((unused)) uint64_t seed)\n {\n-\tuint32_t *k32 = (uint32_t *) key;\n+\tuint32_t *k32 = key;\n \tuint32_t ip_dst = rte_be_to_cpu_32(k32[0]);\n \tuint64_t signature = (ip_dst >> 2) | ((ip_dst & 0x3) << 30);\n \ndiff --git a/test/test/test_efd.c b/test/test/test_efd.c\nindex de49e1d7e..544306166 100644\n--- a/test/test/test_efd.c\n+++ b/test/test/test_efd.c\n@@ -306,7 +306,7 @@ static int test_five_keys(void)\n \t\tkey_array[i] = &keys[i];\n \n \trte_efd_lookup_bulk(handle, test_socket_id, 5,\n-\t\t\t(const void **) (void *) &key_array, result);\n+\t\t\t(void *) &key_array, result);\n \n \tfor (i = 0; i < 5; i++) {\n \t\tTEST_ASSERT_EQUAL(result[i], data[i],\ndiff --git a/test/test/test_interrupts.c b/test/test/test_interrupts.c\nindex 5377292b5..e0229e5ee 100644\n--- a/test/test/test_interrupts.c\n+++ b/test/test/test_interrupts.c\n@@ -201,7 +201,7 @@ test_interrupt_handle_compare(struct rte_intr_handle *intr_handle_l,\n static void\n test_interrupt_callback(void *arg)\n {\n-\tstruct rte_intr_handle *intr_handle = (struct rte_intr_handle *)arg;\n+\tstruct rte_intr_handle *intr_handle = arg;\n \tif (test_intr_type >= TEST_INTERRUPT_HANDLE_MAX) {\n \t\tprintf(\"invalid interrupt type\\n\");\n \t\tflag = -1;\n@@ -233,7 +233,7 @@ test_interrupt_callback(void *arg)\n static void\n test_interrupt_callback_1(void *arg)\n {\n-\tstruct rte_intr_handle *intr_handle = (struct rte_intr_handle *)arg;\n+\tstruct rte_intr_handle *intr_handle = arg;\n \tif (test_interrupt_handle_sanity_check(intr_handle) < 0) {\n \t\tprintf(\"null or invalid intr_handle for %s\\n\", __func__);\n \t\tflag = -1;\ndiff --git a/test/test/test_mbuf.c b/test/test/test_mbuf.c\nindex a2e9bc6cf..d3ea812e5 100644\n--- a/test/test/test_mbuf.c\n+++ b/test/test/test_mbuf.c\n@@ -692,7 +692,7 @@ test_refcnt_slave(__attribute__((unused)) void *arg)\n \twhile (refcnt_stop_slaves == 0) {\n \t\tif (rte_ring_dequeue(refcnt_mbuf_ring, &mp) == 0) {\n \t\t\tfree++;\n-\t\t\trte_pktmbuf_free((struct rte_mbuf *)mp);\n+\t\t\trte_pktmbuf_free(mp);\n \t\t}\n \t}\n \ndiff --git a/test/test/test_table.c b/test/test/test_table.c\nindex 1faa0a6d8..9e9eed886 100644\n--- a/test/test/test_table.c\n+++ b/test/test/test_table.c\n@@ -75,7 +75,7 @@ uint64_t pipeline_test_hash(void *key,\n \t\t__attribute__((unused)) uint32_t key_size,\n \t\t__attribute__((unused)) uint64_t seed)\n {\n-\tuint32_t *k32 = (uint32_t *) key;\n+\tuint32_t *k32 = key;\n \tuint32_t ip_dst = rte_be_to_cpu_32(k32[0]);\n \tuint64_t signature = ip_dst;\n \ndiff --git a/test/test/test_table_acl.c b/test/test/test_table_acl.c\nindex 4d43be7bc..08c100ffa 100644\n--- a/test/test/test_table_acl.c\n+++ b/test/test/test_table_acl.c\n@@ -720,7 +720,7 @@ test_pipeline_single_filter(int expected_count)\n \t\t} else {\n \t\t\tprintf(\"Got %d object(s) from ring %d!\\n\", ret, i);\n \t\t\tfor (j = 0; j < ret; j++) {\n-\t\t\t\tmbuf = (struct rte_mbuf *)objs[j];\n+\t\t\t\tmbuf = objs[j];\n \t\t\t\trte_hexdump(stdout, \"mbuf\",\n \t\t\t\t\trte_pktmbuf_mtod(mbuf, char *), 64);\n \t\t\t\trte_pktmbuf_free(mbuf);\ndiff --git a/test/test/test_table_pipeline.c b/test/test/test_table_pipeline.c\nindex b58aa5d12..a6fef721d 100644\n--- a/test/test/test_table_pipeline.c\n+++ b/test/test/test_table_pipeline.c\n@@ -501,7 +501,7 @@ test_pipeline_single_filter(int test_type, int expected_count)\n \t\telse {\n \t\t\tprintf(\"Got %d object(s) from ring %d!\\n\", ret, i);\n \t\t\tfor (j = 0; j < ret; j++) {\n-\t\t\t\tmbuf = (struct rte_mbuf *)objs[j];\n+\t\t\t\tmbuf = objs[j];\n \t\t\t\trte_hexdump(stdout, \"Object:\",\n \t\t\t\t\trte_pktmbuf_mtod(mbuf, char *),\n \t\t\t\t\tmbuf->data_len);\ndiff --git a/test/test/virtual_pmd.c b/test/test/virtual_pmd.c\nindex b209355af..b8802cd6a 100644\n--- a/test/test/virtual_pmd.c\n+++ b/test/test/virtual_pmd.c\n@@ -366,7 +366,7 @@ static uint16_t\n virtual_ethdev_tx_burst_success(void *queue, struct rte_mbuf **bufs,\n \t\tuint16_t nb_pkts)\n {\n-\tstruct virtual_ethdev_queue *tx_q = (struct virtual_ethdev_queue *)queue;\n+\tstruct virtual_ethdev_queue *tx_q = queue;\n \n \tstruct rte_eth_dev *vrtl_eth_dev;\n \tstruct virtual_ethdev_private *dev_private;\n@@ -402,7 +402,7 @@ virtual_ethdev_tx_burst_fail(void *queue, struct rte_mbuf **bufs,\n \n \tint i;\n \n-\ttx_q = (struct virtual_ethdev_queue *)queue;\n+\ttx_q = queue;\n \tvrtl_eth_dev = &rte_eth_devices[tx_q->port_id];\n \tdev_private = vrtl_eth_dev->data->dev_private;\n \n",
    "prefixes": [
        "dpdk-dev",
        "11/11"
    ]
}