Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/23296/?format=api
{ "id": 23296, "url": "http://patches.dpdk.org/api/patches/23296/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20170406141455.14894-1-olivier.matz@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20170406141455.14894-1-olivier.matz@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20170406141455.14894-1-olivier.matz@6wind.com", "date": "2017-04-06T14:14:55", "name": "[dpdk-dev] mk: fix lib filtering", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d8ef2fb2511c2df62e4898e518041c5e4e615a3e", "submitter": { "id": 8, "url": "http://patches.dpdk.org/api/people/8/?format=api", "name": "Olivier Matz", "email": "olivier.matz@6wind.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20170406141455.14894-1-olivier.matz@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/23296/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/23296/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id F0108374C;\n\tThu, 6 Apr 2017 16:14:40 +0200 (CEST)", "from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com\n\t[62.23.145.76]) by dpdk.org (Postfix) with ESMTP id DB931326C;\n\tThu, 6 Apr 2017 16:14:39 +0200 (CEST)", "from glumotte.dev.6wind.com (unknown [10.16.0.195])\n\tby proxy.6wind.com (Postfix) with ESMTP id A7C8A29879;\n\tThu, 6 Apr 2017 16:14:34 +0200 (CEST)" ], "From": "Olivier Matz <olivier.matz@6wind.com>", "To": "dev@dpdk.org", "Cc": "thomas.monjalon@6wind.com,\n\tstable@dpdk.org", "Date": "Thu, 6 Apr 2017 16:14:55 +0200", "Message-Id": "<20170406141455.14894-1-olivier.matz@6wind.com>", "X-Mailer": "git-send-email 2.11.0", "Subject": "[dpdk-dev] [PATCH] mk: fix lib filtering", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "I get the following error when linking the test application:\n build/lib/librte_pmd_thunderx_nicvf.a(nicvf_hw.o):\n In function `nicvf_qsize_regbit':\n drivers/net/thunderx/base/nicvf_hw.c:451: undefined reference to `log2'\n build/lib/librte_pmd_thunderx_nicvf.a(nicvf_hw.o):\n In function `nicvf_rss_reta_update':\n drivers/net/thunderx/base/nicvf_hw.c:804: undefined reference to `log2'\n build/lib/librte_pmd_thunderx_nicvf.a(nicvf_hw.o):\n In function `nicvf_rss_reta_query':\n drivers/net/thunderx/base/nicvf_hw.c:825: undefined reference to `log2'\n\nWhile I don't know why it does not happen for a default build, the error\ncan be explained. The link command line is:\n\n gcc -o test ... *.o ... -Wl,-lm ... -Wl,-lrte_pmd_thunderx_nicvf ...\n\nrte_pmd_thunderx_nicvf needs the math library, and it should be\nadded after. This is not the case because the test application also\nadds the math library.\n\nThe makefile already filters the libraries, but it keeps the first\noccurrence of the lib. Instead, the last one should be kept.\n\nFixes: edf4d331dcdb (\"mk: eliminate duplicates from libraries list\")\n\nCc: stable@dpdk.org\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\n---\n mk/rte.app.mk | 19 +++++++++++++++----\n 1 file changed, 15 insertions(+), 4 deletions(-)", "diff": "diff --git a/mk/rte.app.mk b/mk/rte.app.mk\nindex fcc3a5795..4c659e971 100644\n--- a/mk/rte.app.mk\n+++ b/mk/rte.app.mk\n@@ -186,10 +186,21 @@ _LDLIBS-y += $(EXECENV_LDLIBS)\n \n LDLIBS += $(_LDLIBS-y) $(CPU_LDLIBS) $(EXTRA_LDLIBS)\n \n-# Eliminate duplicates without sorting\n-LDLIBS := $(shell echo $(LDLIBS) | \\\n-\tawk '{for (i = 1; i <= NF; i++) { \\\n-\t\tif ($$i !~ /^-l.*/ || !seen[$$i]++) print $$i }}')\n+# all the words except the first one\n+allbutfirst = $(wordlist 2,$(words $(1)),$(1))\n+\n+# Eliminate duplicates without sorting, only keep the last occurrence\n+filter-libs = \\\n+\t$(if $(1),$(strip\\\n+\t\t$(if \\\n+\t\t\t$(and \\\n+\t\t\t\t$(filter $(firstword $(1)),$(call allbutfirst,$(1))),\\\n+\t\t\t\t$(filter -l%,$(firstword $(1)))),\\\n+\t\t\t,\\\n+\t\t\t$(firstword $(1))) \\\n+\t\t$(call filter-libs,$(call allbutfirst,$(1)))))\n+\n+LDLIBS := $(call filter-libs,$(LDLIBS))\n \n ifeq ($(RTE_DEVEL_BUILD)$(CONFIG_RTE_BUILD_SHARED_LIB),yy)\n LDFLAGS += -rpath=$(RTE_SDK_BIN)/lib\n", "prefixes": [ "dpdk-dev" ] }