Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/23284/?format=api
{ "id": 23284, "url": "http://patches.dpdk.org/api/patches/23284/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1491479991-26802-1-git-send-email-i.maximets@samsung.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1491479991-26802-1-git-send-email-i.maximets@samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1491479991-26802-1-git-send-email-i.maximets@samsung.com", "date": "2017-04-06T11:59:51", "name": "[dpdk-dev] net/bonding: remove all slaves on close", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "50a4a851c434dac2ae6c51f72cfa24b5425f73fd", "submitter": { "id": 323, "url": "http://patches.dpdk.org/api/people/323/?format=api", "name": "Ilya Maximets", "email": "i.maximets@samsung.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1491479991-26802-1-git-send-email-i.maximets@samsung.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/23284/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/23284/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 95ECD2A6C;\n\tThu, 6 Apr 2017 14:00:06 +0200 (CEST)", "from mailout3.w1.samsung.com (mailout3.w1.samsung.com\n\t[210.118.77.13]) by dpdk.org (Postfix) with ESMTP id 6E8F829C7\n\tfor <dev@dpdk.org>; Thu, 6 Apr 2017 14:00:05 +0200 (CEST)", "from eucas1p2.samsung.com (unknown [182.198.249.207])\n\tby mailout3.w1.samsung.com\n\t(Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5\n\t2014)) with ESMTP id <0ONZ00IWWLC3JM90@mailout3.w1.samsung.com> for\n\tdev@dpdk.org; Thu, 06 Apr 2017 13:00:03 +0100 (BST)", "from eusmges1.samsung.com (unknown [203.254.199.239])\n\tby\teucas1p2.samsung.com (KnoxPortal) with ESMTP\n\tid\t20170406120002eucas1p22f723171ff4ee2dc3441059c85721226~yzSkIfW4r0582605826eucas1p2x;\n\tThu, 6 Apr 2017 12:00:02 +0000 (GMT)", "from eucas1p1.samsung.com ( [182.198.249.206])\n\tby\teusmges1.samsung.com (EUCPMTA) with SMTP id FA.DD.14140.5CD26E85;\n\tThu, 6\tApr 2017 13:00:05 +0100 (BST)", "from eusmgms1.samsung.com (unknown [182.198.249.179])\n\tby\teucas1p2.samsung.com (KnoxPortal) with ESMTP\n\tid\t20170406120001eucas1p2a05d5006e760aee92254fe462c6c8bd2~yzSjVWKIN1299112991eucas1p2W;\n\tThu, 6 Apr 2017 12:00:01 +0000 (GMT)", "from eusync1.samsung.com ( [203.254.199.211])\n\tby\teusmgms1.samsung.com (EUCPMTA) with SMTP id 51.DC.17452.93E26E85;\n\tThu, 6\tApr 2017 13:02:01 +0100 (BST)", "from imaximets.rnd.samsung.ru ([106.109.129.180])\n\tby\teusync1.samsung.com\n\t(Oracle Communications Messaging Server 7.0.5.31.0 64bit\t(built May 5\n\t2014)) with ESMTPA id <0ONZ00EEYLBW9F60@eusync1.samsung.com>;\tThu,\n\t06 Apr 2017 13:00:01 +0100 (BST)" ], "X-AuditID": "cbfec7ef-f796a6d00000373c-be-58e62dc5076b", "From": "Ilya Maximets <i.maximets@samsung.com>", "To": "dev@dpdk.org, Declan Doherty <declan.doherty@intel.com>", "Cc": "Heetae Ahn <heetae82.ahn@samsung.com>, Eric Kinzie <ehkinzie@gmail.com>, \n\tBernard Iremonger <bernard.iremonger@intel.com>,\n\tJan Blunck <jblunck@infradead.org>,\n\tIlya Maximets <i.maximets@samsung.com>", "Date": "Thu, 06 Apr 2017 14:59:51 +0300", "Message-id": "<1491479991-26802-1-git-send-email-i.maximets@samsung.com>", "X-Mailer": "git-send-email 2.7.4", "X-Brightmail-Tracker": [ "H4sIAAAAAAAAA+NgFtrNIsWRmVeSWpSXmKPExsWy7djPc7pHdZ9FGFzZym+xuVHY4s2DJhaL\n\td5+2M1nMO7WX3WLa59vsFlfaf7JbtD5sZXJg9/i1YCmrx85Zd9k9Nq/Q8li85yWTR9+WVYwB\n\trFFcNimpOZllqUX6dglcGXff72IqeMpTsaGtjbGB8RxXFyMHh4SAicSeE+ZdjJxAppjEhXvr\n\t2boYuTiEBJYxSlx/vZcdwvnMKHFh7Rl2iCoTiX8fJyJU3Zl3hwXCaWaSWNa0iRWkik1AR+LU\n\t6iOMILaIgDVQ9wqwDmaBM4wSrbNvs4DsFhawkFi02AKkhkVAVaL1yh4WEJtXwE3i4eYDrBDb\n\t5CRunutkhrBvs0n8vyEAcbasxKYDUGEXidUrtjNB2MISr45vgTpURqKz4yATyFoJgWZGiYZV\n\tlxghnAmMEl+al0N12EucunkVzGYW4JOYtG06M8QCXomONiGIEg+JKz8usEDYjhJz+zeA3SYk\n\tECvxrGEq+wRG6QWMDKsYRVJLi3PTU4sN9YoTc4tL89L1kvNzNzECo/T0v+PvdzA+bQ45xCjA\n\twajEw+vx+EmEEGtiWXFl7iFGCQ5mJRHePulnEUK8KYmVValF+fFFpTmpxYcYpTlYlMR5eU9d\n\tixASSE8sSc1OTS1ILYLJMnFwSjUwBp+cedlxu/fljoy3vYundv198sVqnYBnR8Zzw5O2MWvW\n\tv+TsvMEev0GM+2nLmcxTJqpGVkwbdYNf5/9a+2x/UOGsKznJP9kfdpUvE2I6NY+/4lpaoHzS\n\twgUznvwsey/Qdy/+SMqZbJHO+b7iV2sTWZ3eW99/+S5F4OT3y0x2393C+jQyufLNlViKMxIN\n\ttZiLihMBe+CMbM4CAAA=", "H4sIAAAAAAAAA+NgFrrALMWRmVeSWpSXmKPExsVy+t/xy7qWes8iDDac5bDY3Chs8eZBE4vF\n\tu0/bmSzmndrLbjHt8212iyvtP9ktWh+2Mjmwe/xasJTVY+esu+wem1doeSze85LJo2/LKsYA\n\t1ig3m4zUxJTUIoXUvOT8lMy8dFul0BA3XQslhbzE3FRbpQhd35AgJYWyxJxSIM/IAA04OAe4\n\tByvp2yW4Zdx9v4up4ClPxYa2NsYGxnNcXYycHBICJhL/Pk5kg7DFJC7cWw9kc3EICSxhlPg5\n\tfRsjhNPKJHF951N2kCo2AR2JU6uPMILYIgLWEhfWrgDrYBY4wyjRcHAeUxcjB4ewgIXEosUW\n\tIDUsAqoSrVf2sIDYvAJuEg83H2CF2CYncfNcJ/MERu4FjAyrGEVSS4tz03OLDfWKE3OLS/PS\n\t9ZLzczcxAkNz27Gfm3cwXtoYfIhRgINRiYd3wdMnEUKsiWXFlbmHGCU4mJVEePukn0UI8aYk\n\tVlalFuXHF5XmpBYfYjQFWj6RWUo0OR8YN3kl8YYmhuaWhkbGFhbmRkZK4rwlH66ECwmkJ5ak\n\tZqemFqQWwfQxcXBKNTBOdCsSkz82o2uWslzr5Q9+y5b5HJfJvMCY9i6OK5AjQbV7k7P58tT7\n\tFS8qgi45HjRSypafs6a0Rmqdb6ttleDC/Exj/tQJ7tzV8QsX75q97G3v/Dc8KxbuON5XbfP0\n\tyx6/e5vVeN9GZ/7olXs/8/PLhEwf58fpy/JeGLoYvVG9fadXbBPz8fNKLMUZiYZazEXFiQC6\n\tPP6hYwIAAA==" ], "X-MTR": "20000000000000000@CPGS", "X-CMS-MailID": "20170406120001eucas1p2a05d5006e760aee92254fe462c6c8bd2", "X-Msg-Generator": "CA", "X-Sender-IP": "182.198.249.179", "X-Local-Sender": "=?utf-8?q?Ilya_Maximets=1BSRR-Virtualization_Lab=1B?=\n\t=?utf-8?b?7IK87ISx7KCE7J6QG0xlYWRpbmcgRW5naW5lZXI=?=", "X-Global-Sender": "=?utf-8?q?Ilya_Maximets=1BSRR-Virtualization_Lab=1BSamsu?=\n\t=?utf-8?q?ng_Electronics=1BLeading_Engineer?=", "X-Sender-Code": "=?utf-8?q?C10=1BCISHQ=1BC10GD01GD010154?=", "CMS-TYPE": "201P", "X-HopCount": "7", "X-CMS-RootMailID": "20170406120001eucas1p2a05d5006e760aee92254fe462c6c8bd2", "X-RootMTR": "20170406120001eucas1p2a05d5006e760aee92254fe462c6c8bd2", "References": "<CGME20170406120001eucas1p2a05d5006e760aee92254fe462c6c8bd2@eucas1p2.samsung.com>", "Subject": "[dpdk-dev] [PATCH] net/bonding: remove all slaves on close", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Some applications like OVS knows nothing about the\ndevice type and wants to use same API to work with\nall of them. But bond_pmd, unlike other pmds, requires\nadditional step (removing of all the slaves) before\nclosing the device.\n\nIn fact that bond_pmd automatically adds all the\ndevices from kvargs to bonding on configuration it\nalso should remove all of them on close.\n\nThis change is intended to have the same API for physical\nand virtual devices. It allows us to handle virtual\ndevices in OVS in a common way.\n\nSigned-off-by: Ilya Maximets <i.maximets@samsung.com>\n---\n drivers/net/bonding/rte_eth_bond_pmd.c | 15 +++++++++++++++\n 1 file changed, 15 insertions(+)", "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex 77d3bee..c398fdb 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -1659,7 +1659,22 @@ void\n bond_ethdev_close(struct rte_eth_dev *dev)\n {\n \tstruct bond_dev_private *internals = dev->data->dev_private;\n+\tuint8_t bond_port_id = internals->port_id;\n+\tint skipped = 0;\n \n+\tRTE_LOG(INFO, EAL, \"Closing bonded device %s\\n\", dev->data->name);\n+\twhile (internals->slave_count != skipped) {\n+\t\tuint8_t port_id = internals->slaves[skipped].port_id;\n+\n+\t\trte_eth_dev_stop(port_id);\n+\n+\t\tif (rte_eth_bond_slave_remove(bond_port_id, port_id) != 0) {\n+\t\t\tRTE_LOG(ERR, EAL,\n+\t\t\t\t\"Failed to remove port %d from bonded device \"\n+\t\t\t\t\"%s\\n\", port_id, dev->data->name);\n+\t\t\tskipped++;\n+\t\t}\n+\t}\n \tbond_ethdev_free_queues(dev);\n \trte_bitmap_reset(internals->vlan_filter_bmp);\n }\n", "prefixes": [ "dpdk-dev" ] }