Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/21700/?format=api
{ "id": 21700, "url": "http://patches.dpdk.org/api/patches/21700/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1489246618-16898-1-git-send-email-liuwf@arraynetworks.com.cn/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1489246618-16898-1-git-send-email-liuwf@arraynetworks.com.cn>", "list_archive_url": "https://inbox.dpdk.org/dev/1489246618-16898-1-git-send-email-liuwf@arraynetworks.com.cn", "date": "2017-03-11T15:36:58", "name": "[dpdk-dev] net/virtio-user: support changing tap interface name", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2d7164fccb90e94785a9eb7adab8fb79f8b5adab", "submitter": { "id": 254, "url": "http://patches.dpdk.org/api/people/254/?format=api", "name": "Wenfeng Liu", "email": "liuwf@arraynetworks.com.cn" }, "delegate": { "id": 355, "url": "http://patches.dpdk.org/api/users/355/?format=api", "username": "yliu", "first_name": "Yuanhan", "last_name": "Liu", "email": "yuanhan.liu@linux.intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1489246618-16898-1-git-send-email-liuwf@arraynetworks.com.cn/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/21700/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/21700/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id BAD9D36E;\n\tSat, 11 Mar 2017 08:38:41 +0100 (CET)", "from mail01.arraynetworks.com.cn (mail.arraynetworks.com.cn\n\t[124.42.99.121]) by dpdk.org (Postfix) with ESMTP id C5BA1201\n\tfor <dev@dpdk.org>; Sat, 11 Mar 2017 08:38:36 +0100 (CET)", "from localhost.localdomain.localdomain (192.168.4.200) by\n\tmail01.arraynetworks.com.cn (10.3.0.251) with Microsoft SMTP Server\n\tid 14.3.123.3; Sat, 11 Mar 2017 15:35:59 +0800" ], "From": "Wenfeng Liu <liuwf@arraynetworks.com.cn>", "To": "<yuanhan.liu@linux.intel.com>, <maxime.coquelin@redhat.com>", "CC": "<dev@dpdk.org>", "Date": "Sat, 11 Mar 2017 15:36:58 +0000", "Message-ID": "<1489246618-16898-1-git-send-email-liuwf@arraynetworks.com.cn>", "X-Mailer": "git-send-email 1.8.3.1", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[192.168.4.200]", "Subject": "[dpdk-dev] [PATCH] net/virtio-user: support changing tap interface\n\tname", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch adds a new option 'iface' to change the interface name of\ntap device with vhost-kernel as backend.\n\nSigned-off-by: Wenfeng Liu <liuwf@arraynetworks.com.cn>\n---\n drivers/net/virtio/virtio_user/virtio_user_dev.c | 12 ++++++++----\n drivers/net/virtio/virtio_user/virtio_user_dev.h | 2 +-\n drivers/net/virtio/virtio_user_ethdev.c | 24 +++++++++++++++++++++---\n 3 files changed, 30 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c\nindex 21ed00d..e7fd65f 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c\n@@ -193,9 +193,6 @@ int virtio_user_stop_device(struct virtio_user_dev *dev)\n \tfor (i = 0; i < dev->max_queue_pairs; ++i)\n \t\tdev->ops->enable_qp(dev, i, 0);\n \n-\tfree(dev->ifname);\n-\tdev->ifname = NULL;\n-\n \treturn 0;\n }\n \n@@ -268,7 +265,7 @@ int virtio_user_stop_device(struct virtio_user_dev *dev)\n \n int\n virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues,\n-\t\t int cq, int queue_size, const char *mac)\n+\t\t int cq, int queue_size, const char *mac, char **ifname)\n {\n \tsnprintf(dev->path, PATH_MAX, \"%s\", path);\n \tdev->max_queue_pairs = queues;\n@@ -277,6 +274,11 @@ int virtio_user_stop_device(struct virtio_user_dev *dev)\n \tdev->mac_specified = 0;\n \tparse_mac(dev, mac);\n \n+\tif (*ifname) {\n+\t\tdev->ifname = *ifname;\n+\t\t*ifname = NULL;\n+\t}\n+\n \tif (virtio_user_dev_setup(dev) < 0) {\n \t\tPMD_INIT_LOG(ERR, \"backend set up fails\");\n \t\treturn -1;\n@@ -327,6 +329,8 @@ int virtio_user_stop_device(struct virtio_user_dev *dev)\n \t\tfree(dev->vhostfds);\n \t\tfree(dev->tapfds);\n \t}\n+\n+\tfree(dev->ifname);\n }\n \n static uint8_t\ndiff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.h b/drivers/net/virtio/virtio_user/virtio_user_dev.h\nindex 0d39f40..6ecb91e 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.h\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.h\n@@ -69,7 +69,7 @@ struct virtio_user_dev {\n int virtio_user_start_device(struct virtio_user_dev *dev);\n int virtio_user_stop_device(struct virtio_user_dev *dev);\n int virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues,\n-\t\t\t int cq, int queue_size, const char *mac);\n+\t\t\t int cq, int queue_size, const char *mac, char **ifname);\n void virtio_user_dev_uninit(struct virtio_user_dev *dev);\n void virtio_user_handle_cq(struct virtio_user_dev *dev, uint16_t queue_idx);\n #endif\ndiff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c\nindex 0b226ac..16d1526 100644\n--- a/drivers/net/virtio/virtio_user_ethdev.c\n+++ b/drivers/net/virtio/virtio_user_ethdev.c\n@@ -243,6 +243,8 @@\n \tVIRTIO_USER_ARG_PATH,\n #define VIRTIO_USER_ARG_QUEUE_SIZE \"queue_size\"\n \tVIRTIO_USER_ARG_QUEUE_SIZE,\n+#define VIRTIO_USER_ARG_INTERFACE_NAME \"iface\"\n+\tVIRTIO_USER_ARG_INTERFACE_NAME,\n \tNULL\n };\n \n@@ -259,6 +261,9 @@\n \n \t*(char **)extra_args = strdup(value);\n \n+\tif (!*(char **)extra_args)\n+\t\treturn -ENOMEM;\n+\n \treturn 0;\n }\n \n@@ -347,6 +352,7 @@\n \tuint64_t cq = VIRTIO_USER_DEF_CQ_EN;\n \tuint64_t queue_size = VIRTIO_USER_DEF_Q_SZ;\n \tchar *path = NULL;\n+\tchar *ifname = NULL;\n \tchar *mac_addr = NULL;\n \tint ret = -1;\n \n@@ -375,6 +381,15 @@\n \t\tgoto end;\n \t}\n \n+\tif (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_INTERFACE_NAME) == 1) {\n+\t\tif (rte_kvargs_process(kvlist, VIRTIO_USER_ARG_INTERFACE_NAME,\n+\t\t\t\t &get_string_arg, &ifname) < 0) {\n+\t\t\tPMD_INIT_LOG(ERR, \"error to parse %s\",\n+\t\t\t\t VIRTIO_USER_ARG_INTERFACE_NAME);\n+\t\t\tgoto end;\n+\t\t}\n+\t}\n+\n \tif (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_MAC) == 1) {\n \t\tif (rte_kvargs_process(kvlist, VIRTIO_USER_ARG_MAC,\n \t\t\t\t &get_string_arg, &mac_addr) < 0) {\n@@ -413,7 +428,7 @@\n \t\tcq = 1;\n \t}\n \n-\tif (queues > 1 && cq == 0) {\n+\tif (queues > 1 && cq == VIRTIO_USER_DEF_CQ_EN) {\n \t\tPMD_INIT_LOG(ERR, \"multi-q requires ctrl-q\");\n \t\tgoto end;\n \t}\n@@ -426,7 +441,7 @@\n \n \thw = eth_dev->data->dev_private;\n \tif (virtio_user_dev_init(hw->virtio_user_dev, path, queues, cq,\n-\t\t\t\t queue_size, mac_addr) < 0) {\n+\t\t\t\t queue_size, mac_addr, &ifname) < 0) {\n \t\tPMD_INIT_LOG(ERR, \"virtio_user_dev_init fails\");\n \t\tvirtio_user_eth_dev_free(eth_dev);\n \t\tgoto end;\n@@ -447,6 +462,8 @@\n \t\tfree(path);\n \tif (mac_addr)\n \t\tfree(mac_addr);\n+\tif (ifname)\n+\t\tfree(ifname);\n \treturn ret;\n }\n \n@@ -492,4 +509,5 @@\n \t\"mac=<mac addr> \"\n \t\"cq=<int> \"\n \t\"queue_size=<int> \"\n-\t\"queues=<int>\");\n+\t\"queues=<int> \"\n+\t\"iface=<string>\");\n", "prefixes": [ "dpdk-dev" ] }