Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 20327,
    "url": "http://patches.dpdk.org/api/patches/20327/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20170209164006.72040-1-benjamin.walker@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20170209164006.72040-1-benjamin.walker@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20170209164006.72040-1-benjamin.walker@intel.com",
    "date": "2017-02-09T16:40:06",
    "name": "[dpdk-dev] Fix overwriting of dev_flags in rte_eth_dev after initialization",
    "commit_ref": null,
    "pull_url": null,
    "state": "rejected",
    "archived": true,
    "hash": "0286a6bcdb4c956ccb7ddecec33267769f5c31c0",
    "submitter": {
        "id": 487,
        "url": "http://patches.dpdk.org/api/people/487/?format=api",
        "name": "Walker, Benjamin",
        "email": "benjamin.walker@intel.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20170209164006.72040-1-benjamin.walker@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/20327/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/20327/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 419E1FA80;\n\tThu,  9 Feb 2017 17:40:17 +0100 (CET)",
            "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 7BD77FA76\n\tfor <dev@dpdk.org>; Thu,  9 Feb 2017 17:40:14 +0100 (CET)",
            "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga105.fm.intel.com with ESMTP; 09 Feb 2017 08:40:13 -0800",
            "from bwalker-desk.ch.intel.com ([143.182.136.68])\n\tby orsmga001.jf.intel.com with ESMTP; 09 Feb 2017 08:40:13 -0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos; i=\"5.35,137,1484035200\"; d=\"scan'208\";\n\ta=\"1092806795\"",
        "From": "Ben Walker <benjamin.walker@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "Ben Walker <benjamin.walker@intel.com>",
        "Date": "Thu,  9 Feb 2017 09:40:06 -0700",
        "Message-Id": "<20170209164006.72040-1-benjamin.walker@intel.com>",
        "X-Mailer": "git-send-email 2.9.3",
        "Subject": "[dpdk-dev] [PATCH] Fix overwriting of dev_flags in rte_eth_dev\n\tafter initialization",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "rte_eth_copy_pci_info no longer sets RTE_ETH_DEV_DETACHABLE\nas per my previous patch, but it still does initialize\nthe dev_flags. In a number of cases, a later assignment to\ndev_flags to set RTE_ETH_DEV_DETACHABLE was overwriting\nthe previously initialized value.\n\nPointed out by Michael Larsen.\n\nSigned-off-by: Ben Walker <benjamin.walker@intel.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c       | 2 +-\n drivers/net/e1000/em_ethdev.c        | 2 +-\n drivers/net/e1000/igb_ethdev.c       | 4 ++--\n drivers/net/fm10k/fm10k_ethdev.c     | 2 +-\n drivers/net/i40e/i40e_ethdev.c       | 2 +-\n drivers/net/i40e/i40e_ethdev_vf.c    | 2 +-\n drivers/net/ixgbe/ixgbe_ethdev.c     | 4 ++--\n drivers/net/nfp/nfp_net.c            | 2 +-\n drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +-\n 9 files changed, 11 insertions(+), 11 deletions(-)",
    "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex d1b2518..a7ea439 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -1087,7 +1087,7 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)\n \t\tRTE_LOG(INFO, PMD, \"%s\", bnxt_version);\n \n \trte_eth_copy_pci_info(eth_dev, pci_dev);\n-\teth_dev->data->dev_flags = RTE_ETH_DEV_DETACHABLE;\n+\teth_dev->data->dev_flags |= RTE_ETH_DEV_DETACHABLE;\n \tbp = eth_dev->data->dev_private;\n \n \tif (bnxt_vf_pciid(pci_dev->id.device_id))\ndiff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c\nindex d778785..4066ef9 100644\n--- a/drivers/net/e1000/em_ethdev.c\n+++ b/drivers/net/e1000/em_ethdev.c\n@@ -339,7 +339,7 @@ eth_em_dev_init(struct rte_eth_dev *eth_dev)\n \t}\n \n \trte_eth_copy_pci_info(eth_dev, pci_dev);\n-\teth_dev->data->dev_flags = RTE_ETH_DEV_DETACHABLE;\n+\teth_dev->data->dev_flags |= RTE_ETH_DEV_DETACHABLE;\n \n \thw->hw_addr = (void *)pci_dev->mem_resource[0].addr;\n \thw->device_id = pci_dev->id.device_id;\ndiff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c\nindex d939774..a112b38 100644\n--- a/drivers/net/e1000/igb_ethdev.c\n+++ b/drivers/net/e1000/igb_ethdev.c\n@@ -777,7 +777,7 @@ eth_igb_dev_init(struct rte_eth_dev *eth_dev)\n \t}\n \n \trte_eth_copy_pci_info(eth_dev, pci_dev);\n-\teth_dev->data->dev_flags = RTE_ETH_DEV_DETACHABLE;\n+\teth_dev->data->dev_flags |= RTE_ETH_DEV_DETACHABLE;\n \n \thw->hw_addr= (void *)pci_dev->mem_resource[0].addr;\n \n@@ -986,7 +986,7 @@ eth_igbvf_dev_init(struct rte_eth_dev *eth_dev)\n \n \tpci_dev = E1000_DEV_TO_PCI(eth_dev);\n \trte_eth_copy_pci_info(eth_dev, pci_dev);\n-\teth_dev->data->dev_flags = RTE_ETH_DEV_DETACHABLE;\n+\teth_dev->data->dev_flags |= RTE_ETH_DEV_DETACHABLE;\n \n \thw->device_id = pci_dev->id.device_id;\n \thw->vendor_id = pci_dev->id.vendor_id;\ndiff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c\nindex dd021e4..c4fe746 100644\n--- a/drivers/net/fm10k/fm10k_ethdev.c\n+++ b/drivers/net/fm10k/fm10k_ethdev.c\n@@ -2858,7 +2858,7 @@ eth_fm10k_dev_init(struct rte_eth_dev *dev)\n \t\treturn 0;\n \n \trte_eth_copy_pci_info(dev, pdev);\n-\tdev->data->dev_flags = RTE_ETH_DEV_DETACHABLE;\n+\tdev->data->dev_flags |= RTE_ETH_DEV_DETACHABLE;\n \n \tmacvlan = FM10K_DEV_PRIVATE_TO_MACVLAN(dev->data->dev_private);\n \tmemset(macvlan, 0, sizeof(*macvlan));\ndiff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex 4492bcc..a09a344 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -1045,7 +1045,7 @@ eth_i40e_dev_init(struct rte_eth_dev *dev)\n \tintr_handle = &pci_dev->intr_handle;\n \n \trte_eth_copy_pci_info(dev, pci_dev);\n-\tdev->data->dev_flags = RTE_ETH_DEV_DETACHABLE;\n+\tdev->data->dev_flags |= RTE_ETH_DEV_DETACHABLE;\n \n \tpf->adapter = I40E_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);\n \tpf->adapter->eth_dev = dev;\ndiff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c\nindex a606aef..cbcab36 100644\n--- a/drivers/net/i40e/i40e_ethdev_vf.c\n+++ b/drivers/net/i40e/i40e_ethdev_vf.c\n@@ -1478,7 +1478,7 @@ i40evf_dev_init(struct rte_eth_dev *eth_dev)\n \t}\n \n \trte_eth_copy_pci_info(eth_dev, pci_dev);\n-\teth_dev->data->dev_flags = RTE_ETH_DEV_DETACHABLE;\n+\teth_dev->data->dev_flags |= RTE_ETH_DEV_DETACHABLE;\n \n \thw->vendor_id = pci_dev->id.vendor_id;\n \thw->device_id = pci_dev->id.device_id;\ndiff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 5b625a3..7debd5f 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -1172,7 +1172,7 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev)\n \t}\n \n \trte_eth_copy_pci_info(eth_dev, pci_dev);\n-\teth_dev->data->dev_flags = RTE_ETH_DEV_DETACHABLE;\n+\teth_dev->data->dev_flags |= RTE_ETH_DEV_DETACHABLE;\n \n \t/* Vendor and Device ID need to be set before init of shared code */\n \thw->device_id = pci_dev->id.device_id;\n@@ -1626,7 +1626,7 @@ eth_ixgbevf_dev_init(struct rte_eth_dev *eth_dev)\n \t}\n \n \trte_eth_copy_pci_info(eth_dev, pci_dev);\n-\teth_dev->data->dev_flags = RTE_ETH_DEV_DETACHABLE;\n+\teth_dev->data->dev_flags |= RTE_ETH_DEV_DETACHABLE;\n \n \thw->device_id = pci_dev->id.device_id;\n \thw->vendor_id = pci_dev->id.vendor_id;\ndiff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c\nindex 173bebf..d79f262 100644\n--- a/drivers/net/nfp/nfp_net.c\n+++ b/drivers/net/nfp/nfp_net.c\n@@ -2465,7 +2465,7 @@ nfp_net_init(struct rte_eth_dev *eth_dev)\n \n \tpci_dev = RTE_DEV_TO_PCI(eth_dev->device);\n \trte_eth_copy_pci_info(eth_dev, pci_dev);\n-\teth_dev->data->dev_flags = RTE_ETH_DEV_DETACHABLE;\n+\teth_dev->data->dev_flags |= RTE_ETH_DEV_DETACHABLE;\n \n \thw->device_id = pci_dev->id.device_id;\n \thw->vendor_id = pci_dev->id.vendor_id;\ndiff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c\nindex 52e3644..2a52f04 100644\n--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c\n+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c\n@@ -250,7 +250,7 @@ eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev)\n \t\treturn 0;\n \n \trte_eth_copy_pci_info(eth_dev, pci_dev);\n-\teth_dev->data->dev_flags = RTE_ETH_DEV_DETACHABLE;\n+\teth_dev->data->dev_flags |= RTE_ETH_DEV_DETACHABLE;\n \n \t/* Vendor and Device ID need to be set before init of shared code */\n \thw->device_id = pci_dev->id.device_id;\n",
    "prefixes": [
        "dpdk-dev"
    ]
}