Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/19837/?format=api
{ "id": 19837, "url": "http://patches.dpdk.org/api/patches/19837/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1484920431-5770-1-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1484920431-5770-1-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1484920431-5770-1-git-send-email-arybchenko@solarflare.com", "date": "2017-01-20T13:53:50", "name": "[dpdk-dev,1/2] net/sfc: use eal I/O device memory read/write API", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "537cd4c2b1ea18de5ad6250cda6cc4a73ec44de3", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1484920431-5770-1-git-send-email-arybchenko@solarflare.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/19837/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/19837/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 243E837AC;\n\tFri, 20 Jan 2017 14:54:27 +0100 (CET)", "from nbfkord-smmo01.seg.att.com (nbfkord-smmo01.seg.att.com\n\t[209.65.160.76]) by dpdk.org (Postfix) with ESMTP id 7E0492BBD\n\tfor <dev@dpdk.org>; Fri, 20 Jan 2017 14:54:05 +0100 (CET)", "from unknown [12.187.104.26] (EHLO webmail.solarflare.com)\n\tby nbfkord-smmo01.seg.att.com(mxl_mta-7.2.4-7) with ESMTP id\n\td7612885.2b393028c940.211188.00-2463.465663.nbfkord-smmo01.seg.att.com\n\t(envelope-from <arybchenko@solarflare.com>); \n\tFri, 20 Jan 2017 13:54:05 +0000 (UTC)", "from unknown [12.187.104.26] (EHLO webmail.solarflare.com)\n\tby nbfkord-smmo01.seg.att.com(mxl_mta-7.2.4-7) over TLS secured\n\tchannel with ESMTP id\n\t57612885.0.211183.00-2333.465644.nbfkord-smmo01.seg.att.com\n\t(envelope-from <arybchenko@solarflare.com>); \n\tFri, 20 Jan 2017 13:53:58 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1044.25; Fri, 20 Jan 2017 05:53:55 -0800", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1044.25 via Frontend Transport; Fri, 20 Jan 2017 05:53:55 -0800", "from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com\n\t[10.17.10.10])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tv0KDrrTm031846; Fri, 20 Jan 2017 13:53:53 GMT", "from uklogin.uk.solarflarecom.com (localhost.localdomain\n\t[127.0.0.1])\n\tby uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tv0KDrruJ005805; Fri, 20 Jan 2017 13:53:53 GMT" ], "X-MXL-Hash": [ "5882167d0e2f0352-22263b1a8cbf5952248b77a36978d2a52cd531bc", "588216760413a975-0b4c0d87dbaee7320263139cb26a095a5a4889a6" ], "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Jerin Jacob <jerin.jacob@caviumnetworks.com>", "Date": "Fri, 20 Jan 2017 13:53:50 +0000", "Message-ID": "<1484920431-5770-1-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.2.3", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-AnalysisOut": [ "[v=2.1 cv=BNm12QkG c=1 sm=1 tr=0 a=8BlWFWvVlq5taO8ncb8nKg==]", "[:17 a=IgFoBzBjUZAA:10 a=zRKbQ67AAAAA:8 a=KPcTMC6hcW3mLvUbq]", "[JYA:9 a=PA03WX8tBzeizutn5_OT:22]" ], "X-Spam": "[F=0.2000000000; CM=0.500; S=0.200(2015072901)]", "X-MAIL-FROM": "<arybchenko@solarflare.com>", "X-SOURCE-IP": "[12.187.104.26]", "Subject": "[dpdk-dev] [PATCH 1/2] net/sfc: use eal I/O device memory\n\tread/write API", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Use relaxed version of these functions to guarantee no changes on\nthe step.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\nDue to late stage when the API appears and small time for testing,\nI prefer conservative way: use relaxed version right now and\ncleanup neighbour rte_*mb() calls later with switching to non-relaxed\nversions.\n\n drivers/net/sfc/efsys.h | 11 +++++++----\n 1 file changed, 7 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/sfc/efsys.h b/drivers/net/sfc/efsys.h\nindex fb2f3b5..a024b6c 100644\n--- a/drivers/net/sfc/efsys.h\n+++ b/drivers/net/sfc/efsys.h\n@@ -43,6 +43,7 @@\n #include <rte_common.h>\n #include <rte_malloc.h>\n #include <rte_log.h>\n+#include <rte_io.h>\n \n #include \"sfc_debug.h\"\n \n@@ -440,7 +441,7 @@\n \t\t\t\t\t\t\t\t\t\\\n \t\t_addr = (volatile uint32_t *)(_base + (_offset));\t\\\n \t\trte_rmb();\t\t\t\t\t\t\\\n-\t\t(_edp)->ed_u32[0] = _addr[0];\t\t\t\t\\\n+\t\t(_edp)->ed_u32[0] = rte_read32_relaxed(_addr);\t\t\\\n \t\t\t\t\t\t\t\t\t\\\n \t\tEFSYS_PROBE2(bar_readd, unsigned int, (_offset),\t\\\n \t\t\t\t\t uint32_t, (_edp)->ed_u32[0]);\t\\\n@@ -463,7 +464,7 @@\n \t\t\t\t\t\t\t\t\t\\\n \t\t_addr = (volatile uint64_t *)(_base + (_offset));\t\\\n \t\trte_rmb();\t\t\t\t\t\t\\\n-\t\t(_eqp)->eq_u64[0] = _addr[0];\t\t\t\t\\\n+\t\t(_eqp)->eq_u64[0] = rte_read64_relaxed(_addr);\t\t\\\n \t\t\t\t\t\t\t\t\t\\\n \t\tEFSYS_PROBE3(bar_readq, unsigned int, (_offset),\t\\\n \t\t\t\t\t uint32_t, (_eqp)->eq_u32[1],\t\\\n@@ -487,6 +488,7 @@\n \t\t\t\t\t\t\t\t\t\\\n \t\t_addr = (volatile __m128i *)(_base + (_offset));\t\\\n \t\trte_rmb();\t\t\t\t\t\t\\\n+\t\t/* There is no rte_read128_relaxed() yet */\t\t\\\n \t\t(_eop)->eo_u128[0] = _addr[0];\t\t\t\t\\\n \t\t\t\t\t\t\t\t\t\\\n \t\tEFSYS_PROBE5(bar_reado, unsigned int, (_offset),\t\\\n@@ -518,7 +520,7 @@\n \t\t\t\t\t uint32_t, (_edp)->ed_u32[0]);\t\\\n \t\t\t\t\t\t\t\t\t\\\n \t\t_addr = (volatile uint32_t *)(_base + (_offset));\t\\\n-\t\t_addr[0] = (_edp)->ed_u32[0];\t\t\t\t\\\n+\t\trte_write32_relaxed((_edp)->ed_u32[0], _addr);\t\t\\\n \t\trte_wmb();\t\t\t\t\t\t\\\n \t\t\t\t\t\t\t\t\t\\\n \t\t_NOTE(CONSTANTCONDITION);\t\t\t\t\\\n@@ -542,7 +544,7 @@\n \t\t\t\t\t uint32_t, (_eqp)->eq_u32[0]);\t\\\n \t\t\t\t\t\t\t\t\t\\\n \t\t_addr = (volatile uint64_t *)(_base + (_offset));\t\\\n-\t\t_addr[0] = (_eqp)->eq_u64[0];\t\t\t\t\\\n+\t\trte_write64_relaxed((_eqp)->eq_u64[0], _addr);\t\t\\\n \t\trte_wmb();\t\t\t\t\t\t\\\n \t\t\t\t\t\t\t\t\t\\\n \t\tSFC_BAR_UNLOCK(_esbp);\t\t\t\t\t\\\n@@ -580,6 +582,7 @@\n \t\t\t\t\t uint32_t, (_eop)->eo_u32[0]);\t\\\n \t\t\t\t\t\t\t\t\t\\\n \t\t_addr = (volatile __m128i *)(_base + (_offset));\t\\\n+\t\t/* There is no rte_write128_relaxed() yet */\t\t\\\n \t\t_addr[0] = (_eop)->eo_u128[0];\t\t\t\t\\\n \t\trte_wmb();\t\t\t\t\t\t\\\n \t\t\t\t\t\t\t\t\t\\\n", "prefixes": [ "dpdk-dev", "1/2" ] }