Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 19762,
    "url": "http://patches.dpdk.org/api/patches/19762/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1484801117-779-7-git-send-email-thomas.monjalon@6wind.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1484801117-779-7-git-send-email-thomas.monjalon@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1484801117-779-7-git-send-email-thomas.monjalon@6wind.com",
    "date": "2017-01-19T04:45:10",
    "name": "[dpdk-dev,v11,06/13] app/test: check bus probe",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "c2501bc3fb6a7d622bd29b5474b8ef57e62a30e8",
    "submitter": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/people/1/?format=api",
        "name": "Thomas Monjalon",
        "email": "thomas.monjalon@6wind.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1484801117-779-7-git-send-email-thomas.monjalon@6wind.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/19762/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/19762/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 17A9AFB4D;\n\tThu, 19 Jan 2017 05:45:46 +0100 (CET)",
            "from mail-wm0-f50.google.com (mail-wm0-f50.google.com\n\t[74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 3864CFB27\n\tfor <dev@dpdk.org>; Thu, 19 Jan 2017 05:45:28 +0100 (CET)",
            "by mail-wm0-f50.google.com with SMTP id c85so272770995wmi.1\n\tfor <dev@dpdk.org>; Wed, 18 Jan 2017 20:45:28 -0800 (PST)",
            "from XPS13.localdomain (184.203.134.77.rev.sfr.net.\n\t[77.134.203.184]) by smtp.gmail.com with ESMTPSA id\n\tt194sm2568586wmd.1.2017.01.18.20.45.27\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 18 Jan 2017 20:45:27 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=M2oKPOElLZ0Mv4Zb0rjdu0rDaSr/bfRrGEojWyXuzkQ=;\n\tb=JJkfQnJnVlSF9Sb843Pr7n0GZALGfs4ug1tiM796X39jK8y9fUmsmXWbt3s5+9izV9\n\tK93DiGSyveGcMx3cH1O4uGF7k0Nwy0To/V6ZQsZQ+N2inaN2l9XTICN3lk0Y+R+8GFaI\n\tkRxWB06JlKDm4YJpUc/6oMKKoqjh7Ar3YlOmx7FK32WhVKRGJ2lEoU9AXAfJTaBbcZEj\n\tTt2h9CBk8JUqjFvqIMmq2Ro0yQl+ZSK/pfwH1KLuNY+1TQ3JW6X4AXt9KqChWHpxAtfJ\n\tSbtIZ88Inz5C1h8eWFVKtRex2ycfgPRsJuhUlwsI1amGVD/HTkQFCbEmO5y8bjJu9RSb\n\t2NKg==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=M2oKPOElLZ0Mv4Zb0rjdu0rDaSr/bfRrGEojWyXuzkQ=;\n\tb=EaF6JQHBxpDGMtH42OgtMOnI/VYorDIUVcLQuz4pxLxjuYYdCYmNPVEThgMLC/Alu2\n\tUV6qO3abYqZNWUaOxdoDF8GqDiZPHtSaJ1c+884M/qmSMmu/ZvM/zwGwojsOn3MJcW9w\n\tprUcK8DmuLYoqqhaHrsGbma6bk4uH2czY0SGUlSNYPgip6rYu7oxBKHtdsaAMQnVPbUv\n\tHtKJTGDmwL9CKeZ9ZlAe67XQ0WcrmJmBYKGVDux7hnfRzQUeSbSSO6kDbizqEUPwrW5W\n\t36JUPVvezH9n/S3UbaCP4aZ7VpR5R31Q32WlSMuq8hmywEXLhu4AYxsTFNETW6Dd5MVs\n\tOfMQ==",
        "X-Gm-Message-State": "AIkVDXKi1I1YzUpKxmjESzlLaR/4gtPEUgJ1ur3H/ZryTCOuXonqQflP1qRQaezo7kCue5k3",
        "X-Received": "by 10.223.135.69 with SMTP id 5mr6301783wrz.174.1484801127908;\n\tWed, 18 Jan 2017 20:45:27 -0800 (PST)",
        "From": "Thomas Monjalon <thomas.monjalon@6wind.com>",
        "To": "Shreyansh Jain <shreyansh.jain@nxp.com>",
        "Cc": "dev@dpdk.org",
        "Date": "Thu, 19 Jan 2017 05:45:10 +0100",
        "Message-Id": "<1484801117-779-7-git-send-email-thomas.monjalon@6wind.com>",
        "X-Mailer": "git-send-email 2.7.0",
        "In-Reply-To": "<1484801117-779-1-git-send-email-thomas.monjalon@6wind.com>",
        "References": "<1484748329-5418-1-git-send-email-shreyansh.jain@nxp.com>\n\t<1484801117-779-1-git-send-email-thomas.monjalon@6wind.com>",
        "Subject": "[dpdk-dev] [PATCH v11 06/13] app/test: check bus probe",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Shreyansh Jain <shreyansh.jain@nxp.com>\n\nSigned-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>\n---\n app/test/test_bus.c | 149 ++++++++++++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 149 insertions(+)",
    "diff": "diff --git a/app/test/test_bus.c b/app/test/test_bus.c\nindex de4f1ab..a3220f3 100644\n--- a/app/test/test_bus.c\n+++ b/app/test/test_bus.c\n@@ -120,12 +120,15 @@ static int scan_fn_for_busB(void);\n \n /* generic implementations wrapped around by above declarations */\n static int generic_scan_fn(struct rte_bus *bus);\n+static int generic_probe_fn(void);\n+static int dummy_match_fn(struct rte_driver *drv, struct rte_device *dev);\n \n struct dummy_bus busA = {\n \t.name = \"busA_impl\", /* busA */\n \t.bus = {\n \t\t.name = \"busA\",\n \t\t.scan = scan_fn_for_busA,\n+\t\t.probe = generic_probe_fn,\n \t},\n };\n \n@@ -134,6 +137,7 @@ struct dummy_bus busB = {\n \t.bus = {\n \t\t.name = \"busB\",\n \t\t.scan = scan_fn_for_busB,\n+\t\t.probe = generic_probe_fn,\n \t},\n };\n \n@@ -283,6 +287,44 @@ generic_scan_fn(struct rte_bus *bus)\n \treturn 0;\n }\n \n+/* @internal\n+ * Obtain bus from driver object. Match the address of rte_device object\n+ * with all the devices associated with that bus.\n+ *\n+ * Being a test function, all this does is validate that device object\n+ * provided is available on the same bus to which driver is registered.\n+ *\n+ * @param drv\n+ *\tdriver to match with\n+ * @param dev\n+ *\tdevice object\n+ * @return\n+ *\t0 for successful match\n+ *\t!0 for failed match\n+ */\n+static int\n+dummy_match_fn(struct rte_driver *drv __rte_unused, struct rte_device *dev)\n+{\n+\tstruct dummy_device *ddev = NULL;\n+\tstruct dummy_device *ddev_as_arg;\n+\tstruct dummy_bus *dbus = NULL;\n+\n+\t/* Match is based entirely on address of 'dev' and 'dev_p' extracted\n+\t * from bus->device_list.\n+\t */\n+\n+\t/* a driver is registered with the bus *before* the scan. */\n+\tdbus = &busA; /* FIXME: bus cannot be retrieved without knowing the driver */\n+\tddev_as_arg = container_of(dev, struct dummy_device, dev);\n+\n+\tTAILQ_FOREACH(ddev, &dbus->device_list, next) {\n+\t\tif (ddev == ddev_as_arg)\n+\t\t\treturn 0;\n+\t}\n+\n+\treturn 1;\n+}\n+\n int\n scan_fn_for_busA(void) {\n \tstruct dummy_bus_map *dbm;\n@@ -499,6 +541,109 @@ test_bus_scan(void)\n \treturn 0;\n }\n \n+/*\n+ *\n+ */\n+static int\n+generic_probe_fn(void)\n+{\n+\tint ret = 0;\n+\tint i, j;\n+\tstruct rte_driver *drv;\n+\tstruct rte_device *dev;\n+\tstruct dummy_bus *dbus = NULL;\n+\tstruct dummy_device *ddev = NULL;\n+\tstruct dummy_driver *ddrv = NULL;\n+\n+\t/* In case of this test:\n+\t * 1. for each bus in rte_bus_list\n+\t * 2.  for each device on that bus (bus specific->device_list)\n+\t * 3.   for each driver on that bus (bus specific->driver_list)\n+\t * 4.    call match\n+\t * 5.    link driver and device\n+\t * 6. Verify the linkage.\n+\t */\n+\tfor (i = 0; bus_map[i].name; i++) {\n+\t\t/* get bus pointer from bus_map itself */\n+\t\tdbus = bus_map[i].dbus;\n+\n+\t\t/* Looping over all scanned devices */\n+\t\tTAILQ_FOREACH(ddev, &dbus->device_list, next) {\n+\t\t\t/* There is a list of drivers within dummy_bus_map.\n+\t\t\t * In case of PMDs, this would be driver registration\n+\t\t\t * APIs/list\n+\t\t\t */\n+\t\t\tfor (j = 0; bus_map[i].ddrivers[j]; j++) {\n+\t\t\t\tddrv = bus_map[i].ddrivers[j];\n+\n+\t\t\t\tdrv = &ddrv->drv;\n+\t\t\t\tdev = &ddev->dev;\n+\t\t\t\tret = dummy_match_fn(drv, dev);\n+\t\t\t\tif (!ret) {\n+\t\t\t\t\t/* As match is generic, it always\n+\t\t\t\t\t * results in dev->drv pointing to\n+\t\t\t\t\t * first driver entry in bus_map[i]\n+\t\t\t\t\t */\n+\t\t\t\t\tdev->driver = drv;\n+\t\t\t\t}\n+\t\t\t\t/* Else, continue */\n+\t\t\t}\n+\t\t}\n+\t}\n+\n+\t/* Verify the linkage. All devices belonging to a bus_map[i]\n+\t * should have same driver (first driver entry of bus_map[i])\n+\t */\n+\tfor (i = 0; bus_map[i].name; i++) {\n+\t\tddrv = bus_map[i].ddrivers[0];\n+\t\tdrv = &ddrv->drv;\n+\n+\t\tfor (j = 0; bus_map[i].ddevices[j]; j++) {\n+\t\t\tddev = bus_map[i].ddevices[j];\n+\t\t\tdev = &ddev->dev;\n+\t\t\tif (dev->driver != drv) {\n+\t\t\t\tprintf(\"Incorrect driver<->device linkage.\\n\");\n+\t\t\t\treturn -1;\n+\t\t\t}\n+\t\t}\n+\t}\n+\n+\treturn 0;\n+}\n+\n+/* @internal\n+ * Function to perform 'probe' and link devices and drivers on a bus.\n+ * This would work over all the buses registered, and all devices and drivers\n+ * registered with it - call match on each pair.\n+ *\n+ * @param void\n+ * @return\n+ *\t0 for successful probe\n+ *\t!0 for failure in probe\n+ *\n+ */\n+static int\n+test_probe_on_bus(void)\n+{\n+\tint ret = 0;\n+\tint i;\n+\tstruct dummy_bus *dbus;\n+\tstruct rte_bus *bus;\n+\n+\tfor (i = 0; bus_map[i].name; i++) {\n+\t\t/* get bus pointer from bus_map itself */\n+\t\tdbus = bus_map[i].dbus;\n+\t\tbus = &dbus->bus;\n+\t\tret = bus->probe();\n+\t\tif (ret)\n+\t\t\tprintf(\"Probe for %s failed.\\n\", bus_map[i].name);\n+\t}\n+\n+\tprintf(\"Probe on all buses successful.\\n\");\n+\tdump_device_tree();\n+\n+\treturn 0;\n+}\n \n int\n test_bus(void)\n@@ -513,6 +658,10 @@ test_bus(void)\n \tif (test_bus_scan())\n \t\treturn -1;\n \n+\t/* Now that the devices and drivers are registered, perform probe */\n+\tif (test_probe_on_bus())\n+\t\treturn -1;\n+\n \tif (test_device_unregistration_on_bus())\n \t\treturn -1;\n \n",
    "prefixes": [
        "dpdk-dev",
        "v11",
        "06/13"
    ]
}