Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/18886/?format=api
{ "id": 18886, "url": "http://patches.dpdk.org/api/patches/18886/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1483599848-7714-16-git-send-email-rasesh.mody@cavium.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1483599848-7714-16-git-send-email-rasesh.mody@cavium.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1483599848-7714-16-git-send-email-rasesh.mody@cavium.com", "date": "2017-01-05T07:03:57", "name": "[dpdk-dev,v2,15/26] net/qede: add new host ring type option", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "14d17cf8a9bb531cc57886ee752db6a49b424532", "submitter": { "id": 569, "url": "http://patches.dpdk.org/api/people/569/?format=api", "name": "Mody, Rasesh", "email": "rasesh.mody@cavium.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1483599848-7714-16-git-send-email-rasesh.mody@cavium.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/18886/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/18886/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 31D9EF958;\n\tThu, 5 Jan 2017 08:07:13 +0100 (CET)", "from mx0b-0016ce01.pphosted.com (mx0a-0016ce01.pphosted.com\n\t[67.231.148.157]) by dpdk.org (Postfix) with ESMTP id 73CAFF91F\n\tfor <dev@dpdk.org>; Thu, 5 Jan 2017 08:06:39 +0100 (CET)", "from pps.filterd (m0095336.ppops.net [127.0.0.1])\n\tby mx0a-0016ce01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id\n\tv0576R9l001817; Wed, 4 Jan 2017 23:06:35 -0800", "from avcashub1.qlogic.com ([198.186.0.116])\n\tby mx0a-0016ce01.pphosted.com with ESMTP id 27pbn8y42h-1\n\t(version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT);\n\tWed, 04 Jan 2017 23:06:35 -0800", "from avluser05.qlc.com (10.1.113.115) by qlc.com (10.1.4.191) with\n\tMicrosoft SMTP Server id 14.3.235.1; Wed, 4 Jan 2017 23:06:35 -0800", "(from rmody@localhost)\tby avluser05.qlc.com (8.14.4/8.14.4/Submit)\n\tid v0576ZpW008247;\tWed, 4 Jan 2017 23:06:35 -0800" ], "X-Authentication-Warning": "avluser05.qlc.com: rmody set sender to\n\trasesh.mody@cavium.com using -f", "From": "Rasesh Mody <rasesh.mody@cavium.com>", "To": "<ferruh.yigit@intel.com>", "CC": "Rasesh Mody <rasesh.mody@cavium.com>, <dev@dpdk.org>,\n\t<Dept-EngDPDKDev@cavium.com>", "Date": "Wed, 4 Jan 2017 23:03:57 -0800", "Message-ID": "<1483599848-7714-16-git-send-email-rasesh.mody@cavium.com>", "X-Mailer": "git-send-email 1.7.10.3", "In-Reply-To": "<1480756289-11835-1-git-send-email-Rasesh.Mody@cavium.com>", "References": "<1480756289-11835-1-git-send-email-Rasesh.Mody@cavium.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "disclaimer": "bypass", "X-Proofpoint-Virus-Version": "vendor=nai engine=5800 definitions=8398\n\tsignatures=670794", "X-Proofpoint-Spam-Details": "rule=notspam policy=default score=0\n\tpriorityscore=1501 malwarescore=0\n\tsuspectscore=3 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015\n\tlowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam\n\tadjust=0\n\treason=mlx scancount=1 engine=8.0.1-1612050000\n\tdefinitions=main-1701050115", "Subject": "[dpdk-dev] [PATCH v2 15/26] net/qede: add new host ring type option", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add new option called external PBL (page base list) to ecore_chain_alloc\nfor future use. Mark chain as external if external PBL is provided.\n\nSigned-off-by: Rasesh Mody <rasesh.mody@cavium.com>\n---\n drivers/net/qede/base/ecore_chain.h | 9 ++++++++-\n drivers/net/qede/base/ecore_dev.c | 27 ++++++++++++++++++++-------\n drivers/net/qede/base/ecore_dev_api.h | 3 ++-\n drivers/net/qede/base/ecore_spq.c | 17 +++++++++++------\n drivers/net/qede/qede_if.h | 18 ++++++++++--------\n drivers/net/qede/qede_rxtx.c | 9 ++++++---\n 6 files changed, 57 insertions(+), 26 deletions(-)", "diff": "diff --git a/drivers/net/qede/base/ecore_chain.h b/drivers/net/qede/base/ecore_chain.h\nindex 9ad1874..61e39b5 100644\n--- a/drivers/net/qede/base/ecore_chain.h\n+++ b/drivers/net/qede/base/ecore_chain.h\n@@ -54,6 +54,11 @@ struct ecore_chain_pbl_u32 {\n \tu32 cons_page_idx;\n };\n \n+struct ecore_chain_ext_pbl {\n+\tdma_addr_t p_pbl_phys;\n+\tvoid *p_pbl_virt;\n+};\n+\n struct ecore_chain_pbl {\n \t/* Base address of a pre-allocated buffer for pbl */\n \tdma_addr_t p_phys_table;\n@@ -69,6 +74,8 @@ struct ecore_chain_pbl {\n \t\tstruct ecore_chain_pbl_u16 pbl16;\n \t\tstruct ecore_chain_pbl_u32 pbl32;\n \t} u;\n+\n+\tbool external;\n };\n \n struct ecore_chain_u16 {\n@@ -570,7 +577,7 @@ ecore_chain_init_params(struct ecore_chain *p_chain, u32 page_cnt, u8 elem_size,\n \tp_chain->page_cnt = page_cnt;\n \tp_chain->capacity = p_chain->usable_per_page * page_cnt;\n \tp_chain->size = p_chain->elem_per_page * page_cnt;\n-\n+\tp_chain->pbl.external = false;\n \tp_chain->pbl.p_phys_table = 0;\n \tp_chain->pbl.p_virt_table = OSAL_NULL;\n \tp_chain->pbl.pp_virt_addr_tbl = OSAL_NULL;\ndiff --git a/drivers/net/qede/base/ecore_dev.c b/drivers/net/qede/base/ecore_dev.c\nindex f043808..f29b3cd 100644\n--- a/drivers/net/qede/base/ecore_dev.c\n+++ b/drivers/net/qede/base/ecore_dev.c\n@@ -3193,8 +3193,10 @@ static void ecore_chain_free_pbl(struct ecore_dev *p_dev,\n \t}\n \n \tpbl_size = page_cnt * ECORE_CHAIN_PBL_ENTRY_SIZE;\n-\tOSAL_DMA_FREE_COHERENT(p_dev, p_chain->pbl.p_virt_table,\n-\t\t\t p_chain->pbl.p_phys_table, pbl_size);\n+\n+\tif (!p_chain->pbl.external)\n+\t\tOSAL_DMA_FREE_COHERENT(p_dev, p_chain->pbl.p_virt_table,\n+\t\t\t\t p_chain->pbl.p_phys_table, pbl_size);\n out:\n \tOSAL_VFREE(p_dev, p_chain->pbl.pp_virt_addr_tbl);\n }\n@@ -3294,8 +3296,10 @@ ecore_chain_alloc_single(struct ecore_dev *p_dev, struct ecore_chain *p_chain)\n \treturn ECORE_SUCCESS;\n }\n \n-static enum _ecore_status_t ecore_chain_alloc_pbl(struct ecore_dev *p_dev,\n-\t\t\t\t\t\t struct ecore_chain *p_chain)\n+static enum _ecore_status_t\n+ecore_chain_alloc_pbl(struct ecore_dev *p_dev,\n+\t\t struct ecore_chain *p_chain,\n+\t\t struct ecore_chain_ext_pbl *ext_pbl)\n {\n \tvoid *p_virt = OSAL_NULL;\n \tu8 *p_pbl_virt = OSAL_NULL;\n@@ -3319,7 +3323,15 @@ static enum _ecore_status_t ecore_chain_alloc_pbl(struct ecore_dev *p_dev,\n \t * should be saved to allow its freeing during the error flow.\n \t */\n \tsize = page_cnt * ECORE_CHAIN_PBL_ENTRY_SIZE;\n-\tp_pbl_virt = OSAL_DMA_ALLOC_COHERENT(p_dev, &p_pbl_phys, size);\n+\n+\tif (ext_pbl == OSAL_NULL) {\n+\t\tp_pbl_virt = OSAL_DMA_ALLOC_COHERENT(p_dev, &p_pbl_phys, size);\n+\t} else {\n+\t\tp_pbl_virt = ext_pbl->p_pbl_virt;\n+\t\tp_pbl_phys = ext_pbl->p_pbl_phys;\n+\t\tp_chain->pbl.external = true;\n+\t}\n+\n \tecore_chain_init_pbl_mem(p_chain, p_pbl_virt, p_pbl_phys,\n \t\t\t\t pp_virt_addr_tbl);\n \tif (!p_pbl_virt) {\n@@ -3357,7 +3369,8 @@ enum _ecore_status_t ecore_chain_alloc(struct ecore_dev *p_dev,\n \t\t\t\t enum ecore_chain_mode mode,\n \t\t\t\t enum ecore_chain_cnt_type cnt_type,\n \t\t\t\t u32 num_elems, osal_size_t elem_size,\n-\t\t\t\t struct ecore_chain *p_chain)\n+\t\t\t\t struct ecore_chain *p_chain,\n+\t\t\t\t struct ecore_chain_ext_pbl *ext_pbl)\n {\n \tu32 page_cnt;\n \tenum _ecore_status_t rc = ECORE_SUCCESS;\n@@ -3388,7 +3401,7 @@ enum _ecore_status_t ecore_chain_alloc(struct ecore_dev *p_dev,\n \t\trc = ecore_chain_alloc_single(p_dev, p_chain);\n \t\tbreak;\n \tcase ECORE_CHAIN_MODE_PBL:\n-\t\trc = ecore_chain_alloc_pbl(p_dev, p_chain);\n+\t\trc = ecore_chain_alloc_pbl(p_dev, p_chain, ext_pbl);\n \t\tbreak;\n \t}\n \tif (rc)\ndiff --git a/drivers/net/qede/base/ecore_dev_api.h b/drivers/net/qede/base/ecore_dev_api.h\nindex cbddd24..0ec02b5 100644\n--- a/drivers/net/qede/base/ecore_dev_api.h\n+++ b/drivers/net/qede/base/ecore_dev_api.h\n@@ -370,7 +370,8 @@ ecore_chain_alloc(struct ecore_dev *p_dev,\n \t\t enum ecore_chain_cnt_type cnt_type,\n \t\t u32 num_elems,\n \t\t osal_size_t elem_size,\n-\t\t struct ecore_chain *p_chain);\n+\t\t struct ecore_chain *p_chain,\n+\t\t struct ecore_chain_ext_pbl *ext_pbl);\n \n /**\n * @brief ecore_chain_free - Free chain DMA memory\ndiff --git a/drivers/net/qede/base/ecore_spq.c b/drivers/net/qede/base/ecore_spq.c\nindex 0d744dd..c524cab 100644\n--- a/drivers/net/qede/base/ecore_spq.c\n+++ b/drivers/net/qede/base/ecore_spq.c\n@@ -373,7 +373,8 @@ struct ecore_eq *ecore_eq_alloc(struct ecore_hwfn *p_hwfn, u16 num_elem)\n \t\t\t ECORE_CHAIN_MODE_PBL,\n \t\t\t ECORE_CHAIN_CNT_TYPE_U16,\n \t\t\t num_elem,\n-\t\t\t sizeof(union event_ring_element), &p_eq->chain)) {\n+\t\t\t sizeof(union event_ring_element),\n+\t\t\t &p_eq->chain, OSAL_NULL)) {\n \t\tDP_NOTICE(p_hwfn, true, \"Failed to allocate eq chain\\n\");\n \t\tgoto eq_allocate_fail;\n \t}\n@@ -501,10 +502,13 @@ enum _ecore_status_t ecore_spq_alloc(struct ecore_hwfn *p_hwfn)\n \t}\n \n \t/* SPQ ring */\n-\tif (ecore_chain_alloc(p_hwfn->p_dev, ECORE_CHAIN_USE_TO_PRODUCE,\n-\t\t\tECORE_CHAIN_MODE_SINGLE, ECORE_CHAIN_CNT_TYPE_U16, 0,\n-\t\t\t/* N/A when the mode is SINGLE */\n-\t\t\tsizeof(struct slow_path_element), &p_spq->chain)) {\n+\tif (ecore_chain_alloc(p_hwfn->p_dev,\n+\t\t\t ECORE_CHAIN_USE_TO_PRODUCE,\n+\t\t\t ECORE_CHAIN_MODE_SINGLE,\n+\t\t\t ECORE_CHAIN_CNT_TYPE_U16,\n+\t\t\t 0, /* N/A when the mode is SINGLE */\n+\t\t\t sizeof(struct slow_path_element),\n+\t\t\t &p_spq->chain, OSAL_NULL)) {\n \t\tDP_NOTICE(p_hwfn, true, \"Failed to allocate spq chain\\n\");\n \t\tgoto spq_allocate_fail;\n \t}\n@@ -956,7 +960,8 @@ struct ecore_consq *ecore_consq_alloc(struct ecore_hwfn *p_hwfn)\n \t\t\t ECORE_CHAIN_MODE_PBL,\n \t\t\t ECORE_CHAIN_CNT_TYPE_U16,\n \t\t\t ECORE_CHAIN_PAGE_SIZE / 0x80,\n-\t\t\t 0x80, &p_consq->chain)) {\n+\t\t\t 0x80,\n+\t\t\t &p_consq->chain, OSAL_NULL)) {\n \t\tDP_NOTICE(p_hwfn, true, \"Failed to allocate consq chain\");\n \t\tgoto consq_allocate_fail;\n \t}\ndiff --git a/drivers/net/qede/qede_if.h b/drivers/net/qede/qede_if.h\nindex 2131fe2..4289d0b 100644\n--- a/drivers/net/qede/qede_if.h\n+++ b/drivers/net/qede/qede_if.h\n@@ -110,14 +110,16 @@ struct qed_common_ops {\n \t\t uint32_t dp_module, uint8_t dp_level, bool is_vf);\n \tvoid (*set_id)(struct ecore_dev *edev,\n \t\tchar name[], const char ver_str[]);\n-\tenum _ecore_status_t (*chain_alloc)(struct ecore_dev *edev,\n-\t\t\t\t\t enum ecore_chain_use_mode\n-\t\t\t\t\t intended_use,\n-\t\t\t\t\t enum ecore_chain_mode mode,\n-\t\t\t\t\t enum ecore_chain_cnt_type cnt_type,\n-\t\t\t\t\t uint32_t num_elems,\n-\t\t\t\t\t osal_size_t elem_size,\n-\t\t\t\t\t struct ecore_chain *p_chain);\n+\tenum _ecore_status_t\n+\t\t(*chain_alloc)(struct ecore_dev *edev,\n+\t\t\t enum ecore_chain_use_mode\n+\t\t\t intended_use,\n+\t\t\t enum ecore_chain_mode mode,\n+\t\t\t enum ecore_chain_cnt_type cnt_type,\n+\t\t\t uint32_t num_elems,\n+\t\t\t osal_size_t elem_size,\n+\t\t\t struct ecore_chain *p_chain,\n+\t\t\t struct ecore_chain_ext_pbl *ext_pbl);\n \n \tvoid (*chain_free)(struct ecore_dev *edev,\n \t\t\t struct ecore_chain *p_chain);\ndiff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c\nindex 2a8939a..814d384 100644\n--- a/drivers/net/qede/qede_rxtx.c\n+++ b/drivers/net/qede/qede_rxtx.c\n@@ -176,7 +176,8 @@ qede_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,\n \t\t\t\t\t ECORE_CHAIN_CNT_TYPE_U16,\n \t\t\t\t\t rxq->nb_rx_desc,\n \t\t\t\t\t sizeof(struct eth_rx_bd),\n-\t\t\t\t\t &rxq->rx_bd_ring);\n+\t\t\t\t\t &rxq->rx_bd_ring,\n+\t\t\t\t\t NULL);\n \n \tif (rc != ECORE_SUCCESS) {\n \t\tDP_NOTICE(edev, false,\n@@ -196,7 +197,8 @@ qede_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,\n \t\t\t\t\t ECORE_CHAIN_CNT_TYPE_U16,\n \t\t\t\t\t rxq->nb_rx_desc,\n \t\t\t\t\t sizeof(union eth_rx_cqe),\n-\t\t\t\t\t &rxq->rx_comp_ring);\n+\t\t\t\t\t &rxq->rx_comp_ring,\n+\t\t\t\t\t NULL);\n \n \tif (rc != ECORE_SUCCESS) {\n \t\tDP_NOTICE(edev, false,\n@@ -291,7 +293,8 @@ qede_tx_queue_setup(struct rte_eth_dev *dev,\n \t\t\t\t\t ECORE_CHAIN_CNT_TYPE_U16,\n \t\t\t\t\t txq->nb_tx_desc,\n \t\t\t\t\t sizeof(union eth_tx_bd_types),\n-\t\t\t\t\t &txq->tx_pbl);\n+\t\t\t\t\t &txq->tx_pbl,\n+\t\t\t\t\t NULL);\n \tif (rc != ECORE_SUCCESS) {\n \t\tDP_ERR(edev,\n \t\t \"Unable to allocate memory for txbd ring on socket %u\",\n", "prefixes": [ "dpdk-dev", "v2", "15/26" ] }