Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/18882/?format=api
{ "id": 18882, "url": "http://patches.dpdk.org/api/patches/18882/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1483599848-7714-11-git-send-email-rasesh.mody@cavium.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1483599848-7714-11-git-send-email-rasesh.mody@cavium.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1483599848-7714-11-git-send-email-rasesh.mody@cavium.com", "date": "2017-01-05T07:03:52", "name": "[dpdk-dev,v2,10/26] net/qede/base: semantic change", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2264da41f6159d1986e017c2b1bc8a30afc023a0", "submitter": { "id": 569, "url": "http://patches.dpdk.org/api/people/569/?format=api", "name": "Mody, Rasesh", "email": "rasesh.mody@cavium.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1483599848-7714-11-git-send-email-rasesh.mody@cavium.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/18882/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/18882/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 23FC05A44;\n\tThu, 5 Jan 2017 08:07:04 +0100 (CET)", "from mx0b-0016ce01.pphosted.com (mx0a-0016ce01.pphosted.com\n\t[67.231.148.157]) by dpdk.org (Postfix) with ESMTP id 424E0F91C\n\tfor <dev@dpdk.org>; Thu, 5 Jan 2017 08:06:36 +0100 (CET)", "from pps.filterd (m0095336.ppops.net [127.0.0.1])\n\tby mx0a-0016ce01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id\n\tv0576R9k001817; Wed, 4 Jan 2017 23:06:32 -0800", "from avcashub1.qlogic.com ([198.186.0.117])\n\tby mx0a-0016ce01.pphosted.com with ESMTP id 27pbn8y42c-1\n\t(version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT);\n\tWed, 04 Jan 2017 23:06:31 -0800", "from avluser05.qlc.com (10.1.113.115) by qlc.com (10.1.4.192) with\n\tMicrosoft SMTP Server id 14.3.235.1; Wed, 4 Jan 2017 23:06:31 -0800", "(from rmody@localhost)\tby avluser05.qlc.com (8.14.4/8.14.4/Submit)\n\tid v0576V6T008237;\tWed, 4 Jan 2017 23:06:31 -0800" ], "X-Authentication-Warning": "avluser05.qlc.com: rmody set sender to\n\trasesh.mody@cavium.com using -f", "From": "Rasesh Mody <rasesh.mody@cavium.com>", "To": "<ferruh.yigit@intel.com>", "CC": "Rasesh Mody <rasesh.mody@cavium.com>, <dev@dpdk.org>,\n\t<Dept-EngDPDKDev@cavium.com>", "Date": "Wed, 4 Jan 2017 23:03:52 -0800", "Message-ID": "<1483599848-7714-11-git-send-email-rasesh.mody@cavium.com>", "X-Mailer": "git-send-email 1.7.10.3", "In-Reply-To": "<1480756289-11835-1-git-send-email-Rasesh.Mody@cavium.com>", "References": "<1480756289-11835-1-git-send-email-Rasesh.Mody@cavium.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "disclaimer": "bypass", "X-Proofpoint-Virus-Version": "vendor=nai engine=5800 definitions=8398\n\tsignatures=670794", "X-Proofpoint-Spam-Details": "rule=notspam policy=default score=0\n\tpriorityscore=1501 malwarescore=0\n\tsuspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015\n\tlowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam\n\tadjust=0\n\treason=mlx scancount=1 engine=8.0.1-1612050000\n\tdefinitions=main-1701050115", "Subject": "[dpdk-dev] [PATCH v2 10/26] net/qede/base: semantic change", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Semantic change: No reason to have p_ prefix to non-pointers\n\nSigned-off-by: Rasesh Mody <rasesh.mody@cavium.com>\n---\n drivers/net/qede/base/ecore_sriov.c | 36 +++++++++++++++++------------------\n 1 file changed, 18 insertions(+), 18 deletions(-)", "diff": "diff --git a/drivers/net/qede/base/ecore_sriov.c b/drivers/net/qede/base/ecore_sriov.c\nindex 0e2b324..eaad843 100644\n--- a/drivers/net/qede/base/ecore_sriov.c\n+++ b/drivers/net/qede/base/ecore_sriov.c\n@@ -1987,7 +1987,7 @@ static void ecore_iov_vf_mbx_start_rxq(struct ecore_hwfn *p_hwfn,\n \t\t\t\t struct ecore_ptt *p_ptt,\n \t\t\t\t struct ecore_vf_info *vf)\n {\n-\tstruct ecore_queue_start_common_params p_params;\n+\tstruct ecore_queue_start_common_params params;\n \tstruct ecore_iov_vf_mbx *mbx = &vf->vf_mbx;\n \tu8 status = PFVF_STATUS_NO_RESOURCE;\n \tstruct vfpf_start_rxq_tlv *req;\n@@ -2000,13 +2000,13 @@ static void ecore_iov_vf_mbx_start_rxq(struct ecore_hwfn *p_hwfn,\n \t !ecore_iov_validate_sb(p_hwfn, vf, req->hw_sb))\n \t\tgoto out;\n \n-\tOSAL_MEMSET(&p_params, 0, sizeof(p_params));\n-\tp_params.queue_id = (u8)vf->vf_queues[req->rx_qid].fw_rx_qid;\n-\tp_params.vf_qid = req->rx_qid;\n-\tp_params.vport_id = vf->vport_id;\n-\tp_params.stats_id = vf->abs_vf_id + 0x10,\n-\tp_params.sb = req->hw_sb;\n-\tp_params.sb_idx = req->sb_index;\n+\tOSAL_MEMSET(¶ms, 0, sizeof(params));\n+\tparams.queue_id = (u8)vf->vf_queues[req->rx_qid].fw_rx_qid;\n+\tparams.vf_qid = req->rx_qid;\n+\tparams.vport_id = vf->vport_id;\n+\tparams.stats_id = vf->abs_vf_id + 0x10,\n+\tparams.sb = req->hw_sb;\n+\tparams.sb_idx = req->sb_index;\n \n \t/* Legacy VFs have their Producers in a different location, which they\n \t * calculate on their own and clean the producer prior to this.\n@@ -2022,7 +2022,7 @@ static void ecore_iov_vf_mbx_start_rxq(struct ecore_hwfn *p_hwfn,\n \n \trc = ecore_sp_eth_rxq_start_ramrod(p_hwfn, vf->opaque_fid,\n \t\t\t\t\t vf->vf_queues[req->rx_qid].fw_cid,\n-\t\t\t\t\t &p_params,\n+\t\t\t\t\t ¶ms,\n \t\t\t\t\t req->bd_max_bytes,\n \t\t\t\t\t req->rxq_addr,\n \t\t\t\t\t req->cqe_pbl_addr,\n@@ -2087,7 +2087,7 @@ static void ecore_iov_vf_mbx_start_txq(struct ecore_hwfn *p_hwfn,\n \t\t\t\t struct ecore_ptt *p_ptt,\n \t\t\t\t struct ecore_vf_info *vf)\n {\n-\tstruct ecore_queue_start_common_params p_params;\n+\tstruct ecore_queue_start_common_params params;\n \tstruct ecore_iov_vf_mbx *mbx = &vf->vf_mbx;\n \tu8 status = PFVF_STATUS_NO_RESOURCE;\n \tunion ecore_qm_pq_params pq_params;\n@@ -2099,24 +2099,24 @@ static void ecore_iov_vf_mbx_start_txq(struct ecore_hwfn *p_hwfn,\n \tpq_params.eth.is_vf = 1;\n \tpq_params.eth.vf_id = vf->relative_vf_id;\n \n-\tOSAL_MEMSET(&p_params, 0, sizeof(p_params));\n+\tOSAL_MEMSET(¶ms, 0, sizeof(params));\n \treq = &mbx->req_virt->start_txq;\n \n \tif (!ecore_iov_validate_txq(p_hwfn, vf, req->tx_qid) ||\n \t !ecore_iov_validate_sb(p_hwfn, vf, req->hw_sb))\n \t\tgoto out;\n \n-\tp_params.queue_id = (u8)vf->vf_queues[req->tx_qid].fw_tx_qid;\n-\tp_params.qzone_id = (u8)vf->vf_queues[req->tx_qid].fw_tx_qid;\n-\tp_params.vport_id = vf->vport_id;\n-\tp_params.stats_id = vf->abs_vf_id + 0x10,\n-\tp_params.sb = req->hw_sb;\n-\tp_params.sb_idx = req->sb_index;\n+\tparams.queue_id = (u8)vf->vf_queues[req->tx_qid].fw_tx_qid;\n+\tparams.qzone_id = (u8)vf->vf_queues[req->tx_qid].fw_tx_qid;\n+\tparams.vport_id = vf->vport_id;\n+\tparams.stats_id = vf->abs_vf_id + 0x10,\n+\tparams.sb = req->hw_sb;\n+\tparams.sb_idx = req->sb_index;\n \n \trc = ecore_sp_eth_txq_start_ramrod(p_hwfn,\n \t\t\t\t\t vf->opaque_fid,\n \t\t\t\t\t vf->vf_queues[req->tx_qid].fw_cid,\n-\t\t\t\t\t &p_params,\n+\t\t\t\t\t ¶ms,\n \t\t\t\t\t req->pbl_addr,\n \t\t\t\t\t req->pbl_size,\n \t\t\t\t\t &pq_params);\n", "prefixes": [ "dpdk-dev", "v2", "10/26" ] }