Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 18388,
    "url": "http://patches.dpdk.org/api/patches/18388/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1482332986-7599-5-git-send-email-jblunck@infradead.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1482332986-7599-5-git-send-email-jblunck@infradead.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1482332986-7599-5-git-send-email-jblunck@infradead.org",
    "date": "2016-12-21T15:09:27",
    "name": "[dpdk-dev,v4,04/23] pmd: remove useless reset of dev_info->dev_pci",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "d58ffb07e1ae0783d87f4ab209ee9201c5b90fa2",
    "submitter": {
        "id": 249,
        "url": "http://patches.dpdk.org/api/people/249/?format=api",
        "name": "Jan Blunck",
        "email": "jblunck@infradead.org"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1482332986-7599-5-git-send-email-jblunck@infradead.org/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/18388/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/18388/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 320BA10CD0;\n\tWed, 21 Dec 2016 16:10:19 +0100 (CET)",
            "from mail-wm0-f65.google.com (mail-wm0-f65.google.com\n\t[74.125.82.65]) by dpdk.org (Postfix) with ESMTP id C677410CAD\n\tfor <dev@dpdk.org>; Wed, 21 Dec 2016 16:10:05 +0100 (CET)",
            "by mail-wm0-f65.google.com with SMTP id l2so5470897wml.2\n\tfor <dev@dpdk.org>; Wed, 21 Dec 2016 07:10:05 -0800 (PST)",
            "from weierstrass.local.net ([91.200.109.169])\n\tby smtp.gmail.com with ESMTPSA id\n\t135sm27627375wmh.14.2016.12.21.07.10.04\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 21 Dec 2016 07:10:04 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=GkqxD4h6pcqN0SJMeUaau2sMpB+YldyFF/Kv+oq49Aw=;\n\tb=nAT0rCtxMWryuYx7bAoS4v+VDtKK2fSjGpa1s0/gNZoDiyGoHU0WrH3WHylailyY0O\n\tc1KixqIFWChsDh0EiI2VhVEbE7kkVY0SjHKAPS591XxgFB1OT+HZ7nxMEqhqu2S0NaWE\n\tfyVmcIJKmOlD6qJPZl7ZD1M5I3mbEo/qjRiAYPhAVsP3q9ejlgheFwAbNB4qzgUqwhjX\n\tS6fiiCf0WPqa9kmaS/FRmq5gp3ZkQNvCJxaXFAKs9L30aPAd9Tx5WrUeI+Aj3bc3HDp6\n\tJ8daK8ffGW/QV2Xs8uK+mz2ZMV8nhzGEMjDQeXuJdy2XOZhvM9fuEzTxIXU/re5NkEyJ\n\t2rig==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references;\n\tbh=GkqxD4h6pcqN0SJMeUaau2sMpB+YldyFF/Kv+oq49Aw=;\n\tb=TuxejXX4RuUL837o3Cm3izhNNJLdt4Teh0umqSTlOX74m/Gj2Dvsni43ucvQvdB5EQ\n\t5lt5G6xVb+pI5N+ebrcL4O+Fa41IncZGxOSptBuM6+5xNeKEbDrpQTFXlT1zUZnsRpLd\n\tsVUIaxMwcjuITxkfUIjvbdi26ZraRwiYJ+oj7P8nP90nUq4W1ne1BqHBcuvAc8zxbAJp\n\txCuPynjHRY+ilNLGqP4+fMkBkp817y108ywQyLBYaNnkQlJkBNRZ9a/6z4afDwhWeRIz\n\tsgBmWibxbAzKDOErRoMMGDOQ/B4AWVxW/CCHYYDu6svJf7rDdJEj3qO29wevuD6MXIoY\n\tKMZA==",
        "X-Gm-Message-State": "AIkVDXKdpqnijSC8adKVS7fBjeaW7iFAc4WoulgDmb9oS/eQiKsiWBWUk89zFbUhjvFh8g==",
        "X-Received": "by 10.28.95.197 with SMTP id t188mr7080948wmb.99.1482333005297; \n\tWed, 21 Dec 2016 07:10:05 -0800 (PST)",
        "From": "Jan Blunck <jblunck@infradead.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>, shreyansh.jain@nxp.com, \n\tdavid.marchand@6wind.com, Stephen Hemminger <sthemmin@microsoft.com>",
        "Date": "Wed, 21 Dec 2016 16:09:27 +0100",
        "Message-Id": "<1482332986-7599-5-git-send-email-jblunck@infradead.org>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1482332986-7599-1-git-send-email-jblunck@infradead.org>",
        "References": "<1482332986-7599-1-git-send-email-jblunck@infradead.org>",
        "Subject": "[dpdk-dev] [PATCH v4 04/23] pmd: remove useless reset of\n\tdev_info->dev_pci",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Stephen Hemminger <stephen@networkplumber.org>\n\nSince rte_eth_dev_info_get does memset() on dev_info before\ncalling device specific code, the explicit assignment of NULL\nin all these virtual drivers has no effect.\n\nSigned-off-by: Stephen Hemminger <sthemmin@microsoft.com>\nAcked-by: Jan Blunck <jblunck@infradead.org>\n---\n app/test/virtual_pmd.c                    | 1 -\n drivers/net/af_packet/rte_eth_af_packet.c | 1 -\n drivers/net/bonding/rte_eth_bond_pmd.c    | 1 -\n drivers/net/null/rte_eth_null.c           | 1 -\n drivers/net/pcap/rte_eth_pcap.c           | 1 -\n drivers/net/ring/rte_eth_ring.c           | 1 -\n drivers/net/xenvirt/rte_eth_xenvirt.c     | 1 -\n 7 files changed, 7 deletions(-)",
    "diff": "diff --git a/app/test/virtual_pmd.c b/app/test/virtual_pmd.c\nindex 65b44c6..e0447fd 100644\n--- a/app/test/virtual_pmd.c\n+++ b/app/test/virtual_pmd.c\n@@ -117,7 +117,6 @@ virtual_ethdev_info_get(struct rte_eth_dev *dev __rte_unused,\n \tdev_info->max_tx_queues = (uint16_t)512;\n \n \tdev_info->min_rx_bufsize = 0;\n-\tdev_info->pci_dev = NULL;\n }\n \n static int\ndiff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c\nindex ff45068..2951f86 100644\n--- a/drivers/net/af_packet/rte_eth_af_packet.c\n+++ b/drivers/net/af_packet/rte_eth_af_packet.c\n@@ -287,7 +287,6 @@ eth_dev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \tdev_info->max_rx_queues = (uint16_t)internals->nb_queues;\n \tdev_info->max_tx_queues = (uint16_t)internals->nb_queues;\n \tdev_info->min_rx_bufsize = 0;\n-\tdev_info->pci_dev = NULL;\n }\n \n static void\ndiff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex a80b6fa..74af658 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -1675,7 +1675,6 @@ bond_ethdev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \tdev_info->max_tx_queues = (uint16_t)512;\n \n \tdev_info->min_rx_bufsize = 0;\n-\tdev_info->pci_dev = NULL;\n \n \tdev_info->rx_offload_capa = internals->rx_offload_capa;\n \tdev_info->tx_offload_capa = internals->tx_offload_capa;\ndiff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c\nindex 836d982..b4f253a 100644\n--- a/drivers/net/null/rte_eth_null.c\n+++ b/drivers/net/null/rte_eth_null.c\n@@ -301,7 +301,6 @@ eth_dev_info(struct rte_eth_dev *dev,\n \tdev_info->max_rx_queues = RTE_DIM(internals->rx_null_queues);\n \tdev_info->max_tx_queues = RTE_DIM(internals->tx_null_queues);\n \tdev_info->min_rx_bufsize = 0;\n-\tdev_info->pci_dev = NULL;\n \tdev_info->reta_size = internals->reta_size;\n \tdev_info->flow_type_rss_offloads = internals->flow_type_rss_offloads;\n }\ndiff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c\nindex 0162f44..7253b9a 100644\n--- a/drivers/net/pcap/rte_eth_pcap.c\n+++ b/drivers/net/pcap/rte_eth_pcap.c\n@@ -559,7 +559,6 @@ eth_dev_info(struct rte_eth_dev *dev,\n \tdev_info->max_rx_queues = dev->data->nb_rx_queues;\n \tdev_info->max_tx_queues = dev->data->nb_tx_queues;\n \tdev_info->min_rx_bufsize = 0;\n-\tdev_info->pci_dev = NULL;\n }\n \n static void\ndiff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c\nindex c1767c4..dc99a1f 100644\n--- a/drivers/net/ring/rte_eth_ring.c\n+++ b/drivers/net/ring/rte_eth_ring.c\n@@ -179,7 +179,6 @@ eth_dev_info(struct rte_eth_dev *dev,\n \tdev_info->max_rx_queues = (uint16_t)internals->max_rx_queues;\n \tdev_info->max_tx_queues = (uint16_t)internals->max_tx_queues;\n \tdev_info->min_rx_bufsize = 0;\n-\tdev_info->pci_dev = NULL;\n }\n \n static void\ndiff --git a/drivers/net/xenvirt/rte_eth_xenvirt.c b/drivers/net/xenvirt/rte_eth_xenvirt.c\nindex c08a056..609824b 100644\n--- a/drivers/net/xenvirt/rte_eth_xenvirt.c\n+++ b/drivers/net/xenvirt/rte_eth_xenvirt.c\n@@ -337,7 +337,6 @@ eth_dev_info(struct rte_eth_dev *dev,\n \tdev_info->max_rx_queues = (uint16_t)1;\n \tdev_info->max_tx_queues = (uint16_t)1;\n \tdev_info->min_rx_bufsize = 0;\n-\tdev_info->pci_dev = NULL;\n }\n \n static void\n",
    "prefixes": [
        "dpdk-dev",
        "v4",
        "04/23"
    ]
}