Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/17733/?format=api
{ "id": 17733, "url": "http://patches.dpdk.org/api/patches/17733/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1481081535-37448-14-git-send-email-wenzhuo.lu@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1481081535-37448-14-git-send-email-wenzhuo.lu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1481081535-37448-14-git-send-email-wenzhuo.lu@intel.com", "date": "2016-12-07T03:31:56", "name": "[dpdk-dev,v2,13/32] net/i40e: set VF MAC from VF support", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b380f459dc385cfe020749186b5ccae5844488d9", "submitter": { "id": 258, "url": "http://patches.dpdk.org/api/people/258/?format=api", "name": "Wenzhuo Lu", "email": "wenzhuo.lu@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1481081535-37448-14-git-send-email-wenzhuo.lu@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/17733/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/17733/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id C123CFA46;\n\tWed, 7 Dec 2016 04:33:41 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 70D412BB3\n\tfor <dev@dpdk.org>; Wed, 7 Dec 2016 04:32:31 +0100 (CET)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga101.fm.intel.com with ESMTP; 06 Dec 2016 19:32:31 -0800", "from dpdk26.sh.intel.com ([10.239.128.228])\n\tby orsmga003.jf.intel.com with ESMTP; 06 Dec 2016 19:32:30 -0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.33,310,1477983600\"; d=\"scan'208\";a=\"909513296\"", "From": "Wenzhuo Lu <wenzhuo.lu@intel.com>", "To": "dev@dpdk.org", "Cc": "Ferruh Yigit <ferruh.yigit@intel.com>", "Date": "Wed, 7 Dec 2016 11:31:56 +0800", "Message-Id": "<1481081535-37448-14-git-send-email-wenzhuo.lu@intel.com>", "X-Mailer": "git-send-email 1.9.3", "In-Reply-To": "<1481081535-37448-1-git-send-email-wenzhuo.lu@intel.com>", "References": "<1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com>\n\t<1481081535-37448-1-git-send-email-wenzhuo.lu@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 13/32] net/i40e: set VF MAC from VF support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Support changing VF default MAC address.\nThis function is not supported if PF set the MAC\naddress for the PF.\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\n drivers/net/i40e/i40e_ethdev.h | 4 +++-\n drivers/net/i40e/i40e_ethdev_vf.c | 48 +++++++++++++++++++++++++++++++++------\n 2 files changed, 44 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.h b/drivers/net/i40e/i40e_ethdev.h\nindex 0db140b..b687b0c 100644\n--- a/drivers/net/i40e/i40e_ethdev.h\n+++ b/drivers/net/i40e/i40e_ethdev.h\n@@ -126,6 +126,7 @@ enum i40e_flxpld_layer_idx {\n #define I40E_FLAG_FDIR (1ULL << 6)\n #define I40E_FLAG_VXLAN (1ULL << 7)\n #define I40E_FLAG_RSS_AQ_CAPABLE (1ULL << 8)\n+#define I40E_FLAG_VF_MAC_BY_PF (1ULL << 9)\n #define I40E_FLAG_ALL (I40E_FLAG_RSS | \\\n \t\t I40E_FLAG_DCB | \\\n \t\t I40E_FLAG_VMDQ | \\\n@@ -134,7 +135,8 @@ enum i40e_flxpld_layer_idx {\n \t\t I40E_FLAG_HEADER_SPLIT_ENABLED | \\\n \t\t I40E_FLAG_FDIR | \\\n \t\t I40E_FLAG_VXLAN | \\\n-\t\t I40E_FLAG_RSS_AQ_CAPABLE)\n+\t\t I40E_FLAG_RSS_AQ_CAPABLE | \\\n+\t\t I40E_FLAG_VF_MAC_BY_PF)\n \n #define I40E_RSS_OFFLOAD_ALL ( \\\n \tETH_RSS_FRAG_IPV4 | \\\ndiff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c\nindex 262c4c1..cc2d03c 100644\n--- a/drivers/net/i40e/i40e_ethdev_vf.c\n+++ b/drivers/net/i40e/i40e_ethdev_vf.c\n@@ -152,6 +152,8 @@ static int i40evf_dev_rss_hash_update(struct rte_eth_dev *dev,\n static int i40evf_dev_rss_hash_conf_get(struct rte_eth_dev *dev,\n \t\t\t\t\tstruct rte_eth_rss_conf *rss_conf);\n static int i40evf_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu);\n+static void i40evf_set_default_mac_addr(struct rte_eth_dev *dev,\n+\t\t\t\t\tstruct ether_addr *mac_addr);\n static int\n i40evf_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id);\n static int\n@@ -227,6 +229,7 @@ struct rte_i40evf_xstats_name_off {\n \t.rss_hash_update = i40evf_dev_rss_hash_update,\n \t.rss_hash_conf_get = i40evf_dev_rss_hash_conf_get,\n \t.mtu_set = i40evf_dev_mtu_set,\n+\t.mac_addr_set = i40evf_set_default_mac_addr,\n };\n \n /*\n@@ -888,19 +891,15 @@ struct rte_i40evf_xstats_name_off {\n }\n \n static void\n-i40evf_del_mac_addr(struct rte_eth_dev *dev, uint32_t index)\n+i40evf_del_mac_addr_by_addr(struct rte_eth_dev *dev, struct ether_addr *addr)\n {\n \tstruct i40e_virtchnl_ether_addr_list *list;\n \tstruct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);\n-\tstruct rte_eth_dev_data *data = dev->data;\n-\tstruct ether_addr *addr;\n \tuint8_t cmd_buffer[sizeof(struct i40e_virtchnl_ether_addr_list) + \\\n \t\t\tsizeof(struct i40e_virtchnl_ether_addr)];\n \tint err;\n \tstruct vf_cmd_info args;\n \n-\taddr = &(data->mac_addrs[index]);\n-\n \tif (i40e_validate_mac_addr(addr->addr_bytes) != I40E_SUCCESS) {\n \t\tPMD_DRV_LOG(ERR, \"Invalid mac:%x-%x-%x-%x-%x-%x\",\n \t\t\t addr->addr_bytes[0], addr->addr_bytes[1],\n@@ -927,6 +926,17 @@ struct rte_i40evf_xstats_name_off {\n \treturn;\n }\n \n+static void\n+i40evf_del_mac_addr(struct rte_eth_dev *dev, uint32_t index)\n+{\n+\tstruct rte_eth_dev_data *data = dev->data;\n+\tstruct ether_addr *addr;\n+\n+\taddr = &data->mac_addrs[index];\n+\n+\ti40evf_del_mac_addr_by_addr(dev, addr);\n+}\n+\n static int\n i40evf_update_stats(struct rte_eth_dev *dev, struct i40e_eth_stats **pstats)\n {\n@@ -1261,10 +1271,12 @@ static int i40evf_dev_xstats_get(struct rte_eth_dev *dev,\n \n \t/* Store the MAC address configured by host, or generate random one */\n \tp_mac_addr = (struct ether_addr *)(vf->vsi_res->default_mac_addr);\n-\tif (is_valid_assigned_ether_addr(p_mac_addr)) /* Configured by host */\n+\tif (is_valid_assigned_ether_addr(p_mac_addr)) { /* Configured by host */\n \t\tether_addr_copy(p_mac_addr, (struct ether_addr *)hw->mac.addr);\n-\telse\n+\t\tvf->flags |= I40E_FLAG_VF_MAC_BY_PF;\n+\t} else {\n \t\teth_random_addr(hw->mac.addr); /* Generate a random one */\n+\t}\n \n \t/* If the PF host is not DPDK, set the interval of ITR0 to max*/\n \tif (vf->version_major != I40E_DPDK_VERSION_MAJOR) {\n@@ -2668,3 +2680,25 @@ static int i40evf_dev_xstats_get(struct rte_eth_dev *dev,\n \n \treturn ret;\n }\n+\n+static void\n+i40evf_set_default_mac_addr(struct rte_eth_dev *dev,\n+\t\t\t struct ether_addr *mac_addr)\n+{\n+\tstruct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);\n+\n+\tif (!is_valid_assigned_ether_addr(mac_addr)) {\n+\t\tPMD_DRV_LOG(ERR, \"Tried to set invalid MAC address.\");\n+\t\treturn;\n+\t}\n+\n+\tif (is_same_ether_addr(mac_addr, dev->data->mac_addrs))\n+\t\treturn;\n+\n+\tif (vf->flags & I40E_FLAG_VF_MAC_BY_PF)\n+\t\treturn;\n+\n+\ti40evf_del_mac_addr_by_addr(dev, dev->data->mac_addrs);\n+\n+\ti40evf_add_mac_addr(dev, mac_addr, 0, 0);\n+}\n", "prefixes": [ "dpdk-dev", "v2", "13/32" ] }