Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/17203/?format=api
{ "id": 17203, "url": "http://patches.dpdk.org/api/patches/17203/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1479931644-78960-2-git-send-email-benjamin.walker@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1479931644-78960-2-git-send-email-benjamin.walker@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1479931644-78960-2-git-send-email-benjamin.walker@intel.com", "date": "2016-11-23T20:07:19", "name": "[dpdk-dev,v2,2/7] pci: Separate detaching ethernet ports from PCI devices", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d536965aa373b41ef6f82ce5dd8e7d4f69c8ba5c", "submitter": { "id": 487, "url": "http://patches.dpdk.org/api/people/487/?format=api", "name": "Walker, Benjamin", "email": "benjamin.walker@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1479931644-78960-2-git-send-email-benjamin.walker@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/17203/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/17203/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 6D0B65694;\n\tWed, 23 Nov 2016 21:07:56 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 91DAC5598\n\tfor <dev@dpdk.org>; Wed, 23 Nov 2016 21:07:33 +0100 (CET)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga101.fm.intel.com with ESMTP; 23 Nov 2016 12:07:31 -0800", "from bwalker-desk.ch.intel.com ([143.182.137.60])\n\tby orsmga002.jf.intel.com with ESMTP; 23 Nov 2016 12:07:31 -0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.31,539,1473145200\"; d=\"scan'208\";a=\"8589957\"", "From": "Ben Walker <benjamin.walker@intel.com>", "To": "dev@dpdk.org", "Cc": "Ben Walker <benjamin.walker@intel.com>", "Date": "Wed, 23 Nov 2016 13:07:19 -0700", "Message-Id": "<1479931644-78960-2-git-send-email-benjamin.walker@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1479931644-78960-1-git-send-email-benjamin.walker@intel.com>", "References": "<1479929804-19614-1-git-send-email-benjamin.walker@intel.com>\n\t<1479931644-78960-1-git-send-email-benjamin.walker@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 2/7] pci: Separate detaching ethernet ports\n\tfrom PCI devices", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Attaching and detaching ethernet ports from an application\nis not the same thing as physically removing a PCI device,\nso clarify the flags indicating support. All PCI devices\nare assumed to be physically removable, so no flag is\nnecessary in the PCI layer.\n\nSigned-off-by: Ben Walker <benjamin.walker@intel.com>\n---\n doc/guides/prog_guide/port_hotplug_framework.rst | 2 +-\n drivers/net/bnxt/bnxt_ethdev.c | 3 ++-\n drivers/net/e1000/em_ethdev.c | 4 ++--\n drivers/net/e1000/igb_ethdev.c | 7 ++++---\n drivers/net/fm10k/fm10k_ethdev.c | 4 ++--\n drivers/net/i40e/i40e_ethdev.c | 4 ++--\n drivers/net/i40e/i40e_ethdev_vf.c | 3 ++-\n drivers/net/ixgbe/ixgbe_ethdev.c | 7 ++++---\n drivers/net/nfp/nfp_net.c | 4 ++--\n drivers/net/virtio/virtio_ethdev.c | 3 ++-\n drivers/net/vmxnet3/vmxnet3_ethdev.c | 3 ++-\n drivers/net/xenvirt/rte_eth_xenvirt.c | 2 +-\n lib/librte_eal/common/include/rte_pci.h | 2 --\n lib/librte_ether/rte_ethdev.c | 2 --\n 14 files changed, 26 insertions(+), 24 deletions(-)", "diff": "diff --git a/doc/guides/prog_guide/port_hotplug_framework.rst b/doc/guides/prog_guide/port_hotplug_framework.rst\nindex 6e4436e..d68d08e 100644\n--- a/doc/guides/prog_guide/port_hotplug_framework.rst\n+++ b/doc/guides/prog_guide/port_hotplug_framework.rst\n@@ -106,5 +106,5 @@ Limitations\n \n * Not all PMDs support detaching feature.\n To know whether a PMD can support detaching, search for the\n- \"RTE_PCI_DRV_DETACHABLE\" flag in PMD implementation. If the flag is\n+ \"RTE_ETH_DEV_DETAHABLE\" flag in rte_eth_dev::data::dev_flags. If the flag is\n defined in the PMD, detaching is supported.\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 035fe07..a2100f6 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -1051,6 +1051,7 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)\n \t\tRTE_LOG(INFO, PMD, \"%s\", bnxt_version);\n \n \trte_eth_copy_pci_info(eth_dev, eth_dev->pci_dev);\n+\teth_dev->data->dev_flags = RTE_ETH_DEV_DETACHABLE;\n \tbp = eth_dev->data->dev_private;\n \n \tif (bnxt_vf_pciid(eth_dev->pci_dev->id.device_id))\n@@ -1162,7 +1163,7 @@ static struct eth_driver bnxt_rte_pmd = {\n \t.pci_drv = {\n \t\t .id_table = bnxt_pci_id_map,\n \t\t .drv_flags = RTE_PCI_DRV_NEED_MAPPING |\n-\t\t\t RTE_PCI_DRV_DETACHABLE | RTE_PCI_DRV_INTR_LSC,\n+\t\t\t RTE_PCI_DRV_INTR_LSC,\n \t\t .probe = rte_eth_dev_pci_probe,\n \t\t .remove = rte_eth_dev_pci_remove\n \t\t },\ndiff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c\nindex aee3d34..9af429b 100644\n--- a/drivers/net/e1000/em_ethdev.c\n+++ b/drivers/net/e1000/em_ethdev.c\n@@ -312,6 +312,7 @@ eth_em_dev_init(struct rte_eth_dev *eth_dev)\n \t}\n \n \trte_eth_copy_pci_info(eth_dev, pci_dev);\n+\teth_dev->data->dev_flags = RTE_ETH_DEV_DETACHABLE;\n \n \thw->hw_addr = (void *)pci_dev->mem_resource[0].addr;\n \thw->device_id = pci_dev->id.device_id;\n@@ -392,8 +393,7 @@ eth_em_dev_uninit(struct rte_eth_dev *eth_dev)\n static struct eth_driver rte_em_pmd = {\n \t.pci_drv = {\n \t\t.id_table = pci_id_em_map,\n-\t\t.drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC |\n-\t\t\tRTE_PCI_DRV_DETACHABLE,\n+\t\t.drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC,\n \t\t.probe = rte_eth_dev_pci_probe,\n \t\t.remove = rte_eth_dev_pci_remove,\n \t},\ndiff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c\nindex 2fddf0c..b014b8b 100644\n--- a/drivers/net/e1000/igb_ethdev.c\n+++ b/drivers/net/e1000/igb_ethdev.c\n@@ -771,6 +771,7 @@ eth_igb_dev_init(struct rte_eth_dev *eth_dev)\n \t}\n \n \trte_eth_copy_pci_info(eth_dev, pci_dev);\n+\teth_dev->data->dev_flags = RTE_ETH_DEV_DETACHABLE;\n \n \thw->hw_addr= (void *)pci_dev->mem_resource[0].addr;\n \n@@ -976,6 +977,7 @@ eth_igbvf_dev_init(struct rte_eth_dev *eth_dev)\n \tpci_dev = eth_dev->pci_dev;\n \n \trte_eth_copy_pci_info(eth_dev, pci_dev);\n+\teth_dev->data->dev_flags = RTE_ETH_DEV_DETACHABLE;\n \n \thw->device_id = pci_dev->id.device_id;\n \thw->vendor_id = pci_dev->id.vendor_id;\n@@ -1079,8 +1081,7 @@ eth_igbvf_dev_uninit(struct rte_eth_dev *eth_dev)\n static struct eth_driver rte_igb_pmd = {\n \t.pci_drv = {\n \t\t.id_table = pci_id_igb_map,\n-\t\t.drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC |\n-\t\t\tRTE_PCI_DRV_DETACHABLE,\n+\t\t.drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC,\n \t\t.probe = rte_eth_dev_pci_probe,\n \t\t.remove = rte_eth_dev_pci_remove,\n \t},\n@@ -1095,7 +1096,7 @@ static struct eth_driver rte_igb_pmd = {\n static struct eth_driver rte_igbvf_pmd = {\n \t.pci_drv = {\n \t\t.id_table = pci_id_igbvf_map,\n-\t\t.drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_DETACHABLE,\n+\t\t.drv_flags = RTE_PCI_DRV_NEED_MAPPING,\n \t\t.probe = rte_eth_dev_pci_probe,\n \t\t.remove = rte_eth_dev_pci_remove,\n \t},\ndiff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c\nindex 923690c..578de1f 100644\n--- a/drivers/net/fm10k/fm10k_ethdev.c\n+++ b/drivers/net/fm10k/fm10k_ethdev.c\n@@ -2841,6 +2841,7 @@ eth_fm10k_dev_init(struct rte_eth_dev *dev)\n \t\treturn 0;\n \n \trte_eth_copy_pci_info(dev, dev->pci_dev);\n+\tdev->data->dev_flags = RTE_ETH_DEV_DETACHABLE;\n \n \tmacvlan = FM10K_DEV_PRIVATE_TO_MACVLAN(dev->data->dev_private);\n \tmemset(macvlan, 0, sizeof(*macvlan));\n@@ -3062,8 +3063,7 @@ static const struct rte_pci_id pci_id_fm10k_map[] = {\n static struct eth_driver rte_pmd_fm10k = {\n \t.pci_drv = {\n \t\t.id_table = pci_id_fm10k_map,\n-\t\t.drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC |\n-\t\t\tRTE_PCI_DRV_DETACHABLE,\n+\t\t.drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC,\n \t\t.probe = rte_eth_dev_pci_probe,\n \t\t.remove = rte_eth_dev_pci_remove,\n \t},\ndiff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex 67778ba..7877cc5 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -671,8 +671,7 @@ static const struct rte_i40e_xstats_name_off rte_i40e_txq_prio_strings[] = {\n static struct eth_driver rte_i40e_pmd = {\n \t.pci_drv = {\n \t\t.id_table = pci_id_i40e_map,\n-\t\t.drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC |\n-\t\t\tRTE_PCI_DRV_DETACHABLE,\n+\t\t.drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC,\n \t\t.probe = rte_eth_dev_pci_probe,\n \t\t.remove = rte_eth_dev_pci_remove,\n \t},\n@@ -955,6 +954,7 @@ eth_i40e_dev_init(struct rte_eth_dev *dev)\n \tpci_dev = dev->pci_dev;\n \n \trte_eth_copy_pci_info(dev, pci_dev);\n+\tdev->data->dev_flags = RTE_ETH_DEV_DETACHABLE;\n \n \tpf->adapter = I40E_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);\n \tpf->adapter->eth_dev = dev;\ndiff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c\nindex aa306d6..6aaee37 100644\n--- a/drivers/net/i40e/i40e_ethdev_vf.c\n+++ b/drivers/net/i40e/i40e_ethdev_vf.c\n@@ -1459,6 +1459,7 @@ i40evf_dev_init(struct rte_eth_dev *eth_dev)\n \t}\n \n \trte_eth_copy_pci_info(eth_dev, eth_dev->pci_dev);\n+\teth_dev->data->dev_flags = RTE_ETH_DEV_DETACHABLE;\n \n \thw->vendor_id = eth_dev->pci_dev->id.vendor_id;\n \thw->device_id = eth_dev->pci_dev->id.device_id;\n@@ -1528,7 +1529,7 @@ i40evf_dev_uninit(struct rte_eth_dev *eth_dev)\n static struct eth_driver rte_i40evf_pmd = {\n \t.pci_drv = {\n \t\t.id_table = pci_id_i40evf_map,\n-\t\t.drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_DETACHABLE,\n+\t\t.drv_flags = RTE_PCI_DRV_NEED_MAPPING,\n \t\t.probe = rte_eth_dev_pci_probe,\n \t\t.remove = rte_eth_dev_pci_remove,\n \t},\ndiff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex edc9b22..66dd0c9 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -1130,6 +1130,7 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev)\n \tpci_dev = eth_dev->pci_dev;\n \n \trte_eth_copy_pci_info(eth_dev, pci_dev);\n+\teth_dev->data->dev_flags = RTE_ETH_DEV_DETACHABLE;\n \n \t/* Vendor and Device ID need to be set before init of shared code */\n \thw->device_id = pci_dev->id.device_id;\n@@ -1422,6 +1423,7 @@ eth_ixgbevf_dev_init(struct rte_eth_dev *eth_dev)\n \tpci_dev = eth_dev->pci_dev;\n \n \trte_eth_copy_pci_info(eth_dev, pci_dev);\n+\teth_dev->data->dev_flags = RTE_ETH_DEV_DETACHABLE;\n \n \thw->device_id = pci_dev->id.device_id;\n \thw->vendor_id = pci_dev->id.vendor_id;\n@@ -1565,8 +1567,7 @@ eth_ixgbevf_dev_uninit(struct rte_eth_dev *eth_dev)\n static struct eth_driver rte_ixgbe_pmd = {\n \t.pci_drv = {\n \t\t.id_table = pci_id_ixgbe_map,\n-\t\t.drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC |\n-\t\t\tRTE_PCI_DRV_DETACHABLE,\n+\t\t.drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC,\n \t\t.probe = rte_eth_dev_pci_probe,\n \t\t.remove = rte_eth_dev_pci_remove,\n \t},\n@@ -1581,7 +1582,7 @@ static struct eth_driver rte_ixgbe_pmd = {\n static struct eth_driver rte_ixgbevf_pmd = {\n \t.pci_drv = {\n \t\t.id_table = pci_id_ixgbevf_map,\n-\t\t.drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_DETACHABLE,\n+\t\t.drv_flags = RTE_PCI_DRV_NEED_MAPPING,\n \t\t.probe = rte_eth_dev_pci_probe,\n \t\t.remove = rte_eth_dev_pci_remove,\n \t},\ndiff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c\nindex c6b1587..00d2ba2 100644\n--- a/drivers/net/nfp/nfp_net.c\n+++ b/drivers/net/nfp/nfp_net.c\n@@ -2332,6 +2332,7 @@ nfp_net_init(struct rte_eth_dev *eth_dev)\n \n \tpci_dev = eth_dev->pci_dev;\n \trte_eth_copy_pci_info(eth_dev, pci_dev);\n+\teth_dev->data->dev_flags = RTE_ETH_DEV_DETACHABLE;\n \n \thw->device_id = pci_dev->id.device_id;\n \thw->vendor_id = pci_dev->id.vendor_id;\n@@ -2470,8 +2471,7 @@ static struct rte_pci_id pci_id_nfp_net_map[] = {\n static struct eth_driver rte_nfp_net_pmd = {\n \t.pci_drv = {\n \t\t.id_table = pci_id_nfp_net_map,\n-\t\t.drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC |\n-\t\t\t RTE_PCI_DRV_DETACHABLE,\n+\t\t.drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC,\n \t\t.probe = rte_eth_dev_pci_probe,\n \t\t.remove = rte_eth_dev_pci_remove,\n \t},\ndiff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex 079fd6c..74255c5 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -1211,6 +1211,7 @@ virtio_init_device(struct rte_eth_dev *eth_dev, uint64_t req_features)\n \t\teth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_LSC;\n \n \trte_eth_copy_pci_info(eth_dev, pci_dev);\n+\teth_dev->data->dev_flags = RTE_ETH_DEV_DETACHABLE;\n \n \trx_func_get(eth_dev);\n \n@@ -1379,7 +1380,7 @@ static struct eth_driver rte_virtio_pmd = {\n \t\t\t.name = \"net_virtio\",\n \t\t},\n \t\t.id_table = pci_id_virtio_map,\n-\t\t.drv_flags = RTE_PCI_DRV_DETACHABLE,\n+\t\t.drv_flags = 0,\n \t\t.probe = rte_eth_dev_pci_probe,\n \t\t.remove = rte_eth_dev_pci_remove,\n \t},\ndiff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c\nindex 8bb13e5..dd8dca5 100644\n--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c\n+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c\n@@ -247,6 +247,7 @@ eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev)\n \t\treturn 0;\n \n \trte_eth_copy_pci_info(eth_dev, pci_dev);\n+\teth_dev->data->dev_flags = RTE_ETH_DEV_DETACHABLE;\n \n \t/* Vendor and Device ID need to be set before init of shared code */\n \thw->device_id = pci_dev->id.device_id;\n@@ -336,7 +337,7 @@ eth_vmxnet3_dev_uninit(struct rte_eth_dev *eth_dev)\n static struct eth_driver rte_vmxnet3_pmd = {\n \t.pci_drv = {\n \t\t.id_table = pci_id_vmxnet3_map,\n-\t\t.drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_DETACHABLE,\n+\t\t.drv_flags = RTE_PCI_DRV_NEED_MAPPING,\n \t\t.probe = rte_eth_dev_pci_probe,\n \t\t.remove = rte_eth_dev_pci_remove,\n \t},\ndiff --git a/drivers/net/xenvirt/rte_eth_xenvirt.c b/drivers/net/xenvirt/rte_eth_xenvirt.c\nindex c08a056..ec5d00b 100644\n--- a/drivers/net/xenvirt/rte_eth_xenvirt.c\n+++ b/drivers/net/xenvirt/rte_eth_xenvirt.c\n@@ -673,7 +673,7 @@ eth_dev_xenvirt_create(const char *name, const char *params,\n \teth_dev->data = data;\n \teth_dev->dev_ops = &ops;\n \n-\teth_dev->data->dev_flags = RTE_PCI_DRV_DETACHABLE;\n+\teth_dev->data->dev_flags = RTE_ETH_DEV_DETACHABLE;\n \teth_dev->data->kdrv = RTE_KDRV_NONE;\n \teth_dev->data->drv_name = drivername;\n \teth_dev->driver = NULL;\ndiff --git a/lib/librte_eal/common/include/rte_pci.h b/lib/librte_eal/common/include/rte_pci.h\nindex 9ce8847..74be1f5 100644\n--- a/lib/librte_eal/common/include/rte_pci.h\n+++ b/lib/librte_eal/common/include/rte_pci.h\n@@ -212,8 +212,6 @@ struct rte_pci_driver {\n #define RTE_PCI_DRV_FORCE_UNBIND 0x0004\n /** Device driver supports link state interrupt */\n #define RTE_PCI_DRV_INTR_LSC\t0x0008\n-/** Device driver supports detaching capability */\n-#define RTE_PCI_DRV_DETACHABLE\t0x0010\n \n /**\n * A structure describing a PCI mapping.\ndiff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c\nindex fde8112..3771ffc 100644\n--- a/lib/librte_ether/rte_ethdev.c\n+++ b/lib/librte_ether/rte_ethdev.c\n@@ -3209,8 +3209,6 @@ rte_eth_copy_pci_info(struct rte_eth_dev *eth_dev, struct rte_pci_device *pci_de\n \teth_dev->data->dev_flags = 0;\n \tif (pci_dev->driver->drv_flags & RTE_PCI_DRV_INTR_LSC)\n \t\teth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_LSC;\n-\tif (pci_dev->driver->drv_flags & RTE_PCI_DRV_DETACHABLE)\n-\t\teth_dev->data->dev_flags |= RTE_ETH_DEV_DETACHABLE;\n \n \teth_dev->data->kdrv = pci_dev->kdrv;\n \teth_dev->data->numa_node = pci_dev->device.numa_node;\n", "prefixes": [ "dpdk-dev", "v2", "2/7" ] }