Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 17088,
    "url": "http://patches.dpdk.org/api/patches/17088/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1479460122-18780-1-git-send-email-haifeng.lin@huawei.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1479460122-18780-1-git-send-email-haifeng.lin@huawei.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1479460122-18780-1-git-send-email-haifeng.lin@huawei.com",
    "date": "2016-11-18T09:08:42",
    "name": "[dpdk-dev] net/bonding: improve non-ip packets RSS",
    "commit_ref": null,
    "pull_url": null,
    "state": "rejected",
    "archived": true,
    "hash": "8d781aa671062622c3061722b5965d76901b9669",
    "submitter": {
        "id": 69,
        "url": "http://patches.dpdk.org/api/people/69/?format=api",
        "name": "Linhaifeng",
        "email": "haifeng.lin@huawei.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1479460122-18780-1-git-send-email-haifeng.lin@huawei.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/17088/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/17088/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 901F85591;\n\tFri, 18 Nov 2016 10:09:13 +0100 (CET)",
            "from szxga02-in.huawei.com (unknown [119.145.14.65])\n\tby dpdk.org (Postfix) with ESMTP id 72E3937B2\n\tfor <dev@dpdk.org>; Fri, 18 Nov 2016 10:09:03 +0100 (CET)",
            "from 172.24.1.136 (EHLO szxeml434-hub.china.huawei.com)\n\t([172.24.1.136])\n\tby szxrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued)\n\twith ESMTP id DQX20579; Fri, 18 Nov 2016 17:08:51 +0800 (CST)",
            "from localhost (10.177.20.223) by szxeml434-hub.china.huawei.com\n\t(10.82.67.225) with Microsoft SMTP Server id 14.3.235.1;\n\tFri, 18 Nov 2016 17:08:44 +0800"
        ],
        "From": "Haifeng Lin <haifeng.lin@huawei.com>",
        "To": "<dev@dpdk.org>",
        "CC": "<declan.doherty@intel.com>, <jerry.lilijun@huawei.com>",
        "Date": "Fri, 18 Nov 2016 17:08:42 +0800",
        "Message-ID": "<1479460122-18780-1-git-send-email-haifeng.lin@huawei.com>",
        "X-Mailer": "git-send-email 1.8.5.2.msysgit.0",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[10.177.20.223]",
        "X-CFilter-Loop": "Reflected",
        "Subject": "[dpdk-dev] [PATCH] net/bonding: improve non-ip packets RSS",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Most ethernet not support non-ip packets RSS and only first\nqueue can used to receive. In this scenario lacp bond can\nonly use one queue even if multi queue configured.\n\nWe use below formula to change the map between bond_qid and\nslave_qid to let at least slave_num queues to receive packets:\n\n\tslave_qid = (bond_qid + slave_id) % queue_num\n\nSigned-off-by: Haifeng Lin <haifeng.lin@huawei.com>\n---\n drivers/net/bonding/rte_eth_bond_pmd.c | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex 09ce7bf..8ad843a 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -141,6 +141,8 @@ bond_ethdev_rx_burst_8023ad(void *queue, struct rte_mbuf **bufs,\n \tuint8_t collecting;  /* current slave collecting status */\n \tconst uint8_t promisc = internals->promiscuous_en;\n \tuint8_t i, j, k;\n+\tint slave_qid, bond_qid = bd_rx_q->queue_id;\n+\tint queue_num = internals->nb_rx_queues;\n \n \trte_eth_macaddr_get(internals->port_id, &bond_mac);\n \t/* Copy slave list to protect against slave up/down changes during tx\n@@ -154,7 +156,9 @@ bond_ethdev_rx_burst_8023ad(void *queue, struct rte_mbuf **bufs,\n \t\tcollecting = ACTOR_STATE(&mode_8023ad_ports[slaves[i]], COLLECTING);\n \n \t\t/* Read packets from this slave */\n-\t\tnum_rx_total += rte_eth_rx_burst(slaves[i], bd_rx_q->queue_id,\n+\t\tslave_qid = queue_num ? (bond_qid + slaves[i]) % queue_num :\n+\t\t\t\tbond_qid;\n+\t\tnum_rx_total += rte_eth_rx_burst(slaves[i], slave_qid,\n \t\t\t\t&bufs[num_rx_total], nb_pkts - num_rx_total);\n \n \t\tfor (k = j; k < 2 && k < num_rx_total; k++)\n",
    "prefixes": [
        "dpdk-dev"
    ]
}