Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/17078/?format=api
{ "id": 17078, "url": "http://patches.dpdk.org/api/patches/17078/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1479403792-11928-1-git-send-email-laurent.hardy@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1479403792-11928-1-git-send-email-laurent.hardy@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1479403792-11928-1-git-send-email-laurent.hardy@6wind.com", "date": "2016-11-17T17:29:52", "name": "[dpdk-dev] net/ixgbe: ensure link status is updated", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "aba9ebc6ea35bf337837fd06aad6c9d9061eba37", "submitter": { "id": 606, "url": "http://patches.dpdk.org/api/people/606/?format=api", "name": "Laurent Hardy", "email": "laurent.hardy@6wind.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1479403792-11928-1-git-send-email-laurent.hardy@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/17078/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/17078/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 2789C558D;\n\tThu, 17 Nov 2016 18:30:11 +0100 (CET)", "from mail-wm0-f48.google.com (mail-wm0-f48.google.com\n\t[74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 8BCC6558A\n\tfor <dev@dpdk.org>; Thu, 17 Nov 2016 18:30:06 +0100 (CET)", "by mail-wm0-f48.google.com with SMTP id a197so324577594wmd.0\n\tfor <dev@dpdk.org>; Thu, 17 Nov 2016 09:30:06 -0800 (PST)", "from sphinx.vm.6wind.com. (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by smtp.gmail.com with ESMTPSA id\n\td85sm16781828wmd.17.2016.11.17.09.30.05\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 17 Nov 2016 09:30:05 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=uMfEae4Fn9HyuKdg1Ptm626vNek8AtqiVIRK4NpCQmE=;\n\tb=KJpmXlggIoDY1055SP7iLZxOZZUoi4Tv1nzcXEMWO+gDRvS+7isA5g/yHarJG55RjC\n\tmFrD18jQxbItqLScQIWGR1h9/vLCdKcIAiWZEWspj0oMuDJ1qCrW+aCRDrRjHsNkNveT\n\tjAssQkIXDjFOBFN6WKRwQEYCJYz2obu9DSyC9V9C/k1amJTNny4kD7OK7Z0X7Zj5FtnB\n\tfNhtMt9Ag4ggnk3i/ciGVAyZT/kr0DbF2m+LzGoYDC2Jxtb71OOoqcs+3mKcUOsEms0v\n\thiqPj5Cw1xyjjavItSHUYX78VYThMKbDcR1/WGtnpODbWzp8gwRMdm8DYeNHrJ6DKNHo\n\t7jSQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=uMfEae4Fn9HyuKdg1Ptm626vNek8AtqiVIRK4NpCQmE=;\n\tb=nNAiFFvjp4zseEXPPaKwt9kRnLO9HdVWXLYDFufN1RxcDO544sJlHOrYL9cjjQ1UMX\n\t+iyw/+EA+BWMreXHQYbVNXlfxyjedDZ9gV01ONqAM2rwlT9agoa6VSHTJ6Drg8YQGMy6\n\ts2RS/2rK0I8coGkgCVVChQP0b+lQ3IEu96Q6rqUaEcglzMHvV4gREwzZTrGXQxyVeuxK\n\tEfM2bvrQMnvSo0wWgRAiQAsIr40TsE1n3dJuA7jOfIF6hMBVIg0gPLOlkuyWG0kkeCRq\n\tJMeGUVNa6BN9gocy3d9k9bJVHwEYy1ZHjlCFS+mAFGeZbnW7a7KnNt0mrPmQ1ZVvt/fC\n\thpAg==", "X-Gm-Message-State": "ABUngvfdnwPC/sbF6MM8Z7qv432evltKh0hy/5XXiH2Ej1GAtF3gBISU0UjHSQTC9ZDWe5DQ", "X-Received": "by 10.28.185.78 with SMTP id j75mr17081982wmf.14.1479403806234; \n\tThu, 17 Nov 2016 09:30:06 -0800 (PST)", "From": "Laurent Hardy <laurent.hardy@6wind.com>", "To": "helin.zhang@intel.com,\n\tkonstantin.ananyev@intel.com", "Cc": "dev@dpdk.org", "Date": "Thu, 17 Nov 2016 18:29:52 +0100", "Message-Id": "<1479403792-11928-1-git-send-email-laurent.hardy@6wind.com>", "X-Mailer": "git-send-email 1.7.10.4", "Subject": "[dpdk-dev] [PATCH] net/ixgbe: ensure link status is updated", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In case of link speed set to 1Gb at peer side (with autoneg or with\ndefined speed) and cable not plugged-in when device is configured\nand started, then link status is not updated properly with new speed\nas no link setup is triggered.\n\nTo avoid this issue, IXGBE_FLAG_NEED_LINK_CONFIG is set to try a link\nsetup each time link_update() is triggered and current link status is\ndown. When cable is plugged-in, link setup will be performed via\nixgbe_setup_link().\n\nSigned-off-by: Laurent Hardy <laurent.hardy@6wind.com>\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 20 ++++++++++++++++++++\n drivers/net/ixgbe/ixgbe_ethdev.h | 1 +\n 2 files changed, 21 insertions(+)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 52ebbe4..513d1d5 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -2095,6 +2095,7 @@ ixgbe_dev_configure(struct rte_eth_dev *dev)\n \n \t/* set flag to update link status after init */\n \tintr->flags |= IXGBE_FLAG_NEED_LINK_UPDATE;\n+\tintr->flags |= IXGBE_FLAG_NEED_LINK_CONFIG;\n \n \t/*\n \t * Initialize to TRUE. If any of Rx queues doesn't meet the bulk\n@@ -3117,8 +3118,12 @@ ixgbe_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete)\n \tstruct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \tstruct rte_eth_link link, old;\n \tixgbe_link_speed link_speed = IXGBE_LINK_SPEED_UNKNOWN;\n+\tstruct ixgbe_interrupt *intr =\n+\t\tIXGBE_DEV_PRIVATE_TO_INTR(dev->data->dev_private);\n \tint link_up;\n \tint diag;\n+\tu32 speed = 0;\n+\tbool autoneg = false;\n \n \tlink.link_status = ETH_LINK_DOWN;\n \tlink.link_speed = 0;\n@@ -3128,6 +3133,19 @@ ixgbe_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete)\n \n \thw->mac.get_link_status = true;\n \n+\tif (intr->flags & IXGBE_FLAG_NEED_LINK_CONFIG) {\n+\t\tspeed = hw->phy.autoneg_advertised;\n+\t\tif (!speed) {\n+\t\t\tixgbe_get_link_capabilities(hw, &speed, &autoneg);\n+\t\t\t/* setup the highest link when no autoneg */\n+\t\t\tif (!autoneg) {\n+\t\t\t\tif (speed & IXGBE_LINK_SPEED_10GB_FULL)\n+\t\t\t\t\tspeed = IXGBE_LINK_SPEED_10GB_FULL;\n+\t\t\t}\n+\t\t}\n+\t\tixgbe_setup_link(hw, speed, true);\n+\t}\n+\n \t/* check if it needs to wait to complete, if lsc interrupt is enabled */\n \tif (wait_to_complete == 0 || dev->data->dev_conf.intr_conf.lsc != 0)\n \t\tdiag = ixgbe_check_link(hw, &link_speed, &link_up, 0);\n@@ -3145,10 +3163,12 @@ ixgbe_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete)\n \n \tif (link_up == 0) {\n \t\trte_ixgbe_dev_atomic_write_link_status(dev, &link);\n+\t\tintr->flags |= IXGBE_FLAG_NEED_LINK_CONFIG;\n \t\tif (link.link_status == old.link_status)\n \t\t\treturn -1;\n \t\treturn 0;\n \t}\n+\tintr->flags &= ~IXGBE_FLAG_NEED_LINK_CONFIG;\n \tlink.link_status = ETH_LINK_UP;\n \tlink.link_duplex = ETH_LINK_FULL_DUPLEX;\n \ndiff --git a/drivers/net/ixgbe/ixgbe_ethdev.h b/drivers/net/ixgbe/ixgbe_ethdev.h\nindex e060c3d..9d335ba 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.h\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.h\n@@ -43,6 +43,7 @@\n #define IXGBE_FLAG_NEED_LINK_UPDATE (uint32_t)(1 << 0)\n #define IXGBE_FLAG_MAILBOX (uint32_t)(1 << 1)\n #define IXGBE_FLAG_PHY_INTERRUPT (uint32_t)(1 << 2)\n+#define IXGBE_FLAG_NEED_LINK_CONFIG (uint32_t)(1 << 3)\n \n /*\n * Defines that were not part of ixgbe_type.h as they are not used by the\n", "prefixes": [ "dpdk-dev" ] }