Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/15054/?format=api
{ "id": 15054, "url": "http://patches.dpdk.org/api/patches/15054/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1469800228-29558-1-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1469800228-29558-1-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1469800228-29558-1-git-send-email-thomas.monjalon@6wind.com", "date": "2016-07-29T13:50:28", "name": "[dpdk-dev,v2] log: remove history dump", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "cef972ef427b0689bf415fabffb940f453c5cf97", "submitter": { "id": 1, "url": "http://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1469800228-29558-1-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/15054/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/15054/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id B669F5323;\n\tFri, 29 Jul 2016 15:55:30 +0200 (CEST)", "from mail-wm0-f51.google.com (mail-wm0-f51.google.com\n\t[74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 7E929376D\n\tfor <dev@dpdk.org>; Fri, 29 Jul 2016 15:55:29 +0200 (CEST)", "by mail-wm0-f51.google.com with SMTP id f65so291268801wmi.0\n\tfor <dev@dpdk.org>; Fri, 29 Jul 2016 06:55:29 -0700 (PDT)", "from XPS13.localdomain (184.203.134.77.rev.sfr.net.\n\t[77.134.203.184]) by smtp.gmail.com with ESMTPSA id\n\th7sm16699055wjd.17.2016.07.29.06.55.27 for <dev@dpdk.org>\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 29 Jul 2016 06:55:28 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:subject:date:message-id:in-reply-to:references;\n\tbh=gJKWftrQQX+x0Kti0kl5JePpq3bjbbK/Zo7DhU33GUs=;\n\tb=GuKx8iG5rYkDzgN/5Dx44wVOe/trGVyDqvKxtXuc7MGzy+lobsWSW9a2HjlnKRlTPi\n\tDRguCs9Zg10HJ/7dUfFXkYOVnXCaRhIl2oQsrp2sa5NQTG2IiQRGFmO38DXyRdwlfpVY\n\t7pYbPF37UeVeBEiJbmp8bUJ1Ed4D9GewPpajMRPB4E6gt8JpDEmWBArijB126ek+S9XS\n\togPUccUEs9jg9Axau14em3Y9q+c0y1sxh7frclq/Lt8G42n80ZQqmuwmKdhgDHTeMgQn\n\tymsRocQQ05EdIis2ZvncwSk20bQfv0jf+ynQtxW9/HFt9uy77lhPYULX5jyvESQFb+ZN\n\tqJEA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=gJKWftrQQX+x0Kti0kl5JePpq3bjbbK/Zo7DhU33GUs=;\n\tb=Na2S6SrVMPG5D928Ga/vfOp+CCXcw/NvKMh3IZvyPPrFZ9aOoWes7Iu05ogTaFR0Wy\n\t2NIgVc7fdk5QcIkzlXuaze2KFaQ9sgyPLmeaxaX9LLe5uzsTVgVjaTHP8qyrdmMI0tny\n\tkXay45n0ZM4pIa5rGC6TZ83HIPK05JV93Bkz3+6zEtw1Vl4ZQSogMvHfSoA1f/QmenmE\n\tt5BmCtvBK/1rXCnaDyAmN0d6QapJe6DrJ8RxNTu1XQvlQTlbIo+256fNqfh/ToFmlQXd\n\tNxCGMPPZ1jCZ90U4NQWqYig0UMCgp7rxYjNKAa8QNmdOvVwfWmUaClmbxL68J6u3shW+\n\tiniw==", "X-Gm-Message-State": "AEkoouv8gFGe+0NYY1qxMtYm0GxGCQeb5YwbFfS20s4tAat0MqQEKXAST7W6Pm4XCntk4xtR", "X-Received": "by 10.194.149.176 with SMTP id\n\tub16mr38609286wjb.54.1469800528769; \n\tFri, 29 Jul 2016 06:55:28 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "dev@dpdk.org", "Date": "Fri, 29 Jul 2016 15:50:28 +0200", "Message-Id": "<1469800228-29558-1-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.7.0", "In-Reply-To": "<1469797306-14527-1-git-send-email-thomas.monjalon@6wind.com>", "References": "<1469797306-14527-1-git-send-email-thomas.monjalon@6wind.com>", "Subject": "[dpdk-dev] [PATCH v2] log: remove history dump", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The log history feature was deprecated in 16.07.\nThe remaining empty functions are removed in 16.11.\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\nv2: fix LIBABIVER and compilation of test\n---\n app/test/test.h | 5 +++-\n doc/guides/rel_notes/deprecation.rst | 3 ---\n doc/guides/rel_notes/release_16_11.rst | 4 +++-\n lib/librte_eal/bsdapp/eal/Makefile | 2 +-\n lib/librte_eal/common/eal_common_log.c | 19 ---------------\n lib/librte_eal/common/include/rte_log.h | 41 ---------------------------------\n lib/librte_eal/linuxapp/eal/Makefile | 2 +-\n 7 files changed, 9 insertions(+), 67 deletions(-)", "diff": "diff --git a/app/test/test.h b/app/test/test.h\nindex 467b9c0..74d6021 100644\n--- a/app/test/test.h\n+++ b/app/test/test.h\n@@ -33,9 +33,12 @@\n \n #ifndef _TEST_H_\n #define _TEST_H_\n+\n #include <stddef.h>\n #include <sys/queue.h>\n-#include \"rte_log.h\"\n+\n+#include <rte_common.h>\n+#include <rte_log.h>\n \n #define TEST_SUCCESS (0)\n #define TEST_FAILED (-1)\ndiff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 8263d03..96db661 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -8,9 +8,6 @@ API and ABI deprecation notices are to be posted here.\n Deprecation Notices\n -------------------\n \n-* The log history is deprecated.\n- It is voided in 16.07 and will be removed in release 16.11.\n-\n * The ethdev library file will be renamed from libethdev.* to librte_ethdev.*\n in release 16.11 in order to have a more consistent namespace.\n \ndiff --git a/doc/guides/rel_notes/release_16_11.rst b/doc/guides/rel_notes/release_16_11.rst\nindex a6e3307..0b9022d 100644\n--- a/doc/guides/rel_notes/release_16_11.rst\n+++ b/doc/guides/rel_notes/release_16_11.rst\n@@ -94,6 +94,8 @@ API Changes\n \n This section is a comment. Make sure to start the actual text at the margin.\n \n+* The log history is removed.\n+\n \n ABI Changes\n -----------\n@@ -131,7 +133,7 @@ The libraries prepended with a plus sign were incremented in this version.\n librte_cmdline.so.2\n librte_cryptodev.so.1\n librte_distributor.so.1\n- librte_eal.so.2\n+ + librte_eal.so.3\n librte_hash.so.2\n librte_ip_frag.so.1\n librte_ivshmem.so.1\ndiff --git a/lib/librte_eal/bsdapp/eal/Makefile b/lib/librte_eal/bsdapp/eal/Makefile\nindex 988cbbc..7a0fea5 100644\n--- a/lib/librte_eal/bsdapp/eal/Makefile\n+++ b/lib/librte_eal/bsdapp/eal/Makefile\n@@ -48,7 +48,7 @@ LDLIBS += -lgcc_s\n \n EXPORT_MAP := rte_eal_version.map\n \n-LIBABIVER := 2\n+LIBABIVER := 3\n \n # specific to linuxapp exec-env\n SRCS-$(CONFIG_RTE_EXEC_ENV_BSDAPP) := eal.c\ndiff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c\nindex 7916c78..967991a 100644\n--- a/lib/librte_eal/common/eal_common_log.c\n+++ b/lib/librte_eal/common/eal_common_log.c\n@@ -64,19 +64,6 @@ static RTE_DEFINE_PER_LCORE(struct log_cur_msg, log_cur_msg);\n \n /* default logs */\n \n-int\n-rte_log_add_in_history(const char *buf __rte_unused, size_t size __rte_unused)\n-{\n-\treturn 0;\n-}\n-\n-void\n-rte_log_set_history(int enable)\n-{\n-\tif (enable)\n-\t\tRTE_LOG(WARNING, EAL, \"The log history is deprecated.\\n\");\n-}\n-\n /* Change the stream that will be used by logging system */\n int\n rte_openlog_stream(FILE *f)\n@@ -131,12 +118,6 @@ int rte_log_cur_msg_logtype(void)\n \treturn RTE_PER_LCORE(log_cur_msg).logtype;\n }\n \n-/* Dump log history to file */\n-void\n-rte_log_dump_history(FILE *out __rte_unused)\n-{\n-}\n-\n /*\n * Generates a log message The message will be sent in the stream\n * defined by the previous call to rte_openlog_stream().\ndiff --git a/lib/librte_eal/common/include/rte_log.h b/lib/librte_eal/common/include/rte_log.h\nindex b1add04..919563c 100644\n--- a/lib/librte_eal/common/include/rte_log.h\n+++ b/lib/librte_eal/common/include/rte_log.h\n@@ -42,8 +42,6 @@\n * This file provides a log API to RTE applications.\n */\n \n-#include \"rte_common.h\" /* for __rte_deprecated macro */\n-\n #ifdef __cplusplus\n extern \"C\" {\n #endif\n@@ -181,45 +179,6 @@ int rte_log_cur_msg_loglevel(void);\n int rte_log_cur_msg_logtype(void);\n \n /**\n- * @deprecated\n- * Enable or disable the history (enabled by default)\n- *\n- * @param enable\n- * true to enable, or 0 to disable history.\n- */\n-__rte_deprecated\n-void rte_log_set_history(int enable);\n-\n-/**\n- * @deprecated\n- * Dump the log history to a file\n- *\n- * @param f\n- * A pointer to a file for output\n- */\n-__rte_deprecated\n-void rte_log_dump_history(FILE *f);\n-\n-/**\n- * @deprecated\n- * Add a log message to the history.\n- *\n- * This function can be called from a user-defined log stream. It adds\n- * the given message in the history that can be dumped using\n- * rte_log_dump_history().\n- *\n- * @param buf\n- * A data buffer containing the message to be saved in the history.\n- * @param size\n- * The length of the data buffer.\n- * @return\n- * - 0: Success.\n- * - (-ENOBUFS) if there is no room to store the message.\n- */\n-__rte_deprecated\n-int rte_log_add_in_history(const char *buf, size_t size);\n-\n-/**\n * Generates a log message.\n *\n * The message will be sent in the stream defined by the previous call\ndiff --git a/lib/librte_eal/linuxapp/eal/Makefile b/lib/librte_eal/linuxapp/eal/Makefile\nindex 182729c..3a7631a 100644\n--- a/lib/librte_eal/linuxapp/eal/Makefile\n+++ b/lib/librte_eal/linuxapp/eal/Makefile\n@@ -37,7 +37,7 @@ ARCH_DIR ?= $(RTE_ARCH)\n EXPORT_MAP := rte_eal_version.map\n VPATH += $(RTE_SDK)/lib/librte_eal/common/arch/$(ARCH_DIR)\n \n-LIBABIVER := 2\n+LIBABIVER := 3\n \n VPATH += $(RTE_SDK)/lib/librte_eal/common\n \n", "prefixes": [ "dpdk-dev", "v2" ] }