Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/14989/?format=api
{ "id": 14989, "url": "http://patches.dpdk.org/api/patches/14989/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1469154287-88523-1-git-send-email-jianfeng.tan@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1469154287-88523-1-git-send-email-jianfeng.tan@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1469154287-88523-1-git-send-email-jianfeng.tan@intel.com", "date": "2016-07-22T02:24:47", "name": "[dpdk-dev] net/virtio_user: fix inconsistent name", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c28aecc580195765dacaa9fefa61c2e043cf3148", "submitter": { "id": 313, "url": "http://patches.dpdk.org/api/people/313/?format=api", "name": "Jianfeng Tan", "email": "jianfeng.tan@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1469154287-88523-1-git-send-email-jianfeng.tan@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/14989/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/14989/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 39CA64A65;\n\tFri, 22 Jul 2016 04:25:10 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 826A547CD\n\tfor <dev@dpdk.org>; Fri, 22 Jul 2016 04:25:08 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga102.fm.intel.com with ESMTP; 21 Jul 2016 19:25:04 -0700", "from dpdk06.sh.intel.com ([10.239.129.195])\n\tby fmsmga001.fm.intel.com with ESMTP; 21 Jul 2016 19:25:02 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.28,402,1464678000\"; d=\"scan'208\";\n\ta=\"1011661918\"", "From": "Jianfeng Tan <jianfeng.tan@intel.com>", "To": "dev@dpdk.org", "Cc": "yuanhan.liu@linux.intel.com, tiwei.bie@intel.com,\n\tJianfeng Tan <jianfeng.tan@intel.com>", "Date": "Fri, 22 Jul 2016 02:24:47 +0000", "Message-Id": "<1469154287-88523-1-git-send-email-jianfeng.tan@intel.com>", "X-Mailer": "git-send-email 2.7.4", "Subject": "[dpdk-dev] [PATCH] net/virtio_user: fix inconsistent name", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The commit cb6696d22023 (\"drivers: update registration macro usage\")\nchanges the name from virtio-user to virtio_user, because hyphen\ncannot be used in a C symbol name. However, this commit does not\nupdate the strings in docs and source code, which could lead to\nfailure to start this device as per the docs.\n\nThis patch updates related strings in the docs and source code.\n\nFixes: cb6696d22023 (\"drivers: update registration macro usage\")\n\nReported-by: Tiwei Bie <tiwei.bie@intel.com>\nSigned-off-by: Jianfeng Tan <jianfeng.tan@intel.com>\n---\n doc/guides/rel_notes/release_16_07.rst | 2 +-\n doc/guides/sample_app_ug/vhost.rst | 12 ++++++------\n drivers/net/virtio/virtio_ethdev.c | 4 ++--\n drivers/net/virtio/virtio_user_ethdev.c | 6 +++---\n drivers/net/virtio/virtqueue.h | 2 +-\n 5 files changed, 13 insertions(+), 13 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_16_07.rst b/doc/guides/rel_notes/release_16_07.rst\nindex d3a144f..0740d4f 100644\n--- a/doc/guides/rel_notes/release_16_07.rst\n+++ b/doc/guides/rel_notes/release_16_07.rst\n@@ -90,7 +90,7 @@ New Features\n \n * **Virtio support for containers.**\n \n- Add a new virtual device, named virtio-user, to support virtio for containers.\n+ Add a new virtual device, named virtio_user, to support virtio for containers.\n \n Known limitations:\n \ndiff --git a/doc/guides/sample_app_ug/vhost.rst b/doc/guides/sample_app_ug/vhost.rst\nindex a93e54d..2b7defc 100644\n--- a/doc/guides/sample_app_ug/vhost.rst\n+++ b/doc/guides/sample_app_ug/vhost.rst\n@@ -834,19 +834,19 @@ The above message indicates that device 0 has been registered with MAC address c\n Any packets received on the NIC with these values is placed on the devices receive queue.\n When a virtio-net device transmits packets, the VLAN tag is added to the packet by the DPDK vhost sample code.\n \n-Running virtio-user with vhost-switch\n+Running virtio_user with vhost-switch\n -------------------------------------\n \n-We can also use virtio-user with vhost-switch now.\n-Virtio-user is a virtual device that can be run in a application (container) parallelly with vhost in the same OS,\n+We can also use virtio_user with vhost-switch now.\n+Virtio_user is a virtual device that can be run in a application (container) parallelly with vhost in the same OS,\n aka, there is no need to start a VM. We just run it with a different --file-prefix to avoid startup failure.\n \n .. code-block:: console\n \n cd ${RTE_SDK}/x86_64-native-linuxapp-gcc/app\n- ./testpmd -c 0x3 -n 4 --socket-mem 1024 --no-pci --file-prefix=virtio-user-testpmd \\\n- --vdev=virtio-user0,mac=00:01:02:03:04:05,path=$path_vhost \\\n+ ./testpmd -c 0x3 -n 4 --socket-mem 1024 --no-pci --file-prefix=virtio_user-testpmd \\\n+ --vdev=virtio_user0,mac=00:01:02:03:04:05,path=$path_vhost \\\n -- -i --txqflags=0xf01 --disable-hw-vlan\n \n There is no difference on the vhost side.\n-Pleae note that there are some limitations (see release note for more information) in the usage of virtio-user.\n+Pleae note that there are some limitations (see release note for more information) in the usage of virtio_user.\ndiff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex 850e3ba..c1ff2ac 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -452,7 +452,7 @@ int virtio_dev_queue_setup(struct rte_eth_dev *dev,\n \t\t*pvq = cvq;\n \t}\n \n-\t/* For virtio-user case (that is when dev->pci_dev is NULL), we use\n+\t/* For virtio_user case (that is when dev->pci_dev is NULL), we use\n \t * virtual address. And we need properly set _offset_, please see\n \t * MBUF_DATA_DMA_ADDR in virtqueue.h for more information.\n \t */\n@@ -1541,7 +1541,7 @@ virtio_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \tif (dev->pci_dev)\n \t\tdev_info->driver_name = dev->driver->pci_drv.name;\n \telse\n-\t\tdev_info->driver_name = \"virtio-user PMD\";\n+\t\tdev_info->driver_name = \"virtio_user PMD\";\n \tdev_info->max_rx_queues = (uint16_t)hw->max_rx_queues;\n \tdev_info->max_tx_queues = (uint16_t)hw->max_tx_queues;\n \tdev_info->min_rx_bufsize = VIRTIO_MIN_RX_BUFSIZE;\ndiff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c\nindex 6b4f66e..daef09b 100644\n--- a/drivers/net/virtio/virtio_user_ethdev.c\n+++ b/drivers/net/virtio/virtio_user_ethdev.c\n@@ -331,7 +331,7 @@ virtio_user_pmd_devinit(const char *name, const char *params)\n \tint ret = -1;\n \n \tif (!params || params[0] == '\\0') {\n-\t\tPMD_INIT_LOG(ERR, \"arg %s is mandatory for virtio-user\",\n+\t\tPMD_INIT_LOG(ERR, \"arg %s is mandatory for virtio_user\",\n \t\t\t VIRTIO_USER_ARG_QUEUE_SIZE);\n \t\tgoto end;\n \t}\n@@ -351,7 +351,7 @@ virtio_user_pmd_devinit(const char *name, const char *params)\n \t\t\tgoto end;\n \t\t}\n \t} else {\n-\t\tPMD_INIT_LOG(ERR, \"arg %s is mandatory for virtio-user\\n\",\n+\t\tPMD_INIT_LOG(ERR, \"arg %s is mandatory for virtio_user\\n\",\n \t\t\t VIRTIO_USER_ARG_QUEUE_SIZE);\n \t\tgoto end;\n \t}\n@@ -405,7 +405,7 @@ virtio_user_pmd_devinit(const char *name, const char *params)\n \n \teth_dev = virtio_user_eth_dev_alloc(name);\n \tif (!eth_dev) {\n-\t\tPMD_INIT_LOG(ERR, \"virtio-user fails to alloc device\");\n+\t\tPMD_INIT_LOG(ERR, \"virtio_user fails to alloc device\");\n \t\tgoto end;\n \t}\n \ndiff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h\nindex 455aaaf..db409d6 100644\n--- a/drivers/net/virtio/virtqueue.h\n+++ b/drivers/net/virtio/virtqueue.h\n@@ -183,7 +183,7 @@ struct virtqueue {\n \tunsigned int vq_ring_size;\n \n \tphys_addr_t vq_ring_mem; /**< physical address of vring */\n-\t\t\t\t/**< use virtual address for virtio-user. */\n+\t\t\t\t/**< use virtual address for virtio_user. */\n \n \t/**\n \t * Head of the free chain in the descriptor table. If\n", "prefixes": [ "dpdk-dev" ] }