Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 14884,
    "url": "http://patches.dpdk.org/api/patches/14884/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1468861764-22197-1-git-send-email-maxime.coquelin@redhat.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1468861764-22197-1-git-send-email-maxime.coquelin@redhat.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1468861764-22197-1-git-send-email-maxime.coquelin@redhat.com",
    "date": "2016-07-18T17:09:24",
    "name": "[dpdk-dev] net: virtio: clear reserved vring properly at setup time",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "e8ec5a03801e93bdd34bb090aa7a8576fa34d05b",
    "submitter": {
        "id": 512,
        "url": "http://patches.dpdk.org/api/people/512/?format=api",
        "name": "Maxime Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1468861764-22197-1-git-send-email-maxime.coquelin@redhat.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/14884/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/14884/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 6D0B82C01;\n\tMon, 18 Jul 2016 19:09:36 +0200 (CEST)",
            "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id D352F19F5\n\tfor <dev@dpdk.org>; Mon, 18 Jul 2016 19:09:34 +0200 (CEST)",
            "from int-mx09.intmail.prod.int.phx2.redhat.com\n\t(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 11AD33D1EC;\n\tMon, 18 Jul 2016 17:09:34 +0000 (UTC)",
            "from max-t460s.redhat.com (vpn1-4-89.ams2.redhat.com [10.36.4.89])\n\tby int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with\n\tESMTP id u6IH9WLX013255; Mon, 18 Jul 2016 13:09:32 -0400"
        ],
        "From": "Maxime Coquelin <maxime.coquelin@redhat.com>",
        "To": "huawei.xie@intel.com, yuanhan.liu@linux.intel.com",
        "Cc": "dev@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>",
        "Date": "Mon, 18 Jul 2016 19:09:24 +0200",
        "Message-Id": "<1468861764-22197-1-git-send-email-maxime.coquelin@redhat.com>",
        "X-Scanned-By": "MIMEDefang 2.68 on 10.5.11.22",
        "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]); Mon, 18 Jul 2016 17:09:34 +0000 (UTC)",
        "Subject": "[dpdk-dev] [PATCH] net: virtio: clear reserved vring properly at\n\tsetup time",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "After vring reservation, only the first bytes of the vring were\ncleared.\n\nThis patch fixes this to clear the real size fo the vring.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n\nNote: I found this bug while doing some code review, it is not a fix for\na problem I encountered.\n\n---\n drivers/net/virtio/virtio_ethdev.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex 850e3ba..336b3fc 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -387,7 +387,7 @@ int virtio_dev_queue_setup(struct rte_eth_dev *dev,\n \t\t}\n \t}\n \n-\tmemset(mz->addr, 0, sizeof(mz->len));\n+\tmemset(mz->addr, 0, mz->len);\n \n \tvq->vq_ring_mem = mz->phys_addr;\n \tvq->vq_ring_virt_mem = mz->addr;\n",
    "prefixes": [
        "dpdk-dev"
    ]
}