Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/14631/?format=api
{ "id": 14631, "url": "http://patches.dpdk.org/api/patches/14631/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1467899348-31998-1-git-send-email-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1467899348-31998-1-git-send-email-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1467899348-31998-1-git-send-email-ferruh.yigit@intel.com", "date": "2016-07-07T13:49:08", "name": "[dpdk-dev] net/virtio: fix gcc6 i686 compiler error", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "41af0d58a8195e03ccb494f737fb27d31fbebf19", "submitter": { "id": 324, "url": "http://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 355, "url": "http://patches.dpdk.org/api/users/355/?format=api", "username": "yliu", "first_name": "Yuanhan", "last_name": "Liu", "email": "yuanhan.liu@linux.intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1467899348-31998-1-git-send-email-ferruh.yigit@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/14631/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/14631/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 636FD2BA7;\n\tThu, 7 Jul 2016 15:49:21 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id DBE2811A2\n\tfor <dev@dpdk.org>; Thu, 7 Jul 2016 15:49:19 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga102.fm.intel.com with ESMTP; 07 Jul 2016 06:49:19 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga002.jf.intel.com with ESMTP; 07 Jul 2016 06:49:19 -0700", "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tu67DnHqx018169; Thu, 7 Jul 2016 14:49:17 +0100", "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id u67DnGAi032038;\n\tThu, 7 Jul 2016 14:49:16 +0100", "(from fyigit@localhost)\n\tby sivswdev02.ir.intel.com with id u67DnGir032034;\n\tThu, 7 Jul 2016 14:49:16 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.28,324,1464678000\"; d=\"scan'208\";\n\ta=\"1012502469\"", "X-Authentication-Warning": "sivswdev02.ir.intel.com: fyigit set sender to\n\tferruh.yigit@intel.com using -f", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "dev@dpdk.org", "Cc": "Yuanhan Liu <yuanhan.liu@linux.intel.com>,\n\tHuawei Xie <huawei.xie@intel.com>", "Date": "Thu, 7 Jul 2016 14:49:08 +0100", "Message-Id": "<1467899348-31998-1-git-send-email-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] net/virtio: fix gcc6 i686 compiler error", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This is for target i686-native-linuxapp-gcc and gcc6,\n\nCompilation error is:\n== Build drivers/net/virtio\n CC virtio_rxtx_simple.o\nIn file included from\n.../build/include/rte_mempool.h:77:0,\n from\n.../drivers/net/virtio/virtio_rxtx_simple.c:46:\n.../drivers/net/virtio/virtio_rxtx_simple.c: In\nfunction ‘virtio_xmit_pkts_simple’:\n.../build/include/rte_memcpy.h:551:2: error: array\nsubscript is above array bounds [-Werror=array-bounds]\n rte_mov16((uint8_t *)dst + 1 * 16, (const uint8_t *)src + 1 * 16);\n ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\nCall stack is as following:\n\nvirtio_xmit_pkts_simple\n virtio_xmit_cleanup\n rte_mempool_put_bulk\n rte_mempool_generic_put\n __mempool_generic_put\n\t rte_memcpy\n\nThe array used as source buffer in virtio_xmit_cleanup (free) is a\npointer array with 32 elements, in 32bit this makes 128 bytes.\n\nin rte_memcpy() implementation, there a code piece as following:\nif (size > 256) {\n rte_move128(...);\n rte_move128(...); <--- [1]\n ....\n}\n\nThe compiler traces the array all through the call stack and knows the\nsize of array is 128 and generates a warning on above [1] which tries to\naccess beyond byte 128.\nBut unfortunately it ignores the \"(size > 256)\" check.\n\nGiving a hint to compiler that variable \"size\" is related to the size of\nthe source buffer fixes compiler warning.\n\nFixes: 863bfb474493 (\"mempool: optimize copy in cache\")\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\n drivers/net/virtio/virtio_rxtx_simple.c | 9 ++++++---\n 1 file changed, 6 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_rxtx_simple.c b/drivers/net/virtio/virtio_rxtx_simple.c\nindex 242ad90..d8fcc15 100644\n--- a/drivers/net/virtio/virtio_rxtx_simple.c\n+++ b/drivers/net/virtio/virtio_rxtx_simple.c\n@@ -301,7 +301,7 @@ static inline void\n virtio_xmit_cleanup(struct virtqueue *vq)\n {\n \tuint16_t i, desc_idx;\n-\tint nb_free = 0;\n+\tuint32_t nb_free = 0;\n \tstruct rte_mbuf *m, *free[VIRTIO_TX_MAX_FREE_BUF_SZ];\n \n \tdesc_idx = (uint16_t)(vq->vq_used_cons_idx &\n@@ -319,13 +319,16 @@ virtio_xmit_cleanup(struct virtqueue *vq)\n \t\t\t\t\tfree[nb_free++] = m;\n \t\t\t\telse {\n \t\t\t\t\trte_mempool_put_bulk(free[0]->pool,\n-\t\t\t\t\t\t(void **)free, nb_free);\n+\t\t\t\t\t\t(void **)free,\n+\t\t\t\t\t\tRTE_MIN(RTE_DIM(free),\n+\t\t\t\t\t\t\tnb_free));\n \t\t\t\t\tfree[0] = m;\n \t\t\t\t\tnb_free = 1;\n \t\t\t\t}\n \t\t\t}\n \t\t}\n-\t\trte_mempool_put_bulk(free[0]->pool, (void **)free, nb_free);\n+\t\trte_mempool_put_bulk(free[0]->pool, (void **)free,\n+\t\t\tRTE_MIN(RTE_DIM(free), nb_free));\n \t} else {\n \t\tfor (i = 1; i < VIRTIO_TX_FREE_NR; i++) {\n \t\t\tm = (struct rte_mbuf *)vq->vq_descx[desc_idx++].cookie;\n", "prefixes": [ "dpdk-dev" ] }