Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/14509/?format=api
{ "id": 14509, "url": "http://patches.dpdk.org/api/patches/14509/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1467594845-3487-4-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1467594845-3487-4-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1467594845-3487-4-git-send-email-thomas.monjalon@6wind.com", "date": "2016-07-04T01:14:01", "name": "[dpdk-dev,v9,3/7] mk: refresh recipe for any host application", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "3201d3c34b19b76c2236af3bce548e5cba43b1e4", "submitter": { "id": 1, "url": "http://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1467594845-3487-4-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/14509/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/14509/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 2A2FD47D1;\n\tMon, 4 Jul 2016 03:14:19 +0200 (CEST)", "from mail-wm0-f46.google.com (mail-wm0-f46.google.com\n\t[74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 0695F2C6E\n\tfor <dev@dpdk.org>; Mon, 4 Jul 2016 03:14:17 +0200 (CEST)", "by mail-wm0-f46.google.com with SMTP id f126so85735290wma.1\n\tfor <dev@dpdk.org>; Sun, 03 Jul 2016 18:14:17 -0700 (PDT)", "from XPS13.localdomain (184.203.134.77.rev.sfr.net.\n\t[77.134.203.184]) by smtp.gmail.com with ESMTPSA id\n\tl4sm5527127wjk.18.2016.07.03.18.14.15\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tSun, 03 Jul 2016 18:14:16 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=jEe+J+q0J/6bjvXrLfyJuPfEEywx0JPHX41JPxlKQCk=;\n\tb=DgiCjg1FZi1SFozwnPh/KGT1X2bzPXaXGF6wd5/98pwwFe0Zw+Ke8h0jBOv28DSgnR\n\ttBF6Bp/XKJKHfHILnRYpqfYmbOMJ3kYBct6eWtI+IGRsJJUbLidRn9ntzvWBga7rKT5O\n\tCng/sxIPoZyuCSSKAEiT5cH9xOnHTCB0zik/R48CX7sznR/qglO3J69CmnsENLqRQAeW\n\tZB6SK+LZJju1GEu3PWkH2jCBmdOAtV516prvlhb9yHz7SN/URqHa/KIQ0EOI5qf7QNoQ\n\tdYWDA/rNFipQzZhfZaKs9Kqg38G2mriMUZYy9fpTJst0geMddmwIRuDMlwRh5GJ95eFa\n\tyg0A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=jEe+J+q0J/6bjvXrLfyJuPfEEywx0JPHX41JPxlKQCk=;\n\tb=dCTfkmL5I2xYpboDfBJKtsdXwXS+6KQLaaVoPdIVGZURv7Ubudl0UTtDLeO12gXLSV\n\tYOYzacH6JporuNgocR6fkxuF1lUL25Yfh3ofteXTTvqJMmw8T2UwdPPtxiKN+fOsTV+L\n\t9zB7a4kjYM5RYDZnmmiXpMaPYueEn/yNJQfSL5y2XrTv73lHLR+ldMk1B+wXB/gzvKnT\n\tlrnfrwqWwGVnLNC0+NB287nZYWtMYydrJXcHQR/rKsHYZwHI3XsGjrv6s9FPkJo10BaQ\n\tTV5Kjvu5N6Ildhplk+67ayHz6ew4KFB9D7eFrQNEQz6u5Xyt6C/53SzWWwdDWJcvyWV5\n\t9tAQ==", "X-Gm-Message-State": "ALyK8tJ1xnN+4WCu2KZuGY35vPlpRxnZ0zy/8r4oaliAkP2OcMdMMRvoyHPz/wU1yDNN1GUS", "X-Received": "by 10.194.170.197 with SMTP id ao5mr7460352wjc.99.1467594856807; \n\tSun, 03 Jul 2016 18:14:16 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "Neil Horman <nhorman@tuxdriver.com>", "Cc": "dev@dpdk.org,\n\tPanu Matilainen <pmatilai@redhat.com>", "Date": "Mon, 4 Jul 2016 03:14:01 +0200", "Message-Id": "<1467594845-3487-4-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.7.0", "In-Reply-To": "<1467594845-3487-1-git-send-email-thomas.monjalon@6wind.com>", "References": "<1466189185-21952-1-git-send-email-nhorman@tuxdriver.com>\n\t<1467594845-3487-1-git-send-email-thomas.monjalon@6wind.com>", "Subject": "[dpdk-dev] [PATCH v9 3/7] mk: refresh recipe for any host\n\tapplication", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Make the recipe simpler to use and build in configurable directory.\nHOSTAPP_DIR must be set before including rte.hostapp.mk.\n\nRemove LDLIBS_FILES as libraries should not be used in an hostapp.\nRemove the \"INSTALL-HOSTAPP\" and build directly in the right directory.\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n doc/guides/freebsd_gsg/build_dpdk.rst | 2 +-\n doc/guides/linux_gsg/build_dpdk.rst | 2 +-\n doc/guides/prog_guide/dev_kit_build_system.rst | 2 +-\n mk/rte.hostapp.mk | 23 +++++------------------\n mk/rte.sdkbuild.mk | 3 +--\n mk/rte.sdkconfig.mk | 3 +--\n 6 files changed, 10 insertions(+), 25 deletions(-)", "diff": "diff --git a/doc/guides/freebsd_gsg/build_dpdk.rst b/doc/guides/freebsd_gsg/build_dpdk.rst\nindex 1d92c08..93c4366 100644\n--- a/doc/guides/freebsd_gsg/build_dpdk.rst\n+++ b/doc/guides/freebsd_gsg/build_dpdk.rst\n@@ -183,7 +183,7 @@ contains the kernel modules to install:\n \n ls x86_64-native-bsdapp-gcc\n \n- app build hostapp include kmod lib Makefile\n+ app build include kmod lib Makefile\n \n \n .. _loading_contigmem:\ndiff --git a/doc/guides/linux_gsg/build_dpdk.rst b/doc/guides/linux_gsg/build_dpdk.rst\nindex 198c0b6..fb2c481 100644\n--- a/doc/guides/linux_gsg/build_dpdk.rst\n+++ b/doc/guides/linux_gsg/build_dpdk.rst\n@@ -152,7 +152,7 @@ A kmod directory is also present that contains kernel modules which may be load\n \n ls x86_64-native-linuxapp-gcc\n \n- app build hostapp include kmod lib Makefile\n+ app build include kmod lib Makefile\n \n Loading Modules to Enable Userspace IO for DPDK\n -----------------------------------------------\ndiff --git a/doc/guides/prog_guide/dev_kit_build_system.rst b/doc/guides/prog_guide/dev_kit_build_system.rst\nindex 9b0de83..dedd18a 100644\n--- a/doc/guides/prog_guide/dev_kit_build_system.rst\n+++ b/doc/guides/prog_guide/dev_kit_build_system.rst\n@@ -264,7 +264,7 @@ These Makefiles generate a binary application.\n \n * rte.extapp.mk: External application\n \n-* rte.hostapp.mk: Host application in the development kit framework\n+* rte.hostapp.mk: Prerequisite tool to build DPDK\n \n Library\n ^^^^^^^\ndiff --git a/mk/rte.hostapp.mk b/mk/rte.hostapp.mk\nindex c44d0f8..05bbd26 100644\n--- a/mk/rte.hostapp.mk\n+++ b/mk/rte.hostapp.mk\n@@ -40,8 +40,8 @@ include $(RTE_SDK)/mk/internal/rte.depdirs-pre.mk\n # VPATH contains at least SRCDIR\n VPATH += $(SRCDIR)\n \n-_BUILD = $(HOSTAPP)\n-_INSTALL = $(INSTALL-FILES-y) $(SYMLINK-FILES-y) $(RTE_OUTPUT)/hostapp/$(HOSTAPP)\n+_BUILD = $(RTE_OUTPUT)/$(HOSTAPP_DIR)/$(HOSTAPP)\n+_INSTALL = $(INSTALL-FILES-y) $(SYMLINK-FILES-y) $(RTE_OUTPUT)/$(HOSTAPP_DIR)/$(HOSTAPP)\n _CLEAN = doclean\n \n .PHONY: all\n@@ -60,7 +60,7 @@ exe2cmd = $(strip $(call dotfile,$(patsubst %,%.cmd,$(1))))\n O_TO_EXE = $(HOSTCC) $(HOST_LDFLAGS) $(LDFLAGS_$(@)) \\\n \t$(EXTRA_HOST_LDFLAGS) -o $@ $(OBJS-y) $(LDLIBS)\n O_TO_EXE_STR = $(subst ','\\'',$(O_TO_EXE)) #'# fix syntax highlight\n-O_TO_EXE_DISP = $(if $(V),\"$(O_TO_EXE_STR)\",\" HOSTLD $(@)\")\n+O_TO_EXE_DISP = $(if $(V),\"$(O_TO_EXE_STR)\",\" HOSTLD $(@F)\")\n O_TO_EXE_CMD = \"cmd_$@ = $(O_TO_EXE_STR)\"\n O_TO_EXE_DO = @set -e; \\\n \techo $(O_TO_EXE_DISP); \\\n@@ -69,15 +69,10 @@ O_TO_EXE_DO = @set -e; \\\n \n -include .$(HOSTAPP).cmd\n \n-# list of .a files that are linked to this application\n-LDLIBS_FILES := $(wildcard \\\n-\t$(addprefix $(RTE_OUTPUT)/lib/, \\\n-\t$(patsubst -l%,lib%.a,$(filter -l%,$(LDLIBS)))))\n-\n #\n # Compile executable file if needed\n #\n-$(HOSTAPP): $(OBJS-y) $(LDLIBS_FILES) FORCE\n+$(RTE_OUTPUT)/$(HOSTAPP_DIR)/$(HOSTAPP): $(OBJS-y) FORCE\n \t@[ -d $(dir $@) ] || mkdir -p $(dir $@)\n \t$(if $(D),\\\n \t\t@echo -n \"$@ -> $< \" ; \\\n@@ -93,14 +88,6 @@ $(HOSTAPP): $(OBJS-y) $(LDLIBS_FILES) FORCE\n \t\t$(O_TO_EXE_DO))\n \n #\n-# install app in $(RTE_OUTPUT)/hostapp\n-#\n-$(RTE_OUTPUT)/hostapp/$(HOSTAPP): $(HOSTAPP)\n-\t@echo \" INSTALL-HOSTAPP $(HOSTAPP)\"\n-\t@[ -d $(RTE_OUTPUT)/hostapp ] || mkdir -p $(RTE_OUTPUT)/hostapp\n-\t$(Q)cp -f $(HOSTAPP) $(RTE_OUTPUT)/hostapp\n-\n-#\n # Clean all generated files\n #\n .PHONY: clean\n@@ -109,7 +96,7 @@ clean: _postclean\n \n .PHONY: doclean\n doclean:\n-\t$(Q)rm -rf $(HOSTAPP) $(OBJS-all) $(DEPS-all) $(DEPSTMP-all) \\\n+\t$(Q)rm -rf $(OBJS-all) $(DEPS-all) $(DEPSTMP-all) \\\n \t $(CMDS-all) $(INSTALL-FILES-all) .$(HOSTAPP).cmd\n \n \ndiff --git a/mk/rte.sdkbuild.mk b/mk/rte.sdkbuild.mk\nindex 6dbdb5d..f1a163a 100644\n--- a/mk/rte.sdkbuild.mk\n+++ b/mk/rte.sdkbuild.mk\n@@ -63,8 +63,7 @@ build: $(ROOTDIRS-y)\n .PHONY: clean\n clean: $(CLEANDIRS)\n \t@rm -rf $(RTE_OUTPUT)/include $(RTE_OUTPUT)/app \\\n-\t\t$(RTE_OUTPUT)/hostapp $(RTE_OUTPUT)/lib \\\n-\t\t$(RTE_OUTPUT)/kmod\n+\t\t$(RTE_OUTPUT)/lib $(RTE_OUTPUT)/kmod\n \t@[ -d $(RTE_OUTPUT)/include ] || mkdir -p $(RTE_OUTPUT)/include\n \t@$(RTE_SDK)/scripts/gen-config-h.sh $(RTE_OUTPUT)/.config \\\n \t\t> $(RTE_OUTPUT)/include/rte_config.h\ndiff --git a/mk/rte.sdkconfig.mk b/mk/rte.sdkconfig.mk\nindex 98789af..44522ac 100644\n--- a/mk/rte.sdkconfig.mk\n+++ b/mk/rte.sdkconfig.mk\n@@ -108,8 +108,7 @@ $(RTE_OUTPUT)/Makefile: | $(RTE_OUTPUT)\n # if NODOTCONF variable is defined, don't try to rebuild .config\n $(RTE_OUTPUT)/include/rte_config.h: $(RTE_OUTPUT)/.config\n \t$(Q)rm -rf $(RTE_OUTPUT)/include $(RTE_OUTPUT)/app \\\n-\t\t$(RTE_OUTPUT)/hostapp $(RTE_OUTPUT)/lib \\\n-\t\t$(RTE_OUTPUT)/kmod $(RTE_OUTPUT)/build\n+\t\t$(RTE_OUTPUT)/lib $(RTE_OUTPUT)/kmod $(RTE_OUTPUT)/build\n \t$(Q)mkdir -p $(RTE_OUTPUT)/include\n \t$(Q)$(RTE_SDK)/scripts/gen-config-h.sh $(RTE_OUTPUT)/.config \\\n \t\t> $(RTE_OUTPUT)/include/rte_config.h\n", "prefixes": [ "dpdk-dev", "v9", "3/7" ] }