Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139971/?format=api
{ "id": 139971, "url": "http://patches.dpdk.org/api/patches/139971/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240507124305.2318-8-venkatkumar.ande@amd.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240507124305.2318-8-venkatkumar.ande@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240507124305.2318-8-venkatkumar.ande@amd.com", "date": "2024-05-07T12:42:48", "name": "[v2,08/25] net/axgbe: fix the SFP codes check for DAC cables", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "b395e247d8b0c920ff2387cea4d0808cc3319ec2", "submitter": { "id": 3256, "url": "http://patches.dpdk.org/api/people/3256/?format=api", "name": "Venkat Kumar Ande", "email": "venkatkumar.ande@amd.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240507124305.2318-8-venkatkumar.ande@amd.com/mbox/", "series": [ { "id": 31890, "url": "http://patches.dpdk.org/api/series/31890/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31890", "date": "2024-05-07T12:42:41", "name": "[v2,01/25] net/axgbe: fix mdio access for non-zero ports and CL45 PHYs", "version": 2, "mbox": "http://patches.dpdk.org/series/31890/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139971/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/139971/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7959C43FC9;\n\tTue, 7 May 2024 14:44:39 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4A0B0433B0;\n\tTue, 7 May 2024 14:44:02 +0200 (CEST)", "from NAM12-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam12on2049.outbound.protection.outlook.com [40.107.243.49])\n by mails.dpdk.org (Postfix) with ESMTP id 10266433B5;\n Tue, 7 May 2024 14:43:56 +0200 (CEST)", "from SA9PR13CA0038.namprd13.prod.outlook.com (2603:10b6:806:22::13)\n by DM4PR12MB6638.namprd12.prod.outlook.com (2603:10b6:8:b5::5) with\n Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7544.41; Tue, 7 May 2024 12:43:53 +0000", "from SN1PEPF00036F3E.namprd05.prod.outlook.com\n (2603:10b6:806:22:cafe::36) by SA9PR13CA0038.outlook.office365.com\n (2603:10b6:806:22::13) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42 via Frontend\n Transport; Tue, 7 May 2024 12:43:53 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n SN1PEPF00036F3E.mail.protection.outlook.com (10.167.248.22) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.7544.18 via Frontend Transport; Tue, 7 May 2024 12:43:53 +0000", "from cae-Lilac-RMB.amd.com (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 7 May\n 2024 07:43:51 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Wr4n9HV6jr78jL5fSsA0Va+KZs/Xcroc3/3H2GM1OGu0yRsfJP554BClXtVQwzSbX/UTYSqMg8imUe/NwV1SSGGwSx4XoDP6KKnzW+y+Nj/iT4lZuLH6DF+y8jxo+YNXjlQGdnvkYjp3YRHwfUaiPEx1waxIiPz5E2/BjZSx9dkXbY7PPKjS43bthTngagzBkAfgL73DvG81j5AjFzwLScGVPpt7ViEiZBylmeKCKmVA++SAJUILDFUzj+N3F8mX4xb16DYsEdkrwffIhilMq/X9tiMkuCuoIdOtBSRqi9BPfWauyLrXUcZfLwdsToZuj4C2+MI0oNc2B+7cGqPG0A==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=ZUnhPzYLKuVcGpGBnxJS1cBfprUXJ9apRrKC8j12efw=;\n b=VucGwapG8q0UFCTWeKqFRjloiQKPbLP3jL8J1f70OxZO5EFfCunAYsOLBwCVIQ0EemCLJY+IEZg2bOdausEtpKtf1P+p+Pnkhf8vyQ5a89AcP7IAtTh1esa1y6CtrUukFj+Q465eEAZIh0LYc+ybHFQDpeF2honF/MjcrI4E2GkYZ7OtIYbxOjnqW2He2tgRtYcaylBiNpfDQILGD7R9ttMUiGnHewx79+BPPr2nVKUEzx+wJ42c8Frbd0nzpXNBLIOMv148+b8bB1K/UjHNl2b8ZfOMnHO64D2fVMrXOH2h5JZkO/MKTxT7vXjBXXOZfaJm5ydeUuAmxOd5ukIMKA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=ZUnhPzYLKuVcGpGBnxJS1cBfprUXJ9apRrKC8j12efw=;\n b=vXQ2rFUsN/Nt37qkvzNVg7d0yO+5PWC8fuGGfcmB+FY2j6KbEbk6UeHeYFujMUutyWYSBcWRPy8XnCTFEX/zFTDtM/qtAqihDYpSDPcHJ+M6DLDRqJ1T+jHPP7M2N8HAf1gSRXLyPf7IGBkqfz6ldqM2+rE3cLo59NASh+JZyPY=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Venkat Kumar Ande <venkatkumar.ande@amd.com>", "To": "<dev@dpdk.org>", "CC": "<Selwin.Sebastian@amd.com>, Venkat Kumar Ande <venkatkumar.ande@amd.com>,\n <stable@dpdk.org>", "Subject": "[PATCH v2 08/25] net/axgbe: fix the SFP codes check for DAC cables", "Date": "Tue, 7 May 2024 18:12:48 +0530", "Message-ID": "<20240507124305.2318-8-venkatkumar.ande@amd.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240507124305.2318-1-venkatkumar.ande@amd.com>", "References": "<20240412125013.10498-1-VenkatKumar.Ande@amd.com>\n <20240507124305.2318-1-venkatkumar.ande@amd.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SN1PEPF00036F3E:EE_|DM4PR12MB6638:EE_", "X-MS-Office365-Filtering-Correlation-Id": "3de74de1-1bf8-4b46-bdc4-08dc6e935a61", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n ARA:13230031|1800799015|36860700004|376005|82310400017;", "X-Microsoft-Antispam-Message-Info": "\n QxzFVT+t9DOs5wFh8yGEGxjlftXCpxmDrrgqPYJ9FzOQuNZDVOJVSW/coleedzEaKUnBG7m/VrRcY4uvk1n86g60kf7RUnfLnbSH1qldV+chKSPJ+MntD+vuJHTBp8SOJWMrDAqrcE4tWEBXzAc6wgCxVtbMc8sXSi3kZVg+5GiqCgPaNPerQz2b4BjR6aBy7AELryh/omlHBWF7mjCRlX54eixlizXvECHvwev0/b/EYUKrr6drLlLk5HGOfnh5akbtq4kc1jiDOm3C8xXA8hwL9vgEAmkRmy17TYAQATqiodPyjALDE/F0R6vtoMjXwbye0oIQCGeVCJXG7oxIrOX3y4n/zoq/Zy/sJPG9ewmrv2FTqvxO+9WvPYm1t7Q1LFn8u53+Jqs4CBZtbjSPXdLoP3WteG5zr47YmacTL91Qt1RZWt87SWL4goh5g+xo0ViU/mkwPlIfzJLhR3yN+vKNSq6fETtmuaf0UPzxo7r4I+3YFD6f/X6yHavptoZhV4raLrLMr6tBhIMPlXvxaPe+Kb8lGNuUkMjrrLL7EgZWJu0zpiddTLOn34sNupKvwmhkX5HVDVcQPkgpaLC8f0ufhT1VbEF75QsQMaDH4vYYbhPXxE85fqV0v2m5a6pbPpYdOQDLXql21HYROecH/W5JwV9w7zoNT1ngMdIeWfEtj8Df3HRzJFXdqdSBIpohSWkgLvhbnPylYtVvz0raYfEwRjIN69DhHnOfbQ1jhVZo4k153pkIf44NHLqFNn4aj4B1mxaedQbGEzFWIWku2+V8LV1wDeYv5GPmyck7JoXGe9HColfwo2UmqdqavYlgWyLz8DBqA7mnicZs+UN1aIPIKoCCrqro5vLqBHM8ZcVDEaOyPVVTOT0LbgcOhxtOyQhFf7KkvldLak85cgeI5VmATQXkBg3nxZoNZTgx4eu9Yf81fPI4iHxdpJNgL3JmHY4AdE6ZiBh40MhVmY+Jvcjzz26IKj7pYbO+A6KsCFwV4lYmLlU9pzIKpskN5mf+D3JP+R4/M3iaLHdlKqoDcroKe8iEAxbE3q7GNbploxualXy7CyGDMqgqEELaEwKLV2O2qWbH/Sipxa88yIAajKSeeQKokqW16G+e8WVFGRAuZrwk9xgEVW+irOVwx4SVgp/hLPi3XfkftivhtpSpUT2n0d4XAYpa8ibDjNFeUOh1Lsc8MKxpL/OgLRUhP3nagMTSooWPNDMfs/0zMTsQU3ZWsTV0IyqmyUCZPXsOGnUXr2YAlFgokkoZhW8t6dNfjgnVKJlmtt8jo//FKm9LwERn0jTRJPexEqSsXMpxs8+NJcfXQ9IMm9BsFOmbTMXqcjss7TOo8U1dO1vuj/jFtbofttXHrlAy+kCWr6o3Pij6Y7wPkxev/pFWo2mrjnrd", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(1800799015)(36860700004)(376005)(82310400017); DIR:OUT;\n SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "07 May 2024 12:43:53.4433 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 3de74de1-1bf8-4b46-bdc4-08dc6e935a61", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n SN1PEPF00036F3E.namprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM4PR12MB6638", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The current AXGBE code assumes that offset 6 of EEPROM SFP DAC (passive)\ncables is NULL. However, some cables (the 5 meter and 7 meter Molex\npassive cables) have non-zero data at offset 6. Fix the logic by moving\nthe passive cable check above the active checks, so as not to be\nimproperly identified as an active cable. This will fix the issue for\nany passive cable that advertises 1000Base-CX in offset 6.\n\nWithout the fix the user will not get link UP for few DAC cables.\n\nFixes: a5c7273771e8 (\"net/axgbe: add phy programming APIs\")\nCc: stable@dpdk.org\n\nSigned-off-by: Venkat Kumar Ande <venkatkumar.ande@amd.com>\n---\n drivers/net/axgbe/axgbe_phy_impl.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c\nindex 9c2ae7bba0..d4c4a89517 100644\n--- a/drivers/net/axgbe/axgbe_phy_impl.c\n+++ b/drivers/net/axgbe/axgbe_phy_impl.c\n@@ -625,7 +625,10 @@ static void axgbe_phy_sfp_parse_eeprom(struct axgbe_port *pdata)\n \t}\n \n \t/* Determine the type of SFP */\n-\tif (sfp_base[AXGBE_SFP_BASE_10GBE_CC] & AXGBE_SFP_BASE_10GBE_CC_SR)\n+\tif (phy_data->sfp_cable == AXGBE_SFP_CABLE_PASSIVE &&\n+\t\t axgbe_phy_sfp_bit_rate(sfp_eeprom, AXGBE_SFP_SPEED_10000))\n+\t\tphy_data->sfp_base = AXGBE_SFP_BASE_10000_CR;\n+\telse if (sfp_base[AXGBE_SFP_BASE_10GBE_CC] & AXGBE_SFP_BASE_10GBE_CC_SR)\n \t\tphy_data->sfp_base = AXGBE_SFP_BASE_10000_SR;\n \telse if (sfp_base[AXGBE_SFP_BASE_10GBE_CC] & AXGBE_SFP_BASE_10GBE_CC_LR)\n \t\tphy_data->sfp_base = AXGBE_SFP_BASE_10000_LR;\n@@ -642,9 +645,6 @@ static void axgbe_phy_sfp_parse_eeprom(struct axgbe_port *pdata)\n \t\tphy_data->sfp_base = AXGBE_SFP_BASE_1000_CX;\n \telse if (sfp_base[AXGBE_SFP_BASE_1GBE_CC] & AXGBE_SFP_BASE_1GBE_CC_T)\n \t\tphy_data->sfp_base = AXGBE_SFP_BASE_1000_T;\n-\telse if ((phy_data->sfp_cable == AXGBE_SFP_CABLE_PASSIVE) &&\n-\t\t axgbe_phy_sfp_bit_rate(sfp_eeprom, AXGBE_SFP_SPEED_10000))\n-\t\tphy_data->sfp_base = AXGBE_SFP_BASE_10000_CR;\n \n \tswitch (phy_data->sfp_base) {\n \tcase AXGBE_SFP_BASE_1000_T:\n", "prefixes": [ "v2", "08/25" ] }