Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139801/?format=api
{ "id": 139801, "url": "http://patches.dpdk.org/api/patches/139801/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/bug-1434-3@http.bugs.dpdk.org%252F/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<bug-1434-3@http.bugs.dpdk.org/>", "list_archive_url": "https://inbox.dpdk.org/dev/bug-1434-3@http.bugs.dpdk.org/", "date": "2024-05-02T14:16:49", "name": "[DPDK/examples,Bug,1434] l3fwd: crashes in ACL mode for mixed traffic", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "77e0d941cb27f6764f34d2ff17965f6f866bb863", "submitter": { "id": 1046, "url": "http://patches.dpdk.org/api/people/1046/?format=api", "name": null, "email": "bugzilla@dpdk.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/bug-1434-3@http.bugs.dpdk.org%252F/mbox/", "series": [ { "id": 31864, "url": "http://patches.dpdk.org/api/series/31864/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31864", "date": "2024-05-02T14:16:49", "name": "[DPDK/examples,Bug,1434] l3fwd: crashes in ACL mode for mixed traffic", "version": 1, "mbox": "http://patches.dpdk.org/series/31864/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139801/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/139801/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A052B43F69;\n\tThu, 2 May 2024 16:16:51 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 308B4402B2;\n\tThu, 2 May 2024 16:16:51 +0200 (CEST)", "from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178])\n by mails.dpdk.org (Postfix) with ESMTP id A517340299\n for <dev@dpdk.org>; Thu, 2 May 2024 16:16:49 +0200 (CEST)", "by inbox.dpdk.org (Postfix, from userid 33)\n id 8842D43F6B; Thu, 2 May 2024 16:16:49 +0200 (CEST)" ], "From": "bugzilla@dpdk.org", "To": "dev@dpdk.org", "Subject": "[DPDK/examples Bug 1434] l3fwd: crashes in ACL mode for mixed traffic", "Date": "Thu, 02 May 2024 14:16:49 +0000", "X-Bugzilla-Reason": "AssignedTo", "X-Bugzilla-Type": "new", "X-Bugzilla-Watch-Reason": "None", "X-Bugzilla-Product": "DPDK", "X-Bugzilla-Component": "examples", "X-Bugzilla-Version": "24.03", "X-Bugzilla-Keywords": "", "X-Bugzilla-Severity": "normal", "X-Bugzilla-Who": "konstantin.v.ananyev@yandex.ru", "X-Bugzilla-Status": "UNCONFIRMED", "X-Bugzilla-Resolution": "", "X-Bugzilla-Priority": "Normal", "X-Bugzilla-Assigned-To": "dev@dpdk.org", "X-Bugzilla-Target-Milestone": "---", "X-Bugzilla-Flags": "", "X-Bugzilla-Changed-Fields": "bug_id short_desc product version rep_platform\n op_sys bug_status bug_severity priority component assigned_to reporter\n target_milestone", "Message-ID": "<bug-1434-3@http.bugs.dpdk.org/>", "Content-Type": "multipart/alternative; boundary=17146594091.ff8bCc089.3785808", "Content-Transfer-Encoding": "7bit", "X-Bugzilla-URL": "http://bugs.dpdk.org/", "Auto-Submitted": "auto-generated", "X-Auto-Response-Suppress": "All", "MIME-Version": "1.0", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "https://bugs.dpdk.org/show_bug.cgi?id=1434\n\n Bug ID: 1434\n Summary: l3fwd: crashes in ACL mode for mixed traffic\n Product: DPDK\n Version: 24.03\n Hardware: All\n OS: All\n Status: UNCONFIRMED\n Severity: normal\n Priority: Normal\n Component: examples\n Assignee: dev@dpdk.org\n Reporter: konstantin.v.ananyev@yandex.ru\n Target Milestone: ---\n\nWhen running l3fwd in ACL mode, if we'll have mix of IPv4/IPv6 packets in the\nsame burst,\nIt will most likely cause a crash. Something like:\n#0 rte_eth_tx_burst (port_id=54, queue_id=0,\n tx_pkts=0x4b249c0 <lcore_conf+550528>, nb_pkts=32)\n at ../lib/ethdev/rte_ethdev.h:6437\n#1 0x0000000000503c0d in send_burst (qconf=0x4b20d40 <lcore_conf+535040>,\n n=32, port=54) at ../examples/l3fwd/l3fwd.h:129\n#2 0x0000000000503ced in send_single_packet (\n qconf=0x4b20d40 <lcore_conf+535040>, m=0x11fc70ba00, port=54)\n at ../examples/l3fwd/l3fwd.h:152\n#3 0x0000000000504138 in send_packets_single (\n qconf=0x4b20d40 <lcore_conf+535040>, pkts=0x7ffff2f24070,\n hops=0x7ffff2f23ab0, nb_tx=32) at ../examples/l3fwd/l3fwd_acl_scalar.h:77\n#4 0x0000000000504286 in l3fwd_acl_send_packets (\n qconf=0x4b20d40 <lcore_conf+535040>, pkts=0x7ffff2f24070,\n res=0x7ffff2f23fe8, nb_tx=32) at ../examples/l3fwd/l3fwd_acl_scalar.h:106\n#5 0x0000000000506870 in acl_main_loop (dummy=0x0)\n\n#4 0x0000000000504286 in l3fwd_acl_send_packets (\n qconf=0x4b20d40 <lcore_conf+535040>, pkts=0x7ffff2f24070,\n res=0x7ffff2f23fe8, nb_tx=32) at ../examples/l3fwd/l3fwd_acl_scalar.h:106\n106 send_packets_single(qconf, pkts, dst_port, nb_tx);\n\nAnd the array of dst_port[] will contain some junk values:\n(gdb) print dst_port\n$7 = {0 <repeats 16 times>, 65535, 65535, 65535, 65535, 54, 65535, 65535,\n 65535, 65535, 65535, 65535, 32766, 58445, 65535, 65535, 65535}\n\nAnd the reason for that is here:\n\nacl_main_loop(__rte_unused void *dummy)\n{\n\n...\n\n if (acl_search.num_ipv4) {\n rte_acl_classify(\n acl_config.acx_ipv4[socketid],\n acl_search.data_ipv4,\n acl_search.res_ipv4,\n acl_search.num_ipv4,\n DEFAULT_MAX_CATEGORIES);\n l3fwd_acl_send_packets(\n qconf,\n pkts_burst,\n acl_search.res_ipv4,\n nb_rx);\n...\n\nI.E. we split our burst of packets into 2 arrays - one for ipv4, anoterh for\nipv6 for classify(),\nBut then we try to send all packets as one burst again, not taking into account\nthat acl_search.res_ipv4[] will be set only for ipv4 packets.\nSame story for ipv6.\nThe fix is straightforward:\nYou are the assignee for the bug.", "diff": "--- a/examples/l3fwd/l3fwd_acl.c\n+++ b/examples/l3fwd/l3fwd_acl.c\n@@ -1073,9 +1073,9 @@ acl_main_loop(__rte_unused void *dummy)\n\n l3fwd_acl_send_packets(\n qconf,\n- pkts_burst,\n+ acl_search.m_ipv4,\n acl_search.res_ipv4,\n- nb_rx);\n+ acl_search.num_ipv4);\n }\n\n if (acl_search.num_ipv6) {\n@@ -1088,9 +1088,9 @@ acl_main_loop(__rte_unused void *dummy)\n\n l3fwd_acl_send_packets(\n qconf,\n- pkts_burst,\n+ acl_search.m_ipv6,\n acl_search.res_ipv6,\n- nb_rx);\n+ acl_search.num_ipv6);\n }\n\n-- \nYou are receiving this mail because:\n", "prefixes": [ "DPDK/examples", "Bug", "1434" ] }