Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139746/?format=api
{ "id": 139746, "url": "http://patches.dpdk.org/api/patches/139746/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240430184533.29247-3-npratte@iol.unh.edu/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240430184533.29247-3-npratte@iol.unh.edu>", "list_archive_url": "https://inbox.dpdk.org/dev/20240430184533.29247-3-npratte@iol.unh.edu", "date": "2024-04-30T18:45:33", "name": "[v5,2/2] dts: Change hugepage 'amount' to a different term", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8d5e471e789ac1dcf9b7422ff400759641ee1cbc", "submitter": { "id": 3281, "url": "http://patches.dpdk.org/api/people/3281/?format=api", "name": "Nicholas Pratte", "email": "npratte@iol.unh.edu" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240430184533.29247-3-npratte@iol.unh.edu/mbox/", "series": [ { "id": 31847, "url": "http://patches.dpdk.org/api/series/31847/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31847", "date": "2024-04-30T18:45:32", "name": "[v5,1/2] dts: Change hugepage runtime config to 2MB Exclusively", "version": 5, "mbox": "http://patches.dpdk.org/series/31847/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139746/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/139746/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5A88343F32;\n\tTue, 30 Apr 2024 20:48:03 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 33538402BA;\n\tTue, 30 Apr 2024 20:47:58 +0200 (CEST)", "from mail-oo1-f51.google.com (mail-oo1-f51.google.com\n [209.85.161.51]) by mails.dpdk.org (Postfix) with ESMTP id 26682402AD\n for <dev@dpdk.org>; Tue, 30 Apr 2024 20:47:57 +0200 (CEST)", "by mail-oo1-f51.google.com with SMTP id\n 006d021491bc7-5afbcf8059cso118916eaf.1\n for <dev@dpdk.org>; Tue, 30 Apr 2024 11:47:57 -0700 (PDT)", "from d121012.iol.unh.edu ([2606:4100:3880:1271:e2f8:4ec3:8bf3:864c])\n by smtp.gmail.com with ESMTPSA id\n dj14-20020a05622a4e8e00b0043ae234c0f2sm2182479qtb.36.2024.04.30.11.47.55\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 30 Apr 2024 11:47:55 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=iol.unh.edu; s=unh-iol; t=1714502876; x=1715107676; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=bhXZM6ke8pyVDtzl88TXVR9AsPng3J/jGrVRdcTxEX4=;\n b=ZJqeywuu7z0KE3ajgdj3sHucD5Fqr8ntHpvt7y8nI8cGECamXEPyxzjWl7IMBzrIkn\n H4I9LKtRz5/K/9XrgkYGKuhRmnOq7tmAStsBNwxpcCzabtE4PHsrMwbZ56gbkw12qhx2\n GvDDpP0c2KdcSYxu6Ku4NSrYrvCXXIYP/FC/Q=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1714502876; x=1715107676;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=bhXZM6ke8pyVDtzl88TXVR9AsPng3J/jGrVRdcTxEX4=;\n b=daXhOnm6IEYfH6rWXmgd0OdxrV+jPRLSpOdwtYR65j/yXWC1YvamK1XVI/OkC9/ji4\n I21vblMY/SfGh2JZyykCTKrTY1aSXG5RW8W3ZsE3Ildfm0g4AarfA2qhaEFGEu2P0vvm\n SOZsEEWkBMzQLqxE8zizUTpAPA68sn/CVnpv58+18K6wnNZCHQGqWVBDFazFC9b8iIPI\n XJu5xepxbFUele68Z/Y/KptUIE3qKDaZ28tzVNYY+kK3V8a9neLxF4ppY/r6DlRhRFDk\n kizci90Tdf4Zd9foNncFRfQ2k+UEUjpV2t/VarrH+0tvS3hf8FAr2uiYpXKqrd27tcuO\n 3S/w==", "X-Gm-Message-State": "AOJu0YxD7AT/cV3jLkvdAntCTo3BOhr8Hb1qysUMHcdmb+7R4biQYdmT\n 7GoahZ40Lp9iz8JiI+Llb/n+pzKPVoKuZpV+twl2S3Bq2JC7k0RVMqe+lLneLAg=", "X-Google-Smtp-Source": "\n AGHT+IEQePP1/iHVnWbMmZ3iqve1lqoZgxvIv6nn6uovFKs+k41Sl7CH7OlGJAhgW5qNYMAdJW8rPQ==", "X-Received": "by 2002:a4a:654d:0:b0:5aa:241a:7f4b with SMTP id\n z13-20020a4a654d000000b005aa241a7f4bmr304320oog.1.1714502876182;\n Tue, 30 Apr 2024 11:47:56 -0700 (PDT)", "From": "Nicholas Pratte <npratte@iol.unh.edu>", "To": "\"jspewock@iol.unh.edumb@smartsharesystems.combruce.richardson\"@intel.com,\n\tyoan.picchi@foss.arm.com, juraj.linkes@pantheon.tech,\n\tpaul.szczepanek@arm.com, wathsala.vithanage@arm.com,\n\tthomas@monjalon.net, Honnappa.Nagarahalli@arm.com, probb@iol.unh.edu", "Cc": "dev@dpdk.org,\n\tNicholas Pratte <npratte@iol.unh.edu>", "Subject": "[PATCH v5 2/2] dts: Change hugepage 'amount' to a different term", "Date": "Tue, 30 Apr 2024 14:45:33 -0400", "Message-ID": "<20240430184533.29247-3-npratte@iol.unh.edu>", "X-Mailer": "git-send-email 2.44.0", "In-Reply-To": "<20240430184533.29247-2-npratte@iol.unh.edu>", "References": "<20240430184533.29247-2-npratte@iol.unh.edu>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The term 'amount' is used for uncountable nouns. Since total hugepages\nis a discrete value (i.e. countable), the declaration of the 'amount'\nkey value pair should be changes to a different term in both the config\nand the rest of the code.\n\nSigned-off-by: Nicholas Pratte <npratte@iol.unh.edu>\n---\n dts/conf.yaml | 4 ++--\n dts/framework/config/__init__.py | 4 ++--\n dts/framework/config/conf_yaml_schema.json | 6 +++---\n dts/framework/config/types.py | 2 +-\n dts/framework/testbed_model/linux_session.py | 4 ++--\n dts/framework/testbed_model/node.py | 2 +-\n 6 files changed, 11 insertions(+), 11 deletions(-)", "diff": "diff --git a/dts/conf.yaml b/dts/conf.yaml\nindex 56c3ae6f4c..44b5e4ec84 100644\n--- a/dts/conf.yaml\n+++ b/dts/conf.yaml\n@@ -36,7 +36,7 @@ nodes:\n use_first_core: false # tells DPDK to use any physical core\n memory_channels: 4 # tells DPDK to use 4 memory channels\n hugepages_2mb: # optional; if removed, will use system hugepage configuration\n- amount: 256\n+ quantity: 256\n force_first_numa: false\n ports:\n # sets up the physical link between \"SUT 1\"@000:00:08.0 and \"TG 1\"@0000:00:08.0\n@@ -72,7 +72,7 @@ nodes:\n peer_node: \"SUT 1\"\n peer_pci: \"0000:00:08.1\"\n hugepages_2mb: # optional; if removed, will use system hugepage configuration\n- amount: 256\n+ quantity: 256\n force_first_numa: false\n traffic_generator:\n type: SCAPY\ndiff --git a/dts/framework/config/__init__.py b/dts/framework/config/__init__.py\nindex b6f820e39e..3a617ef599 100644\n--- a/dts/framework/config/__init__.py\n+++ b/dts/framework/config/__init__.py\n@@ -127,11 +127,11 @@ class HugepageConfiguration:\n r\"\"\"The hugepage configuration of :class:`~framework.testbed_model.node.Node`\\s.\n \n Attributes:\n- amount: The number of hugepages.\n+ quantity: The quantity of hugepages.\n force_first_numa: If :data:`True`, the hugepages will be configured on the first NUMA node.\n \"\"\"\n \n- amount: int\n+ quantity: int\n force_first_numa: bool\n \n \ndiff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/config/conf_yaml_schema.json\nindex f4d7199523..10a8025084 100644\n--- a/dts/framework/config/conf_yaml_schema.json\n+++ b/dts/framework/config/conf_yaml_schema.json\n@@ -150,9 +150,9 @@\n \"type\": \"object\",\n \"description\": \"Optional hugepage configuration. If not specified, hugepages won't be configured and DTS will use system configuration.\",\n \"properties\": {\n- \"amount\": {\n+ \"quantity\": {\n \"type\": \"integer\",\n- \"description\": \"The amount of hugepages to configure. Hugepage size will be the system default.\"\n+ \"description\": \"The quantity of hugepages to configure. Hugepage size will be the system default.\"\n },\n \"force_first_numa\": {\n \"type\": \"boolean\",\n@@ -161,7 +161,7 @@\n },\n \"additionalProperties\": false,\n \"required\": [\n- \"amount\"\n+ \"quantity\"\n ]\n },\n \"mac_address\": {\ndiff --git a/dts/framework/config/types.py b/dts/framework/config/types.py\nindex 016e0c3dbd..57807b0a73 100644\n--- a/dts/framework/config/types.py\n+++ b/dts/framework/config/types.py\n@@ -37,7 +37,7 @@ class HugepageConfigurationDict(TypedDict):\n \"\"\"Allowed keys and values.\"\"\"\n \n #:\n- amount: int\n+ quantity: int\n #:\n force_first_numa: bool\n \ndiff --git a/dts/framework/testbed_model/linux_session.py b/dts/framework/testbed_model/linux_session.py\nindex d0f7cfa77c..ae7d0ba7d2 100644\n--- a/dts/framework/testbed_model/linux_session.py\n+++ b/dts/framework/testbed_model/linux_session.py\n@@ -138,7 +138,7 @@ def _supports_numa(self) -> bool:\n # there's no reason to do any numa specific configuration)\n return len(self._numa_nodes) > 1\n \n- def _configure_huge_pages(self, amount: int, size: int, force_first_numa: bool) -> None:\n+ def _configure_huge_pages(self, quantity: int, size: int, force_first_numa: bool) -> None:\n self._logger.info(\"Configuring Hugepages.\")\n hugepage_config_path = f\"/sys/kernel/mm/hugepages/hugepages-{size}kB/nr_hugepages\"\n if force_first_numa and self._supports_numa():\n@@ -149,7 +149,7 @@ def _configure_huge_pages(self, amount: int, size: int, force_first_numa: bool)\n f\"/hugepages-{size}kB/nr_hugepages\"\n )\n \n- self.send_command(f\"echo {amount} | tee {hugepage_config_path}\", privileged=True)\n+ self.send_command(f\"echo {quantity} | tee {hugepage_config_path}\", privileged=True)\n \n def update_ports(self, ports: list[Port]) -> None:\n \"\"\"Overrides :meth:`~.os_session.OSSession.update_ports`.\"\"\"\ndiff --git a/dts/framework/testbed_model/node.py b/dts/framework/testbed_model/node.py\nindex 3f2a727c3b..512fd01db1 100644\n--- a/dts/framework/testbed_model/node.py\n+++ b/dts/framework/testbed_model/node.py\n@@ -266,7 +266,7 @@ def _setup_hugepages(self) -> None:\n \"\"\"\n if self.config.hugepages:\n self.main_session.setup_hugepages(\n- self.config.hugepages.amount,\n+ self.config.hugepages.quantity,\n self.main_session.hugepage_size,\n self.config.hugepages.force_first_numa,\n )\n", "prefixes": [ "v5", "2/2" ] }