Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139702/?format=api
{ "id": 139702, "url": "http://patches.dpdk.org/api/patches/139702/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240426110947.881407-1-haoqian.he@smartx.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240426110947.881407-1-haoqian.he@smartx.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240426110947.881407-1-haoqian.he@smartx.com", "date": "2024-04-26T11:09:46", "name": "[v2] vhost: cleanup resubmit info before inflight setup", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6f11d95b8a8982395c05c4a674a320583f6fd653", "submitter": { "id": 3294, "url": "http://patches.dpdk.org/api/people/3294/?format=api", "name": "Haoqian He", "email": "haoqian.he@smartx.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240426110947.881407-1-haoqian.he@smartx.com/mbox/", "series": [ { "id": 31831, "url": "http://patches.dpdk.org/api/series/31831/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31831", "date": "2024-04-26T11:09:46", "name": "[v2] vhost: cleanup resubmit info before inflight setup", "version": 2, "mbox": "http://patches.dpdk.org/series/31831/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139702/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/139702/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 69D9143F13;\n\tFri, 26 Apr 2024 13:10:08 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E1E8343D75;\n\tFri, 26 Apr 2024 13:10:07 +0200 (CEST)", "from mail-pl1-f169.google.com (mail-pl1-f169.google.com\n [209.85.214.169])\n by mails.dpdk.org (Postfix) with ESMTP id BFBBA40289\n for <dev@dpdk.org>; Fri, 26 Apr 2024 13:10:06 +0200 (CEST)", "by mail-pl1-f169.google.com with SMTP id\n d9443c01a7336-1e65b29f703so17944125ad.3\n for <dev@dpdk.org>; Fri, 26 Apr 2024 04:10:06 -0700 (PDT)", "from fedora.smartx.com ([1.202.18.10])\n by smtp.gmail.com with ESMTPSA id\n c7-20020a170903234700b001eb0dd08e40sm925467plh.133.2024.04.26.04.10.03\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 26 Apr 2024 04:10:04 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=smartx-com.20230601.gappssmtp.com; s=20230601; t=1714129806; x=1714734606;\n darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=GKTxmqew+rvCX5Zg7C+CU2vpNXsP12QqlfX5l5cK+VU=;\n b=Hqsu5N3uLfBAFPvJGIe/UlOaTHAo4sXxBkbBOrp2Dxu5kEMc7FLZy5yQMD8v6XsvA8\n WhKYc7U2cATqs1tIjMeCwna4ocJ6uHSJyk0GIR9R0/7pGE7sdRbG1eb6iuyF6YRy7eF2\n uzzopBarqUpi1EiYJrdgX6sqJ0+voxzpZ2swi4NjqsSuPAlFQDKHPK9M50unb29WslyV\n xuL4eJCSgpxYEY2x/9ZTWHzlmz+FcyxU7SBxs/GlppNsZNXVpgkG7pA7AHgd0tiEh8Vh\n 1OdIF4s7+ARM7Iol7RnjbUZDzwpW3bmGL9qbmfD+lCwzAtBNLK28FcPJOxpTc6n922Ag\n PrpA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1714129806; x=1714734606;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=GKTxmqew+rvCX5Zg7C+CU2vpNXsP12QqlfX5l5cK+VU=;\n b=KzLfNwurEHx7XYwwJlHofhjnJs4dwaB1KCneVlMR3T9/7x11quz6nllnHBo26OZ03o\n Vr5JPSxlnKbY2IM5q8BSMjD0SndoHMoH/wzI2pJTHSwwRr+AjjEKHtbRd8bMzkpZUeHk\n 8UO/PMWNBBLlbojGC60u4UoJpDNsH0OWd6B08UVKoyDTmSKtw3E0qjHfdAWeZlmk+JaA\n Yv8KgiMQfiBcYOHbJoRbw/LGruhc6QJlO2p2mpsZaKDLNhtVR2X2+x4RMRlQQ4F/WKiV\n zvi7dysbMBgYqbYUrvo6SSnz3R3d7qtUSsqxgHyPegkin79tQba/7Pwj7d1d5TfPEYbV\n Aang==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCU62MO6epGrPtZ3VpbpA9YleZkkJaFqYIi+tMlFGn0kem9iqhjTYdDdLFUfmQuC8IIF23XD8IjeOqkHD60=", "X-Gm-Message-State": "AOJu0Ywcw7rTIifJDtSVRPG0jkBT6QRUx3aw4z1oCS9oc91cnGezMp37\n oCFCTS41WdsxzNUC8cFT//u0OYeLGzLdnXG085lUkMWaZWXQ9W+4MtBlHarCUUI=", "X-Google-Smtp-Source": "\n AGHT+IHn8xo7qifFlwHFNdgh5SZkP3sRCliS7sckA+RoXBIEj8OpUqE1L6CUzJVanSkduYunPzvjMA==", "X-Received": "by 2002:a17:902:ef89:b0:1e1:214:1b7d with SMTP id\n iz9-20020a170902ef8900b001e102141b7dmr2073633plb.61.1714129804855;\n Fri, 26 Apr 2024 04:10:04 -0700 (PDT)", "From": "Haoqian He <haoqian.he@smartx.com>", "To": "maxime.coquelin@redhat.com", "Cc": "chenbox@nvidia.com, dev@dpdk.org, haoqian.he@smartx.com,\n fengli@smartx.com,\n stable@dpdk.org", "Subject": "[PATCH v2] vhost: cleanup resubmit info before inflight setup", "Date": "Fri, 26 Apr 2024 07:09:46 -0400", "Message-ID": "<20240426110947.881407-1-haoqian.he@smartx.com>", "X-Mailer": "git-send-email 2.44.0", "In-Reply-To": "<8a04f203-4ef0-4840-b480-b21e08561c7d@redhat.com>", "References": "<8a04f203-4ef0-4840-b480-b21e08561c7d@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch fixes a potential VM hang bug when the VM reboots after\nvhost live recovery due to missing cleanup virtqueue resubmit info.\n\nSpecifically, if inflight IO that should be resubmitted during\nthe latest vhost reconnection has not been submitted yet while\nVM rebooting, so GET_VRING_BASE would not wait for the inflight\nIO, at this time the resubmit info has been. When the VM restarts,\nSET_VRING_KICK will resubmit the inflight IO (If resubmit info\nis not null, function set_vring_kick will return without updating\nresubmit info).\n\nIt’s an error, any stale inflight IO should not be resubmitted\nafter the VM restart.\n\nThe solution is to clean up virtqueue resubmit info when function\nset_inflight_fd before function set_vring_kick.\n\nFixes: ad0a4ae491fe (\"vhost: checkout resubmit inflight information\")\nCc: stable@dpdk.org\n\nSigned-off-by: Haoqian He <haoqian.he@smartx.com>\n---\nv2: rewrite the commit message.\n\n lib/vhost/vhost_user.c | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c\nindex 414192500e..7c54afc5fb 100644\n--- a/lib/vhost/vhost_user.c\n+++ b/lib/vhost/vhost_user.c\n@@ -1871,6 +1871,7 @@ vhost_user_set_inflight_fd(struct virtio_net **pdev,\n \t\tif (!vq)\n \t\t\tcontinue;\n \n+\t\tcleanup_vq_inflight(dev, vq);\n \t\tif (vq_is_packed(dev)) {\n \t\t\tvq->inflight_packed = addr;\n \t\t\tvq->inflight_packed->desc_num = queue_size;\n", "prefixes": [ "v2" ] }