Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139500/?format=api
{ "id": 139500, "url": "http://patches.dpdk.org/api/patches/139500/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1713470562-17415-3-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1713470562-17415-3-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1713470562-17415-3-git-send-email-roretzla@linux.microsoft.com", "date": "2024-04-18T20:02:25", "name": "[v2,02/19] eal/linux: remove use of VLAs", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "48afbaca7628b8460470930ee74a1bf1f480e826", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1713470562-17415-3-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31785, "url": "http://patches.dpdk.org/api/series/31785/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31785", "date": "2024-04-18T20:02:24", "name": "remove use of VLAs for Windows", "version": 2, "mbox": "http://patches.dpdk.org/series/31785/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139500/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/139500/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 44D3543EA8;\n\tThu, 18 Apr 2024 22:03:16 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D1F2E4067D;\n\tThu, 18 Apr 2024 22:02:51 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 14F2440272\n for <dev@dpdk.org>; Thu, 18 Apr 2024 22:02:45 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 008D120FD921; Thu, 18 Apr 2024 13:02:43 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 008D120FD921", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1713470564;\n bh=eATH/i+nEf7wfqbsClgomcbe34PUBvVsJ2Vxj3rogDo=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=kDhxFNSXw/524InRr44wED7p8pLiM9v5+ZNVRgaEo2XDtkTmekQCJrT6yFKhcS2wI\n uzyqq9XO45H6RANOJGu4OwPBWuvzwvNsdHgnqvDvsJAa6AgMFTdGBa08Cgcx32HBAH\n eKcg9g6zBhH7P4tDvssamRpTyEdkQfYjBwOYTLnI=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "=?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Akhil Goyal <gakhil@marvell.com>, Aman Singh <aman.deep.singh@intel.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Fan Zhang <fanzhang.oss@gmail.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Harman Kalra <hkalra@marvell.com>,\n Harry van Haaren <harry.van.haaren@intel.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jiayu Hu <hujiayu.hu@foxmail.com>, Jingjing Wu <jingjing.wu@intel.com>,\n Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Matan Azrad <matan@nvidia.com>, Ori Kam <orika@nvidia.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>,\n Reshma Pattan <reshma.pattan@intel.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>, Suanming Mou <suanmingm@nvidia.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Volodymyr Fialko <vfialko@marvell.com>, Yipeng Wang <yipeng1.wang@intel.com>,\n Konstantin Ananyev <konstantin.ananyev@huawei.com>", "Subject": "[PATCH v2 02/19] eal/linux: remove use of VLAs", "Date": "Thu, 18 Apr 2024 13:02:25 -0700", "Message-Id": "<1713470562-17415-3-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1713470562-17415-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com>\n <1713470562-17415-1-git-send-email-roretzla@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Konstantin Ananyev <konstantin.ananyev@huawei.com>\n\n1) ./lib/eal/linux/eal_interrupts.c:1073:16\n : warning: ISO C90 forbids variable length array ‘events’\n\neal_intr_handle_interrupts() is called by eal_intr_thread_main()\nso it seems ok to simply alloc space for events from heap and reuse the\nsame buffer through the life of the thread.\n\n2) ./lib/eal/linux/eal_interrupts.c:1319:16\n : warning: ISO C90 forbids variable length array ‘evs’\n\nmake eal_epoll_wait() to use fixed size array and use it though multiple\niterations to preocess upt to @maxevents events.\nNote that techically it is not one to one raplacement, as here we might\nreduce number of events returned by first call to epoll_wait(..., timeout);\n\nSigned-off-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>\n---\n lib/eal/linux/eal_interrupts.c | 59 +++++++++++++++++++++++++++++++++++++-----\n 1 file changed, 52 insertions(+), 7 deletions(-)", "diff": "diff --git a/lib/eal/linux/eal_interrupts.c b/lib/eal/linux/eal_interrupts.c\nindex 6436f79..58e3b8e 100644\n--- a/lib/eal/linux/eal_interrupts.c\n+++ b/lib/eal/linux/eal_interrupts.c\n@@ -34,6 +34,8 @@\n #define EAL_INTR_EPOLL_WAIT_FOREVER (-1)\n #define NB_OTHER_INTR 1\n \n+#define MAX_ITER_EVNUM\tRTE_EVENT_ETH_INTR_RING_SIZE\n+\n static RTE_DEFINE_PER_LCORE(int, _epfd) = -1; /**< epoll fd per thread */\n \n /**\n@@ -1068,9 +1070,9 @@ struct rte_intr_source {\n * void\n */\n static void\n-eal_intr_handle_interrupts(int pfd, unsigned totalfds)\n+eal_intr_handle_interrupts(int pfd, struct epoll_event events[],\n+\tunsigned totalfds)\n {\n-\tstruct epoll_event events[totalfds];\n \tint nfds = 0;\n \n \tfor(;;) {\n@@ -1106,6 +1108,12 @@ struct rte_intr_source {\n static __rte_noreturn uint32_t\n eal_intr_thread_main(__rte_unused void *arg)\n {\n+\tuint32_t n, nb_event;\n+\tstruct epoll_event *events, *p;\n+\n+\tnb_event = 0;\n+\tevents = NULL;\n+\n \t/* host thread, never break out */\n \tfor (;;) {\n \t\t/* build up the epoll fd with all descriptors we are to\n@@ -1159,8 +1167,23 @@ struct rte_intr_source {\n \t\t\t\tnumfds++;\n \t\t}\n \t\trte_spinlock_unlock(&intr_lock);\n+\n+\t\t/* alloc space for events, when necessary */\n+\t\tif (numfds > nb_event) {\n+\t\t\tn = numfds + MAX_ITER_EVNUM;\n+\t\t\tp = realloc(events, n * sizeof(events[0]));\n+\t\t\tif (p == NULL) {\n+\t\t\t\tEAL_LOG(ERR, \"failed to allocate %u events\",\n+\t\t\t\t\tnumfds);\n+\t\t\t\tnumfds = nb_event;\n+\t\t\t} else {\n+\t\t\t\tnb_event = n;\n+\t\t\t\tevents = p;\n+\t\t\t}\n+\t\t}\n+\n \t\t/* serve the interrupt */\n-\t\teal_intr_handle_interrupts(pfd, numfds);\n+\t\teal_intr_handle_interrupts(pfd, events, numfds);\n \n \t\t/**\n \t\t * when we return, we need to rebuild the\n@@ -1168,6 +1191,8 @@ struct rte_intr_source {\n \t\t */\n \t\tclose(pfd);\n \t}\n+\n+\tfree(events);\n }\n \n int\n@@ -1316,8 +1341,9 @@ struct rte_intr_source {\n eal_epoll_wait(int epfd, struct rte_epoll_event *events,\n \t int maxevents, int timeout, bool interruptible)\n {\n-\tstruct epoll_event evs[maxevents];\n \tint rc;\n+\tuint32_t i, k, n, num;\n+\tstruct epoll_event evs[MAX_ITER_EVNUM];\n \n \tif (!events) {\n \t\tEAL_LOG(ERR, \"rte_epoll_event can't be NULL\");\n@@ -1328,12 +1354,31 @@ struct rte_intr_source {\n \tif (epfd == RTE_EPOLL_PER_THREAD)\n \t\tepfd = rte_intr_tls_epfd();\n \n+\tnum = maxevents;\n+\tn = RTE_MIN(RTE_DIM(evs), num);\n+\n+\t/* Process events in chunks of MAX_ITER_EVNUM */\n+\n \twhile (1) {\n-\t\trc = epoll_wait(epfd, evs, maxevents, timeout);\n+\t\trc = epoll_wait(epfd, evs, n, timeout);\n \t\tif (likely(rc > 0)) {\n+\n \t\t\t/* epoll_wait has at least one fd ready to read */\n-\t\t\trc = eal_epoll_process_event(evs, rc, events);\n-\t\t\tbreak;\n+\t\t\tfor (i = 0, k = 0; rc > 0;) {\n+\t\t\t\tk += rc;\n+\t\t\t\trc = eal_epoll_process_event(evs, rc,\n+\t\t\t\t\t\tevents + i);\n+\t\t\t\ti += rc;\n+\n+\t\t\t\t/*\n+\t\t\t\t * try to read more events that are already\n+\t\t\t\t * available (up to maxevents in total).\n+\t\t\t\t */\n+\t\t\t\tn = RTE_MIN(RTE_DIM(evs), num - k);\n+\t\t\t\trc = (n == 0) ? 0 : epoll_wait(epfd, evs, n, 0);\n+\t\t\t}\n+\t\t\treturn i;\n+\n \t\t} else if (rc < 0) {\n \t\t\tif (errno == EINTR) {\n \t\t\t\tif (interruptible)\n", "prefixes": [ "v2", "02/19" ] }