Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139152/?format=api
{ "id": 139152, "url": "http://patches.dpdk.org/api/patches/139152/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240405165518.367503-19-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240405165518.367503-19-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20240405165518.367503-19-stephen@networkplumber.org", "date": "2024-04-05T16:53:29", "name": "[v4,18/30] common: replace use of fixed size rte_memcpy", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b943d46e2166c7c74a41390a47277a1b2e4b9bd1", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240405165518.367503-19-stephen@networkplumber.org/mbox/", "series": [ { "id": 31690, "url": "http://patches.dpdk.org/api/series/31690/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31690", "date": "2024-04-05T16:53:11", "name": "replace use of rte_memcpy with fixed sizes", "version": 4, "mbox": "http://patches.dpdk.org/series/31690/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139152/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/139152/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 978A843E0C;\n\tFri, 5 Apr 2024 18:58:30 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C358E40695;\n\tFri, 5 Apr 2024 18:56:04 +0200 (CEST)", "from mail-pf1-f173.google.com (mail-pf1-f173.google.com\n [209.85.210.173])\n by mails.dpdk.org (Postfix) with ESMTP id EA8D740E72\n for <dev@dpdk.org>; Fri, 5 Apr 2024 18:55:59 +0200 (CEST)", "by mail-pf1-f173.google.com with SMTP id\n d2e1a72fcca58-6ed0938cd1dso365669b3a.2\n for <dev@dpdk.org>; Fri, 05 Apr 2024 09:55:59 -0700 (PDT)", "from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n c2-20020aa781c2000000b006e6c0f8ce1bsm1728555pfn.47.2024.04.05.09.55.58\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 05 Apr 2024 09:55:58 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1712336159;\n x=1712940959; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=wWGruJZndTsR6dy3JQTOVb7AKGrbye4ePcPebgwmfLQ=;\n b=VIy23debTEgLsbdOxzX5UkgcTRtpQjkY/5LOS7Y0tJZRvJOA0fYcIGYMkULQDh/oNi\n gXFm3VJzw40ICB12Zwd85bI5uUfcX0NEfIUcWlEnirCcGNAWSak9vdKWLcIoCZRvtNw4\n zGu/SFehCHj3db0V/s8fX0RO8MltCyDGZ1XIgxJCnzR6/p7KRqirZ408pk7Pfun9i9Hp\n 8pzJ96eA8TvUWNIaS3si9R5w6J148Ms5R2bn91jnTxrKS1Q5wNx6rpIJjBWVRDscaNnp\n 4R63WjkyeUcf9ru6AdxSYeaD3XT3QCiB3AVVe1tWUN6pwy6Ckhe+bSPhGPRq7qP/PZZn\n wkXg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1712336159; x=1712940959;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=wWGruJZndTsR6dy3JQTOVb7AKGrbye4ePcPebgwmfLQ=;\n b=dsQuOSB7z1e7ik47twWiTkypq2qnSo1ubzYjg1Mh0AV237o3FeRgEq55sRRoVzFl/R\n Q4VHsQwbfwJlPgCvMCnPOwQzitrGJj5UA/n0QrW2G/+jtrzeWW8E5aGctIP02AH1pkHT\n Vs7AnlzsZLdmHlccszeOzit/R++oLVbCkZroZEj68m0gwj8QMieHgZy0kzwHDoRw2bPi\n OCkjlg/o2G45+LJI3KmmhUzA1WvpQ3G3qOHeVgHUsVZ0z7LP/jVKox1vOiV/D6ip5zRm\n k7rJIAb5bImIi38qjqFe4oN4O2oYdG+Y+Ni6pnJMXxQdkeuH8O8SFXkJTfEW1XfzgmPi\n Yq5Q==", "X-Gm-Message-State": "AOJu0Yyr3z7lNhKIbgVTy5H8o4PewldLEIBS05Uz6ZCCd8GK3sh23rf9\n ErrfUlYUIAdd2ibORtnipPkOk1rtiP8lBiOCf3qhWJ+uWIYaF7LuxBhSyM6yrmBEEZOlo02fPHh\n pL6ASHg==", "X-Google-Smtp-Source": "\n AGHT+IH36UJnh5IN3Wq+MYkr+cRM2e7fadqoMLO1U7W8bMmnxrYD8U3nGt8Sr2ZDzq4c2I7dV6fLlA==", "X-Received": "by 2002:a05:6a20:bc20:b0:1a7:2374:f1ed with SMTP id\n fw32-20020a056a20bc2000b001a72374f1edmr1733561pzb.42.1712336159148;\n Fri, 05 Apr 2024 09:55:59 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Jingjing Wu <jingjing.wu@intel.com>, Kai Ji <kai.ji@intel.com>,\n Fan Zhang <fanzhang.oss@gmail.com>, Ashish Gupta <ashish.gupta@marvell.com>", "Subject": "[PATCH v4 18/30] common: replace use of fixed size rte_memcpy", "Date": "Fri, 5 Apr 2024 09:53:29 -0700", "Message-ID": "<20240405165518.367503-19-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20240405165518.367503-1-stephen@networkplumber.org>", "References": "<20240403163432.437275-1-stephen@networkplumber.org>\n <20240405165518.367503-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Automatically generated by devtools/cocci/rte_memcpy.cocci\nAlso, remove unnecessary includes of rte_memcpy.h\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/common/idpf/idpf_common_device.c | 4 ++--\n drivers/common/idpf/idpf_common_virtchnl.c | 10 ++++++----\n drivers/common/qat/qat_qp.c | 10 ++++------\n drivers/compress/qat/qat_comp.c | 8 ++++----\n 4 files changed, 16 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/common/idpf/idpf_common_device.c b/drivers/common/idpf/idpf_common_device.c\nindex 8403ed83f9..37c859f830 100644\n--- a/drivers/common/idpf/idpf_common_device.c\n+++ b/drivers/common/idpf/idpf_common_device.c\n@@ -477,8 +477,8 @@ idpf_vport_init(struct idpf_vport *vport,\n \tvport->num_rx_q = vport_info->num_rx_q;\n \tvport->num_rx_bufq = vport_info->num_rx_bufq;\n \tvport->max_mtu = vport_info->max_mtu;\n-\trte_memcpy(vport->default_mac_addr,\n-\t\t vport_info->default_mac_addr, ETH_ALEN);\n+\tmemcpy(vport->default_mac_addr, vport_info->default_mac_addr,\n+\t ETH_ALEN);\n \tvport->rss_algorithm = vport_info->rss_algorithm;\n \tvport->rss_key_size = RTE_MIN(IDPF_RSS_KEY_LEN,\n \t\t\t\t vport_info->rss_key_size);\ndiff --git a/drivers/common/idpf/idpf_common_virtchnl.c b/drivers/common/idpf/idpf_common_virtchnl.c\nindex c46ed50eb5..baabfeb216 100644\n--- a/drivers/common/idpf/idpf_common_virtchnl.c\n+++ b/drivers/common/idpf/idpf_common_virtchnl.c\n@@ -290,7 +290,8 @@ idpf_vc_caps_get(struct idpf_adapter *adapter)\n \t\treturn err;\n \t}\n \n-\trte_memcpy(&adapter->caps, args.out_buffer, sizeof(struct virtchnl2_get_capabilities));\n+\tmemcpy(&adapter->caps, args.out_buffer,\n+\t sizeof(struct virtchnl2_get_capabilities));\n \n \treturn 0;\n }\n@@ -327,7 +328,8 @@ idpf_vc_vport_create(struct idpf_vport *vport,\n \t\treturn err;\n \t}\n \n-\trte_memcpy(&(vport->vport_info.info), args.out_buffer, IDPF_DFLT_MBX_BUF_SIZE);\n+\tmemcpy(&(vport->vport_info.info), args.out_buffer,\n+\t IDPF_DFLT_MBX_BUF_SIZE);\n \treturn 0;\n }\n \n@@ -383,7 +385,7 @@ idpf_vc_queue_grps_add(struct idpf_vport *vport,\n \t\treturn err;\n \t}\n \n-\trte_memcpy(p2p_queue_grps_out, args.out_buffer, IDPF_DFLT_MBX_BUF_SIZE);\n+\tmemcpy(p2p_queue_grps_out, args.out_buffer, IDPF_DFLT_MBX_BUF_SIZE);\n \treturn 0;\n }\n \n@@ -922,7 +924,7 @@ idpf_vc_ptype_info_query(struct idpf_adapter *adapter,\n \tif (err != 0)\n \t\tDRV_LOG(ERR, \"Failed to execute command of VIRTCHNL2_OP_GET_PTYPE_INFO\");\n \n-\trte_memcpy(recv_ptype_info, args.out_buffer, IDPF_DFLT_MBX_BUF_SIZE);\n+\tmemcpy(recv_ptype_info, args.out_buffer, IDPF_DFLT_MBX_BUF_SIZE);\n \treturn err;\n }\n \ndiff --git a/drivers/common/qat/qat_qp.c b/drivers/common/qat/qat_qp.c\nindex f95dd33375..0c30c4d8c1 100644\n--- a/drivers/common/qat/qat_qp.c\n+++ b/drivers/common/qat/qat_qp.c\n@@ -871,9 +871,8 @@ qat_cq_get_fw_cipher_crc_cap(struct qat_qp *qp)\n \t\treturn -EINVAL;\n \t}\n \n-\trte_memcpy(src_data_addr,\n-\t\t\tcipher_crc_cap_check_plaintext,\n-\t\t\tsizeof(cipher_crc_cap_check_plaintext));\n+\tmemcpy(src_data_addr, cipher_crc_cap_check_plaintext,\n+\t sizeof(cipher_crc_cap_check_plaintext));\n \n \tphy_src_addr = rte_mem_virt2iova(src_data_addr);\n \tif (phy_src_addr == 0 || phy_src_addr == RTE_BAD_IOVA) {\n@@ -892,9 +891,8 @@ qat_cq_get_fw_cipher_crc_cap(struct qat_qp *qp)\n \tauth_param = (void *)((uint8_t *)cipher_param +\n \t\t\tICP_QAT_FW_HASH_REQUEST_PARAMETERS_OFFSET);\n \n-\trte_memcpy(cipher_param->u.cipher_IV_array,\n-\t\t\tcipher_crc_cap_check_iv,\n-\t\t\tsizeof(cipher_crc_cap_check_iv));\n+\tmemcpy(cipher_param->u.cipher_IV_array, cipher_crc_cap_check_iv,\n+\t sizeof(cipher_crc_cap_check_iv));\n \n \tcipher_param->cipher_offset = cipher_crc_cap_check_cipher_offset;\n \tcipher_param->cipher_length =\ndiff --git a/drivers/compress/qat/qat_comp.c b/drivers/compress/qat/qat_comp.c\nindex 559948a46a..5bcbefe395 100644\n--- a/drivers/compress/qat/qat_comp.c\n+++ b/drivers/compress/qat/qat_comp.c\n@@ -375,7 +375,7 @@ qat_comp_build_multiple_requests(void *in_op, struct qat_qp *qp,\n \tQAT_DP_LOG(DEBUG, \"op %p, parent_cookie %p\", op, parent_cookie);\n \n \t/* copy original op to the local variable for restoring later */\n-\trte_memcpy(&op_backup, op, sizeof(op_backup));\n+\tmemcpy(&op_backup, op, sizeof(op_backup));\n \n \tparent_cookie->nb_child_responses = 0;\n \tparent_cookie->nb_children = 0;\n@@ -401,7 +401,7 @@ qat_comp_build_multiple_requests(void *in_op, struct qat_qp *qp,\n \t}\n \n \t/* prepare local dst mbuf */\n-\trte_memcpy(&dst_mbuf, op->m_dst, sizeof(dst_mbuf));\n+\tmemcpy(&dst_mbuf, op->m_dst, sizeof(dst_mbuf));\n \trte_pktmbuf_reset(&dst_mbuf);\n \tdst_mbuf.buf_len = dst_data_size;\n \tdst_mbuf.data_len = dst_data_size;\n@@ -457,7 +457,7 @@ qat_comp_build_multiple_requests(void *in_op, struct qat_qp *qp,\n \t\tif (ret < 0) {\n \t\t\tQAT_DP_LOG(WARNING, \"Failed to build child descriptor\");\n \t\t\t/* restore op and clear cookie */\n-\t\t\trte_memcpy(op, &op_backup, sizeof(op_backup));\n+\t\t\tmemcpy(op, &op_backup, sizeof(op_backup));\n \t\t\tparent_cookie->split_op = 0;\n \t\t\tparent_cookie->nb_children = 0;\n \t\t\treturn ret;\n@@ -468,7 +468,7 @@ qat_comp_build_multiple_requests(void *in_op, struct qat_qp *qp,\n \t}\n \n \t/* restore backed up original op */\n-\trte_memcpy(op, &op_backup, sizeof(op_backup));\n+\tmemcpy(op, &op_backup, sizeof(op_backup));\n \n \tif (nb_descr != num_descriptors_built)\n \t\tQAT_DP_LOG(ERR, \"split op. expected %d, built %d\",\n", "prefixes": [ "v4", "18/30" ] }