Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/139129/?format=api
{ "id": 139129, "url": "http://patches.dpdk.org/api/patches/139129/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20240405144604.906695-4-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240405144604.906695-4-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240405144604.906695-4-david.marchand@redhat.com", "date": "2024-04-05T14:45:57", "name": "[v2,3/8] mbuf: fix Tx checksum offload examples", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "106982e2b0a2a0cca7b2652ed7356163bd5f18a6", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20240405144604.906695-4-david.marchand@redhat.com/mbox/", "series": [ { "id": 31689, "url": "http://patches.dpdk.org/api/series/31689/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31689", "date": "2024-04-05T14:45:54", "name": "Fix outer UDP checksum for Intel nics", "version": 2, "mbox": "http://patches.dpdk.org/series/31689/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/139129/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/139129/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 28A5B43E06;\n\tFri, 5 Apr 2024 16:46:41 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 76754406A2;\n\tFri, 5 Apr 2024 16:46:37 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id DEFD040697\n for <dev@dpdk.org>; Fri, 5 Apr 2024 16:46:36 +0200 (CEST)", "from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73])\n by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-Gk_Q3cP2OAWirFfVRfotRA-1; Fri,\n 05 Apr 2024 10:46:32 -0400", "from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com\n [10.11.54.8])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B755238000AE;\n Fri, 5 Apr 2024 14:46:31 +0000 (UTC)", "from dmarchan.redhat.com (unknown [10.45.225.49])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 75EECC04221;\n Fri, 5 Apr 2024 14:46:30 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1712328396;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=v9Xq8FQK1hfn9g+vFXPNjevKVPrRQdO54XU4Uu1gDH0=;\n b=REBFzQAC7/NjyH/rT1TMQpAfP+l63csuL+ixPiIZbAlo0xouSn/25OOGeq1lsjHDFMy2Uc\n sV9DWeWyijLcsDQL61PFcc+oITuSWvs6vpLj2JMBgXsDTarSescRt1bcz5PirA6BtO/wUz\n bN12QEVX5dPMscIDoczx3H8IK8xB5s4=", "X-MC-Unique": "Gk_Q3cP2OAWirFfVRfotRA-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, ferruh.yigit@amd.com, stable@dpdk.org,\n Olivier Matz <olivier.matz@6wind.com>, Jijiang Liu <jijiang.liu@intel.com>", "Subject": "[PATCH v2 3/8] mbuf: fix Tx checksum offload examples", "Date": "Fri, 5 Apr 2024 16:45:57 +0200", "Message-ID": "<20240405144604.906695-4-david.marchand@redhat.com>", "In-Reply-To": "<20240405144604.906695-1-david.marchand@redhat.com>", "References": "<20240405125039.897933-1-david.marchand@redhat.com>\n <20240405144604.906695-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.11.54.8", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Mandate use of rte_eth_tx_prepare() in the mbuf Tx checksum offload\nexamples.\n\nRemove unneeded resetting of checksums to align with the mbuf\nAPI doxygen.\n\nClarify the case when requesting \"inner\" checksum offload with\nlack of outer L4 checksum offload.\n\nFixes: f00dcb7b0a74 (\"mbuf: fix Tx checksum offload API doc\")\nFixes: 609dd68ef14f (\"mbuf: enhance the API documentation of offload flags\")\nCc: stable@dpdk.org\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n doc/guides/prog_guide/mbuf_lib.rst | 16 ++++------------\n 1 file changed, 4 insertions(+), 12 deletions(-)", "diff": "diff --git a/doc/guides/prog_guide/mbuf_lib.rst b/doc/guides/prog_guide/mbuf_lib.rst\nindex 049357c755..4e285c0aab 100644\n--- a/doc/guides/prog_guide/mbuf_lib.rst\n+++ b/doc/guides/prog_guide/mbuf_lib.rst\n@@ -126,6 +126,9 @@ processing to the hardware if it supports it. For instance, the\n RTE_MBUF_F_TX_IP_CKSUM flag allows to offload the computation of the IPv4\n checksum.\n \n+Support for such processing by the hardware is advertised through RTE_ETH_TX_OFFLOAD_* capabilities.\n+Please note that a call to ``rte_eth_tx_prepare`` is needed to handle driver specific requirements such as resetting some checksum fields.\n+\n The following examples explain how to configure different TX offloads on\n a vxlan-encapsulated tcp packet:\n ``out_eth/out_ip/out_udp/vxlan/in_eth/in_ip/in_tcp/payload``\n@@ -135,7 +138,6 @@ a vxlan-encapsulated tcp packet:\n mb->l2_len = len(out_eth)\n mb->l3_len = len(out_ip)\n mb->ol_flags |= RTE_MBUF_F_TX_IPV4 | RTE_MBUF_F_TX_IP_CSUM\n- set out_ip checksum to 0 in the packet\n \n This is supported on hardware advertising RTE_ETH_TX_OFFLOAD_IPV4_CKSUM.\n \n@@ -144,8 +146,6 @@ a vxlan-encapsulated tcp packet:\n mb->l2_len = len(out_eth)\n mb->l3_len = len(out_ip)\n mb->ol_flags |= RTE_MBUF_F_TX_IPV4 | RTE_MBUF_F_TX_IP_CSUM | RTE_MBUF_F_TX_UDP_CKSUM\n- set out_ip checksum to 0 in the packet\n- set out_udp checksum to pseudo header using rte_ipv4_phdr_cksum()\n \n This is supported on hardware advertising RTE_ETH_TX_OFFLOAD_IPV4_CKSUM\n and RTE_ETH_TX_OFFLOAD_UDP_CKSUM.\n@@ -155,7 +155,6 @@ a vxlan-encapsulated tcp packet:\n mb->l2_len = len(out_eth + out_ip + out_udp + vxlan + in_eth)\n mb->l3_len = len(in_ip)\n mb->ol_flags |= RTE_MBUF_F_TX_IPV4 | RTE_MBUF_F_TX_IP_CSUM\n- set in_ip checksum to 0 in the packet\n \n This is similar to case 1), but l2_len is different. It is supported\n on hardware advertising RTE_ETH_TX_OFFLOAD_IPV4_CKSUM.\n@@ -166,8 +165,6 @@ a vxlan-encapsulated tcp packet:\n mb->l2_len = len(out_eth + out_ip + out_udp + vxlan + in_eth)\n mb->l3_len = len(in_ip)\n mb->ol_flags |= RTE_MBUF_F_TX_IPV4 | RTE_MBUF_F_TX_IP_CSUM | RTE_MBUF_F_TX_TCP_CKSUM\n- set in_ip checksum to 0 in the packet\n- set in_tcp checksum to pseudo header using rte_ipv4_phdr_cksum()\n \n This is similar to case 2), but l2_len is different. It is supported\n on hardware advertising RTE_ETH_TX_OFFLOAD_IPV4_CKSUM and\n@@ -181,9 +178,6 @@ a vxlan-encapsulated tcp packet:\n mb->l4_len = len(in_tcp)\n mb->ol_flags |= RTE_MBUF_F_TX_IPV4 | RTE_MBUF_F_TX_IP_CKSUM | RTE_MBUF_F_TX_TCP_CKSUM |\n RTE_MBUF_F_TX_TCP_SEG;\n- set in_ip checksum to 0 in the packet\n- set in_tcp checksum to pseudo header without including the IP\n- payload length using rte_ipv4_phdr_cksum()\n \n This is supported on hardware advertising RTE_ETH_TX_OFFLOAD_TCP_TSO.\n Note that it can only work if outer L4 checksum is 0.\n@@ -196,12 +190,10 @@ a vxlan-encapsulated tcp packet:\n mb->l3_len = len(in_ip)\n mb->ol_flags |= RTE_MBUF_F_TX_OUTER_IPV4 | RTE_MBUF_F_TX_OUTER_IP_CKSUM | \\\n RTE_MBUF_F_TX_IP_CKSUM | RTE_MBUF_F_TX_TCP_CKSUM;\n- set out_ip checksum to 0 in the packet\n- set in_ip checksum to 0 in the packet\n- set in_tcp checksum to pseudo header using rte_ipv4_phdr_cksum()\n \n This is supported on hardware advertising RTE_ETH_TX_OFFLOAD_IPV4_CKSUM,\n RTE_ETH_TX_OFFLOAD_UDP_CKSUM and RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM.\n+ Note that it can only work if outer L4 checksum is 0.\n \n The list of flags and their precise meaning is described in the mbuf API\n documentation (rte_mbuf.h). Also refer to the testpmd source code\n", "prefixes": [ "v2", "3/8" ] }